[Piglit] [Bug 106370] New: /bin/sh: BYPRODUCTS: command not found

2018-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106370 Bug ID: 106370 Summary: /bin/sh: BYPRODUCTS: command not found Product: piglit Version: unspecified Hardware: x86-64 (AMD64) OS: All Status: NEW Keywords

[Piglit] [Bug 106369] New: TypeError: must be unicode, not str

2018-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106369 Bug ID: 106369 Summary: TypeError: must be unicode, not str Product: piglit Version: unspecified Hardware: x86-64 (AMD64) OS: Mac OS X (All) Status: NEW

Re: [Piglit] [PATCH v2] ext_texture_norm16-render: test for GL_EXT_texture_norm16

2018-05-02 Thread Tapani Pälli
On 02.05.2018 21:29, Eric Anholt wrote: Tapani Pälli writes: Test includes: - texture uploads - mipmap generation - framebuffer creation - rendering to - reading from - interaction with GL_EXT_copy_image v2: code cleanup Signed-off-by: Tapani Pälli --- tests/all.

[Piglit] [Bug 106277] [CI] spec@glsl-1.40-compat@execution@built-in-constants failing

2018-05-02 Thread bugzilla-daemon
https://bugs.freedesktop.org/show_bug.cgi?id=106277 Timothy Arceri changed: What|Removed |Added Resolution|--- |FIXED Status|NEW

[Piglit] [PATCH] tests: fix unicode issue on MinGW in find_static_tests.py

2018-05-02 Thread Brian Paul
Explicity convert strings to unicode before writing. This fixes an error when building with MinGW: Traceback (most recent call last): File "/var/workspace/tests/find_static_tests.py", line 74, in main() File "/var/workspace/tests/find_static_tests.py", line 69, in main f.write(filename

Re: [Piglit] [PATCH 3/5] framework: handle UnicodeDecodeError

2018-05-02 Thread Dylan Baker
Quoting Marek Olšák (2018-05-02 13:55:06) > On Wed, May 2, 2018 at 4:48 PM, Dylan Baker wrote: > > Quoting Marek Olšák (2018-05-02 13:32:45) > > From: Marek Olšák > > > > This happens due to LLVM printing colored text into stdout/stderr on > error. > > --- > >  framew

Re: [Piglit] [PATCH 1/5] framework/html: guard against errors writing individual test results

2018-05-02 Thread Marek Olšák
On Wed, May 2, 2018 at 4:51 PM, Dylan Baker wrote: > Quoting Marek Olšák (2018-05-02 13:32:43) > > From: Nicolai Hähnle > > > > --- > > framework/summary/html_.py | 18 +++--- > > 1 file changed, 11 insertions(+), 7 deletions(-) > > > > diff --git a/framework/summary/html_.py b/fram

[Piglit] [PATCH 4/4] crucible: if a test has not XML output consider it a crash

2018-05-02 Thread Dylan Baker
--- tests/crucible.py | 10 ++ 1 file changed, 10 insertions(+) diff --git a/tests/crucible.py b/tests/crucible.py index 476869a31..635033a74 100644 --- a/tests/crucible.py +++ b/tests/crucible.py @@ -32,7 +32,13 @@ import six import subprocess import tempfile +try: +from lxml imp

[Piglit] [PATCH 2/4] crucible: use tempfiles to allow running with concurrency

2018-05-02 Thread Dylan Baker
Because concurrency is nice. --- tests/crucible.py | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/crucible.py b/tests/crucible.py index 796d0951a..71ccf9d70 100644 --- a/tests/crucible.py +++ b/tests/crucible.py @@ -30,6 +30,7 @@ from __future__ import ( import

[Piglit] [PATCH 1/4] crucible: fix getting values from piglit.conf

2018-05-02 Thread Dylan Baker
--- tests/crucible.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/crucible.py b/tests/crucible.py index 279cadde8..796d0951a 100644 --- a/tests/crucible.py +++ b/tests/crucible.py @@ -39,7 +39,7 @@ __all__ = ['profile'] crucible_bin = os.environ.get('PIGLIT_CRUCIBL

[Piglit] [PATCH 3/4] crucible: ensure tempfile is removed even if there's an error.

2018-05-02 Thread Dylan Baker
--- tests/crucible.py | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/crucible.py b/tests/crucible.py index 71ccf9d70..476869a31 100644 --- a/tests/crucible.py +++ b/tests/crucible.py @@ -57,11 +57,13 @@ class CrucibleTest(Test): super(CrucibleTest,

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-02 Thread Dylan Baker
Quoting Juan A. Suarez Romero (2018-05-02 09:49:08) > Hi, Dylan. > > I see you've pushed this series. > > Now, when I'm trying to run some profiles (mainly, tests/crucible and > tests/khr_gl* ), seems they are broken: > > [/7776] > Traceback (most recent call last): > File "./piglit", line

Re: [Piglit] [PATCH 3/5] framework: handle UnicodeDecodeError

2018-05-02 Thread Marek Olšák
On Wed, May 2, 2018 at 4:48 PM, Dylan Baker wrote: > Quoting Marek Olšák (2018-05-02 13:32:45) > > From: Marek Olšák > > > > This happens due to LLVM printing colored text into stdout/stderr on > error. > > --- > > framework/test/base.py | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff

Re: [Piglit] [PATCH 1/5] framework/html: guard against errors writing individual test results

2018-05-02 Thread Dylan Baker
Quoting Marek Olšák (2018-05-02 13:32:43) > From: Nicolai Hähnle > > --- > framework/summary/html_.py | 18 +++--- > 1 file changed, 11 insertions(+), 7 deletions(-) > > diff --git a/framework/summary/html_.py b/framework/summary/html_.py > index f7fdc8576..512b42c24 100644 > --- a/

Re: [Piglit] [PATCH 4/5] khr_gl45: add support for mustpass lists

2018-05-02 Thread Dylan Baker
Quoting Marek Olšák (2018-05-02 13:32:46) > From: Nicolai Hähnle > > --- > tests/khr_gl45.py | 15 +-- > 1 file changed, 9 insertions(+), 6 deletions(-) > > diff --git a/tests/khr_gl45.py b/tests/khr_gl45.py > index 08e6280bb..95f474220 100644 > --- a/tests/khr_gl45.py > +++ b/tests

Re: [Piglit] [PATCH 5/5] deqp_egl: add support for mustpass lists

2018-05-02 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Marek Olšák (2018-05-02 13:32:47) > From: Nicolai Hähnle > > --- > tests/deqp_egl.py | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/tests/deqp_egl.py b/tests/deqp_egl.py > index 7422c82e3..ccd40b2af 100644 > --- a/tests/deq

Re: [Piglit] [PATCH 3/5] framework: handle UnicodeDecodeError

2018-05-02 Thread Dylan Baker
Quoting Marek Olšák (2018-05-02 13:32:45) > From: Marek Olšák > > This happens due to LLVM printing colored text into stdout/stderr on error. > --- > framework/test/base.py | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/framework/test/base.py b/framework/test/base.py > index 134b87

Re: [Piglit] [PATCH 2/5] framework: fix grouptools.commonprefix when len(args) == 1

2018-05-02 Thread Dylan Baker
Reviewed-by: Dylan Baker Quoting Marek Olšák (2018-05-02 13:32:44) > From: Nicolai Hähnle > > --- > framework/grouptools.py | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/framework/grouptools.py b/framework/grouptools.py > index f28241d3c..ce2e97c79 100644 > --- a/fr

[Piglit] [PATCH] piglit-util: use _exit to skip context destruction

2018-05-02 Thread Marek Olšák
From: Marek Olšák --- tests/util/piglit-util.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/util/piglit-util.c b/tests/util/piglit-util.c index ed7d21c95..01207ffa5 100644 --- a/tests/util/piglit-util.c +++ b/tests/util/piglit-util.c @@ -58,20 +58,21 @@ # include # include # in

[Piglit] [PATCH 5/5] deqp_egl: add support for mustpass lists

2018-05-02 Thread Marek Olšák
From: Nicolai Hähnle --- tests/deqp_egl.py | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tests/deqp_egl.py b/tests/deqp_egl.py index 7422c82e3..ccd40b2af 100644 --- a/tests/deqp_egl.py +++ b/tests/deqp_egl.py @@ -19,36 +19,40 @@ # OUT OF OR IN CONNECTION WITH TH

[Piglit] [PATCH 4/5] khr_gl45: add support for mustpass lists

2018-05-02 Thread Marek Olšák
From: Nicolai Hähnle --- tests/khr_gl45.py | 15 +-- 1 file changed, 9 insertions(+), 6 deletions(-) diff --git a/tests/khr_gl45.py b/tests/khr_gl45.py index 08e6280bb..95f474220 100644 --- a/tests/khr_gl45.py +++ b/tests/khr_gl45.py @@ -36,34 +36,37 @@ PIGLIT_KHR_GL_BIN -- environm

[Piglit] [PATCH 1/5] framework/html: guard against errors writing individual test results

2018-05-02 Thread Marek Olšák
From: Nicolai Hähnle --- framework/summary/html_.py | 18 +++--- 1 file changed, 11 insertions(+), 7 deletions(-) diff --git a/framework/summary/html_.py b/framework/summary/html_.py index f7fdc8576..512b42c24 100644 --- a/framework/summary/html_.py +++ b/framework/summary/html_.py

[Piglit] [PATCH 2/5] framework: fix grouptools.commonprefix when len(args) == 1

2018-05-02 Thread Marek Olšák
From: Nicolai Hähnle --- framework/grouptools.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/framework/grouptools.py b/framework/grouptools.py index f28241d3c..ce2e97c79 100644 --- a/framework/grouptools.py +++ b/framework/grouptools.py @@ -82,21 +82,21 @@ def splitname(g

[Piglit] [PATCH 3/5] framework: handle UnicodeDecodeError

2018-05-02 Thread Marek Olšák
From: Marek Olšák This happens due to LLVM printing colored text into stdout/stderr on error. --- framework/test/base.py | 3 +++ 1 file changed, 3 insertions(+) diff --git a/framework/test/base.py b/framework/test/base.py index 134b87245..f187c0210 100644 --- a/framework/test/base.py +++ b/fra

Re: [Piglit] [PATCH v2] ext_texture_norm16-render: test for GL_EXT_texture_norm16

2018-05-02 Thread Eric Anholt
Tapani Pälli writes: > Test includes: >- texture uploads >- mipmap generation >- framebuffer creation >- rendering to >- reading from >- interaction with GL_EXT_copy_image > > v2: code cleanup > > Signed-off-by: Tapani Pälli > --- > tests/all.py

Re: [Piglit] [PATCH 7/7] nv_fog_distance: Test interactions with GL_FOG_COORDINATE

2018-05-02 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > The issuses section of GL_NV_fog_distance says: > > How does this extension interact with the EXT_fog_coord extension? > > If FOG_COORDINATE_SOURCE_EXT is set to FOG_COORDINATE_EXT, then > the fog distance mode is ignored. Howe

Re: [Piglit] [PATCH 6/7] nv_fog_distance: Simple rendering test

2018-05-02 Thread Eric Anholt
Ian Romanick writes: > diff --git a/tests/spec/nv_fog_distance/simple-draw.c > b/tests/spec/nv_fog_distance/simple-draw.c > new file mode 100644 > index 0..e7be6bf5e > --- /dev/null > +++ b/tests/spec/nv_fog_distance/simple-draw.c > @@ -0,0 +1,245 @@ > +/* Copyright © 2017 Intel Corporati

Re: [Piglit] [PATCH 5/7] nv_fog_distance: Simple touch test for the enums

2018-05-02 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > Signed-off-by: Ian Romanick > --- > tests/all.py | 5 + > tests/spec/CMakeLists.txt| 1 + > tests/spec/nv_fog_distance/CMakeLists.gl.txt | 11 ++ > tests/spec/nv_fog_distance/CMakeLists.txt

[Piglit] [PATCH] find_static_tests.py: fix python2 compatibility

2018-05-02 Thread Dylan Baker
Because python2 uses bytes, but python3 uses unicode. CC: Michel Dänzer Fixes: d42d909cd754d0e2c41eec60f3a1015f2d882b95 ("tests: Add script to find all hand written test files") --- tests/find_static_tests.py | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/

Re: [Piglit] [PATCH 1/7] gl-1.0-blend: Fix problems with blend extension detection

2018-05-02 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > There were two bugs here. First, GL_EXT_blend_color and > GL_EXT_blend_func_separate were only tested if the version is 1.4. This > is unnecessary because those extensions are part of OpenGL 1.4. Second, > GL_EXT_blend_minmax was typoed GL_EXT_ble

Re: [Piglit] [PATCH 2/7] gl-1.0-blend: Enable EXT_blend_subtract tests on implementations that lack EXT_blend_minmax

2018-05-02 Thread Eric Anholt
Ian Romanick writes: > From: Ian Romanick > > And vice versa. > > Signed-off-by: Ian Romanick > --- > tests/spec/gl-1.0/blend.c | 40 ++-- > 1 file changed, 26 insertions(+), 14 deletions(-) > > diff --git a/tests/spec/gl-1.0/blend.c b/tests/spec/gl-1.0/blen

Re: [Piglit] [PATCH 00/35] Serialize profiles into XML at build time

2018-05-02 Thread Juan A. Suarez Romero
Hi, Dylan. I see you've pushed this series. Now, when I'm trying to run some profiles (mainly, tests/crucible and tests/khr_gl* ), seems they are broken: [/7776] Traceback (most recent call last): File "./piglit", line 178, in main() File "./piglit", line 174, in main sys.exit(r

[Piglit] [PATCH] arb_fragment_shader_interlock: Fix image load/store test.

2018-05-02 Thread Plamena Manolova
This test is meant to check whether ARB_fragment_shader_interlock functions as expected by simulating blending behaviour via image load/stores. The formula used is meant to be used per-pixel not per-sample. With multisampling disabled the tests works as expected. Signed-off-by: Plamena Manolova -