Peter Eisentraut writes:
> On tis, 2010-09-28 at 12:18 -0400, Tom Lane wrote:
>> It would be good to get rid of this whitespace because (I believe) it is
>> one of very few reasons for needing to have any trailing whitespace in
>> git-controlled files. If we could get to a point where trailing
>>
On tis, 2010-09-28 at 12:18 -0400, Tom Lane wrote:
> I'm inclined to think that that's not a fatal objection; it's not like
> we haven't felt free to change psql's output format before. As long as
> we don't back-patch this change, it should be no worse than other things
> we've done to third-part
On mån, 2010-09-27 at 11:09 -0700, David Fetter wrote:
> I must be missing something pretty crucial here as far as the
> complexity of changing all the regression tests. Wouldn't trimming
> all trailing whitespace do the trick?
No, there is trailing whitespace that is significant.
--
Sent via
David Fetter writes:
> On Mon, Sep 27, 2010 at 03:11:07PM -0400, Robert Haas wrote:
>> Sure. But everyone using pg_regress will have to update their
>> regression test expected outputs.
> Again, I must be missing something super important. What is it that
> prevents people from doing
> find . -
On Tue, Sep 28, 2010 at 12:18 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Mon, Sep 27, 2010 at 2:09 PM, David Fetter wrote:
>>> I must be missing something pretty crucial here as far as the
>>> complexity of changing all the regression tests. Wouldn't trimming
>>> all trailing whitespace do
Robert Haas writes:
> On Mon, Sep 27, 2010 at 2:09 PM, David Fetter wrote:
>> I must be missing something pretty crucial here as far as the
>> complexity of changing all the regression tests. Wouldn't trimming
>> all trailing whitespace do the trick?
> Sure. But everyone using pg_regress will
On Mon, Sep 27, 2010 at 4:12 PM, David Fetter wrote:
> On Mon, Sep 27, 2010 at 03:11:07PM -0400, Robert Haas wrote:
>> On Mon, Sep 27, 2010 at 2:09 PM, David Fetter wrote:
>> > On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote:
>> >> On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera
>> >>
On Mon, Sep 27, 2010 at 03:11:07PM -0400, Robert Haas wrote:
> On Mon, Sep 27, 2010 at 2:09 PM, David Fetter wrote:
> > On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote:
> >> On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera
> >> wrote:
> >> > Excerpts from David E. Wheeler's message of
On Mon, Sep 27, 2010 at 2:09 PM, David Fetter wrote:
> On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote:
>> On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera
>> wrote:
>> > Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010:
>> >> On Sep 27, 2010, at 5:05 AM, Pete
On Mon, Sep 27, 2010 at 01:53:45PM -0400, Robert Haas wrote:
> On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera
> wrote:
> > Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010:
> >> On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote:
> >>
> >> > Um, no.
> >> >
> >> > In the
On Mon, Sep 27, 2010 at 1:34 PM, Alvaro Herrera
wrote:
> Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010:
>> On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote:
>>
>> > Um, no.
>> >
>> > In the meantime, I have arrived at the conclusion that doing this isn't
>> > worth
Excerpts from David E. Wheeler's message of lun sep 27 12:25:31 -0400 2010:
> On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote:
>
> > Um, no.
> >
> > In the meantime, I have arrived at the conclusion that doing this isn't
> > worth it because it will break all regression test output. We can f
On Sep 27, 2010, at 5:05 AM, Peter Eisentraut wrote:
> Um, no.
>
> In the meantime, I have arrived at the conclusion that doing this isn't
> worth it because it will break all regression test output. We can fix
> the stuff in our tree, but pg_regress is also used externally, and those
> guys wou
On fre, 2010-09-24 at 22:38 +0100, Roger Leigh wrote:
> On Tue, Sep 21, 2010 at 09:28:07PM +0300, Peter Eisentraut wrote:
> > Everyone using git diff in color mode will already or soon be aware that
> > psql, for what I can only think is an implementation oversight, produces
> > trailing whitespace
On Tue, Sep 21, 2010 at 09:28:07PM +0300, Peter Eisentraut wrote:
> Everyone using git diff in color mode will already or soon be aware that
> psql, for what I can only think is an implementation oversight, produces
> trailing whitespace in the table headers, like this:
>
> two | f1 $
> -
On Wed, Sep 22, 2010 at 09:48:12AM +0900, Itagaki Takahiro wrote:
> On Wed, Sep 22, 2010 at 3:28 AM, Peter Eisentraut wrote:
> > Everyone using git diff in color mode will already or soon be
> > aware that psql, for what I can only think is an implementation
> > oversight, produces trailing whites
On Wed, Sep 22, 2010 at 3:28 AM, Peter Eisentraut wrote:
> Everyone using git diff in color mode will already or soon be aware that
> psql, for what I can only think is an implementation oversight, produces
> trailing whitespace in the table headers,
I think removing trailing whitespace in header
Everyone using git diff in color mode will already or soon be aware that
psql, for what I can only think is an implementation oversight, produces
trailing whitespace in the table headers, like this:
two | f1 $
-+$
| asdfghjkl;$
| d34aaasdf$
(2 rows)$
($ is the l
18 matches
Mail list logo
