On Tue, Sep 28, 2010 at 12:18 PM, Tom Lane <t...@sss.pgh.pa.us> wrote: > Robert Haas <robertmh...@gmail.com> writes: >> On Mon, Sep 27, 2010 at 2:09 PM, David Fetter <da...@fetter.org> wrote: >>> I must be missing something pretty crucial here as far as the >>> complexity of changing all the regression tests. Wouldn't trimming >>> all trailing whitespace do the trick? > >> Sure. But everyone using pg_regress will have to update their >> regression test expected outputs. > > I'm inclined to think that that's not a fatal objection; it's not like > we haven't felt free to change psql's output format before. As long as > we don't back-patch this change, it should be no worse than other things > we've done to third-party code without a backwards glance. > > It would be good to get rid of this whitespace because (I believe) it is > one of very few reasons for needing to have any trailing whitespace in > git-controlled files. If we could get to a point where trailing > whitespace in patches could be rejected automatically, it'd eliminate > one small pet peeve.
I have to agree that would be nice. -- Robert Haas EnterpriseDB: http://www.enterprisedb.com The Enterprise Postgres Company -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
