> On 13 Sep 2017, at 01:24, Daniel Gustafsson wrote:
>
>> On 18 Apr 2017, at 05:13, Amos Bird wrote:
>>
>> Ah, thanks for the suggestions. I'll revise this patch soon :)
>
> Have you had a chance to revise the patch to address the review comments such
> that the patch can move forward during t
> On 18 Apr 2017, at 05:13, Amos Bird wrote:
>
> Ah, thanks for the suggestions. I'll revise this patch soon :)
Have you had a chance to revise the patch to address the review comments such
that the patch can move forward during this Commitfest?
cheers ./daniel
--
Sent via pgsql-hackers mail
Ah, thanks for the suggestions. I'll revise this patch soon :)
Fabien COELHO writes:
>> Done.
>
> Ok. The file should be named "v2".
>
>> Would you like to be the reviewer?
>
> Dunno. At least I wanted to have a look at it!
>
> My 0.02€:
>
> I think that the improvement provided is worthwhile.
Done.
Ok. The file should be named "v2".
Would you like to be the reviewer?
Dunno. At least I wanted to have a look at it!
My 0.02€:
I think that the improvement provided is worthwhile.
Two questions: Why no documentation update? Why no non-regressions
tests?
As far as the output is
Done. Would you like to be the reviewer? Thanks! diff --git a/src/bin/psql/describe.c b/src/bin/psql/describe.c
index 0f9f497..a6dc599 100644
--- a/src/bin/psql/describe.c
+++ b/src/bin/psql/describe.c
@@ -3284,7 +3284,7 @@ listTables(const char *tabtypes, const char *pattern, bool verbose, bool s
I'm not sure where to add documentations about this patch or if needed one.
Please help
me if you think this patch is useful.
This patch does not apply anymore. Are you planning to update it?
--
Fabien.
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes t
* Robert Haas (robertmh...@gmail.com) wrote:
> On Mon, Mar 6, 2017 at 9:30 AM, Stephen Frost wrote:
> > * Amos Bird (amosb...@gmail.com) wrote:
> >> Well, the prefix is used to differentiate other \d commands, like
> >> this,
> >
> > Ah, ok, fair enough.
> >
> > Should we consider differentiating
On Mon, Mar 6, 2017 at 9:30 AM, Stephen Frost wrote:
> * Amos Bird (amosb...@gmail.com) wrote:
>> Well, the prefix is used to differentiate other \d commands, like
>> this,
>
> Ah, ok, fair enough.
>
> Should we consider differentiating different table types also? I
> suppose those are primairly
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 3/8/17 08:30, Stephen Frost wrote:
> > Right, I don't think having an extra column which is going to be NULL a
> > large amount of the time is good.
>
> Note that \di already has a column "Table" that is null for something
> that is
Peter,
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
> On 3/8/17 04:11, Ashutosh Bapat wrote:
> > The header for this table is "list of relations", so type gets
> > associated with relations indicated type of relation. btree: gin as a
> > type of relation doesn't sound really great.
On 3/8/17 08:30, Stephen Frost wrote:
> Right, I don't think having an extra column which is going to be NULL a
> large amount of the time is good.
Note that \di already has a column "Table" that is null for something
that is not an index. So I don't think this argument is very strong.
--
Peter
On 3/8/17 04:11, Ashutosh Bapat wrote:
> The header for this table is "list of relations", so type gets
> associated with relations indicated type of relation. btree: gin as a
> type of relation doesn't sound really great. Instead we might want to
> add another column "access method" and specify th
On Wed, Mar 8, 2017 at 7:00 PM, Stephen Frost wrote:
> Ashutosh,
>
> * Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote:
>> On Mon, Mar 6, 2017 at 7:54 PM, Amos Bird wrote:
>> > Well, the prefix is used to differentiate other \d commands, like
>> > this,
>> >
>> > amos=# \ditv
>> >
Ashutosh,
* Ashutosh Bapat (ashutosh.ba...@enterprisedb.com) wrote:
> On Mon, Mar 6, 2017 at 7:54 PM, Amos Bird wrote:
> > Well, the prefix is used to differentiate other \d commands, like
> > this,
> >
> > amos=# \ditv
> > List of relations
> > Schema |Name
On Mon, Mar 6, 2017 at 7:54 PM, Amos Bird wrote:
>
> Hello Stephen,
>
> Well, the prefix is used to differentiate other \d commands, like
> this,
>
> amos=# \ditv
> List of relations
> Schema |Name| Type | Owner | Table
> +---
Yeah, I'm thinking about that too. Here is a full list of the original
type values,
"Schema"
"Name"
"table"
"view"
"materialized view"
"index"
"sequence"
"special"
"foreign table"
"table"
What else do you think will benefit from extra type information?
regards,
Amos
Stephen Frost writes:
> A
Amos,
* Amos Bird (amosb...@gmail.com) wrote:
> Well, the prefix is used to differentiate other \d commands, like
> this,
Ah, ok, fair enough.
Should we consider differentiating different table types also? I
suppose those are primairly just logged and unlogged, but I could see
that being useful
Hello Stephen,
Well, the prefix is used to differentiate other \d commands, like
this,
amos=# \ditv
List of relations
Schema |Name| Type | Owner | Table
++--+---+-
public | i | t
Greetings,
* Amos Bird (amosb...@gmail.com) wrote:
> psql currently supports \di+ to view indexes,
>
> List of relations
> Schema |Name| Type | Owner | Table | Size | Description
> ++---+---+-+
psql currently supports \di+ to view indexes,
List of relations
Schema |Name| Type | Owner | Table | Size | Description
++---+---+-++-
public | ii | index | amos |
20 matches
Mail list logo
