Re: [HACKERS] [pgsql-www] Schedule for migration to pglister

2017-11-06 Thread Magnus Hagander
On Mon, Nov 6, 2017 at 5:00 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Mon, Nov 6, 2017 at 4:46 PM, Tom Lane wrote: > >> Hm, around here it's no match -> spam bucket. But in any case, why > > > I think you're quite uncommon in that setup. >

Re: [HACKERS] [pgsql-www] Schedule for migration to pglister

2017-11-06 Thread Magnus Hagander
On Mon, Nov 6, 2017 at 4:46 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Mon, Nov 6, 2017 at 4:40 PM, Tom Lane wrote: > >> I suggest doing that the other way 'round. Otherwise, the email > >> about the change will inevitably go into a lot of peoples&#

Re: [HACKERS] [pgsql-www] Schedule for migration to pglister

2017-11-06 Thread Magnus Hagander
the migration, not the bitbucket. That's the default action in most peoples MUAs when their rules no longer match... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Exclude pg_internal.init from base backup

2017-11-05 Thread Magnus Hagander
o seems the list in the documentation is not in sync with the code. AFAICT docs are not mentioning the current_logfile. This seems to be a miss in 19dc233c32f ? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Minor comment issue in receivelog.c

2017-11-05 Thread Magnus Hagander
_STREAMING is what's returned by START_REPLICATION. Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Comment typo

2017-10-30 Thread Magnus Hagander
On Mon, Oct 30, 2017 at 3:49 AM, Etsuro Fujita wrote: > Here is a patch to fix a typo in a comment in partition.c: > s/specificiation/specification/. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-li

Re: [HACKERS] git down

2017-10-30 Thread Magnus Hagander
ng sessions. I've cleaned up for now and it seems to be working again, and we'll do some more digging into what actually was the root cause. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] stalled post to mailing list - wrong filter?

2017-10-22 Thread Magnus Hagander
nd then, and will get released from the moderation queue quickly I'm sure :) Long term we'll be getting rid of those filters, but they're there for a while longer. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] A handful of typos in allpaths.c

2017-10-19 Thread Magnus Hagander
On Wed, Oct 18, 2017 at 4:45 AM, David Rowley wrote: > A small patch to fix these is attached. > Applied, thanks. I backpatched the actual error message typo fix. Left the comment alone in backbranches because it conflicted, so it didn't seem worth it. -- Magnus Hagander

Re: [HACKERS] Fix a typo in libpq/auth.c

2017-10-19 Thread Magnus Hagander
On Thu, Oct 19, 2017 at 12:05 PM, Masahiko Sawada wrote: > Hi, > > Attached a patch for $subject. > > s/RAIDUS/RADIUS/ > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Determine state of cluster (HA)

2017-10-16 Thread Magnus Hagander
don't reroute active connections based on it, and we're not smart enough to do anything beyond "try them one by one until you reach the one with the correct attributes", but the basic functionality is there. Basically what we already have fulfills what JD is suggesting, but

Re: [HACKERS] v10 bottom-listed

2017-10-13 Thread Magnus Hagander
ugly. Once the caches expire I believe sorting should be correct. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] search path security issue?

2017-10-06 Thread Magnus Hagander
for memory parameters and such. We have no permissions at all when it comes to userset gucs today -- and of course, if something should be added about this, it should be done in a way that works for all the userset variables, not just search_path. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] list of credits for release notes

2017-10-04 Thread Magnus Hagander
too much to ask. > Whether that's traditionally or not very much depends on which part of the world you are in, I believe. Let's try to avoid going down that rabbithole :) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Possible SSL improvements for a newcomer to tackle

2017-10-03 Thread Magnus Hagander
On Tue, Oct 3, 2017 at 3:51 PM, Stephen Frost wrote: > Tom, > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > > Magnus Hagander writes: > > > On Tue, Oct 3, 2017 at 6:33 AM, Tom Lane wrote: > > >> I'm not an SSL expert, so insert appropriate grain of salt, b

Re: [HACKERS] Possible SSL improvements for a newcomer to tackle

2017-10-03 Thread Magnus Hagander
essy and unreliable, > so I'm not sure it would really add any security. > No that's horrible. If it's unreliable, it doesn't provide any actual benefit. We have a history of that in our default being prefer instead of allow, but we definitely shouldn't make that situation e

Re: [HACKERS] 64-bit queryId?

2017-10-02 Thread Magnus Hagander
deal with a lot of such parameters changing around. I'm sure most of them would be more than happy with an improvement, even if it's not mathematically perfect. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Enhancements to passwordcheck

2017-09-29 Thread Magnus Hagander
nice? > I believe it's usually referred to as "localhost"? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Built-in plugin for logical decoding output

2017-09-26 Thread Magnus Hagander
ast to > support logical replication). > > But what about earlier versions? Any chance it could be backported > down to 9.4? If that would be acceptable, I could probably help/do that... The likelihood is zero if you mean backported into core of earlier versions. If you mean backported as a standalone extension that could be installed on a previous version, probably. I'm not sure if it relies on any internals not present before that would make it harder, but it would probably at least be possible. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Built-in plugin for logical decoding output

2017-09-26 Thread Magnus Hagander
On Tue, Sep 26, 2017 at 7:42 AM, Alvaro Hernandez wrote: > > > On 25/09/17 22:13, Magnus Hagander wrote: > > On Mon, Sep 25, 2017 at 8:20 PM, Alvaro Hernandez wrote: > >> >> >> On 25/09/17 20:18, Andres Freund wrote: >> >>> O

Re: [HACKERS] Built-in plugin for logical decoding output

2017-09-25 Thread Magnus Hagander
e will accept it as such, and that's good enough. > Historically the fact that we have been pickier than many of the "someone big":s is exactly how we ended up with the codebase and relative stability we have today. Just because someone is big doesn't mean they know what

Re: [HACKERS] Reading backup label file for checkpoint and redo location during crash recovery

2017-09-25 Thread Magnus Hagander
tinguish > between the recovery from the dump and the regular crash recovery? > > This is why the exclusive backup method has been deprecated in PG10 in > favor of the non-exclusive backup method, which avoids this by not > creating a backup label file (it's up to the backup s

Re: [HACKERS] Reporting query on crash even if completed

2017-09-18 Thread Magnus Hagander
the query when the backend is > idle, I'd change the display for that case to: > > DETAIL: Failed process was idle; last query was: %s > > Or something like that. I guess we'd need another case for a backend > that crashed without ever running a query. > +1, t

Re: [HACKERS] pg_basebackup behavior on non-existent slot

2017-09-14 Thread Magnus Hagander
On Tue, Sep 12, 2017 at 7:35 PM, Jeff Janes wrote: > On Wed, Sep 6, 2017 at 2:50 AM, Alvaro Herrera > wrote: > >> Magnus Hagander wrote: >> > On Mon, Sep 4, 2017 at 3:21 PM, Jeff Janes >> wrote: >> >> > > Should the parent process of pg_baseba

Re: [HACKERS] Supporting huge pages on Windows

2017-09-13 Thread Magnus Hagander
On Wed, Sep 13, 2017 at 3:41 AM, Tsunakawa, Takayuki < tsunakawa.ta...@jp.fujitsu.com> wrote: > Hi Thomas, Magnus > > From: pgsql-hackers-ow...@postgresql.org > > [mailto:pgsql-hackers-ow...@postgresql.org] On Behalf Of Thomas Munro > > Since it only conflicts with c

Re: [HACKERS] pg_basebackup behavior on non-existent slot

2017-09-12 Thread Magnus Hagander
On Wed, Sep 6, 2017 at 11:50 AM, Alvaro Herrera wrote: > Magnus Hagander wrote: > > On Mon, Sep 4, 2017 at 3:21 PM, Jeff Janes wrote: > > > > Should the parent process of pg_basebackup be made to respond to > SIGCHLD? > > > Or call waitpid(bgchild, &st

Re: [HACKERS] WIP: Separate log file for extension

2017-09-10 Thread Magnus Hagander
ugh that I got the two confused :) Based on the feedback of that one, have you done any performance checks? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] log_destination=file

2017-09-07 Thread Magnus Hagander
? To the console, to /dev/null or to a file? 2. Could you run the same thing (on the same machine) with the logging collector on and logging to file, without the patch? I'd assume that gives performance similar to running with the patch, but it would be good to confirm that. And thanks for ru

Re: [HACKERS] GnuTLS support

2017-09-07 Thread Magnus Hagander
ql.conf as well? It will still be a mess though -- documentation, and tutorials around and whatnot, will be dependent on library. But I'm not sure we can really get around that. Do we have some examples of how other products that support multiple libraries do to handle this? > > I

Re: [HACKERS] pg_basebackup behavior on non-existent slot

2017-09-05 Thread Magnus Hagander
we should react. And we should then exit the main process with an error before actually streaming everything. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Release Note changes

2017-09-04 Thread Magnus Hagander
ference is alongside a bunch of other third-party > tools. Mentioning it at the very top of our release notes would give > it a pride of place with which I'm not too comfortable. > I agree that singling it out there is probably not the best idea. But a sentence/paragraph

Re: [HACKERS] Function to move the position of a replication slot

2017-09-03 Thread Magnus Hagander
On Sun, Sep 3, 2017 at 12:20 AM, Robert Haas wrote: > On Fri, Sep 1, 2017 at 11:30 PM, Peter Eisentraut > wrote: > > On 8/31/17 08:19, Magnus Hagander wrote: > >> Rebased. Now named pg_advance_replication_slot. ERROR on logical slots. > >> Forward only. >

Re: [HACKERS] adding the commit to a patch's thread

2017-09-03 Thread Magnus Hagander
On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson wrote: > > On 03 Sep 2017, at 19:33, Magnus Hagander wrote: > > > > On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson <mailto:dan...@yesql.se>> wrote: > > > On 01 Sep 2017, at 15:40, Robert Haas robertmh.

Re: [HACKERS] adding the commit to a patch's thread

2017-09-03 Thread Magnus Hagander
ng the patch, for people who preferred to publish full branches for those that want it. This has been done for a grand total of 43 patches throughout (out of a total of 1231). Not sure if that's enough to say "let's not repurpose it"? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] log_destination=file

2017-09-01 Thread Magnus Hagander
On Fri, Sep 1, 2017 at 6:44 PM, Tom Lane wrote: > Magnus Hagander writes: > > On Fri, Sep 1, 2017 at 6:00 PM, Greg Stark wrote: > >> So what happens now with these messages? My understanding is that > >> they're missing from the CSV logs and are simply inserted

Re: [HACKERS] log_destination=file

2017-09-01 Thread Magnus Hagander
On Fri, Sep 1, 2017 at 6:00 PM, Greg Stark wrote: > On 31 August 2017 at 13:49, Tom Lane wrote: > > Magnus Hagander writes: > >> On Thu, Aug 31, 2017 at 2:34 PM, Tom Lane wrote: > > Yes, it's pretty important, because of assorted stuff not-under-our- > &

Re: [HACKERS] log_destination=file

2017-08-31 Thread Magnus Hagander
On Thu, Aug 31, 2017 at 2:34 PM, Tom Lane wrote: > Magnus Hagander writes: > > My understanding is that the main reason for this is that we cannot > change > > logging_collector without restarting postmaster, whereas we can change > > log_destination. > > Right, b

Re: [HACKERS] Function to move the position of a replication slot

2017-08-31 Thread Magnus Hagander
ed pg_advance_replication_slot. ERROR on logical slots. Forward only. I think that, in the end, covered all the comments? -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/> diff --git a/doc/src/

[HACKERS] log_destination=file

2017-08-31 Thread Magnus Hagander
int, simply because I haven't figured out how to pass the original stderr down to the syslogger. I'm sure there are also many other smaller issues around it, but I wanted to get the discussion done before I spend the time to go through those. Thoughts? -- Magnus Hagander Me: https:/

Re: [HACKERS] segment size depending *_wal_size defaults (was increasing the default WAL segment size)

2017-08-29 Thread Magnus Hagander
7;d rather just have the byte variant. > I'd say we definitely want the "user interface" to be in bytes(/mbytes/gbytes etc). We used to have that in segments and it was quite confusing for a lot of new uers, and seemed very silly... Also agreed that (1) above seems very confusi

Re: [HACKERS] Not listed as committer

2017-08-25 Thread Magnus Hagander
g. Should be fixed now, please try again. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] shared memory based stat collector (was: Sharing record typmods between backends)

2017-08-14 Thread Magnus Hagander
I got stalled when I feature-crept myself by realizing I wanted it snapshotted to WAL so it could fix the PITR and replication issues. And then properly bogged down when I realized that on the standby I'd want *both* the stats from the standby (while it's running) and the stats fr

Re: [HACKERS] Patches I'm thinking of pushing shortly

2017-08-14 Thread Magnus Hagander
waiting until v11 with it. We have plenty enough other things that could end up needing a quick post-release-release, and those are things that have received at least somem testing... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] More flexible LDAP auth search filters?

2017-07-17 Thread Magnus Hagander
On Mon, Jul 17, 2017 at 6:47 PM, Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 17/07/17 13:09, Magnus Hagander wrote: > > Hi Magnus, > > Great to hear from you! It has definitely been a while... > Indeed. You should spend more time on these lists :P

Re: [HACKERS] More flexible LDAP auth search filters?

2017-07-17 Thread Magnus Hagander
On Mon, Jul 17, 2017 at 1:23 AM, Stephen Frost wrote: > > * Magnus Hagander (mag...@hagander.net) wrote: > > On Sun, Jul 16, 2017 at 11:05 PM, Stephen Frost > wrote: > > > I'd suggest that we try to understand why Kerberos couldn't be used in > > > th

Re: [HACKERS] More flexible LDAP auth search filters?

2017-07-17 Thread Magnus Hagander
On Sun, Jul 16, 2017 at 7:58 PM, Mark Cave-Ayland < mark.cave-ayl...@ilande.co.uk> wrote: > On 16/07/17 00:08, Thomas Munro wrote: > > > On Fri, Jul 14, 2017 at 11:04 PM, Magnus Hagander > wrote: > >> On Thu, Jul 13, 2017 at 9:31 AM, Thomas Munr

Re: [HACKERS] More flexible LDAP auth search filters?

2017-07-16 Thread Magnus Hagander
On Sun, Jul 16, 2017 at 11:05 PM, Stephen Frost wrote: > Magnus, all, > > * Magnus Hagander (mag...@hagander.net) wrote: > > (FWIW, a workaround I've applied more than once to this in AD > environments > > (where kerberos for one reason or other can't be done, s

Re: [HACKERS] More flexible LDAP auth search filters?

2017-07-16 Thread Magnus Hagander
On Sun, Jul 16, 2017 at 1:08 AM, Thomas Munro wrote: > On Fri, Jul 14, 2017 at 11:04 PM, Magnus Hagander > wrote: > > On Thu, Jul 13, 2017 at 9:31 AM, Thomas Munro > > wrote: > >> A post on planet.postgresql.org today reminded me that a colleague had > >>

Re: [HACKERS] More flexible LDAP auth search filters?

2017-07-14 Thread Magnus Hagander
han once to this in AD environments (where kerberos for one reason or other can't be done, sorry Stephen) is to set up a RADIUS server and use that one as a "middle man". But it would be much better if we could do it natively) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

[HACKERS] Re: retry shm attach for windows (WAS: Re: OK, so culicidae is *still* broken)

2017-07-10 Thread Magnus Hagander
of windows testing on non packaged releases I think we should definitely push this for beta2. That will give it a much better real world testing on what is still a beta. If it breaks its a lot better to do it in beta2 (and possibly quickly roll a beta3) than in production. /Magnus

Re: [HACKERS] pg_receivewal and messages printed in non-verbose mode

2017-07-08 Thread Magnus Hagander
ed. I wonder if we should actually just remove the second message? AFAICT no other tools log that information. Is there any particular reason why we want that logging in pg_receivewal when we don't have it in other tools? //Magnus -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Fix header comment of streamutil.c

2017-07-07 Thread Magnus Hagander
Attached patch fixes this. > Yeah, both a typo and a missing user :) Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

2017-06-29 Thread Magnus Hagander
On Thu, Jun 22, 2017 at 6:22 PM, Masahiko Sawada wrote: > On Thu, Jun 22, 2017 at 10:36 PM, Magnus Hagander > wrote: > > > > > > On Thu, Jun 22, 2017 at 10:12 AM, Masahiko Sawada > > > wrote: > >> > >> Hi, > >> > >> Since an

Re: [HACKERS] Fix a typo in partition.c

2017-06-22 Thread Magnus Hagander
r/ > > > > fixed > > > > Thank you! > I found another one. > > s/retrived/retrieved/ > > Thanks, applied. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] pg_stop_backup(wait_for_archive := true) on standby server

2017-06-22 Thread Magnus Hagander
ckup with > wait_for_archive = true is executed on the standby. Attached patch > change it so that. > Wouldn't it be better to make it *work*? If you have archive_mode=always, it makes sense to want to wait on the standby as well, does it not? -- Magnus Hagander Me: https://www.h

Re: [HACKERS] Typo in drop_publication.sgml

2017-06-18 Thread Magnus Hagander
On Sun, Jun 18, 2017 at 8:46 AM, Julien Rouhaud wrote: > Patch attached. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Incorrect comment in 001_ssltests.pl

2017-06-17 Thread Magnus Hagander
; my $connstr = $_[0] > > But test_connect_ok and test_connect_fails do not have a second > argument as the hostname is appended directly into $common_connstr. > One could argue that the first sentences should just read "the argument" once the second one isn't referred, but I ca

Re: [HACKERS] Typos in comments

2017-06-17 Thread Magnus Hagander
On Sat, Jun 17, 2017 at 8:55 AM, Daniel Gustafsson wrote: > Spotted one “paramter” typo and git grep found two more, patch attached > with > s/paramter/parameter/ for these. > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net

Re: [HACKERS] Making server name part of the startup message

2017-06-15 Thread Magnus Hagander
e) as different database names with one mapping to the master and one mapping to a load-balanced set of standbys, and things like that. ISTM that using the database name is a good choice for that. For the original idea in this thread, using something like dbname@server seems a more logical

Re: [HACKERS] Why does logical replication launcher set application_name?

2017-06-07 Thread Magnus Hagander
tivity extension that is valid to fix in PG10. > +1. I definitely think it would be a bad idea to put in what basically looks like a workaround into 10, since the new feature was added there. I'd rather have the fix for pg_stat_activity. We used to keep our query state as a

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

2017-06-05 Thread Magnus Hagander
On Mon, Jun 5, 2017 at 1:35 PM, Amit Kapila wrote: > On Mon, Jun 5, 2017 at 4:58 PM, Magnus Hagander > wrote: > > On Mon, Jun 5, 2017 at 1:16 PM, Amit Kapila > wrote: > >> > >> On Mon, Jun 5, 2017 at 9:15 AM, Tom Lane wrote: > >> > Amit Kapila wr

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

2017-06-05 Thread Magnus Hagander
ata segments. It does randomize the entire location of the heap, in which case it might also change. But not for the individual block. But in neither of those cases does it help to retry without restarting the process, because the heap will be mapped into the same place, and any DLLs loading prior to our code will already have been loaded. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] comment fix in attoptcache.c

2017-06-02 Thread Magnus Hagander
tribute options cache. > */ > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Fix a typo in predicate.c

2017-06-02 Thread Magnus Hagander
On Fri, Jun 2, 2017 at 7:32 AM, Masahiko Sawada wrote: > Hi, > > While reading predicate lock source code, I found a comment typo in > predicate.c file. > Attached patch fixes it. > > s/scrach/scratch/ > Applied, thanks. -- Magnus Hagander Me: https:/

Re: [HACKERS] Re: [GENERAL] pg_basebackup error: replication slot "pg_basebackup_2194" already exists

2017-05-31 Thread Magnus Hagander
On Wed, May 31, 2017 at 8:18 PM, Andres Freund wrote: > On 2017-05-31 18:22:18 +0200, Magnus Hagander wrote: > > However, the client can't access the pid of the server as it is now, > > and its the client that has to create the name. > > I don't think that

[HACKERS] Re: [GENERAL] pg_basebackup error: replication slot "pg_basebackup_2194" already exists

2017-05-31 Thread Magnus Hagander
On Wed, May 31, 2017 at 12:20 AM, Ludovic Vaugeois-Pepin < ludovi...@gmail.com> wrote: > On Tue, May 30, 2017 at 9:32 PM, Magnus Hagander > wrote: > > On Tue, May 30, 2017 at 9:14 PM, Ludovic Vaugeois-Pepin > > wrote: > >> > >> I ran into the issue d

Re: [HACKERS] [COMMITTERS] Re: pgsql: Code review focused on new node types added by partitioning supp

2017-05-30 Thread Magnus Hagander
way. We're > > > already unlikely to reach 10.0 without bumping catversion, but if we > otherwise > > > did, releasing 10.0 with a 10beta1 catversion would have negative > value. > > > > I'm not really for doing it that way, but I'm willing to apply the

Re: [HACKERS] Fix a typo in execExpr.c

2017-05-29 Thread Magnus Hagander
On Mon, May 29, 2017 at 4:04 PM, Masahiko Sawada wrote: > Hi, > > Attached for $subject. > > s/Expession/Expression/ > Thanks, applied! -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: retry shm attach for windows (WAS: Re: [HACKERS] OK, so culicidae is *still* broken)

2017-05-26 Thread Magnus Hagander
think it's a good idea to give it some proper real world experience in 10 first. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Fix a typo in hash.c

2017-05-22 Thread Magnus Hagander
On Mon, May 22, 2017 at 3:36 AM, Masahiko Sawada wrote: > Hi, > > Attached patch for $subject. > > s/curent/current/ > > Applied, thanks! //Magnus

Re: [HACKERS] Making replication commands case-insensitive

2017-05-20 Thread Magnus Hagander
e code completely unreadable. And since any program using it should figure out pretty quickly that it's not working if they us the wrong casing... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] [COMMITTERS] pgsql: Tag refs/tags/REL_10_BETA1 was created

2017-05-17 Thread Magnus Hagander
maybe "10beta1" > > should be "10.beta1". > > That's not a naming format I've ever seen. > > I think the current format is fine. > > +1. I have also never seen that one, and think the current one is good. -- Magnus Hagander Me: https://www.ha

Re: [HACKERS] [PATCH v2] Progress command to monitor progression of long running SQL queries

2017-05-16 Thread Magnus Hagander
mber of reads etc),and this seems like it could be used for that as well. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Typos in pg_basebackup.c

2017-05-15 Thread Magnus Hagander
On Mon, May 15, 2017 at 7:02 AM, Michael Paquier wrote: > Hi all, > > Found $subject while working on the area. A patch is attached. > Thanks, > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redp

Re: [HACKERS] [patch] Build pgoutput with MSVC

2017-05-05 Thread Magnus Hagander
breaks with "patch unexpectedly ends in middle of line patch: Only garbage was found in the patch input.". But I can just copy/paste it manually :) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Error message on missing SCRAM authentication with older clients

2017-05-05 Thread Magnus Hagander
On Fri, May 5, 2017 at 10:19 AM, Aleksander Alekseev < a.aleks...@postgrespro.ru> wrote: > Hi Heikki, > > > psql: SCRAM authentication requires libpq version 10 or above > > Sounds good. > > +1. -- Magnus Hagander Me: https://www.hagander.net/ <http:

Re: [HACKERS] password_encryption, default and 'plain' support

2017-05-05 Thread Magnus Hagander
g libpq and never bothered to move to "md5". > > But then, it might be a good idea to break this application, because that > would force the vendor to implement something that is not a > blatant security problem. > It might. But I'm pretty sure the suggestion does no

Re: [HACKERS] Function to move the position of a replication slot

2017-05-04 Thread Magnus Hagander
On Thu, May 4, 2017 at 2:42 PM, Craig Ringer wrote: > On 4 May 2017 at 20:05, Magnus Hagander wrote: > > PFA a patch that adds a new function, pg_move_replication_slot, that > makes > > it possible to move the location of a replication slot without actually > > con

[HACKERS] Function to move the position of a replication slot

2017-05-04 Thread Magnus Hagander
. (Obviously this is intended for 11, as we're well into the freeze for 10. Just to be clear. so I'll go add itto the summer commitfest) -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com

Re: [HACKERS] [PostgreSQL 10] default of hot_standby should be "on"?

2017-05-03 Thread Magnus Hagander
On Wed, May 3, 2017 at 4:18 PM, Michael Banck wrote: > Hi, > > On Tue, May 02, 2017 at 11:13:58AM +0200, Magnus Hagander wrote: > > Looks good to me as well. Applied, with only a minor further docs > addition > > saying that this is the default also on the high

Re: [HACKERS] password_encryption, default and 'plain' support

2017-05-03 Thread Magnus Hagander
thing in time. It might make sense to ping other "major drivers" people as well -- such as maybe npgsql. What else? A good approach might be to change the default now, before beta. Then if drivers don't change, or if we get a lot of pushback from beta testers, we change it back before rel

Re: [HACKERS] password_encryption, default and 'plain' support

2017-05-03 Thread Magnus Hagander
On Wed, May 3, 2017 at 2:25 PM, Michael Paquier wrote: > On Wed, May 3, 2017 at 8:38 PM, Magnus Hagander > wrote: > > On Wed, May 3, 2017 at 1:31 PM, Heikki Linnakangas > wrote: > >> In various threads on SCRAM, we've skirted around the question of > whether &g

Re: [HACKERS] Error message on missing SCRAM authentication with older clients

2017-05-03 Thread Magnus Hagander
27;s not strictly speaking a bugfix to go in a backpatch, I think it will help enough users that it's worth doing. And I can't see how it could possibly be unsafe... -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] password_encryption, default and 'plain' support

2017-05-03 Thread Magnus Hagander
ic in the release notes mentioning the error message you get in libpq, and possibly some of the other most common drivers. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] scram and \password

2017-05-03 Thread Magnus Hagander
to use it in > psql and createuser. This closes the open issue with \password. If we're basically just telling people to call SHOW manually, we might as well do it in the default case. I think the wording you put into the docs there is good, as it tells people exactly what happens and how t

Re: [HACKERS] [PostgreSQL 10] default of hot_standby should be "on"?

2017-05-02 Thread Magnus Hagander
> Thanks, I attached the update patch. > > So it looks good to me. > Looks good to me as well. Applied, with only a minor further docs addition saying that this is the default also on the high availability page. And per the comments from Michael, I did not include the change to PostgresNode.pm. Thanks! -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] [PostgreSQL 10] default of hot_standby should be "on"?

2017-04-26 Thread Magnus Hagander
change that. I wonder if we should also consider changing the standby error message to be a WARNING instead of an ERROR. So that if you try to start up a standby with hot_standby=on but master with wal_level=replica it would turn into a cold standby. We should change the default independentl

Re: [HACKERS] scram and \password

2017-04-25 Thread Magnus Hagander
much liked that magic behavior of PQescapeString, and don't > think we should replicate it elsewhere, so I definitely don't like (C). > And I don't think we can do (B) because that will break the functionality > altogether when talking to an older server. That leaves (A) plus in

Re: [HACKERS] SCRAM authentication, take three

2017-04-18 Thread Magnus Hagander
e can also implement this functionality but under a differet name. Like just "hashed" or something, which would mean md5-or-scram? > In any case, I think we would probably still need more fine-grained > control, too, so we would still need to have "scram-sha-256" as a method > you can specify directly in pg_hba.conf. So I consider this as a separate, > new, feature that we can add in the future, if it seems worth the effort. > Yes, I think wherever we go we don't want to loose the fine-grained control. But some people will be happier for not having to use it. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] Self-signed certificate instructions

2017-04-15 Thread Magnus Hagander
> Seems reasonable, +1 for simplifications. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

2017-04-14 Thread Magnus Hagander
On Fri, Apr 14, 2017 at 9:36 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/14/17 14:45, Magnus Hagander wrote: > > Attached is a patch that can be applied to pgweb which should fix > all of > > this. > > > > > > &g

Re: [HACKERS] Wincrypt.h vs wincrypt.h

2017-04-14 Thread Magnus Hagander
g, I believe using lowercase is more or less the convention on Windows for this. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

2017-04-14 Thread Magnus Hagander
ly inject additional CSS > to be _more_ specific than the first CSS and set the font-size to a > simple '1em' so the first CSS is not called twice. I don't think > 'important!' is necessary but it would be good to test this. > > Attached is a patch that can be applied to pgweb which should fix all of > this. > > Applied, thanks. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Magnus Hagander
On Thu, Apr 13, 2017 at 9:13 PM, Bruce Momjian wrote: > On Thu, Apr 13, 2017 at 09:02:27PM +0200, Magnus Hagander wrote: > > On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut < > > peter.eisentr...@2ndquadrant.com> wrote: > > > > On 4/10/17 11:30, Magnu

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Magnus Hagander
statistics > - triggering heap scans to reclaim HEAP_MOVED_* bits, if we have that > kind of thing someday > > I agree it makes a lot of sense to have a separate tool that can do these things, and that pg_upgrade can point the user towards it. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>

Re: [HACKERS] pg_upgrade vs extension upgrades

2017-04-13 Thread Magnus Hagander
On Thu, Apr 13, 2017 at 12:30 AM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/10/17 11:30, Magnus Hagander wrote: > > After you've run pg_upgrade, you have to loop through all your databases > > and do an "ALTER EXTENSION abc UPDATE"

Re: [HACKERS] Function to control physical replication slot

2017-04-13 Thread Magnus Hagander
On Thu, Apr 13, 2017 at 2:40 AM, Andres Freund wrote: > On 2017-04-12 20:15:52 -0400, Peter Eisentraut wrote: > > On 4/11/17 05:15, Magnus Hagander wrote: > > > Is there a particular reason we don't have a function to *set* the > > > restart_lsn of a replication

Re: [HACKERS] [PATCH v1] Add and report the new "in_hot_standby" GUC pseudo-variable.

2017-04-12 Thread Magnus Hagander
On Wed, Apr 12, 2017 at 2:36 PM, Robert Haas wrote: > On Tue, Apr 11, 2017 at 4:05 AM, Magnus Hagander > wrote: > > On Tue, Apr 11, 2017 at 3:26 AM, Michael Paquier < > michael.paqu...@gmail.com> wrote: > >> On Mon, Apr 10, 2017 at 5:47 PM, Magnus Hagander >

Re: [HACKERS] Reversed sync check in pg_receivewal

2017-04-12 Thread Magnus Hagander
On Tue, Apr 11, 2017 at 6:51 PM, Tom Lane wrote: > Magnus Hagander writes: > > Something like the attached? > > Not sure about > > + * All methods that have a failure path will set errno on failure. > > Given that you've got a getlasterror method, I don't th

Re: [pgsql-www] [HACKERS] Small issue in online devel documentation build

2017-04-12 Thread Magnus Hagander
On Tue, Apr 11, 2017 at 4:30 PM, Peter Eisentraut < peter.eisentr...@2ndquadrant.com> wrote: > On 4/11/17 08:49, Magnus Hagander wrote: > > At the risk of being proven wrong again, won't this affect tags in > > the old documentation as well? And if so, is that some

  1   2   3   4   5   6   7   8   9   10   >