On Sun, Sep 3, 2017 at 8:55 PM, Daniel Gustafsson <dan...@yesql.se> wrote:
> > On 03 Sep 2017, at 19:33, Magnus Hagander <mag...@hagander.net> wrote: > > > > On Sun, Sep 3, 2017 at 12:00 AM, Daniel Gustafsson <dan...@yesql.se > <mailto:dan...@yesql.se>> wrote: > > > On 01 Sep 2017, at 15:40, Robert Haas <robertmh...@gmail.com <mailto: > robertmh...@gmail.com>> wrote: > > > > > > On Fri, Sep 1, 2017 at 4:26 AM, Alvaro Herrera < > alvhe...@alvh.no-ip.org <mailto:alvhe...@alvh.no-ip.org>> wrote: > > >> Erik Rijkers wrote: > > >>> Would it be possible to change the commitfest a bit and make it > possible to > > >>> add the commit (or commit-message, or hash) to the thread in the > > >>> commitfest-app. > > >> > > >> +1 to add one or more commit hashes to CF entry metadata. > > >> > > >> (Back-filling for old entries welcome) > > > > > > Couldn't the CF app scrape the commit messages for references to > > > threads, and if the commit message points to a thread with exactly 1 > > > patch record, associate the commit to that patch? > > > > Since there is a Gitlink field in the patch metadata, we could start > simple > > with setting that to link to the commit on pg gitweb? While adding the > thread > > of the commit from -committers would be great as well, this gets us off > the > > ground quickly. > > > > The original idea behind the gitlink field was to link to a git > repo/branch representing the patch, for people who preferred to publish > full branches for those that want it. > > > > This has been done for a grand total of 43 patches throughout (out of a > total of 1231). > > > > Not sure if that's enough to say "let's not repurpose it”? > > My thinking was that it wasn’t really repurposing, since the commit is > quite > representative of the patch and comma separated list could house both > (especially since the former usecase is quite rate). Looking at the code > however, the Gitlink is a UrlField which I believe won’t support that so > it’s > dead in the water either way. > I think that would definitely be repurposing it since it's not used for that in the past :) That leaves us back at parsing/scraping -committers and adding the > mailthread. > For this CF I can add the commits manually, since attaching a thread isn’t > limited to threads in -hackers. This way we have more time to figure out > an > automated way for the next CF. I’ve added the commit for my patch here as > an > example: > > https://commitfest.postgresql.org/14/1245/ That's a good start. We can also add a separate field that's just a comma separated list of commit hashes that auto-links to the git server if we want. *That* would be a trivial addition. Actually auto-populating it would probably be a lot less so, but for a manually managed one it should be fairly easy. -- Magnus Hagander Me: https://www.hagander.net/ <http://www.hagander.net/> Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/>
