Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

2011-10-03 Thread Heikki Linnakangas
On 04.10.2011 08:35, Amit Khandekar wrote: On 3 October 2011 22:37, Alex Hunsaker wrote: It might be worth adding a regression test also... I could not find any basic pl/perl tests in the regression serial_schedule. I am not sure if we want to add just this scenario without any basic tests fo

Re: [HACKERS] bug of recovery?

2011-10-03 Thread Fujii Masao
On Mon, Oct 3, 2011 at 4:32 PM, Simon Riggs wrote: >> I don't think this should use the rm_safe_restartpoint machinery. As you >> said, it's not tied to any specific resource manager. And I've actually been >> thinking that we will get rid of rm_safe_restartpoint altogether in the >> future. The t

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

2011-10-03 Thread Amit Khandekar
On 3 October 2011 22:37, Alex Hunsaker wrote: > On Mon, Oct 3, 2011 at 04:20, Amit Khandekar > wrote: > >> Is there a plan to commit this issue? I am still seeing this issue on >> PG 9.1 STABLE branch. Attached is a small patch that targets only the >> specific issue in the described testcase : >

Re: [HACKERS] Tracking latest timeline in standby mode

2011-10-03 Thread Fujii Masao
On Mon, Oct 3, 2011 at 3:18 PM, senthilnathan wrote: > Whether this feature is available in version 9.1.0. ?? Yes, it's available in 9.1.x. Regards, -- Fujii Masao NIPPON TELEGRAPH AND TELEPHONE CORPORATION NTT Open Source Software Center -- Sent via pgsql-hackers mailing list (pgsql-hackers

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Bruce Momjian wrote: > Alvaro Herrera wrote: > > > > Excerpts from Bruce Momjian's message of lun oct 03 17:28:53 -0300 2011: > > > > > > Alvaro Herrera wrote: > > > > > > Well, we have the Gentoo developer in this very thread. I'm sure they > > > > would fix their command line if we gave them

Re: [HACKERS] [v9.2] make_greater_string() does not return a string in some cases

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 2:13 PM, Robert Haas wrote: > On Thu, Sep 29, 2011 at 6:24 AM, Kyotaro HORIGUCHI > wrote: >> This is new version of make_greater_string patch. > > According to the comments in the original source code, the purpose of > savelastchar is to avoid confusing pg_mbcliplen().  You

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 06:45 PM, Bruce Momjian wrote: Alvaro Herrera wrote: Excerpts from Bruce Momjian's message of lun oct 03 17:28:53 -0300 2011: Alvaro Herrera wrote: Well, we have the Gentoo developer in this very thread. I'm sure they would fix their command line if we gave them a pg_ctl that

[HACKERS] restoring an object to a different name

2011-10-03 Thread Andrew Dunstan
This is a subject that has come up recently, and I can think of a number of use cases for it. However, there are lots of wrinkles. For example, the names of objects appear in LOTS of places, and making sure we caught them all might be quite tricky. Say you have a table x that inherits a,b, a

Re: [HACKERS] Separating bgwriter and checkpointer

2011-10-03 Thread Dickson S. Guedes
2011/10/3 Simon Riggs : > On Sun, Oct 2, 2011 at 11:45 PM, Dickson S. Guedes > wrote: >> I'm trying your patch, it was applied cleanly to master and compiled >> ok. But since I started postgres I'm seeing a  99% of CPU usage: > > Oh, thanks. I see what happened. I was toying with the idea of goin

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 10/03/2011 06:45 PM, Bruce Momjian wrote: > > Alvaro Herrera wrote: > >> Excerpts from Bruce Momjian's message of lun oct 03 17:28:53 -0300 2011: > >>> Alvaro Herrera wrote: > Well, we have the Gentoo developer in this very thread. I'm sure they > would f

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Aidan Van Dyk
On Mon, Oct 3, 2011 at 7:10 PM, Andrew Dunstan wrote: >> Agreed.  If you remove that, the logical problem goes away and it >> becomes a simple problem of dumping the contents of postgresql.conf and >> having pg_ctl (and pg_upgrade) use that.  Let me look at how much code >> that would take. >> >

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of lun oct 03 17:28:53 -0300 2011: > > > > Alvaro Herrera wrote: > > > > Well, we have the Gentoo developer in this very thread. I'm sure they > > > would fix their command line if we gave them a pg_ctl that worked. > > > Surely th

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 10/03/2011 04:41 PM, Peter Eisentraut wrote: > > On m?n, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > >> Why were people not using pg_ctl? Because of the limitations which > >> were fixed in PG 9.1? As Dave already said, windows already has to > >> use pg_ctl

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> No, because there are people who do intentionally use placeholder >> variables as session-local storage, and that would be taking away >> that capability. > Or do you want to open SET typo.wrogn TO 'foobar' to just work silently? Well, right at the

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 04:41 PM, Peter Eisentraut wrote: On mån, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: Why were people not using pg_ctl? Because of the limitations which were fixed in PG 9.1? As Dave already said, windows already has to use pg_ctl. Historically, pg_ctl has had a lot of lim

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Dimitri Fontaine
Tom Lane writes: > Dimitri Fontaine writes: >> Another compromise might be to allow for defining variable in any class >> from the configuration files but restrict that to existing classes from >> the SET command. Wait, that's exactly what happens as soon as there's >> no explicit custom_variabl

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Peter Eisentraut
On mån, 2011-10-03 at 15:09 -0400, Bruce Momjian wrote: > Why were people not using pg_ctl? Because of the limitations which > were fixed in PG 9.1? As Dave already said, windows already has to > use pg_ctl. Historically, pg_ctl has had a lot of limitations. Just off the top of my head, nonsta

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Tom Lane
Dimitri Fontaine writes: > Another compromise might be to allow for defining variable in any class > from the configuration files but restrict that to existing classes from > the SET command. Wait, that's exactly what happens as soon as there's > no explicit custom_variable_classes, right? No, b

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 4:25 PM, Simon Riggs wrote: > On Mon, Oct 3, 2011 at 8:07 PM, Robert Haas wrote: > >> Sorry, but I still don't really think it's fair to say that you've >> proposed a solution to this problem.  Or if you have, neither I nor >> Fujii Masao understand that proposal well enoug

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of lun oct 03 17:28:53 -0300 2011: > > Alvaro Herrera wrote: > > Well, we have the Gentoo developer in this very thread. I'm sure they > > would fix their command line if we gave them a pg_ctl that worked. > > Surely the package that contains the init scrip

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 3:59 PM, Bruce Momjian wrote: > pg_ctl would have to do some detective work to see if PG_VERSION existed > in that directory and adjust its behavior --- the pg_upgrade patch I > posted does this kind of detection.  The goal is the change would happen > only for people using

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Peter Eisentraut
On mån, 2011-10-03 at 19:11 +0100, Dave Page wrote: > On Mon, Oct 3, 2011 at 7:07 PM, Peter Eisentraut wrote: > > On mån, 2011-10-03 at 11:27 -0400, Bruce Momjian wrote: > >> Frankly, I am confused how this breakage has gone unreported for so > >> long. > > > > Well, nobody is required to use pg_c

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of lun oct 03 17:06:16 -0300 2011: > > > > Magnus Hagander wrote: > > > Well, how does the server get from the config file to where the state > > > file is? Can we do it the same way, or even expose it to the tools > > > using a comm

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-10-03 Thread Simon Riggs
On Mon, Oct 3, 2011 at 8:07 PM, Robert Haas wrote: > Sorry, but I still don't really think it's fair to say that you've > proposed a solution to this problem.  Or if you have, neither I nor > Fujii Masao understand that proposal well enough to decide whether we > like it. Arguing between trenche

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of lun oct 03 17:06:16 -0300 2011: > > Magnus Hagander wrote: > > Well, how does the server get from the config file to where the state > > file is? Can we do it the same way, or even expose it to the tools > > using a commandline parameter or something? > >

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directoriesf

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > The problem is pg_ctl has to read server _state_ which cannot be put > > in a configuration directory, and we don't even require the real data > > directory to be recorded in the config file. > > How so? It certainly is in postgresql.conf. See my other email, e.g. -o 'd

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of lun oct 03 16:55:54 -0300 2011: > > Alvaro Herrera wrote: > > > > Excerpts from Bruce Momjian's message of lun oct 03 16:09:08 -0300 2011: > > > > > Alvaro Herrera wrote: > > > > > > My guess is that we could fix the simple case (the one that doesn't >

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Magnus Hagander wrote: > Well, how does the server get from the config file to where the state > file is? Can we do it the same way, or even expose it to the tools > using a commandline parameter or something? In that case (the Gentoo example), they use --data-directory su -l postgres \

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Robert Haas wrote: > On Mon, Oct 3, 2011 at 3:09 PM, Bruce Momjian wrote: > > Well, we are unlikely to backpatch that parse-and-report option so it > > would be +2 years before it could be expected to work for even > > single-major-version upgrades. ?That just seems unworkable. ?Yeah. :-( > > I'd

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Magnus Hagander
On Mon, Oct 3, 2011 at 21:55, Bruce Momjian wrote: > Alvaro Herrera wrote: >> >> Excerpts from Bruce Momjian's message of lun oct 03 16:09:08 -0300 2011: >> >> > Alvaro Herrera wrote: >> >> > > My guess is that we could fix the simple case (the one that doesn't >> > > involve a "-o datadir" option

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of lun oct 03 16:09:08 -0300 2011: > > > Alvaro Herrera wrote: > > > > My guess is that we could fix the simple case (the one that doesn't > > > involve a "-o datadir" option) with the parse-and-report option that has > > > been men

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of lun oct 03 16:09:08 -0300 2011: > Alvaro Herrera wrote: > > My guess is that we could fix the simple case (the one that doesn't > > involve a "-o datadir" option) with the parse-and-report option that has > > been mentioned, and dictate that the other one

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 3:09 PM, Bruce Momjian wrote: > Well, we are unlikely to backpatch that parse-and-report option so it > would be +2 years before it could be expected to work for even > single-major-version upgrades.  That just seems unworkable.  Yeah. :-( I'd like to see the patch first, b

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Dimitri Fontaine
David Fetter writes: > Perhaps it's best to document this usage and include the warning for > those less "bright," as you term them. I'd be less tempted to call > them "not bright" and more tempted to think they might assume > PostgreSQL already takes care of cleaning this up, but whatever. Who

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of lun oct 03 16:03:47 -0300 2011: > > > > I'm not sure how big the overlap is - would it be easier if you moved > > > the required functionality into pg_upgrade itself, as you mentioned at > > > some point? As in, would it be easier

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > Excerpts from Bruce Momjian's message of lun oct 03 15:23:47 -0300 2011: > > Peter Eisentraut wrote: > > > On m?n, 2011-10-03 at 11:27 -0400, Bruce Momjian wrote: > > > > Frankly, I am confused how this breakage has gone unreported for so > > > > long. > > > > > > Well,

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of lun oct 03 16:03:47 -0300 2011: > > I'm not sure how big the overlap is - would it be easier if you moved > > the required functionality into pg_upgrade itself, as you mentioned at > > some point? As in, would it be easier to fix the config-only directory

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-10-03 Thread Robert Haas
On Sun, Oct 2, 2011 at 8:21 AM, Simon Riggs wrote: > The problem is to find the replication delay, even when the system is quiet. > > What I have proposed finds the replication delay more accurately even > than looking at the last commit, since often there are writes but no > commits. > > If we fo

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Magnus Hagander wrote: > >> So, you are saying that people who want config-only directories are just > >> not people who normally use pg_ctl, because if they were, they would > >> have reported the bug? ?That seems unlikely. ?I will admit the Gentoo > >> case is exactly that. > > > > As Dave has po

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Bruce Momjian's message of lun oct 03 15:23:47 -0300 2011: > Peter Eisentraut wrote: > > On m?n, 2011-10-03 at 11:27 -0400, Bruce Momjian wrote: > > > Frankly, I am confused how this breakage has gone unreported for so > > > long. > > > > Well, nobody is required to use pg_ctl, and

Re: [HACKERS] PostgreSQL X/Open Socket / BSD Socket Issue on HP-UX

2011-10-03 Thread Heikki Linnakangas
On 22.09.2011 13:51, MUHAMMAD ASIF wrote: You are right, _xpg_ socket functionality is not available in older systems, it is available in hp-ux 11.23 version through patch HCO_35744 . HPUX 10.20 is very old machine (1996). I am using latest HPUX B.11.31 machine, I don't have access to older sy

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Magnus Hagander
On Mon, Oct 3, 2011 at 20:39, Andrew Dunstan wrote: > > On 10/03/2011 02:25 PM, Bruce Momjian wrote: >> >> Andrew Dunstan wrote: >>> >>> On 10/03/2011 02:15 PM, Bruce Momjian wrote: Andrew Dunstan wrote: > > On 10/03/2011 12:54 PM, Tom Lane wrote: >> >> I was never exactl

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 10/03/2011 02:25 PM, Bruce Momjian wrote: > > Andrew Dunstan wrote: > >> > >> On 10/03/2011 02:15 PM, Bruce Momjian wrote: > >>> Andrew Dunstan wrote: > On 10/03/2011 12:54 PM, Tom Lane wrote: > > I was never exactly thrilled with the separate-config-direct

Re: [HACKERS] Unexpected collation error in 9.1.1

2011-10-03 Thread Christian Ullrich
* Tom Lane wrote: Christian Ullrich writes: I tried adding a not-null column in one step and got a collation error for a different column. itd=> alter table livedata add column pricechanged timestamp not null default current_timestamp; ERROR: no collation was derived for column "whois_

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 02:25 PM, Bruce Momjian wrote: Andrew Dunstan wrote: On 10/03/2011 02:15 PM, Bruce Momjian wrote: Andrew Dunstan wrote: On 10/03/2011 12:54 PM, Tom Lane wrote: I was never exactly thrilled with the separate-config-directory design to start with, so I'm probably not the person

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 10/03/2011 02:15 PM, Bruce Momjian wrote: > > Andrew Dunstan wrote: > >> > >> On 10/03/2011 12:54 PM, Tom Lane wrote: > >>> I was never exactly thrilled with the separate-config-directory design > >>> to start with, so I'm probably not the person to opine on whether

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Dave Page
On Mon, Oct 3, 2011 at 7:15 PM, Bruce Momjian wrote: > Andrew Dunstan wrote: >> >> >> On 10/03/2011 12:54 PM, Tom Lane wrote: >> > >> > I was never exactly thrilled with the separate-config-directory design >> > to start with, so I'm probably not the person to opine on whether we >> > could get aw

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Peter Eisentraut wrote: > On m?n, 2011-10-03 at 11:27 -0400, Bruce Momjian wrote: > > Frankly, I am confused how this breakage has gone unreported for so > > long. > > Well, nobody is required to use pg_ctl, and for the longest time, it was > pg_ctl that was considered to be broken (for various ot

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 02:15 PM, Bruce Momjian wrote: Andrew Dunstan wrote: On 10/03/2011 12:54 PM, Tom Lane wrote: I was never exactly thrilled with the separate-config-directory design to start with, so I'm probably not the person to opine on whether we could get away with removing it.

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Tom Lane wrote: > Bruce Momjian writes: > > Config-only directories seem to be only adding confusion. All possible > > solutions seem to be adding more code and user requirements, which the > > creation of symlinks avoids. > > > Is it time for me to ask on 'general' if removal of this feature is

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Andrew Dunstan wrote: > > > On 10/03/2011 12:54 PM, Tom Lane wrote: > > > > I was never exactly thrilled with the separate-config-directory design > > to start with, so I'm probably not the person to opine on whether we > > could get away with removing it. > > > > > > The ho

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 12:54 PM, Tom Lane wrote: I was never exactly thrilled with the separate-config-directory design to start with, so I'm probably not the person to opine on whether we could get away with removing it. The horse has well and truly bolted. We'd have a majo

Re: [HACKERS] [v9.2] make_greater_string() does not return a string in some cases

2011-10-03 Thread Robert Haas
On Thu, Sep 29, 2011 at 6:24 AM, Kyotaro HORIGUCHI wrote: > This is new version of make_greater_string patch. According to the comments in the original source code, the purpose of savelastchar is to avoid confusing pg_mbcliplen(). You've preserved savelastchar only for the case where datatype ==

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Dave Page
On Mon, Oct 3, 2011 at 7:07 PM, Peter Eisentraut wrote: > On mån, 2011-10-03 at 11:27 -0400, Bruce Momjian wrote: >> Frankly, I am confused how this breakage has gone unreported for so >> long. > > Well, nobody is required to use pg_ctl, You are if you wish to run as a service on Windows. -- D

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Peter Eisentraut
On mån, 2011-10-03 at 11:27 -0400, Bruce Momjian wrote: > Frankly, I am confused how this breakage has gone unreported for so > long. Well, nobody is required to use pg_ctl, and for the longest time, it was pg_ctl that was considered to be broken (for various other reasons) and avoided in packaged

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

2011-10-03 Thread Alex Hunsaker
On Mon, Oct 3, 2011 at 04:20, Amit Khandekar wrote: > Is there a plan to commit this issue? I am still seeing this issue on > PG 9.1 STABLE branch. Attached is a small patch that targets only the > specific issue in the described testcase : > > create or replace function zerob() returns text as $

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Tom Lane
Bruce Momjian writes: > Config-only directories seem to be only adding confusion. All possible > solutions seem to be adding more code and user requirements, which the > creation of symlinks avoids. > Is it time for me to ask on 'general' if removal of this feature is > warranted? Well, the way

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 12:25 PM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Oct 3, 2011 at 11:16 AM, Tom Lane wrote: >>> Robert Haas writes: Yeah.  custom_variable_classes is a pretty annoying wart, but if it's set to the default value (namely, empty) then it actually does preve

Re: [HACKERS] Unexpected collation error in 9.1.1

2011-10-03 Thread Tom Lane
Christian Ullrich writes: > I tried adding a not-null column in one step and got a collation > error for a different column. > itd=> alter table livedata add column pricechanged timestamp not null default > current_timestamp; > ERROR: no collation was derived for column "whois_b" with collatabl

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Alvaro Herrera wrote: > > Excerpts from Tom Lane's message of lun oct 03 12:34:22 -0300 2011: > > Bruce Momjian writes: > > > I am starting to question the value of config-only directories if pg_ctl > > > stop doesn't work, or you have to specify a different directory for > > > start and stop. >

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Tom Lane
Robert Haas writes: > On Mon, Oct 3, 2011 at 11:16 AM, Tom Lane wrote: >> Robert Haas writes: >>> Yeah.  custom_variable_classes is a pretty annoying wart, but if it's >>> set to the default value (namely, empty) then it actually does prevent >>> people from setting bajillions of completely poin

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 11:28 AM, Tom Lane wrote: > Robert Haas writes: >> On Mon, Oct 3, 2011 at 10:54 AM, Dimitri Fontaine >> wrote: >>> Robert Haas writes: I think that new versions of patch can handle unified diffs without a problem, but older versions choke on them.  My Mac has 2.

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 11:16 AM, Tom Lane wrote: > Robert Haas writes: >> Yeah.  custom_variable_classes is a pretty annoying wart, but if it's >> set to the default value (namely, empty) then it actually does prevent >> people from setting bajillions of completely pointless settings, which >> se

Re: [HACKERS] pg_dump issues

2011-10-03 Thread Tom Lane
Alvaro Herrera writes: > Excerpts from Tom Lane's message of lun oct 03 01:47:18 -0300 2011: >> (Without cassert, it looks like LockReassignCurrentOwner is the next >> biggest time sink; I'm wondering if there's some sort of O(N^2) behavior >> in there.) > That seems fishy. Even if there weren't

Re: [HACKERS] How can i get record by data block not by sql?

2011-10-03 Thread Kevin Grittner
Please don't cross-post. Responding on -hackers because it seems a better fit here than on -performance. "姜头" <104186...@qq.com> wrote: > How can i get record by data block not by sql? > > I want to read and write lots of data by data blocks and write > record to a appointed data block and rea

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Alvaro Herrera
Excerpts from Tom Lane's message of lun oct 03 12:34:22 -0300 2011: > Bruce Momjian writes: > > I am starting to question the value of config-only directories if pg_ctl > > stop doesn't work, or you have to specify a different directory for > > start and stop. > > Yup. > > > Did we not think of

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Dimitri Fontaine
Robert Haas writes: > Yeah, it just skips right over them. I've never had even a minor > problem on that account, which is why I was surprised to see it giving > you so much trouble. Ok then, I'll try some more next time. Been trying not to spend too much time here… on the other hand git apply

Re: [HACKERS] pg_dump issues

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 12:47 AM, Tom Lane wrote: Andrew Dunstan writes: While investigating a client problem I just observed that pg_dump takes a surprisingly large amount of time to dump a schema with a large number of views. The client's hardware is quite spiffy, and yet pg_dump is taking many minut

Re: [HACKERS] pg_dump issues

2011-10-03 Thread Alvaro Herrera
Excerpts from Tom Lane's message of lun oct 03 01:47:18 -0300 2011: > (Without cassert, it looks like LockReassignCurrentOwner is the next > biggest time sink; I'm wondering if there's some sort of O(N^2) behavior > in there.) That seems fishy. Even if there weren't quadratic behavior, should t

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Tom Lane
Bruce Momjian writes: > I am starting to question the value of config-only directories if pg_ctl > stop doesn't work, or you have to specify a different directory for > start and stop. Yup. > Did we not think of these things when we designed config-only > directories? I don't even see this prob

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of lun oct 03 11:54:36 -0300 2011: > Robert Haas writes: > > I think that new versions of patch can handle unified diffs without a > > problem, but older versions choke on them. My Mac has 2.5.8 and > > handles unidiffs no problem. > > Even containing gi

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Tom Lane
Robert Haas writes: > On Mon, Oct 3, 2011 at 10:54 AM, Dimitri Fontaine > wrote: >> Robert Haas writes: >>> I think that new versions of patch can handle unified diffs without a >>> problem, but older versions choke on them. My Mac has 2.5.8 and >>> handles unidiffs no problem. >> Even contain

Re: [HACKERS] Mismatch of relation names: pg_toast.pg_toast_nnn during pg_upgrade from 8.4 to 9.1

2011-10-03 Thread Bruce Momjian
Jamie Fox wrote: > I regret that as a part-timer recently brought back on here I didn't > get an opportunity to test this earlier. The upgrade with the patch > worked fine on my first attempt. Great. Thanks for the report, and sorry for the bug. -

Re: [HACKERS] Bug with pg_ctl -w/wait and config-only directories

2011-10-03 Thread Bruce Momjian
Fujii Masao wrote: > On Sun, Oct 2, 2011 at 7:54 AM, Bruce Momjian wrote: > > What exactly is your question? ?You are not using a config-only > > directory but the real data directory, so it should work fine. > > No. He is using PGDATA (= /etc/postgresql-9.0) as a config-only > directory, and DAT

Re: [HACKERS] pg_dump issues

2011-10-03 Thread Tom Lane
Robert Haas writes: > On Sat, Oct 1, 2011 at 9:46 PM, Andrew Dunstan wrote: >> How would that help? This isn't a lock failure. > It is, rather, a failure to lock. Currently, LOCK TABLE only works on > tables, and pg_dump only applies it to tables. If the offending > object had been a table rat

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Tom Lane
Robert Haas writes: > Yeah. custom_variable_classes is a pretty annoying wart, but if it's > set to the default value (namely, empty) then it actually does prevent > people from setting bajillions of completely pointless settings, which > seems like it has some merit. I'm not sure it has enough

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 10:54 AM, Dimitri Fontaine wrote: > Robert Haas writes: >> I think that new versions of patch can handle unified diffs without a >> problem, but older versions choke on them.  My Mac has 2.5.8 and >> handles unidiffs no problem. > > Even containing git headers? Yeah, it ju

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Robert Haas
On Mon, Oct 3, 2011 at 10:55 AM, David Fetter wrote: > Perhaps it's best to document this usage and include the warning for > those less "bright," as you term them.   I'd be less tempted to call > them "not bright" and more tempted to think they might assume > PostgreSQL already takes care of clea

Re: [HACKERS] pg_dump issues

2011-10-03 Thread Robert Haas
On Sat, Oct 1, 2011 at 9:46 PM, Andrew Dunstan wrote: > How would that help? This isn't a lock failure. It is, rather, a failure to lock. Currently, LOCK TABLE only works on tables, and pg_dump only applies it to tables. If the offending object had been a table rather than a view, pg_dump would

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread David Fetter
On Mon, Oct 03, 2011 at 10:41:48AM -0400, Tom Lane wrote: > Andrew Dunstan writes: > > On 10/03/2011 10:17 AM, Tom Lane wrote: > >> Right. Getting rid of custom_variable_classes should actually > >> make those use-cases easier, since it will eliminate a required > >> setup step. > > > So are we

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Dimitri Fontaine
Robert Haas writes: > I think that new versions of patch can handle unified diffs without a > problem, but older versions choke on them. My Mac has 2.5.8 and > handles unidiffs no problem. Even containing git headers? Here's what I'm talking about here: src/backend/catalog/objectaddress.c |

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Tom Lane
Andrew Dunstan writes: > On 10/03/2011 10:17 AM, Tom Lane wrote: >> Right. Getting rid of custom_variable_classes should actually make >> those use-cases easier, since it will eliminate a required setup step. > So are we going to sanction using this as a poor man's session variable > mechanism?

Re: [HACKERS] SPI_processed is not set for COPY statement

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 10:34 AM, Pavel Stehule wrote: Hello is there some possibility to get a processed rows from COPY statement from PL/pgSQL? I searched any ways, but there are no command tag. You mean something like a RETURNING clause? My worry would be about possible speed effects, although

[HACKERS] SPI_processed is not set for COPY statement

2011-10-03 Thread Pavel Stehule
Hello is there some possibility to get a processed rows from COPY statement from PL/pgSQL? I searched any ways, but there are no command tag. Regards Pavel Stehule -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Andrew Dunstan
On 10/03/2011 10:17 AM, Tom Lane wrote: Magnus Hagander writes: Don't forget that there are usecases for variables under custom_variable_classes that aren't actually associated with extensions (as general session-shared-variables). Though I guess if it was somehow restricted to extensions, th

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Tom Lane
Magnus Hagander writes: > Don't forget that there are usecases for variables under > custom_variable_classes that aren't actually associated with > extensions (as general session-shared-variables). Though I guess if it > was somehow restricted to extensions, those who needed that could just > rewr

[HACKERS] How can i get record by data block not by sql?

2011-10-03 Thread 姜头
How can i get record by data block not by sql? I want to read and write lots of data by data blocks and write a record to a appointed data blocks,so i can form a disk-resident tree by recording the block address. But i don't know how to implement in postgresql. Is there system function can do

Re: [HACKERS] [v9.2] DROP statement reworks

2011-10-03 Thread Robert Haas
On Sun, Oct 2, 2011 at 4:08 PM, Dimitri Fontaine wrote: > Ok I needed `git apply' to apply the patches, now that I used that I can > confirm that the 3 patches apply, compile, pass tests, and that I could > play with them a little.  I think I'm going to mark that ready for > commiter.  I don't hav

Re: [HACKERS] [PATCH] Unremovable tuple monitoring (was: Addition of some trivial auto vacuum logging)

2011-10-03 Thread Royce Ausburn
On 28/09/2011, at 11:17 AM, Tom Lane wrote: > Alvaro Herrera writes: >> Excerpts from Royce Ausburn's message of mar sep 27 21:28:26 -0300 2011: >>> Tom's suggestion looks like it's less trivial that I can do just yet, but >>> I'll take a look and ask for help if I need it. > >> It's not that d

[HACKERS] Unexpected collation error in 9.1.1

2011-10-03 Thread Christian Ullrich
I tried adding a not-null column in one step and got a collation error for a different column. Adding the column in several steps works: itd=> alter table livedata add column pricechanged timestamp not null default current_timestamp; ERROR: no collation was derived for column "whois_b" with co

Re: [HACKERS] Tracking latest timeline in standby mode

2011-10-03 Thread senthilnathan
Whether this feature is available in version 9.1.0. ?? -- View this message in context: http://postgresql.1045698.n5.nabble.com/Tracking-latest-timeline-in-standby-mode-tp3238829p4863900.html Sent from the PostgreSQL - hackers mailing list archive at Nabble.com. -- Sent via pgsql-hackers maili

Re: [HACKERS] Re: [COMMITTERS] pgsql: Force strings passed to and from plperl to be in UTF8 encoding.

2011-10-03 Thread Amit Khandekar
On 12 February 2011 14:48, Alex Hunsaker wrote: > On Sun, Feb 6, 2011 at 15:31, Andrew Dunstan wrote: >> Force strings passed to and from plperl to be in UTF8 encoding. >> >> String are converted to UTF8 on the way into perl and to the >> database encoding on the way back. This avoids a number of

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-10-03 Thread Fujii Masao
On Fri, Sep 30, 2011 at 4:18 PM, Simon Riggs wrote: > If we want to measure times, we can easily send regular messages into > WAL to provide this function. Using checkpoint records would seem > frequent enough to me. We don't always send checkpoint records but we > can send an info message instead

Re: [HACKERS] [REVIEW] pg_last_xact_insert_timestamp

2011-10-03 Thread Fujii Masao
On Sun, Oct 2, 2011 at 8:19 PM, Robert Haas wrote: > It occurs to me that pgstat_report_xact_end_timestamp doesn't really > need to follow the protocol of bumping the change count before and > after bumping the timestamp. We elsewhere assume that four-byte reads > and writes are atomic, so there'

Re: [HACKERS] pg_dump issues

2011-10-03 Thread Florian Pflug
On Oct2, 2011, at 23:15 , Joe Abbate wrote: > I'm > somewhat surprised there appears to be no ability to lock a database > exclusively for something like pg_dump/pg_restore, so you're not > surprised by concurrent activity against the catalogs. I'm guessing the > assumption is that MVCC will take

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Magnus Hagander
On Sun, Oct 2, 2011 at 23:05, Tom Lane wrote: > During the discussion of Alexey Klyukin's rewrite of ParseConfigFile, > considerable unhappiness was expressed by various people about the > complexity and relative uselessness of the custom_variable_classes GUC. > While working over his patch just n

Re: [HACKERS] [v9.2] Object access hooks with arguments support (v1)

2011-10-03 Thread Kohei KaiGai
BTW, I remember that I was suggested the object-access-hooks to acquire controls around changes of system catalogs are also useful to implement clustering features, not only enhanced security features, when I had a talk at PGcon2001. It might be my mistake that I categorized this patch at the "sec

Re: [HACKERS] Should we get rid of custom_variable_classes altogether?

2011-10-03 Thread Dimitri Fontaine
Tom Lane writes: > Simon Riggs writes: >> On Sun, Oct 2, 2011 at 10:05 PM, Tom Lane wrote: >>> So at this point I'd vote for just dropping it and always allowing >>> custom (that is, qualified) GUC names to be set, whether the prefix >>> corresponds to any loaded module or not. > >> Sounds sensi

Re: [HACKERS] WIP: Join push-down for foreign tables

2011-10-03 Thread Kohei KaiGai
Hanada-san, I applied your patch and run a few test cases. while this test, I noticed a few points. At first, I tried to use file_fdw, however, it was crashed of course. It seems to me this logic should be modified to confirm whether the target FDW support join push down, or not. + if (ena

Re: [HACKERS] bug of recovery?

2011-10-03 Thread Simon Riggs
On Mon, Oct 3, 2011 at 6:23 AM, Fujii Masao wrote: > So I think that the idea should be implemented separately from > the patch I've posted. Agreed. I'll do a final review and commit today. --  Simon Riggs   http://www.2ndQuadrant.com/  PostgreSQL Development, 24x7 Support, Tra

  1   2   >