Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Peter Eisentraut
On ons, 2011-06-29 at 18:48 -0500, Kevin Grittner wrote: > I think this needs a well-defined and sustainable *process*, not > just a set of volunteers. I'm skeptical that a workable process can > be devised, but I'm willing to be proven wrong. We had translated FAQs, each with a maintainer, which

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Florian Pflug
On Jun30, 2011, at 07:22 , Casey Havenor wrote: > What recommendations do you have for the other systems? - Win7, Win XP and > Mac? Mac OS X comes with "patch" already installed I think - at least it gets installed when you install XCode (Apple's IDE), which you need anyway to get a C compiler (Th

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Florian Pflug
On Jun29, 2011, at 23:44 , Peter Eisentraut wrote: > On ons, 2011-06-29 at 10:15 -0700, David E. Wheeler wrote: >> On Jun 29, 2011, at 10:13 AM, Florian Pflug wrote: >>> Because there might be more than one range type for a >>> base type. Say there are two range types over text, one >>> with collat

Re: [HACKERS] Online base backup from the hot-standby

2011-06-29 Thread Jun Ishiduka
> > > Process of online base backup on standby server: > > > 1. pg_start_backup('x'); > > > 2. copy the data directory > > > 3. copy *pg_control* > > > > Who deletes the backup_label file created by pg_start_backup()? > > Isn't pg_stop_backup() required to do that? > > You need it to take the

[HACKERS] ToDo: list of active channels

2011-06-29 Thread Pavel Stehule
Hello I use a LISTEN/NOTIFY. Now I have to check, if second application that creates channels is active. It should be simple with system view of active channels. Regards Pavel Stehule -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: ht

Re: [HACKERS] Latch implementation that wakes on postmaster death on both win32 and Unix

2011-06-29 Thread Fujii Masao
On Sat, Jun 25, 2011 at 10:41 AM, Peter Geoghegan wrote: > Attached is patch that addresses Fujii's third and most recent set of > concerns. Thanks for updating the patch! > I think that Heikki is currently taking another look at my work, > because he indicates in a new message to the list a sh

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Hitoshi Harada
2011/6/30 Itagaki Takahiro : > On Thu, Jun 30, 2011 at 09:42, Tatsuo Ishii wrote: >> BTW I will talk to some Japanese speaking developers about my idea if >> community agree to add Japanese README to the source tree so that I am >> not the only one who are contributing this project >> >>> Now, if

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Casey Havenor
What recommendations do you have for the other systems? - Win7, Win XP and Mac? Thanks for the info - learning curves don't bother me - love a challenge! - Warmest regards, Casey Havenor -- View this message in context: http://postgresql.1045698.n5.nabble.com/Patch-file-questions-tp4536

Re: [HACKERS] Small patch for GiST: move childoffnum to child

2011-06-29 Thread Jeff Janes
On Tue, Jun 28, 2011 at 10:21 AM, Alexander Korotkov wrote: > Actually, there is no more direct need of this patch because I've rewrote > insert function for fast build. But there are still two points for having > this changes: > 1) As it was noted before, it simplifies code a bit. > 2) It would b

Re: [HACKERS] pgbench--new transaction type

2011-06-29 Thread Greg Smith
On 06/30/2011 12:13 AM, Jeff Janes wrote: One more thought I had, would it make sense to change this from the creation of a PL/pgSQL permanent function to instead use the recently added DO anonymous block syntax? I think that would be somewhat cleaner about leaving cruft behind in the database.

Re: [HACKERS] hint bit cache v6

2011-06-29 Thread Jim Nasby
On Jun 29, 2011, at 3:18 PM, Robert Haas wrote: > To be clear, I don't really think it matters how sensitive the cache > is to a *complete* flush. The question I want to ask is: how much > does it take to knock ONE page out of cache? And what are the chances > of that happening too frequently? I

Re: [HACKERS] pgbench--new transaction type

2011-06-29 Thread Jeff Janes
On Sun, Jun 19, 2011 at 3:30 PM, Greg Smith wrote: ... > > Things to fix in the patch before it would be a commit candidate: > > -Adjust the loop size/name, per above > -Reformat some of the longer lines to try and respect the implied right > margin in the code formatting > -Don't include the "plg

Re: [HACKERS] Online base backup from the hot-standby

2011-06-29 Thread Magnus Hagander
On Jun 30, 2011 5:59 AM, "Fujii Masao" wrote: > > 2011/6/28 Jun Ishiduka : > > > >> Considering everything that has been discussed on this thread so far. > >> > >> Do you still think your patch is the best way to accomplish base backups > >> from standby servers? > >> If not what changes do you th

Re: [HACKERS] Online base backup from the hot-standby

2011-06-29 Thread Fujii Masao
2011/6/28 Jun Ishiduka : > >> Considering everything that has been discussed on this thread so far. >> >> Do you still think your patch is the best way to accomplish base backups >> from standby servers? >> If not what changes do you think should be made? > > I reconsider the way to not use pg_stop

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Fujii Masao
On Thu, Jun 30, 2011 at 12:14 PM, Fujii Masao wrote: > We should disable this feature also after recovery reaches the stop > point (specified in recovery_target_xxx)? Another comment; it's very helpful to document the behavior of delayed standby when promoting or after reaching the stop point. R

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Fujii Masao
On Thu, Jun 30, 2011 at 10:56 AM, Robert Haas wrote: >>> Nope, it gets stuck and stops there.  Replay doesn't advance unless you >> can somehow clear out some space manually; if the disk is full, the disk >> is full, and PostgreSQL doesn't remove WAL files without being able to >> write files firs

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Fujii Masao
On Wed, Jun 29, 2011 at 11:14 AM, Robert Haas wrote: > On Wed, Jun 15, 2011 at 1:58 AM, Fujii Masao wrote: >> After we run "pg_ctl promote", time-delayed replication should be disabled? >> Otherwise, failover might take very long time when we set recovery_time_delay >> to high value. > > PFA a pa

Re: [HACKERS] Dry Run mode for pg_archivecleanup

2011-06-29 Thread Fujii Masao
On Tue, Jun 28, 2011 at 6:33 AM, Gabriele Bartolini wrote: >   I have added the '-n' option to pg_archivecleanup which performs a dry-run > and outputs the names of the files to be removed to stdout (making possible > to pass the list via pipe to another process). Please find attached the > small

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 9:54 PM, Josh Berkus wrote: >> I am not sure exactly how walreceiver handles it if the disk is full. >> I assume it craps out and eventually retries, so probably what will >> happen is that, after the standby's pg_xlog directory fills up, >> walreceiver will sit there and e

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Josh Berkus
On 6/29/11 11:11 AM, Robert Haas wrote: > If the standby gets far enough behind the master that the required > files are no longer there, then it will switch to the archive, if > available. One more thing: As I understand it (and my testing shows this), the standby *prefers* the archive logs, and

Re: [HACKERS] default privileges wording

2011-06-29 Thread Andrew Dunstan
On 06/29/2011 09:20 PM, Robert Haas wrote: On Wed, Jun 29, 2011 at 8:53 PM, David Fetter wrote: How about this? PostgreSQL grants some types of objects some default privileges to PUBLIC. Tables, columns, schemas and tablespaces grant no privileges to PUBLIC by default. For other types, the

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Josh Berkus
Robert, > I don't really see how that's any different from what happens now. If > (for whatever reason) the master is generating WAL faster than a > streaming standby can replay it, then the excess WAL is going to pile > up someplace, and you might run out of disk space. Time-delaying the > sta

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Michael Paquier
On Thu, Jun 30, 2011 at 10:43 AM, Tatsuo Ishii wrote: > > IMHO, the Wiki approach seems to be reasonable than a README file. > > It will be suitable for adding non-Japanese translations and > > non-core developer can join to translate or fix the docs. > > I doubt other than developers can transla

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Tatsuo Ishii
> IMHO, the Wiki approach seems to be reasonable than a README file. > It will be suitable for adding non-Japanese translations and > non-core developer can join to translate or fix the docs. I doubt other than developers can translate those README files since the words used in the files chosen to

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Itagaki Takahiro
On Thu, Jun 30, 2011 at 09:42, Tatsuo Ishii wrote: > BTW I will talk to some Japanese speaking developers about my idea if > community agree to add Japanese README to the source tree so that I am > not the only one who are contributing this project > >> Now, if someone wanted to set up a web site

Re: [HACKERS] default privileges wording

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 8:53 PM, David Fetter wrote: > How about this? > > PostgreSQL grants some types of objects some default privileges to > PUBLIC.  Tables, columns, schemas and tablespaces grant no privileges > to PUBLIC by default.  For other types, the default privileges granted > to PUBLIC

Re: [HACKERS] default privileges wording

2011-06-29 Thread David Fetter
On Wed, Jun 29, 2011 at 08:42:58PM -0400, Robert Haas wrote: > On Wed, Jun 29, 2011 at 4:49 PM, Alvaro Herrera > wrote: > > Excerpts from Robert Haas's message of mié jun 29 13:42:34 -0400 2011: > > > >> > How about this? > >> > > >> > Some types of objects deny all privileges to PUBLIC by default

Re: [HACKERS] SECURITY LABEL on shared database object

2011-06-29 Thread Joe Conway
On 06/29/2011 05:34 PM, Joe Conway wrote: > The third key passed to SearchSysCache is CStringGetTextDatum(provider). > Ultimately FunctionCall2Coll gets called with collation == 0 and > varstr_cmp fails due to the ambiguity. > > Is there something new that should be used in place of > CStringGetTe

Re: [HACKERS] default privileges wording

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 4:49 PM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of mié jun 29 13:42:34 -0400 2011: > >> > How about this? >> > >> > Some types of objects deny all privileges to PUBLIC by default.  These >> > are tables, columns, schemas and tablespaces.  For other type

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Tatsuo Ishii
>> My idea is defining "maintainer" for each README. Of course I am >> ready for Japanese one. > > That would only cover part of the problem, and not on a permanent > basis. > > How do you notice that a README has changed? Commit messages, obviously. > How does the community know when the cha

Re: [HACKERS] SECURITY LABEL on shared database object

2011-06-29 Thread Joe Conway
On 06/29/2011 04:18 PM, Joe Conway wrote: > 1) COLLATE clause is a new feature in 9.1? > 2) The doc search feature on postgresql.org does not search the 9.1 >documentation? > > I looked in the 9.1 docs in SQL Commands->SELECT and could find no > reference to COLLATE. Can anyone point me to som

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Tatsuo Ishii
> I think this is basically a bad idea, because 90% of the developers will > be unable to update such a file when changing the source code, or even > verify whether it's an accurate translation. Thus it will inevitably > become out-of-date, and that seems worse than useless. I'm fairly > dubious

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Kevin Grittner
Tatsuo Ishii wrote: >> The obvious concern would be "drift". As README files are >> patched, someone would need to stay on top of the translation >> process. Any ideas on how that could be reasonably managed? > > My idea is defining "maintainer" for each README. Of course I am > ready for Japa

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Alvaro Herrera
Excerpts from Tom Lane's message of mié jun 29 19:24:07 -0400 2011: > Tatsuo Ishii writes: > > I would like to propose to add Japanese translated version of README > > in the source tree(for example against backend/storage/buffer/README). > > I think this is basically a bad idea, because 90% of t

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Tatsuo Ishii
>> I would like to propose to add Japanese translated version of >> README in the source tree > >> Comments? > > The obvious concern would be "drift". As README files are patched, > someone would need to stay on top of the translation process. Any > ideas on how that could be reasonably manag

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Tom Lane
Tatsuo Ishii writes: > I would like to propose to add Japanese translated version of README > in the source tree(for example against backend/storage/buffer/README). I think this is basically a bad idea, because 90% of the developers will be unable to update such a file when changing the source co

Re: [HACKERS] Adding Japanese README

2011-06-29 Thread Kevin Grittner
Tatsuo Ishii wrote: > I would like to propose to add Japanese translated version of > README in the source tree > Comments? The obvious concern would be "drift". As README files are patched, someone would need to stay on top of the translation process. Any ideas on how that could be reason

[HACKERS] avoid including rel.h in execnodes.h

2011-06-29 Thread Alvaro Herrera
This simple patch moves two struct declarations (Trigger and TriggerDesc) from rel.h into a new file, reltrigger.h. The benefit is that execnodes.h only needs to include the latter. Since execnodes.h is very widely included, this change means there are less files that indirectly include rel.h now

[HACKERS] SECURITY LABEL on shared database object

2011-06-29 Thread Joe Conway
I signed up to do a review on $subject patch for the commitfest. In order to do that, I want to get SELinux and contrib/sepgsql properly set up so that I can test. I ran into a problem when trying to do: cd contrib/sepgsql make install (succeeds) make installcheck

Re: [HACKERS] [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-29 Thread Michael Paquier
On Thu, Jun 30, 2011 at 12:03 AM, Alvaro Herrera wrote: > Excerpts from Magnus Hagander's message of mié jun 29 10:30:51 -0400 2011: > > On Tue, Jun 28, 2011 at 19:45, Alvaro Herrera > > wrote: > > > Excerpts from Tom Lane's message of mar jun 28 10:39:22 -0400 2011: > > > > > >> I think it woul

[HACKERS] Adding Japanese README

2011-06-29 Thread Tatsuo Ishii
I would like to propose to add Japanese translated version of README in the source tree(for example against backend/storage/buffer/README). Benefits of our community include: - Increase possibility to hire more Japanese speaking developers by helping them to understand source code using those RE

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-29 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié jun 29 18:16:20 -0400 2011: > On Wed, Jun 29, 2011 at 4:59 PM, Alvaro Herrera > wrote: > > Excerpts from Robert Haas's message of mié jun 29 13:07:25 -0400 2011: > >> On Wed, Jun 29, 2011 at 12:51 PM, Alvaro Herrera > >> wrote: > >> > Excerpts from Rober

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 4:59 PM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of mié jun 29 13:07:25 -0400 2011: >> On Wed, Jun 29, 2011 at 12:51 PM, Alvaro Herrera >> wrote: >> > Excerpts from Robert Haas's message of lun jun 27 10:35:59 -0400 2011: > >> > Interesting.  This whole

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Peter Eisentraut
On ons, 2011-06-29 at 10:15 -0700, David E. Wheeler wrote: > On Jun 29, 2011, at 10:13 AM, Florian Pflug wrote: > > > Because there might be more than one range type for a > > base type. Say there are two range types over text, one > > with collation 'de_DE' and one with collation 'en_US'. > > Wha

Re: [HACKERS] default privileges wording

2011-06-29 Thread Andrew Dunstan
On 06/29/2011 05:16 PM, David Fetter wrote: Hmm, I like David's suggestion better, but I agree with you that "deny" isn't the right verb there. I have no better suggestions at moment though. I chose "deny" in the sense of "default deny," which is a term of art in security engineering referri

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Andrew Dunstan
On 06/29/2011 05:18 PM, Casey Havenor wrote: Googled patch utility - not sure of which one to get as none I found use the .patch extensions? So is this the workflow... - Get patch - Get patch utility - Not sure which one - On Linux run "man patch". If it's not installed, then install your d

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Casey Havenor
Googled patch utility - not sure of which one to get as none I found use the .patch extensions? So is this the workflow... - Get patch - Get patch utility - Not sure which one - Any recommendations for Win7, Mac, Linux? - Apply patch to installer for PostgreSQL or after PostgreSQL is installed?

Re: [HACKERS] default privileges wording

2011-06-29 Thread David Fetter
On Wed, Jun 29, 2011 at 04:49:15PM -0400, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of mié jun 29 13:42:34 -0400 2011: > > > > How about this? > > > > > > Some types of objects deny all privileges to PUBLIC by default. > > >  These are tables, columns, schemas and tablespaces.  F

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-29 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié jun 29 13:07:25 -0400 2011: > On Wed, Jun 29, 2011 at 12:51 PM, Alvaro Herrera > wrote: > > Excerpts from Robert Haas's message of lun jun 27 10:35:59 -0400 2011: > > Interesting.  This whole thing requires quite a bit of rejiggering in > > the initial t

Re: [HACKERS] default privileges wording

2011-06-29 Thread Alvaro Herrera
Excerpts from Robert Haas's message of mié jun 29 13:42:34 -0400 2011: > > How about this? > > > > Some types of objects deny all privileges to PUBLIC by default.  These > > are tables, columns, schemas and tablespaces.  For other types, the > > default privileges granted to PUBLIC are as follows:

Re: [HACKERS] Patch Review: Bugfix for XPATH() if text or attribute nodes are selected

2011-06-29 Thread Florian Pflug
On Jun29, 2011, at 19:34 , Radosław Smogura wrote: > B. 6. Current behaviour _is intended_ (there is "if" to check node type) and > _"natural"_. In this particular case user ask for text content of some node, > and this content is actually "<". I don't buy that. The check for the node type is t

Re: [HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-06-29 Thread Florian Pflug
On Jun29, 2011, at 19:57 , Radosław Smogura wrote: > This is review of patch > https://commitfest.postgresql.org/action/patch_view?id=565 > "Bugfix for XPATH() if expression returns a scalar value" > > SELECT XMLELEMENT(name root, XMLATTRIBUTES(foo.namespace AS sth)) FROM > (SELECT > (XPATH('nam

[HACKERS] serializable installcheck

2011-06-29 Thread Kevin Grittner
I've discovered (the hard way) that if you run `make installcheck` with default_transaction_isolation = 'serializable' and you have a serializable read write transaction sitting idle (or prepared) that the "transactions" test will block indefinitely waiting for a safe time to run, because of the te

Re: [HACKERS] hint bit cache v6

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 3:16 PM, Merlin Moncure wrote: > I think it's a fair point to ask how often thrashing cases will truly > come up where you don't have some other significant cost like i/o. > Even when you do thrash, you are just falling back on stock postgres > behaviors minus the maintenan

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Alvaro Herrera
Excerpts from Casey Havenor's message of mié jun 29 15:53:31 -0400 2011: > Partitioning becomes impossible as I'd have to hunt down every single row > from every table within the hierarchy when needed. I've got an object > driven system with permissions for users so I'll easily have thousands of

Re: [HACKERS] Feature request: new column is_paused in pg_stat_replication

2011-06-29 Thread Simon Riggs
On Wed, Jun 29, 2011 at 8:49 PM, Emanuel Calvo wrote: > I don't know if it's possible or not, but could be interesting to add > a column in pg_stat_replication to now if the standby is paused. It > could be useful if > somebody has several standby servers and use this function for some tasks. > >

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Casey Havenor
Partitioning becomes impossible as I'd have to hunt down every single row from every table within the hierarchy when needed. I've got an object driven system with permissions for users so I'll easily have thousands of rows to manage across 100's of tables. For inheritance I'm using it for the f

[HACKERS] Patch file questions?

2011-06-29 Thread Casey Havenor
I'm obviously new. But making great progress in PostgreSQL with my new application... Setup: I'm running on MAC. Postgre 9.0.4 Virtual Machine with application dev in Linux. Problem: I like many other have come across the inherit issues. I found the thread here about such issue... htt

[HACKERS] Feature request: new column is_paused in pg_stat_replication

2011-06-29 Thread Emanuel Calvo
Hi hackers, I don't know if it's possible or not, but could be interesting to add a column in pg_stat_replication to now if the standby is paused. It could be useful if somebody has several standby servers and use this function for some tasks. I know that there is an indirect way to calculate thi

Re: [HACKERS] SSI modularity questions

2011-06-29 Thread Kevin Grittner
Heikki Linnakangas wrote: > On 29.06.2011 00:33, Kevin Grittner wrote: >> Heikki Linnakangas wrote: >>> On 28.06.2011 20:47, Kevin Grittner wrote: >> >>> Hmm, the calls in question are the ones in heapgettup() and >>> heapgettup_pagemode(), which are subroutines of heap_getnext(). >>> heap_getnex

Re: [HACKERS] Repeated PredicateLockRelation calls during seqscan

2011-06-29 Thread Heikki Linnakangas
On 26.06.2011 23:49, Kevin Grittner wrote: "Kevin Grittner" wrote: "Kevin Grittner" wrote: Heikki Linnakangas wrote: BTW, isn't bitgetpage() in nodeBitmapHeapscan.c missing PredicateLockTuple() and CheckForSerializableConflictOut() calls in the codepath for a lossy bitmap? In the non-lossy

Re: [HACKERS] SSI modularity questions

2011-06-29 Thread Heikki Linnakangas
On 29.06.2011 00:33, Kevin Grittner wrote: Heikki Linnakangas wrote: On 28.06.2011 20:47, Kevin Grittner wrote: Hmm, the calls in question are the ones in heapgettup() and heapgettup_pagemode(), which are subroutines of heap_getnext(). heap_getnext() is only used in sequential scans, so it s

Re: [HACKERS] hint bit cache v6

2011-06-29 Thread Merlin Moncure
On Wed, Jun 29, 2011 at 11:11 AM, Robert Haas wrote: > On Fri, May 13, 2011 at 3:48 PM, Merlin Moncure wrote: >> what's changed: >> *) as advertised, i'm no longer bothering to cache invalid bits.  hint >> bit i/o via rollbacked transactions is not a big deal IMNSHO, so they >> will work as they

Re: [HACKERS] Patch file questions?

2011-06-29 Thread Alvaro Herrera
Excerpts from Casey Havenor's message of mié jun 29 14:24:11 -0400 2011: > Problem: > > I like many other have come across the inherit issues. > > I found the thread here about such issue... > http://postgresql.1045698.n5.nabble.com/FK-s-to-refer-to-rows-in-inheritance-child-td3287684.html >

[HACKERS] Patch file questions?

2011-06-29 Thread Casey Havenor
I'm obviously new. But making great progress in PostgreSQL with my new application... Setup: I'm running on MAC. Postgre 9.0.4 Virtual Machine with application dev in Linux. Problem: I like many other have come across the inherit issues. I found the thread here about such issue... htt

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 1:50 PM, Simon Riggs wrote: >> As implemented, the feature will work with either streaming >> replication or with file-based replication. > > That sounds like the exact opposite of yours and Fujii's comments > above. Please explain. I think our comments above were addressi

[HACKERS] Review of patch Bugfix for XPATH() if expression returns a scalar value

2011-06-29 Thread Radosław Smogura
This is review of patch https://commitfest.postgresql.org/action/patch_view?id=565 "Bugfix for XPATH() if expression returns a scalar value" Patch applies cleanly, and compiles cleanly too, I didn't checked tests. Form discussion about patch, and referenced thread in this patch http://ar

Re: [HACKERS] time-delayed standbys

2011-06-29 Thread Simon Riggs
On Wed, Jun 29, 2011 at 1:24 PM, Robert Haas wrote: > On Wed, Jun 29, 2011 at 4:00 AM, Simon Riggs wrote: >> On Thu, Jun 16, 2011 at 7:29 PM, Robert Haas wrote: >>> On Wed, Jun 15, 2011 at 1:58 AM, Fujii Masao wrote: When the replication connection is terminated, the standby tries to read

Re: [HACKERS] default privileges wording

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 1:20 PM, David Fetter wrote: > On Wed, Jun 29, 2011 at 11:50:38AM -0400, Alvaro Herrera wrote: >> Excerpts from Andrew Dunstan's message of mié jun 29 11:21:12 -0400 2011: >> > >> > I was just reading the docs on default privileges, and they say this: >> > >> >     Dependin

[HACKERS] Patch Review: Bugfix for XPATH() if text or attribute nodes are selected

2011-06-29 Thread Radosław Smogura
Review of patch https://commitfest.postgresql.org/action/patch_view?id=580 === Patch description === SUMMARY: When text() based XPATH expression is invoked output is not XML escaped DESCRIPTION: Submitter invokes following statement: SELECT (XPATH('/*/text()', '<'))[1]. He expect (escaped) re

Re: [HACKERS] Parameterized aggregate subquery (was: Pull up aggregate subquery)

2011-06-29 Thread Hitoshi Harada
2011/6/29 Yeb Havinga : > > On 2011-06-17 09:54, Hitoshi Harada wrote: >> >> While reviewing the gist/box patch, I found some planner APIs that can >> replace parts in my patch. Also, comments in includes wasn't updated >> appropriately. Revised patch attached. > > Hello Hitoshi-san, Hi Yeb, > I

Re: [HACKERS] default privileges wording

2011-06-29 Thread David Fetter
On Wed, Jun 29, 2011 at 11:50:38AM -0400, Alvaro Herrera wrote: > Excerpts from Andrew Dunstan's message of mié jun 29 11:21:12 -0400 2011: > > > > I was just reading the docs on default privileges, and they say this: > > > > Depending on the type of object, the initial default privileges > >

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread David E. Wheeler
On Jun 29, 2011, at 10:13 AM, Florian Pflug wrote: > Because there might be more than one range type for a > base type. Say there are two range types over text, one > with collation 'de_DE' and one with collation 'en_US'. > What would the type of > range('foo', 'f') > be? The one that corres

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Florian Pflug
On Jun29, 2011, at 19:05 , David E. Wheeler wrote: > I'm still not clear, though, on why the return type of range() > should not be related to the types of its arguments. So > >range(1, 5) > > Should return intrange, and > >range(1::int8, 5::int8) > > Should return int8range, and > >

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Florian Pflug
On Jun29, 2011, at 18:34 , Robert Haas wrote: > It also seems a bit strange to me that we're contemplating a system > where users are always going to have to cast the return type. > Generally, casts are annoying and we want to minimize the need for > them. I'm not sure what the alternative is, tho

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 12:51 PM, Alvaro Herrera wrote: > Excerpts from Robert Haas's message of lun jun 27 10:35:59 -0400 2011: >> On Mon, Jun 27, 2011 at 3:08 AM, Dean Rasheed >> wrote: > >> > I would summarise the consistency requirements as: >> > >> > 1). ADD CONSTRAINT should leave both par

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread David E. Wheeler
On Jun 29, 2011, at 8:41 AM, Jeff Davis wrote: > We could make it a pseudo-type and make the IO functions generate > exceptions. That should prevent most mistakes and effectively hide it > from the user (sure, they could probably use it somewhere if they really > want to, but I wouldn't be worried

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread David E. Wheeler
On Jun 28, 2011, at 8:02 PM, Jeff Davis wrote: > I think David Wheeler was trying to make a similar point, but I'm still > not convinced. > > It's not a pair, because it can be made up of 0, 1, or 2 scalar values > (unless you count infinity as one of those values, in which case 0 or > 2). And wi

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2011-06-29 Thread Alvaro Herrera
Excerpts from Robert Haas's message of lun jun 27 10:35:59 -0400 2011: > On Mon, Jun 27, 2011 at 3:08 AM, Dean Rasheed > wrote: > > I would summarise the consistency requirements as: > > > > 1). ADD CONSTRAINT should leave both parent and child tables in the > > same state as they would have bee

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-06-29 Thread Josh Berkus
> I don't have a strong feeling on whether or not we should put that > setting in its own section. Right now, we only have one setting for > synchronous replication, so I guess maybe it depends on if we think > there will be more in the future. I believe there will be more in the future. Howev

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 11:41 AM, Jeff Davis wrote: > Robert didn't really seem to like the idea of throwing an error though > -- Robert, can you expand on your reasoning here? I guess I don't have any terribly well-thought out reasoning - maybe it's fine. It just seems strange to have a type th

Re: [HACKERS] patch: Allow \dd to show constraint comments

2011-06-29 Thread Merlin Moncure
On Thu, May 19, 2011 at 9:36 PM, Josh Kupershmidt wrote: > On Thu, May 19, 2011 at 10:26 AM, Robert Haas wrote: >> At the risk of opening a can of worms, if we're going to fix \dd, >> shouldn't we fix it completely, and include comments on ALL the object >> types that can have them?  IIRC it's mi

Re: [HACKERS] hint bit cache v6

2011-06-29 Thread Robert Haas
On Fri, May 13, 2011 at 3:48 PM, Merlin Moncure wrote: > what's changed: > *) as advertised, i'm no longer bothering to cache invalid bits.  hint > bit i/o via rollbacked transactions is not a big deal IMNSHO, so they > will work as they have always done. > *) all the tuple visibility routines are

Re: [HACKERS] [v9.2] Fix leaky-view problem, part 1

2011-06-29 Thread Kohei KaiGai
2011/6/28 Noah Misch : > On Tue, Jun 28, 2011 at 10:11:59PM +0200, Kohei KaiGai wrote: >> 2011/6/28 Noah Misch : >> > Suppose your query references two views owned by different roles. ?The >> > quals >> > of those views will have the same depth. ?Is there a way for information to >> > leak from on

Re: [HACKERS] default privileges wording

2011-06-29 Thread Alvaro Herrera
Excerpts from Andrew Dunstan's message of mié jun 29 11:21:12 -0400 2011: > > I was just reading the docs on default privileges, and they say this: > > Depending on the type of object, the initial default privileges > might include granting some privileges to PUBLIC. The default is no >

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Jeff Davis
On Wed, 2011-06-29 at 08:52 -0400, Robert Haas wrote: > On Tue, Jun 28, 2011 at 11:02 PM, Jeff Davis wrote: > > It's still not out of the question, but I thought that the intermediate > > type would be a less-intrusive alternative (and Robert seemed concerned > > about how intrusive it was). > >

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Jeff Davis
On Wed, 2011-06-29 at 13:35 +0200, Florian Pflug wrote: > What I'm concerned about is how elegantly we'd be able to tie up all > the loose ends. What'd be the result of > select range(1,2) > for example? Or > create table (r rangeinput) > for that matter. > > I think we'd want to forbid both o

[HACKERS] default privileges wording

2011-06-29 Thread Andrew Dunstan
I was just reading the docs on default privileges, and they say this: Depending on the type of object, the initial default privileges might include granting some privileges to PUBLIC. The default is no public access for tables, columns, schemas, and tablespaces; CONNECT privilege and

Re: [HACKERS] Process local hint bit cache

2011-06-29 Thread Merlin Moncure
On Wed, Jun 29, 2011 at 10:09 AM, Merlin Moncure wrote: > That is not correct.   Any cache 'miss' on a page continues to fall > through to SetHintBitsCache() which dirties the page as it always has. er, SetHintBits(), not SetHintBitsCache() merlin -- Sent via pgsql-hackers mailing list (pgsql-

Re: [HACKERS] Process local hint bit cache

2011-06-29 Thread Merlin Moncure
On Wed, Jun 29, 2011 at 9:09 AM, Simon Riggs wrote: > On Sat, Apr 2, 2011 at 8:40 PM, Tom Lane wrote: >> Merlin Moncure writes: > >>> aside: >>> Moving TransactionIdInProgress below TransactionIdDidCommit can help >>> in once sense: TransactionIdDidCommit grabs the XidStatus but discards >>> the

Re: [HACKERS] [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-29 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of mié jun 29 10:30:51 -0400 2011: > On Tue, Jun 28, 2011 at 19:45, Alvaro Herrera > wrote: > > Excerpts from Tom Lane's message of mar jun 28 10:39:22 -0400 2011: > > > >> I think it would be sensible to block branch removal, as there's > >> basically never

Re: [HACKERS] [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-29 Thread Magnus Hagander
On Wed, Jun 29, 2011 at 16:30, Magnus Hagander wrote: > On Tue, Jun 28, 2011 at 19:45, Alvaro Herrera > wrote: >> Excerpts from Tom Lane's message of mar jun 28 10:39:22 -0400 2011: >> >>> I think it would be sensible to block branch removal, as there's >>> basically never a scenario where we'd d

Re: [HACKERS] [COMMITTERS] pgsql: Branch refs/heads/REL9_1_STABLE was removed

2011-06-29 Thread Magnus Hagander
On Tue, Jun 28, 2011 at 19:45, Alvaro Herrera wrote: > Excerpts from Tom Lane's message of mar jun 28 10:39:22 -0400 2011: > >> I think it would be sensible to block branch removal, as there's >> basically never a scenario where we'd do that during current usage. >> I'm not excited about blocking

Re: [HACKERS] Process local hint bit cache

2011-06-29 Thread Simon Riggs
On Sat, Apr 2, 2011 at 8:40 PM, Tom Lane wrote: > Merlin Moncure writes: >> aside: >> Moving TransactionIdInProgress below TransactionIdDidCommit can help >> in once sense: TransactionIdDidCommit grabs the XidStatus but discards >> the knowledge if the transaction is known aborted. > > Doesn't t

Re: [HACKERS] Parameterized aggregate subquery (was: Pull up aggregate subquery)

2011-06-29 Thread Yeb Havinga
On 2011-06-17 09:54, Hitoshi Harada wrote: While reviewing the gist/box patch, I found some planner APIs that can replace parts in my patch. Also, comments in includes wasn't updated appropriately. Revised patch attached. Hello Hitoshi-san, I read your latest patch implementing parameterizing

Re: [HACKERS] Process local hint bit cache

2011-06-29 Thread Robert Haas
On Wed, Jun 29, 2011 at 9:39 AM, Merlin Moncure wrote: > On Tue, Jun 28, 2011 at 10:03 PM, Robert Haas wrote: >> On Thu, Apr 7, 2011 at 2:49 PM, Merlin Moncure wrote: >>> On Thu, Apr 7, 2011 at 1:28 PM, Merlin Moncure wrote:                        int ByteOffset = xid / BITS_PER_BYTE; >>>

Re: [HACKERS] Avoid index rebuilds for no-rewrite ALTER TABLE ALTER TYPE

2011-06-29 Thread Robert Haas
On Tue, Jun 28, 2011 at 3:40 PM, Noah Misch wrote: > On Tue, Jun 28, 2011 at 02:11:11PM -0400, Robert Haas wrote: >> On Mon, Jun 27, 2011 at 10:43 PM, Noah Misch wrote: >> > On Mon, Jun 27, 2011 at 03:45:43PM -0400, Robert Haas wrote: >> >> On Wed, Jun 15, 2011 at 1:03 AM, Noah Misch wrote: >> >

Re: [HACKERS] Process local hint bit cache

2011-06-29 Thread Merlin Moncure
On Tue, Jun 28, 2011 at 10:03 PM, Robert Haas wrote: > On Thu, Apr 7, 2011 at 2:49 PM, Merlin Moncure wrote: >> On Thu, Apr 7, 2011 at 1:28 PM, Merlin Moncure wrote: >>>                        int ByteOffset = xid / BITS_PER_BYTE; >> >> whoops, I just notice this was wrong -- the byte offset nee

Re: [HACKERS] Range Types, constructors, and the type system

2011-06-29 Thread Robert Haas
On Tue, Jun 28, 2011 at 11:02 PM, Jeff Davis wrote: > It's still not out of the question, but I thought that the intermediate > type would be a less-intrusive alternative (and Robert seemed concerned > about how intrusive it was). I'm no great fan of our existing type system, and I'm not opposed

Re: [HACKERS] Inconsistency between postgresql.conf and docs

2011-06-29 Thread Robert Haas
On Tue, Jun 28, 2011 at 11:52 PM, Josh Berkus wrote: > But in the sample file, the "synchronous_standby_names" parameter is the > first parameter under the heading "- Streaming Replication - Server > Settings" while in the documentation, that parameter has its own > subsection 18.5.5 after the "st

  1   2   >