Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Oleg Bartunov
On Mon, 14 Feb 2011, David E. Wheeler wrote: On Feb 14, 2011, at 11:37 PM, Oleg Bartunov wrote: it's not easy to hack tsearch parser, sorry. You can preparse your input before to_tsquery,to_tsvector. Yeah, I was thinking about s{/}{-}g before passing the values in. Might be the only way to

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Oleg Bartunov
On Mon, 14 Feb 2011, Tom Lane wrote: "David E. Wheeler" writes: Is it possible to modify the default tsearch parser so that / doesn't get lexed as a "file" token? There is zero, none, nada, provision for modifying the behavior of the default parser, other than by changing its compiled-in st

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 11:37 PM, Oleg Bartunov wrote: > it's not easy to hack tsearch parser, sorry. You can preparse your input > before to_tsquery,to_tsvector. Yeah, I was thinking about s{/}{-}g before passing the values in. Might be the only way to do it for now… Thanks, David -- Sent via

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Oleg Bartunov
David, it's not easy to hack tsearch parser, sorry. You can preparse your input before to_tsquery,to_tsvector. Oleg On Mon, 14 Feb 2011, David E. Wheeler wrote: Hackers, Is it possible to modify the default tsearch parser so that / doesn't get lexed as a "file" token? That is, instead of thi

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-14 Thread Jaime Casanova
On Sat, Jan 15, 2011 at 4:40 PM, Simon Riggs wrote: > > Here's the latest patch for sync rep. > I was looking at this code and found something in SyncRepWaitOnQueue we declare a timeout variable that is a long and another that is a boolean (this last one in the else part of the "if (!IsOnSyncRepQ

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Stefan Kaltenbrunner
On 02/14/2011 02:26 PM, Marko Kreen wrote: On Mon, Feb 14, 2011 at 3:08 PM, Martin Pitt wrote: thanks Markus for CC'ing me, I'm not on -hackers@. Markus Wanner [2011-02-14 13:37 +0100]: On 02/10/2011 11:34 PM, Joshua D. Drake wrote: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=607109 N

Re: [HACKERS] Sync Rep for 2011CF1

2011-02-14 Thread Fujii Masao
On Mon, Feb 14, 2011 at 2:08 PM, Fujii Masao wrote: > On Fri, Feb 11, 2011 at 4:06 AM, Heikki Linnakangas > wrote: >> I committed the patch with those changes, and some minor comment tweaks and >> other kibitzing. I have another comment: The description of wal_receiver_status_interval is in "18

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Sushant Sinha
I agree that it will be a good idea to rewrite the entire thing. However, in the mean time, I sent a proposal earlier http://archives.postgresql.org/pgsql-hackers/2010-08/msg00019.php And a patch later: http://archives.postgresql.org/pgsql-hackers/2010-09/msg00476.php Tom asked me to look into

Re: [HACKERS] Add support for logging the current role

2011-02-14 Thread Itagaki Takahiro
On Mon, Feb 14, 2011 at 23:30, Stephen Frost wrote: > > * In assign_csvlog_fields(), we need to cleanup memory and memory context > > before return on error. > Fixed this and a couple of similar issues. Not yet fixed. Switched memory context is not restored on error. > Updated patch attached, gi

Re: [HACKERS] Change pg_last_xlog_receive_location not to move backwards

2011-02-14 Thread Fujii Masao
On Sat, Feb 12, 2011 at 11:32 PM, Robert Haas wrote: > So, what if we did some renaming?  I'd be inclined to start by > renaming "receivedUpTo" to Flush, and add a new position called > Stream.  When walreciever is started, we set Stream to the position at > which streaming is going to begin (whic

Re: [HACKERS] pg_upgrade seems a tad broken

2011-02-14 Thread Tom Lane
I wrote: > I tried to do a pg_upgrade from 9.0.x to HEAD today. The pg_upgrade run > went through without complaint, and I could start the postmaster, but > every connection attempt fails with > psql: FATAL: could not read block 0 in file "base/11964/11683": read only 0 > of 8192 bytes > The

[HACKERS] pg_upgrade seems a tad broken

2011-02-14 Thread Tom Lane
I tried to do a pg_upgrade from 9.0.x to HEAD today. The pg_upgrade run went through without complaint, and I could start the postmaster, but every connection attempt fails with psql: FATAL: could not read block 0 in file "base/11964/11683": read only 0 of 8192 bytes The database OID varies d

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Peter Eisentraut
On mån, 2011-02-14 at 11:49 -0500, Stephen Frost wrote: > Perhaps a thought for next time would be to offset things a bit. eg: > > CF 2011-03 (or whatever): > 2011-02-14: Patches should all be submitted > 2011-02-14: Reviewers start > 2011-03-01: Committers start w/ 'Ready for Committer' patches

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Peter Eisentraut
On mån, 2011-02-14 at 22:22 +0100, Jan Urbański wrote: > The problem is that every *second* call to the function fails, > regardless of the number. The first execution succeeds, but then > PLy_delete_args deletes the argument from the globals, and when the > next execution tries to fetch "n" from i

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 8:03 PM, Tom Lane wrote: > Robert Haas writes: >> Are we deparsing the names of the SQL files to infer the set of >> version numbers we have to worry about?  It seems to me that if >> there's a list of known version numbers somewhere, we can use dash as >> the separator wi

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 7:52 AM, Noah Misch wrote: >> I'm half-tempted to put that part off to >> 9.2, in the hopes of getting a more substantial solution that can also >> handle things like text -> xml which we don't have time to re-engineer >> right now. > > I see. After sleeping on it, I think

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 8:18 PM, Tom Lane wrote: >> >> Yes, but the truth is that the extension name, at least, is known from the >> control file. > > Yeah, I think it's true in the current code base that we always know the > extension name we are interested in. However, that's no protection if >

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
"David E. Wheeler" writes: > On Feb 14, 2011, at 5:03 PM, Tom Lane wrote: >>> Are we deparsing the names of the SQL files to infer the set of >>> version numbers we have to worry about? It seems to me that if >>> there's a list of known version numbers somewhere, we can use dash as >>> the separa

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 3:57 PM, Tom Lane wrote: > There is zero, none, nada, provision for modifying the behavior of the > default parser, other than by changing its compiled-in state transition > tables. > > It doesn't help any that said tables are baroquely designed and utterly > undocumented. >

Re: [DOCS] [HACKERS] "Extension" versus "module"

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 5:42 PM, Tom Lane wrote: >> Remember also that not all modules out there on the net will have been >> updated either, so we must be able to discuss "extension-izing a >> module". (??) > > Right. So it seems like we ought to stick with more or less the > existing terminology:

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 5:03 PM, Tom Lane wrote: >> Are we deparsing the names of the SQL files to infer the set of >> version numbers we have to worry about? It seems to me that if >> there's a list of known version numbers somewhere, we can use dash as >> the separator without any special restricto

Re: [HACKERS] .gitignore patch for coverage builds

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 7:38 PM, Jeff Janes wrote: > On Wed, Jan 26, 2011 at 2:41 PM, Alvaro Herrera > wrote: >> Excerpts from Tom Lane's message of mié ene 26 19:20:52 -0300 2011: >>> Robert Haas writes: >>> > On Wed, Jan 26, 2011 at 4:44 PM, Tom Lane wrote: >>> >> Ick. That's an awful lot of

Re: [HACKERS] pg_ctl failover Re: Latches, signals, and waiting

2011-02-14 Thread Fujii Masao
On Tue, Feb 15, 2011 at 2:10 AM, Stephen Frost wrote: > Fujii, > > * Fujii Masao (masao.fu...@gmail.com) wrote: >> Yeah, I rebased the patch to the current git master and attached it. > > Reviewing this, I just had a couple of comments and questions.  Overall, > I think it looks good and hence wil

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Tom Lane
Andrew Dunstan writes: > On 02/14/2011 08:36 PM, Tom Lane wrote: >> It looks to me like /selinux/mls is some weird phony-filesystem file, >> because "cat" prints one character (a "1") while "ls" claims the file is >> of zero length. So it's probably something consed up by the kernel, >> like /pro

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread David Blewett
On Mon, Feb 14, 2011 at 6:57 PM, Tom Lane wrote: > "David E. Wheeler" writes: >> Is it possible to modify the default tsearch parser so that / doesn't get >> lexed as a "file" token? > > There is zero, none, nada, provision for modifying the behavior of the > default parser, other than by changi

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Noah Misch
On Mon, Feb 14, 2011 at 04:06:59PM -0500, Stephen Frost wrote: > * Noah Misch (n...@leadboat.com) wrote: > > On Mon, Feb 14, 2011 at 01:12:21PM -0500, Stephen Frost wrote: > > > In ATColumnChangeSetWorkLevel(), I'm really not a huge fan of using a > > > passed-in argument to move through a list wit

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Andrew Dunstan
On 02/14/2011 08:36 PM, Tom Lane wrote: Andrew Dunstan writes: Yeah. The next thing I hit was this: [andrew@aurelia sepgsql]$ make -f /usr/share/selinux/devel/Makefile sepgsql-regtest.pp cat: /selinux/mls: No such file or directory make: *** No rule to make target `sepgsql

Re: [HACKERS] Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

2011-02-14 Thread Fujii Masao
On Wed, Feb 9, 2011 at 5:12 PM, Magnus Hagander wrote: > I was also worried about the non-hot-standby case, but I see that the > patch makes sure you can't enable pause when not in hot standby mode. > Which in itself might be surprising - perhaps we need a NOTICE for > when that happens as well? >

[HACKERS] Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

2011-02-14 Thread Fujii Masao
On Tue, Feb 15, 2011 at 9:21 AM, Simon Riggs wrote: > On Wed, 2011-02-09 at 15:22 +0900, Fujii Masao wrote: > >> On the second thought, I think it's useful to emit the NOTICE message when >> recovery reaches the pause point, as follows. >> >>     NOTICE: Recovery will not complete until pg_xlog_re

Re: [DOCS] [HACKERS] "Extension" versus "module"

2011-02-14 Thread Tom Lane
Simon Riggs writes: > I would say that some modules are extensions, but not all. A standalone > executable might be part of a module, but would not be an extension. > Remember also that not all modules out there on the net will have been > updated either, so we must be able to discuss "extension

Re: [HACKERS] "Extension" versus "module"

2011-02-14 Thread Simon Riggs
On Mon, 2011-02-14 at 12:48 +0100, Dimitri Fontaine wrote: > Tom Lane writes: > > Appendix F (contrib.sgml and its subsidiary files) is pretty consistent > > about using "module" to refer to a contrib, uh, module. > > I'm now thinking in those terms: the module is the shared object library > that

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Tom Lane
Andrew Dunstan writes: > Yeah. The next thing I hit was this: > [andrew@aurelia sepgsql]$ make -f /usr/share/selinux/devel/Makefile > sepgsql-regtest.pp > cat: /selinux/mls: No such file or directory > make: *** No rule to make target `sepgsql-regtest.pp'. Stop. > [andrew@aur

Re: [HACKERS] Replication server timeout patch

2011-02-14 Thread Simon Riggs
On Mon, 2011-02-14 at 14:13 -0800, Daniel Farina wrote: > On Mon, Feb 14, 2011 at 12:48 AM, Fujii Masao wrote: > > On Sat, Feb 12, 2011 at 8:58 AM, Daniel Farina wrote: > >> Context diff equivalent attached. > > > > Thanks for the patch! > > > > As I said before, the timeout which this patch prov

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > But the > trickiest part of this whole process is that, on the one hand, it's > not fair for committers to ignore other people's patches, but on the > other hand, it's not fair to expect committers to sacrifice getting > their own projects done to get

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
Robert Haas writes: > Are we deparsing the names of the SQL files to infer the set of > version numbers we have to worry about? It seems to me that if > there's a list of known version numbers somewhere, we can use dash as > the separator without any special restricton. The list of known version

Re: [HACKERS] .gitignore patch for coverage builds

2011-02-14 Thread Jeff Janes
On Wed, Jan 26, 2011 at 2:41 PM, Alvaro Herrera wrote: > Excerpts from Tom Lane's message of mié ene 26 19:20:52 -0300 2011: >> Robert Haas writes: >> > On Wed, Jan 26, 2011 at 4:44 PM, Tom Lane wrote: >> >> Ick. That's an awful lot of stuff to have global ignores for. >> >> > The "coverage" dir

[HACKERS] Re: [COMMITTERS] pgsql: Basic Recovery Control functions for use in Hot Standby. Pause,

2011-02-14 Thread Simon Riggs
On Wed, 2011-02-09 at 15:22 +0900, Fujii Masao wrote: > On the second thought, I think it's useful to emit the NOTICE message when > recovery reaches the pause point, as follows. > > NOTICE: Recovery will not complete until pg_xlog_replay_resume() is > called. I'm OK with adding a message,

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Thom Brown
On 14 February 2011 23:57, Tom Lane wrote: > "David E. Wheeler" writes: >> Is it possible to modify the default tsearch parser so that / doesn't get >> lexed as a "file" token? > > There is zero, none, nada, provision for modifying the behavior of the > default parser, other than by changing its

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 10:13 AM, Tom Lane wrote: > Peter Eisentraut writes: >> Why do the extension load files need two dashes, like xml2--1.0.sql? >> Why isn't one enough? > > Because we'd have to forbid dashes in extension name and version > strings.  This was judged to be a less annoying solu

Re: [HACKERS] tsearch Parser Hacking

2011-02-14 Thread Tom Lane
"David E. Wheeler" writes: > Is it possible to modify the default tsearch parser so that / doesn't get > lexed as a "file" token? There is zero, none, nada, provision for modifying the behavior of the default parser, other than by changing its compiled-in state transition tables. It doesn't hel

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Robert Haas
Sorry for the previous, content-free reply. On Mon, Feb 14, 2011 at 11:49 AM, Stephen Frost wrote: > * Robert Haas (robertmh...@gmail.com) wrote: >> Here's where I think we are with this CommitFest. > >  Subject: Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04 > > I'm gonna go out on a limb and

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-14 Thread Alvaro Herrera
Excerpts from Marti Raudsepp's message of lun feb 14 19:39:25 -0300 2011: > On Fri, Feb 11, 2011 at 09:13, Noah Misch wrote: > > The patch had a trivial conflict in planner.c, plus plenty of offsets.  I've > > attached the rebased patch that I used for review.  For anyone following > > along, > >

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Robert Haas
On Mon, Feb 14, 2011 at 11:49 AM, Stephen Frost wrote: > I have to say that I've always been a bit suprised by the idea that the > CommitFest is intended to be done and all patches *committed* at the end > of the month.  It's been working really rather well, which is due in > great part to the exc

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-14 Thread Marti Raudsepp
On Fri, Feb 11, 2011 at 09:13, Noah Misch wrote: > The patch had a trivial conflict in planner.c, plus plenty of offsets.  I've > attached the rebased patch that I used for review.  For anyone following > along, > all the interesting hunks touch heapam.c; the rest is largely mechanical.  A > "dif

[HACKERS] tsearch Parser Hacking

2011-02-14 Thread David E. Wheeler
Hackers, Is it possible to modify the default tsearch parser so that / doesn't get lexed as a "file" token? That is, instead of this: try=# select * from ts_debug('simple'::regconfig, 'w/d'); alias │description│ token │ dictionaries │ dictionary │ lexemes ───┼───┼──

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Andrew Dunstan
On 02/14/2011 04:21 PM, Tom Lane wrote: Andrew Dunstan writes: Thew makefile still has this bogosity: sepgsql-regtest.pp: sepgsql-regtest.te $(MAKE) -f $(DESTDIR)/usr/share/selinux/devel/Makefile $@ We need to fix that up before we even think of trying to get buildfarm coverage

Re: [HACKERS] Replication server timeout patch

2011-02-14 Thread Daniel Farina
On Mon, Feb 14, 2011 at 12:48 AM, Fujii Masao wrote: > On Sat, Feb 12, 2011 at 8:58 AM, Daniel Farina wrote: >> Context diff equivalent attached. > > Thanks for the patch! > > As I said before, the timeout which this patch provides doesn't work well > when the walsender gets blocked in sending WA

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 16:15, Magnus Hagander wrote: > On Mon, Feb 14, 2011 at 10:39, Stefan Kaltenbrunner > wrote: >> On 02/14/2011 10:09 AM, Magnus Hagander wrote: >>> On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner >>> wrote: On 02/14/2011 01:27 AM, Tom Lane wrote: > > Magnu

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Tom Lane
Andrew Dunstan writes: > Thew makefile still has this bogosity: > sepgsql-regtest.pp: sepgsql-regtest.te > $(MAKE) -f $(DESTDIR)/usr/share/selinux/devel/Makefile $@ > We need to fix that up before we even think of trying to get buildfarm > coverage. The presence and location of thi

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Jan Urbański
On 14/02/11 22:13, Jan Urbański wrote: > On 14/02/11 21:06, Peter Eisentraut wrote: >> On ons, 2011-02-09 at 10:02 +0100, Jan Urbański wrote: >>> On 09/02/11 04:52, Hitoshi Harada wrote: 2010/12/31 Jan Urbański : > (continuing the flurry of patches) > > Here's a patch that stops PL

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Jan Urbański
On 14/02/11 21:06, Peter Eisentraut wrote: > On ons, 2011-02-09 at 10:02 +0100, Jan Urbański wrote: >> On 09/02/11 04:52, Hitoshi Harada wrote: >>> 2010/12/31 Jan Urbański : (continuing the flurry of patches) Here's a patch that stops PL/Python from removing the function's argum

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Stephen Frost
* Noah Misch (n...@leadboat.com) wrote: > On Mon, Feb 14, 2011 at 01:12:21PM -0500, Stephen Frost wrote: > > First question is- why do you use #ifdef USE_ASSERT_CHECKING ..? > > The other six code sites checking assert_enabled directly do the same. Wow, I could have sworn that I looked at what ot

Re: [HACKERS] FOR KEY LOCK foreign keys

2011-02-14 Thread Alvaro Herrera
Excerpts from Noah Misch's message of vie feb 11 04:13:22 -0300 2011: > I observe visibility breakage with this test case: > > [ ... ] > > The problem seems to be that funny t_cid (2249). Tracing through heap_update, > the new code is not setting t_cid during this test case. So I can fix this p

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Chris Browne
t...@sss.pgh.pa.us (Tom Lane) writes: > Peter Eisentraut writes: >> On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: >>> Peter Eisentraut writes: Why do the extension load files need two dashes, like xml2--1.0.sql? Why isn't one enough? > >>> Because we'd have to forbid dashes in exte

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Cédric Villemain
2011/2/14 Tom Lane : > =?ISO-8859-1?Q?C=E9dric_Villemain?= > writes: >> why do we care if there is a dash in the middle of a text where there >> are no numbers ? > > Umm ... we are not requiring version names to be numbers. good point I was believing we had something like multi-name-1.2.3-5

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
=?ISO-8859-1?Q?C=E9dric_Villemain?= writes: > why do we care if there is a dash in the middle of a text where there > are no numbers ? Umm ... we are not requiring version names to be numbers. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postg

Re: [HACKERS] pl/python do not delete function arguments

2011-02-14 Thread Peter Eisentraut
On ons, 2011-02-09 at 10:02 +0100, Jan Urbański wrote: > On 09/02/11 04:52, Hitoshi Harada wrote: > > 2010/12/31 Jan Urbański : > >> (continuing the flurry of patches) > >> > >> Here's a patch that stops PL/Python from removing the function's > >> arguments from its globals dict after calling it. I

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Dimitri Fontaine
Robert Haas writes: > We have committed 45 patches and returned with feedback or rejected > 23. There are 30 remaining patches, every single one of which has > been reviewed. 20 of those are marked Ready for Committer; 5 are > marked Waiting on Author; 5 are marked Needs Review. However, again,

[HACKERS] pageinspect's infomask and infomask2 as smallint

2011-02-14 Thread Alvaro Herrera
Thanks to Noah Misch's review of the keylock patch I noticed that pageinspect's heap_page_items(bytea) function returns infomask and infomask2 as smallint (signed). But the fields in the tuple header are 16 bits unsigned, so if the high (16th) bit is set, it returns negative values which seem hard

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Cédric Villemain
2011/2/14 Tom Lane : > "David E. Wheeler" writes: >> On Feb 14, 2011, at 8:54 AM, Tom Lane wrote: I'm not convinced.  There was nothing in that discussion why any particular character would have to be allowed in a version number. > >>> Well, there's already a counterexample in the curren

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Noah Misch
Hi Stephen, Thanks for jumping in on this one. On Mon, Feb 14, 2011 at 01:12:21PM -0500, Stephen Frost wrote: > First question is- why do you use #ifdef USE_ASSERT_CHECKING ..? The other six code sites checking assert_enabled directly do the same. > assert_enabled exists and will work the way y

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Andrew Dunstan
On 02/14/2011 11:47 AM, Kohei Kaigai wrote: We really need to get a buildfarm which is building with this. To that end, would you mind providing directions so someone else could set up a buildfarm member to test it..? It seems to me not difficult to describe a direction to build, install and

Re: [HACKERS] SSI bug?

2011-02-14 Thread Kevin Grittner
YAMAMOTO Takashi wrote: >> Did you notice whether the loop involved multiple tuples within a >> single page? > > if i understand correctly, yes. > > the following is a snippet of my debug code (dump targets when > triggerCheckTargetForConflictsIn loops >1000 times) and its > output.the same lo

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Alvaro Herrera
Excerpts from Kohei Kaigai's message of lun feb 14 13:47:58 -0300 2011: > > We really need to get a buildfarm which is building with this. To that > > end, would you mind providing directions so someone else could set up a > > buildfarm member to test it..? > > It seems to me not difficult to des

Re: [HACKERS] pg_terminate_backend and pg_cancel_backend by not administrator user

2011-02-14 Thread Kevin Grittner
Torello Querci wrote: > I attach a path for this It's too late in the release cycle to consider this for version 9.1. Please add it to the open CommitFest for consideration for 9.2: https://commitfest.postgresql.org/action/commitfest_view/open -Kevin -- Sent via pgsql-hackers mailing lis

Re: [HACKERS] pika failing since the per-column collation patch

2011-02-14 Thread Rémi Zara
Le 12 févr. 2011 à 18:51, Peter Eisentraut a écrit : > On lör, 2011-02-12 at 13:34 +0100, Rémi Zara wrote: >> Since the per-column collation patch went in, pika (NetBSD 5.1/mips) started >> failing consistently with this diff: >> >> *** >> /home/pgbuildfarm/workdir/HEAD/pgsql.15101/src/test/re

Re: [HACKERS] ALTER TYPE 2: skip already-provable no-work rewrites

2011-02-14 Thread Stephen Frost
Noah, I'm even less familiar w/ this code than Robert, but figured I'd give a shot at reviewing this anyway. I definitely like avoiding table rewrites if I can get away with it. :) First question is- why do you use #ifdef USE_ASSERT_CHECKING ..? assert_enabled exists and will work the way you ex

Re: [HACKERS] SSI bug?

2011-02-14 Thread Kevin Grittner
Heikki Linnakangas wrote: > Looking at the prior/next version chaining, aside from the > looping issue, isn't it broken by lock promotion too? There's a > check in RemoveTargetIfNoLongerUsed() so that we don't release a > lock target if its priorVersionOfRow is set, but what if the tuple > lock

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Kohei Kaigai
> We really need to get a buildfarm which is building with this. To that > end, would you mind providing directions so someone else could set up a > buildfarm member to test it..? It seems to me not difficult to describe a direction to build, install and run regression test. Do we have any Fedora

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Dimitri Fontaine
Tom Lane writes: > I don't really think that's a behavior we want to encourage. ISTM the > cases that are going to be trouble are paths you failed to think about, > and therefore what you want to do is look over the whole output set to > see if there are any surprising paths... Mmm, yes. Ok. -

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Stephen Frost
* Florian Weimer (fwei...@bfk.de) wrote: > Source? I've only seen GPLed copies. We wouldn't face this issue > with LGPL code. Yeah, Greg corrected me on this already. So we have both FSF folks *and* OpenSSL people being foolish. Sigh. Stephen signature.asc Description: Digital signa

Re: [HACKERS] Debian readline/libedit breakage

2011-02-14 Thread Florian Weimer
* Stephen Frost: > * Greg Smith (g...@2ndquadrant.com) wrote: >> -GNU libreadine is certainly never going to add an OpenSSL exemption > > I really wish they would, that's just them being obnoxious- it's already > LGPL, after all.. Source? I've only seen GPLed copies. We wouldn't face this issue

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >>> [ about omitting rows for which there is no update path ] >> Yeah, possibly. I'm a bit concerned about cases where the author meant >> to provide an update path and forgot: it would be fairly obvious in this >> representation but maybe you could k

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 9:14 AM, Tom Lane wrote: > Commas do not seem like an improvement to me at all --- they are widely > used as list separators. Fair enough. > I guess the real question is what's Peter's concrete objection to the > double-dash method? Hey, I know, a double-dash between the ext

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
"David E. Wheeler" writes: > On Feb 14, 2011, at 8:54 AM, Tom Lane wrote: >>> I'm not convinced. There was nothing in that discussion why any >>> particular character would have to be allowed in a version number. >> Well, there's already a counterexample in the current contrib stuff: >> uuid-oss

Re: [HACKERS] pg_ctl failover Re: Latches, signals, and waiting

2011-02-14 Thread Stephen Frost
Fujii, * Fujii Masao (masao.fu...@gmail.com) wrote: > Yeah, I rebased the patch to the current git master and attached it. Reviewing this, I just had a couple of comments and questions. Overall, I think it looks good and hence will be marking it 'Ready for Committer'. * You removed trigger_fil

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread David E. Wheeler
On Feb 14, 2011, at 8:54 AM, Tom Lane wrote: >> I'm not convinced. There was nothing in that discussion why any >> particular character would have to be allowed in a version number. > > Well, there's already a counterexample in the current contrib stuff: > uuid-ossp. We could rename that to uui

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Dimitri Fontaine
Tom Lane writes: > I intentionally left out columns that seem like extension implementation > details rather than things users of the extension need to know. Hence, > no directory, encoding, or module_pathname. There's no fundamental > reason not to include these, I guess, although maybe there c

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Marko Kreen
On Mon, Feb 14, 2011 at 6:49 PM, Peter Eisentraut wrote: > On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: >> Peter Eisentraut writes: >> > Why do the extension load files need two dashes, like xml2--1.0.sql? >> > Why isn't one enough? >> >> Because we'd have to forbid dashes in extension name

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
Peter Eisentraut writes: > On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: >> Peter Eisentraut writes: >>> Why do the extension load files need two dashes, like xml2--1.0.sql? >>> Why isn't one enough? >> Because we'd have to forbid dashes in extension name and version >> strings. This was

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> and pg_available_extension_versions that produces a row per install >> script, with columns >> >> name >> version ((name, version) is primary key) >> comment >> requires >> relocatable >> schema >> >> where the last four column

Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Stephen Frost
* Robert Haas (robertmh...@gmail.com) wrote: > Here's where I think we are with this CommitFest. Subject: Re: [HACKERS] CommitFest 2011-01 as of 2011-02-04 I'm gonna go out on a limb and hope you meant '2011-02-14' there. :) > So there are two basic difficulties with wrapping the CommitFest up

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Peter Eisentraut
On mån, 2011-02-14 at 10:13 -0500, Tom Lane wrote: > Peter Eisentraut writes: > > Why do the extension load files need two dashes, like xml2--1.0.sql? > > Why isn't one enough? > > Because we'd have to forbid dashes in extension name and version > strings. This was judged to be a less annoying s

Re: [HACKERS] using a lot of maintenance_work_mem

2011-02-14 Thread Kevin Grittner
Frederik Ramm wrote: > I am (ab)using a PostgreSQL database (with PostGIS extension) in > a large data processing job - each day, I load several GB of data, > run a lot of analyses on it, and then throw everything away again. > Loading, running, and dumping the results takes about 18 hours > eve

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Dimitri Fontaine
Tom Lane writes: > Thinking about this some more ... it seems like we now need two separate > views, because there is some information that could change per-version, > and some that really only makes sense at the per-extension level. Makes sense. > For instance, we could have pg_available_extens

Re: [HACKERS] "Extension" versus "module"

2011-02-14 Thread Tom Lane
Dimitri Fontaine writes: > Another concern has to do with PLs. We said that with the dependency > mechanism it would be good to have PLs be EXTENSIONs. But those are > core provided extensions, one of them installed by default. > If we make PLs extensions, we might also want to have CREATE LANG

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Stephen Frost
KaiGai, * Kohei Kaigai (kohei.kai...@eu.nec.com) wrote: > > It would be good to have some buildfarm coverage of this code. Can we > > find anyone brave enough to set up a buildfarm critter using > > --with-selinux? > > > Although I don't have an account on the buildfarm, I'll set up an environmen

[HACKERS] CommitFest 2011-01 as of 2011-02-04

2011-02-14 Thread Robert Haas
Here's where I think we are with this CommitFest. We have committed 45 patches and returned with feedback or rejected 23. There are 30 remaining patches, every single one of which has been reviewed. 20 of those are marked Ready for Committer; 5 are marked Waiting on Author; 5 are marked Needs Re

Re: [HACKERS] "Extension" versus "module"

2011-02-14 Thread Dimitri Fontaine
Tom Lane writes: > Hmm ... but what of contrib "modules" that don't build shared libraries > at all --- pgbench and pg_upgrade for example? > > I think "shared library" is a perfectly fine term for that kind of > object, and we don't need an alias for it anyway. In my view, if there's no script,

Re: [HACKERS] Range Types: empty ranges

2011-02-14 Thread Kevin Grittner
Jan Wieck wrote: > Does ['15:15:00','15:15:00') make any more sense? Doesn't this > essentially mean > > >= '15:15:00' && < '15:15:00' > > which again doesn't include a single point on the time line? It defines a position in time with zero duration. Some of the graphics programming I

Re: [HACKERS] Extensions vs PGXS' MODULE_PATHNAME handling

2011-02-14 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> Also, I've been looking at the pg_available_extensions issue a bit. >> I don't yet have a proposal for exactly how we ought to redefine it, >> but I did notice that the existing code is terribly confused by >> secondary control files: it doesn't real

Re: [HACKERS] Range Types: empty ranges

2011-02-14 Thread Jan Wieck
On 2/11/2011 1:50 PM, Kevin Grittner wrote: Josh Berkus wrote: if I, in one of my applications, accidentally defined something as having the range '('15:15:00','15:15:00')', I would *want* the database to through an error and not accept it. I can agree with that, but I think that range '[

Re: [HACKERS] mingw64

2011-02-14 Thread Peter Rosin
Den 2011-02-12 11:10 skrev Ralf Wildenhues: > Hello, and sorry for the delay, > > * Peter Rosin wrote on Sat, Jan 29, 2011 at 02:26:24PM CET: >> Or is plain 'ar' used somewhere instead of 'x86_64-w64-mingw32-ar'? > > Automake outputs 'AR = ar' in Makefile.in for rules creating old > libraries iff

Re: [HACKERS] sepgsql contrib module

2011-02-14 Thread Kohei Kaigai
Sorry for the late responding, because of my relocation. > It would be good to have some buildfarm coverage of this code. Can we > find anyone brave enough to set up a buildfarm critter using > --with-selinux? > Although I don't have an account on the buildfarm, I'll set up an environment for dai

Re: [HACKERS] "Extension" versus "module"

2011-02-14 Thread Tom Lane
Dimitri Fontaine writes: > Tom Lane writes: >> Appendix F (contrib.sgml and its subsidiary files) is pretty consistent >> about using "module" to refer to a contrib, uh, module. > I'm now thinking in those terms: the module is the shared object library > that the backend needs to dlopen(). The

Re: [HACKERS] Scheduled maintenance affecting gitmaster

2011-02-14 Thread Magnus Hagander
On Mon, Feb 14, 2011 at 10:39, Stefan Kaltenbrunner wrote: > On 02/14/2011 10:09 AM, Magnus Hagander wrote: >> On Mon, Feb 14, 2011 at 07:13, Stefan Kaltenbrunner >> wrote: >>> On 02/14/2011 01:27 AM, Tom Lane wrote: Magnus Hagander  writes: > > Unfortunately, one of the worst-c

Re: [HACKERS] why two dashes in extension load files

2011-02-14 Thread Tom Lane
Peter Eisentraut writes: > Why do the extension load files need two dashes, like xml2--1.0.sql? > Why isn't one enough? Because we'd have to forbid dashes in extension name and version strings. This was judged to be a less annoying solution. See yesterday's discussion.

Re: [HACKERS] using a lot of maintenance_work_mem

2011-02-14 Thread Tom Lane
Frederik Ramm writes: > Now I assume that there are reasons that you're doing this. memutils.h > has the (for me) cryptic comment about MaxAllocSize: "XXX This is > deliberately chosen to correspond to the limiting size of varlena > objects under TOAST. See VARATT_MASK_SIZE in postgres.h.", but

[HACKERS] using a lot of maintenance_work_mem

2011-02-14 Thread Frederik Ramm
Hi, I am (ab)using a PostgreSQL database (with PostGIS extension) in a large data processing job - each day, I load several GB of data, run a lot of analyses on it, and then throw everything away again. Loading, running, and dumping the results takes about 18 hours every day. The job inv

Re: [HACKERS] Add support for logging the current role

2011-02-14 Thread Stephen Frost
Itagaki, * Itagaki Takahiro (itagaki.takah...@gmail.com) wrote: > We need to design csvlog_header more carefully. csvlog_header won't work > if log_filename is low-resolution, ex. log-per-day. This isn't any different a problem to the issue of someone changing the csvlog_fields GUC but not checki

  1   2   >