On Mon, Jan 24, 2011 at 08:45, Fujii Masao wrote:
> On Fri, Jan 21, 2011 at 12:28 AM, Tom Lane wrote:
>> Magnus Hagander writes:
- Why not initialize logid and logseg like so?:
int logid = startptr.xlogid;
int logseg = startptr.xrecoff / XLogSegSize;
On Fri, Jan 21, 2011 at 12:28 AM, Tom Lane wrote:
> Magnus Hagander writes:
>>> - Why not initialize logid and logseg like so?:
>>>
>>> int logid = startptr.xlogid;
>>> int logseg = startptr.xrecoff / XLogSegSize;
>>>
>>> Then use those in your elog? Seems cleaner to me.
>
>> Hmm.
On 24.01.2011 03:48, Kevin Grittner wrote:
If I get a solid answer on the SSI/HS issue before I post V14, I
might be able to cover that, too, in that patch. I haven't wanted to
totally write off the possibility of integrating them as long as
discussion was ongoing; but if someone wants to assume
On Wed, Jan 5, 2011 at 5:08 AM, Heikki Linnakangas
wrote:
> I finally got around to look at this. I wrote a patch to validate that the
> TLI on xlog page header matches ThisTimeLineID during recovery, and noticed
> quickly in testing that it doesn't catch all the cases I'd like to catch
> :-(.
Th
On 24.01.2011 03:42, Itagaki Takahiro wrote:
I found the following warning with Fedora 14 / gcc 4.5.1.
pg_backup_archiver.c: In function ‘_discoverArchiveFormat’:
pg_backup_archiver.c:1736:11: warning: ‘fh’ may be used uninitialized
in this function
To suppress it, I'm thinking to add n
On Sun, Jan 23, 2011 at 8:33 PM, Magnus Hagander wrote:
> I've committed this with the current name, pg_basebackup
Great!
But, per subsequent commit logs, I should have reviewed more about
portability issues :(
Regards,
--
Fujii Masao
NIPPON TELEGRAPH AND TELEPHONE CORPORATION
NTT Open Source
And there are two versions of gcc installed on my WinXP PRO SP3, 3.4.4
is the one used to the above test
D:\devproj\postgresql-9.0.2>gcc -v
Reading specs from /usr/lib/gcc/i686-pc-msys/3.4.4/specs
Configured with: /home/cstrauss/build/gcc3/gcc-3.4.4/configure --prefix=/usr --s
ysconfdir=/etc --loc
Hi,
I download the lastest 32bit MinGW from sourceforge, and found there
are *NIX like tools such as chmod and ls in the MinGW\msys\1.0\bin
directory.
But the make process does not success,
This test is done on my 32bit Windows XP SP3
Here are the messages:
D:\devproj\postgresql-9.0.2>sh confi
On Sun, Jan 23, 2011 at 12:06:43PM -0500, Tom Lane wrote:
> Robert Haas writes:
> > On Sun, Jan 9, 2011 at 5:01 PM, Noah Misch wrote:
> >> As unintended fallout, it's no longer an error to add oids or a column
> >> with a
> >> default value to a table whose rowtype is used in columns elsewhere.
2011/1/23 Jan Urbański :
> On 22/01/11 11:15, Hitoshi Harada wrote:
>> This is a review for
>> https://commitfest.postgresql.org/action/patch_view?id=460
>
> Thanks,
>
>> One issue is typmod of record type.
>>
>> regression=# create or replace function func1(t text) returns record
>> as $$ return
On Sun, Jan 23, 2011 at 12:06 PM, Tom Lane wrote:
> Robert Haas writes:
>> On Sun, Jan 9, 2011 at 5:01 PM, Noah Misch wrote:
>>> As unintended fallout, it's no longer an error to add oids or a column with
>>> a
>>> default value to a table whose rowtype is used in columns elsewhere. This
>>>
Yes, I want it working on 64 bit Windows Server 2003 R2 and 64 bit
Windows 7 home basic.
Which version of 32bit MinGW do you use, I use the one shipped with
Rtools212.exe which is downloaded from
http://www.murdoch-sutherland.com/Rtools, and there is no chmod.
xiaobo gu
2011/1/24 Andrew Dunstan
On Sun, Jan 23, 2011 at 9:20 PM, Joseph Adams
wrote:
> The attached patch changes hstore's Makefile so it is like the others.
Thanks, committed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@pos
* Robert Haas (robertmh...@gmail.com) wrote:
> Uh oh. You just reopened the can of worms from hell.
Alright.. I'm missing what happened to this suggestion of using:
FOR var in ARRAY array_expression ...
I like that a lot more than inventing a new top-level keyword, for the
same reasons that To
* Robert Haas (robertmh...@gmail.com) wrote:
> On Sun, Jan 23, 2011 at 9:49 PM, Stephen Frost wrote:
> > Why are you using 'FOREACH' here instead of just making it another
> > variation of 'FOR'?
>
> Uh oh. You just reopened the can of worms from hell.
hahahaha. Apparently I missed that discus
On Sun, Jan 23, 2011 at 9:49 PM, Stephen Frost wrote:
> Pavel,
>
> * Pavel Stehule (pavel.steh...@gmail.com) wrote:
>> I merge your changes and little enhanced comments.
>
> Thanks. Reviewing this further-
>
> Why are you using 'FOREACH' here instead of just making it another
> variation of 'FOR'
On Sun, Jan 23, 2011 at 9:56 PM, Robert Haas wrote:
> On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas wrote:
>> 2011/1/21 KaiGai Kohei :
>>> The attached patch is a revised version.
>>
>> I've committed this. Cleanup coming...
>
> Yikes. On further examination, exec_object_restorecon() is pretty
>
On 01/23/2011 10:09 PM, Xiaobo Gu wrote:
> Here is my plan,
> 1. To make the configurate script pass:
> Currently MinGW does not provide chmod, but on Windows I think this
> can be ignored now, we all use Admin
> users to do the work.
> 2. To make a pg-client Makefile target, can you
Here is my plan,
1. To make the configurate script pass:
Currently MinGW does not provide chmod, but on Windows I think this
can be ignored now, we all use Admin
users to do the work.
2. To make a pg-client Makefile target, can you help wich which c
files should be compiled and link
On Sun, Jan 23, 2011 at 8:53 PM, Robert Haas wrote:
> 2011/1/21 KaiGai Kohei :
>> The attached patch is a revised version.
>
> I've committed this. Cleanup coming...
Yikes. On further examination, exec_object_restorecon() is pretty
bogus. Surely you need some calls to quote_literal_cstr() in t
Pavel,
* Pavel Stehule (pavel.steh...@gmail.com) wrote:
> I merge your changes and little enhanced comments.
Thanks. Reviewing this further-
Why are you using 'FOREACH' here instead of just making it another
variation of 'FOR'? What is 'FOUND' set to following this? I realize
that might make
I discovered today that hstore's Makefile currently does not support
PGXS; namely, the ability to install it like so:
USE_PGXS=1 make
sudo USE_PGXS=1 make install
Moreover, hstore is the *only* contrib module whose Makefile does not
contain "PGXS".
The attached patch changes hstore's Mak
2011/1/21 KaiGai Kohei :
> The attached patch is a revised version.
I've committed this. Cleanup coming...
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your s
Dan is still beating up on the latest patch with DBT-2, but I expect
that I'll be posting a patch tomorrow with all known issues fixed, no
known bugs, and reasonable performance -- except for the issue of how
this work relates to hot standby in the 9.1 release. (We did find
and fix a few bugs afte
I found the following warning with Fedora 14 / gcc 4.5.1.
pg_backup_archiver.c: In function ‘_discoverArchiveFormat’:
pg_backup_archiver.c:1736:11: warning: ‘fh’ may be used uninitialized
in this function
To suppress it, I'm thinking to add noreturn to die_horribly().
Any objections? Ano
Tom Lane wrote:
> I seem to recall pointing out upthread that the FK check triggers
> are designed on the assumption that the constraint does hold
> currently. Has any analysis been done on exactly how badly they'll
> fail when it doesn't hold? I remain unconvinced that this behavior
> is desir
Unexpected argument handling in pl/python variadic argument function
create or replace function variadic_sql
(template text, variadic args text[], out text)
language sql as
$$
select $1 || ' -- ' || $2::text
$$;
create or replace function variadic
On Sun, Jan 23, 2011 at 4:24 PM, Joel Jacobson wrote:
> In the aftermath, I realized I was almost about to feel a bit ashamed
> about the fact my original forum post probably gave birth to the most
> long lived discussion in the history of PostgreSQL.
I think you'd need another order of magnitude
Hi,
I tested the patch from
http://archives.postgresql.org/message-id/aanlktikvxx6_ajzb52ona7mbzijcpdqszomcd-3u1...@mail.gmail.com
which adds GIN and GIST index support for wildcard LIKE queries using
pg_trgm.
The patch is a context diff that applies cleanly. Regression test work
after applying i
On Sun, 2011-01-23 at 16:13 -0500, Tom Lane wrote:
> Simon Riggs writes:
> > You can add an FK without an initial check, but the FK is enforced for
> > all further DML changes.
>
> I seem to recall pointing out upthread that the FK check triggers are
> designed on the assumption that the constrai
On Thu, Jan 20, 2011 at 6:19 PM, Stephen Frost wrote:
> Errr, well, ok, this is curious.
>
> gis=> alter user sfrost set role gis;
> ALTER ROLE
> gis=> ^D\q
> beren:/home/sfrost> psql --cluster 8.4/main -d gis
> psql (8.4.5)
> Type "help" for help.
>
> gis=> show role;
> role
> --
> gis
So
2011/1/23 Dimitri Fontaine :
> Tom Lane writes:
>> But anyway, this patch has now officially
>> been discussed to death.
>
> +1 :)
+∞ :)
In the aftermath, I realized I was almost about to feel a bit ashamed
about the fact my original forum post probably gave birth to the most
long lived discus
On 21.01.2011 19:11, Euler Taveira de Oliveira wrote:
Em 21-01-2011 12:47, Andrew Dunstan escreveu:
Maybe we could change the hint to say "--file=DESTINATION" or
"--file=FILENAME|DIRNAME" ?
... "--file=OUTPUT" or "--file=OUTPUTNAME".
Ok, works for me.
I've committed this patch now, with a w
Simon Riggs writes:
> You can add an FK without an initial check, but the FK is enforced for
> all further DML changes.
I seem to recall pointing out upthread that the FK check triggers are
designed on the assumption that the constraint does hold currently.
Has any analysis been done on exactly h
On Tue, 2010-12-14 at 11:24 -0500, Chris Browne wrote:
> t...@sss.pgh.pa.us (Tom Lane) writes:
> > Robert Haas writes:
> >> ... On the
> >> other hand, there's clearly also a use case for this behavior. If a
> >> bulk load of prevalidated data forces an expensive revalidation of
> >> constraints
Tom Lane writes:
> But anyway, this patch has now officially
> been discussed to death.
+1 :)
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your sub
On Sun, 2011-01-23 at 14:45 -0500, Tom Lane wrote:
> Simon Riggs writes:
> > On Sun, 2011-01-23 at 20:33 +0200, Marko Tiikkaja wrote:
> >> \d table now only shows that there's a FOREIGN KEY, which might lead the
> >> user to think that there should not be any values that don't exist in
> >> the
Simon Riggs writes:
> On Sun, 2011-01-23 at 20:33 +0200, Marko Tiikkaja wrote:
>> \d table now only shows that there's a FOREIGN KEY, which might lead the
>> user to think that there should not be any values that don't exist in
>> the referenced table.
> Neither \d nor \di shows invalid indexes
Robert Haas writes:
> On Sun, Jan 23, 2011 at 11:50 AM, Tom Lane wrote:
>> So I guess I'm coming around to the idea that we want something not too
>> much bigger than Andreas' original patch, but applying to both amop and
>> amproc, and putting the operator/function description at the end.
> Tha
On Sun, 2011-01-23 at 20:56 +0200, Marko Tiikkaja wrote:
> On 1/23/2011 8:43 PM, Simon Riggs wrote:
> > On Sun, 2011-01-23 at 20:33 +0200, Marko Tiikkaja wrote:
> >> On 1/23/2011 8:23 PM, Simon Riggs wrote:
> >>> On Sun, 2011-01-23 at 19:50 +0200, Marko Tiikkaja wrote:
> Another problem I foun
On 1/23/2011 8:43 PM, Simon Riggs wrote:
On Sun, 2011-01-23 at 20:33 +0200, Marko Tiikkaja wrote:
On 1/23/2011 8:23 PM, Simon Riggs wrote:
On Sun, 2011-01-23 at 19:50 +0200, Marko Tiikkaja wrote:
Another problem I found is that psql doesn't indicate in any way that a
FOREIGN KEY constraint is
On Sun, Jan 23, 2011 at 19:27, Simon Riggs wrote:
> On Sun, 2011-01-23 at 16:28 +, Magnus Hagander wrote:
>
>> Only show pg_stat_replication details to superusers
>
> What happens to those with REPLICATION privilege? Denied access?
Correct, same as those without it - only superuser is enough.
On Sun, 2011-01-23 at 20:33 +0200, Marko Tiikkaja wrote:
> On 1/23/2011 8:23 PM, Simon Riggs wrote:
> > On Sun, 2011-01-23 at 19:50 +0200, Marko Tiikkaja wrote:
> >> Another problem I found is that psql doesn't indicate in any way that a
> >> FOREIGN KEY constraint is not validated yet.
> >
> > Sho
On 1/23/2011 8:23 PM, Simon Riggs wrote:
On Sun, 2011-01-23 at 19:50 +0200, Marko Tiikkaja wrote:
Another problem I found is that psql doesn't indicate in any way that a
FOREIGN KEY constraint is not validated yet.
Should it?
What command do you think needs changing?
\d table now only shows
On Sun, 2011-01-23 at 16:28 +, Magnus Hagander wrote:
> Only show pg_stat_replication details to superusers
What happens to those with REPLICATION privilege? Denied access?
--
Simon Riggs http://www.2ndQuadrant.com/books/
PostgreSQL Development, 24x7 Support, Training and Servic
On Sun, 2011-01-23 at 19:50 +0200, Marko Tiikkaja wrote:
> Hi Simon,
>
> On 1/14/2011 1:15 PM, Simon Riggs wrote:
> > Patch to implement the proposed feature attached, for CFJan2011.
>
> Overall, I think the patch looks good
Thanks for the review.
> , but I found some problems with
> it. In t
Hi Simon,
On 1/14/2011 1:15 PM, Simon Riggs wrote:
Patch to implement the proposed feature attached, for CFJan2011.
Overall, I think the patch looks good, but I found some problems with
it. In tablecmds.c you have:
+ if (found && con->contype == CONSTR_FOREIGN && !con->convalidated)
On Sun, Jan 23, 2011 at 11:50 AM, Tom Lane wrote:
> And yet ... and yet ... if you adopt the position that what we're going
> to print is "amproc item: referenced procedure", then it's not entirely
> clear why the amproc item description shouldn't be complete. The
> argument that it's redundant wi
On 23 January 2011 14:28, Kris Shannon wrote:
> On 23 January 2011 13:14, Andrew Dunstan wrote:
>> But there are quite a few perlheads around. ISTR Matt Trout was muttering
>> about these scripts on IRC recently.
>
> A quick cleanup of the check_rules.pl...
>
> It's a starting point at least.
>
On 24 January 2011 03:06, Andrew Dunstan wrote:
> It's doing the right thing. But it's really spaghetti code, generated by
> a2p. Matt was just (rightly) offended by the $[ setting, IIRC.
>
> The point is that it's close to being totally unmaintainable.
>
> But if you think you can remedy it witho
Kris Shannon writes:
> What is the minimal perl version that we are requiring these days?
5.8 according to configure.
regards, tom lane
--
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/
Andy Colson writes:
> Is there anyway to make bison/yacc/gcc/etc spit out the rule names?
bison -v produces a debug output file that includes nicely cleaned-up
versions of all the rules. But it includes a lot of other stuff too,
and I'm not at all sure that the file format is stable across bison
Magnus Hagander writes:
> On Sun, Jan 23, 2011 at 03:19, Robert Haas wrote:
>> That's pretty horrendous. Tom/Bruce, any ideas?
> I saw some similar things earlier, and it turned out to be two
> different reasons in two different cases. In one case, it was because
> I was using GNU indent, even
On 01/23/2011 10:06 AM, Andrew Dunstan wrote:
On 01/23/2011 10:16 AM, Andy Colson wrote:
On 01/23/2011 08:29 AM, Andy Colson wrote:
On 01/22/2011 09:28 PM, k...@shannon.id.au wrote:
On 23 January 2011 13:14, Andrew Dunstan wrote:
But there are quite a few perlheads around. ISTR Matt Trout w
Robert Haas writes:
> On Sun, Jan 9, 2011 at 5:01 PM, Noah Misch wrote:
>> As unintended fallout, it's no longer an error to add oids or a column with a
>> default value to a table whose rowtype is used in columns elsewhere. This
>> seems
>> best. Defaults on the origin table do not even apply
I wrote:
> Robert Haas writes:
>> We're trying to represent the pg_amproc entry here, and including a
>> bunch of details of the pg_proc entry to which it happens to point
>> seems almost better to be confusing the issue.
> Yeah, that occurred to me too. However, the CREATE OPERATOR CLASS
> synt
On Sun, Jan 23, 2011 at 09:16:33AM -0600, Andy Colson wrote:
> Are there other problems with this script? Does it not pull out the rule
> names correct all the time or something? What problem was Matt having with
> it?
No, afaict it works correctly but throws some warnings.
Michael
--
Michae
On Mon, Jan 17, 2011 at 13:14, Magnus Hagander wrote:
> On Mon, Jan 17, 2011 at 12:11, Itagaki Takahiro
> wrote:
>> On Mon, Jan 17, 2011 at 19:51, Magnus Hagander wrote:
>>> Here's a patch that limits it to superuser only. We can't easily match
>>> it to the user of the session given the way the
On 01/23/2011 10:16 AM, Andy Colson wrote:
On 01/23/2011 08:29 AM, Andy Colson wrote:
On 01/22/2011 09:28 PM, k...@shannon.id.au wrote:
On 23 January 2011 13:14, Andrew Dunstan wrote:
But there are quite a few perlheads around. ISTR Matt Trout was
muttering
about these scripts on IRC recent
On 01/23/2011 08:29 AM, Andy Colson wrote:
On 01/22/2011 09:28 PM, k...@shannon.id.au wrote:
On 23 January 2011 13:14, Andrew Dunstan wrote:
But there are quite a few perlheads around. ISTR Matt Trout was muttering
about these scripts on IRC recently.
Ok, so I've figured out what its purpose
* Christian Ullrich wrote:
Magnus Hagander wrote:
On Mon, Jan 3, 2011 at 14:11, Christian Ullrich
wrote:
This change has been tested and works correctly on FreeBSD 8.1, using
the Kerberos and GSSAPI libraries from Heimdal 1.4. The server is
running PostgreSQL 9.0.2 on Windows 2008.
Does
Hi
I am not so familiar with the PostgreSQL development team, but using a MinGW
compatible client side is important to us, so I'd like to start doing it
myself if any of you experts can help.
Cheers
Xiaobo Gu
> -邮件原件-
> 发件人: Andrew Dunstan [mailto:and...@dunslane.net]
> 发送时间: 2011年1月21
On 01/23/2011 06:11 AM, Michael Meskes wrote:
On Sat, Jan 22, 2011 at 08:40:13PM -0500, Andrew Dunstan wrote:
I think these really need to be rewritten from scratch. They look
like they were written by someone who never heard of Perl 5 (it's
only about 16 years old).
You might remember that w
On 01/22/2011 09:28 PM, k...@shannon.id.au wrote:
On 23 January 2011 13:14, Andrew Dunstan wrote:
But there are quite a few perlheads around. ISTR Matt Trout was muttering
about these scripts on IRC recently.
A quick cleanup of the check_rules.pl...
It's a starting point at least.
Oh!
Bruce Momjian wrote:
xlogdefs.h says:
/*
* Because O_DIRECT bypasses the kernel buffers, and because we never
* read those buffers except during crash recovery, it is a win to use
* it in all cases where we sync on each write(). We could allow O_DIRECT
* with fsync(), but because skippi
On Thu, Jan 20, 2011 at 17:17, Magnus Hagander wrote:
> On Thu, Jan 20, 2011 at 16:45, Bruce Momjian wrote:
>> Do we envision pg_basebackup as something we will enahance, and if so,
>> should we consider a generic name?
>
> Well, it's certainly going to be enhanced. I think there are two main
> u
On Sat, Jan 22, 2011 at 08:40:13PM -0500, Andrew Dunstan wrote:
> I think these really need to be rewritten from scratch. They look
> like they were written by someone who never heard of Perl 5 (it's
> only about 16 years old).
You might remember that we had this discussion before. The script was
On Sun, Jan 23, 2011 at 03:19, Robert Haas wrote:
> 2011/1/21 KaiGai Kohei :
>> Do we have any workaround to avoid these indenting/formatting?
>> Or, the reformatted code is better than before?
>
> That's pretty horrendous. Tom/Bruce, any ideas?
I saw some similar things earlier, and it turned o
68 matches
Mail list logo
