On Mon, Jan 24, 2011 at 08:45, Fujii Masao <masao.fu...@gmail.com> wrote: > On Fri, Jan 21, 2011 at 12:28 AM, Tom Lane <t...@sss.pgh.pa.us> wrote: >> Magnus Hagander <mag...@hagander.net> writes: >>>> - Why not initialize logid and logseg like so?: >>>> >>>> int logid = startptr.xlogid; >>>> int logseg = startptr.xrecoff / XLogSegSize; >>>> >>>> Then use those in your elog? Seems cleaner to me. >> >>> Hmm. Yes. Agreed. >> >> Marginal complaint here: int is the wrong type, I'm pretty sure. > > And, we should use XLByteToPrevSeg here instead of just =, I think.
Not XLByteToSeg? (I admit I missed the existance of both those macros, though) I plan to post a rebased version of this patch today or tomorrow, btw, that should work against all the changes that have been applied to git. -- Magnus Hagander Me: http://www.hagander.net/ Work: http://www.redpill-linpro.com/ -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
