Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Radosław Smogura
On Tue, 12 Oct 2010 20:03:29 +0200, Magnus Hagander wrote: > On Tue, Oct 12, 2010 at 17:55, David Fetter wrote: >> On Tue, Oct 12, 2010 at 10:37:00AM -0500, Kevin Grittner wrote: >>> David Fetter wrote: >>> > Is there something incomplete about the ones I sent, and if so, >>> > what? >>> >>> Wel

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread David Fetter
On Thu, Oct 14, 2010 at 05:53:30PM -0400, Tom Lane wrote: > Bruce Momjian writes: > > Should we consider moving pg_filedump into our /contrib? > > Can't: it's GPL. Depends on whether we can get it relicensed. Cheers, David. -- David Fetter http://fetter.org/ Phone: +1 415 235 3778 AIM: dfett

Re: [HACKERS] string function - "format" function proposal

2010-10-14 Thread Itagaki Takahiro
On Fri, Oct 15, 2010 at 12:59 PM, Pavel Stehule wrote: > then maybe %ls or %is - like "literal string" or "ident string". Yeah, good idea! > I don't think so merging sprintf and format can be good. Sprintf is > too complex - so long years users don't know specification well and > creating some l

Re: [HACKERS] string function - "format" function proposal

2010-10-14 Thread Pavel Stehule
2010/10/15 Itagaki Takahiro : > On Thu, Oct 14, 2010 at 9:50 PM, Andrew Dunstan wrote: >> They're both somewhat arcane. But I think the C syntax is likely to be more >> familiar to a wider group of users (including, for example, perl hackers) >> than the C# syntax, and is to be preferred on those

Re: [HACKERS] XML schema validation

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 4:26 PM, Tomáš Pospíšil wrote: > Hi hackers, > > I choose (for my master's thesis) support PostgresSQL XML schema validation. > Is anybody there with suggestions? I had a look at current state and noted > that there is commented out code for DTD. > > My plan is to use lib

Re: [HACKERS] knngist plans

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 7:07 PM, Marios Vodas wrote: > I would like to ask in which future version of postgresql knngist is planned > to be included. Is there any possibility to be included in 9.1? There's a possibility, but I think the patch still needs some more work. One thing that would help

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Alvaro Herrera
Excerpts from Bernd Helmle's message of jue oct 14 16:44:36 -0300 2010: > Yepp, that was it. I had a CFLAGS='-O0' in my dev build from a former > debugging cycle and forgot about it (which reminds me to do a > maintainer-clean more often between coding). This is also the reason i > haven't seen

Re: [HACKERS] Per-column collation, work in progress

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:53 PM, Peter Eisentraut wrote: > On ons, 2010-10-13 at 19:15 -0400, Robert Haas wrote: >> What's the status of this patch? > > I would appreciate some more review of the basic architecture. Wow, what a patch. On the whole, I think this looks pretty good. Of course,

Re: [HACKERS] patch: SQL/MED(FDW) DDL

2010-10-14 Thread Shigeru HANADA
On Wed, 13 Oct 2010 19:10:42 -0400 Robert Haas wrote: > On Tue, Oct 12, 2010 at 2:27 AM, Shigeru HANADA > wrote: > > Thanks for the review! > > I'll finish the SQL/MED patch by applying your comments. > > I think this patch has gotten as much review as we can reasonably give > it this CommitFest

Re: [HACKERS] shmget error text reports funny max_connections numbers

2010-10-14 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue oct 14 21:36:48 -0300 2010: > On Wed, Oct 13, 2010 at 2:39 PM, Peter Eisentraut wrote: > > Since MaxBackends is actually max_connections + autovacuum_max_workers + > > 1, when you get an error message from shmget() it will tell you > > > > "reduce ... its

Re: [HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Hitoshi Harada
2010/10/15 Tom Lane : > Hitoshi Harada writes: >> UNION DISTINCT is nothing more than UNION itself, but gram.y >> definitely accept it and the SQL standard describes it as well. Should >> we add DISTINCT to docs? > > I think it'd be hard to describe without confusing people, because > while DISTIN

Re: [HACKERS] string function - "format" function proposal

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 9:50 PM, Andrew Dunstan wrote: > They're both somewhat arcane. But I think the C syntax is likely to be more > familiar to a wider group of users (including, for example, perl hackers) > than the C# syntax, and is to be preferred on those grounds alone. OK, probably C synt

Re: [HACKERS] FreeBSD 8.0 i386, plpythonu, threaded Python not supported on this platform

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 3:36 PM, Sergey Burladyan wrote: > Hi all! > > ./configure --prefix=$HOME/inst/pg-9 --enable-nls --enable-debug > --enable-depend --enable-cassert --enable-thread-safety --with-pgport=5431 > --with-libxml --with-libxslt --with-python --with-perl --with-tcl > FLEX=/usr/lo

Re: [HACKERS] shmget error text reports funny max_connections numbers

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 2:39 PM, Peter Eisentraut wrote: > Since MaxBackends is actually max_connections + autovacuum_max_workers + > 1, when you get an error message from shmget() it will tell you > > "reduce ... its max_connections parameter (currently 104)" > > when you actually set > > max_con

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread Tatsuo Ishii
> What new public interfaces do you think are needed for 9.1 in this > regard? At this point I'm thinking of modifying existing pg_is_in_recovery(), thus 0 new public interface. The heart of the function is RecoveryInProgress(). It simply returns LocalRecoveryInProgress. In addition to that, check

Re: [HACKERS] Path question

2010-10-14 Thread Greg Stark
On Thu, Oct 14, 2010 at 8:34 AM, Tom Lane wrote: > I did run into a problem with my plan to call the new node type "Merge": > the planner is already using "MergePath" as the name for the Path struct > that is precursor to a MergeJoin.  For the moment I'm calling the new > node type MergeAppend, bu

Re: [HACKERS] is sync rep stalled?

2010-10-14 Thread Bruce Momjian
Heikki Linnakangas wrote: > On 04.10.2010 10:49, Markus Wanner wrote: > > On 10/04/2010 09:18 AM, Heikki Linnakangas wrote: > >> With 'replay' and hot standby combination, you'll want to set > >> max_standby_archive_delay to a very low value, or a read-only query can > >> cause master to stop proce

Re: [HACKERS] Extensions, this time with a patch

2010-10-14 Thread Dimitri Fontaine
Dimitri Fontaine writes: > Open Items : > > - cfparser Still in attached v1 patch, but will repost separately, as proposed by Álvaro. > - User Documentation. Where in the manual do I write it? Chapter 35. Extending SQL looked like a good choice, there it is. Needs to get expanded with latest

Re: [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Tom Lane
Brendan Jurd writes: > Agreed that there are no doc bugs. The reason I suggested a backpatch > is that I'm concerned that a lot of people are going to be approaching > the whole Standby topic for the first time with 9.0, so it would be > nice to give those folks an accessible account of how > arc

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Robert Haas writes: > I kind of dislike SET PERMANENT as a command name, partly because I > think it sounds more certain than it really is, and partly because > it's asymmetric with the other, similar GUC-setting commands, which > are: > ALTER ROLE name [ IN DATABASE database_name ] SET > configu

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Tom Lane
"Kevin Grittner" writes: > Robert Haas wrote: >> I thought we had decided on the client-side approach, but maybe >> I'm confused. I don't have a position one way or the other, just >> trying to understand the state of the conversation. > Well, I've been pretty vocal on supporting a client-side

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread Tom Lane
Bruce Momjian writes: > Should we consider moving pg_filedump into our /contrib? Can't: it's GPL. regards, tom lane -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hacke

Re: [HACKERS] Extensions, this time with a patch

2010-10-14 Thread Dimitri Fontaine
Alvaro Herrera writes: > Okay. I looked at the code and I have to admit that it seems awkward to > have pg_dump left-joining everything against pg_depend and checking for > NULLs. I wondered if there was a simpler way to go about it, perhaps > using EXCEPT? No specific proposal though. Thanks

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Andrew Dunstan writes: > If the file is completely machine-maintained, including the comments, it > seems eminently doable. It's only if the file gets mangled by humans > that there's a problem. Yeah. We could have comments that were injected by some sort of COMMENT ON command, stored in the f

Re: [HACKERS] Path question

2010-10-14 Thread Tom Lane
Robert Haas writes: > So I tried out the logic described in this email and, with a few > modifications, it seemed to work. Updated patch attached, any review > appreciated. Applied with revisions. >> 3. TGL: "Speaking of sorting, it's not entirely clear to me how the >> patch ensures that all t

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Andrew Dunstan
On 10/14/2010 01:10 PM, Robert Haas wrote: On Thu, Oct 14, 2010 at 12:40 PM, Josh Berkus wrote: Sure. I just lose comments. I'll live with that. Actually, as part of this scheme, it would be nice if pg_settings had a "comment" column, which would be optionally set with SET PERMANENT. Not re

[HACKERS] XML schema validation

2010-10-14 Thread Tomáš Pospíšil
Hi hackers, I choose (for my master's thesis) support PostgresSQL XML schema validation. Is anybody there with suggestions? I had a look at current state and noted that there is commented out code for DTD. My plan is to use libxml2, that have in the last version better support for DTD, XSD and

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Bernd Helmle
--On 14. Oktober 2010 19:16:56 +0100 Dean Rasheed wrote: Program received signal SIGSEGV, Segmentation fault. ATExecSetNotNullInternal (is_local=1 '\001', is_new_constraint=, atttup=, attr_rel=, rel=) at tablecmds.c:4847 4847Form_pg_constraint constr

[HACKERS] Darth Revan wants to chat

2010-10-14 Thread Darth Revan
--- Darth Revan wants to stay in better touch using some of Google's coolest new products. If you already have Gmail or Google Talk, visit: http://mail.google.com/mail/b-eb174a8d94-0811140ea1-_yP4b-RCSu5vdiKkK0WEDXikE-c You'll ne

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread Alvaro Herrera
Excerpts from Robert Haas's message of jue oct 14 14:10:57 -0300 2010: > On Thu, Oct 14, 2010 at 12:41 PM, Bruce Momjian wrote: > > David Boreham wrote: > >> > >> As far as I can see there is no pre-built pg_filedump binary for the > >> PDGD yum repository (8.3.11 for RHEL5). Before I embark on bu

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Alvaro Herrera
> Looking in that function, there is a similar "found" variable that > isn't being initialised (which my compiler didn't warn about). > Initialising that to false, sems to fix the problem and all the > regression tests then pass. Excellent. Please send an updated patch. -- Álvaro Herrera The P

[HACKERS] How to determine failed connection attempt due to invalid authorization (libpq)?

2010-10-14 Thread Dmitriy Igrishin
Hey all, Is there way to determine failed connection attempt due to invalid authorization (libpq)? -- // Dmitriy.

Re: [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 2:33 PM, Simon Riggs wrote: > On Fri, 2010-10-15 at 02:24 +1100, Brendan Jurd wrote: > >> I'll drop this onto the next open commitfest.  If it passes muster, it >> sure wouldn't hurt to backpatch it to 9.0. > > Committed. Not sure there's anything there worth backpatching?

Re: [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Brendan Jurd
On 15 October 2010 05:33, Simon Riggs wrote: > On Fri, 2010-10-15 at 02:24 +1100, Brendan Jurd wrote: >> I'll drop this onto the next open commitfest.  If it passes muster, it >> sure wouldn't hurt to backpatch it to 9.0. > > Committed. Not sure there's anything there worth backpatching? There > a

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Radosław Smogura
> Regarding JDBC in the CF process -- other interfaces are handled > there. I haven't seen one patch this size for JDBC since I've been > involved, let alone two competing patches to implement the same > feature. Small patches which can be quickly handled don't make sense > to put into the proces

Re: [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Simon Riggs
On Fri, 2010-10-15 at 02:24 +1100, Brendan Jurd wrote: > I'll drop this onto the next open commitfest. If it passes muster, it > sure wouldn't hurt to backpatch it to 9.0. Committed. Not sure there's anything there worth backpatching? There aren't any doc bugs there. -- Simon Riggs

Re: [HACKERS] signal and startup process

2010-10-14 Thread Simon Riggs
Committed. On Thu, 2010-10-14 at 12:57 +0900, Fujii Masao wrote: > Hi, > > It takes nonsensically extra several seconds to shut down the standby server. > This is because the startup process cannot respond immediately the SIGTERM > signal sent by postmaster for the shutdown while it's sleeping on

Re: [HACKERS] Bug in writeTimeLineHistory

2010-10-14 Thread Simon Riggs
Agreed, committed and backpatched. On Thu, 2010-10-14 at 14:11 +0900, Fujii Masao wrote: > Hi, > > -- > if (recoveryTarget == RECOVERY_TARGET_XID) > snprintf(buffer, sizeof(buffer), >"%s%u\t%s\t%s transaction %u\n", >

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Dean Rasheed
On 14 October 2010 17:40, Bernd Helmle wrote: > > > --On 14. Oktober 2010 11:42:27 -0400 Robert Haas > wrote: > >>> I did a sanity make clean && make && make check before applying the >>> patch and all the tests passed.  After applying the patch and doing >>> make clean && make && make check, I g

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Bernd Helmle
--On 14. Oktober 2010 10:02:12 -0400 Andrew Geery wrote: The first failure I get is in the inherit tests (tail of /src/test/regress/results/inherit.out): alter table a alter column aa type integer using bit_length(aa); server closed the connection unexpectedly This probably means t

[HACKERS] Foreign Visual Studio builds

2010-10-14 Thread Greg Smith
We got an interesting documentation document left by Christian Freund recently, in regards to http://www.postgresql.org/docs/9.0/interactive/install-windows-full.html ; it says: Regarding 16.1.3 - "perl mkvcbuild.pl" In case you use a German version of VC change line 69 in "Solution.pm" to:

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 9:50 AM, Tom Lane wrote: > The fact is that you cannot know the active value anyway without > checking, because what you did with SET PERMANENT might be overridden > in various session-local ways.  The proposal for hand-edited versus > machine-edited files just adds one mor

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Kevin Grittner
Robert Haas wrote: Kevin Grittner wrote: > I thought we had decided on the client-side approach, but maybe > I'm confused. I don't have a position one way or the other, just > trying to understand the state of the conversation. Well, I've been pretty vocal on supporting a client-side solution

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:40 PM, Josh Berkus wrote: > >> Sure. I just lose comments. I'll live with that. > > Actually, as part of this scheme, it would be nice if pg_settings had a > "comment" column, which would be optionally set with SET PERMANENT.  Not > required, but nice to have. > > If we

Re: [HACKERS] A small update for postgresql.conf.sample

2010-10-14 Thread Bruce Momjian
Robert Haas wrote: > 2010/10/14 Bruce Momjian : > > Robert Haas wrote: > >> 2010/9/27 Devrim G?ND?Z : > >> > On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: > >> >> > Actually, I don't see any reason why not to backpatch it. > >> >> > >> >> I was wondering if it would cause package management

Re: [HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 10:37 AM, Hitoshi Harada wrote: > I found PostgreSQL accepts UNION DISTINCT but documents don't mention it. > > http://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-UNION > > select_statement UNION [ ALL ] select_statement > > UNION DISTINCT is nothing more than UN

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:41 PM, Bruce Momjian wrote: > David Boreham wrote: >> >> As far as I can see there is no pre-built pg_filedump binary for the >> PDGD yum repository (8.3.11 for RHEL5). Before I embark on building it >> from source I figured I'd ask here if I'm correct that there is no >

Re: [HACKERS] A small update for postgresql.conf.sample

2010-10-14 Thread Robert Haas
2010/10/14 Bruce Momjian : > Robert Haas wrote: >> 2010/9/27 Devrim G?ND?Z : >> > On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: >> >> > Actually, I don't see any reason why not to backpatch it. >> >> >> >> I was wondering if it would cause package management headaches for >> >> people who h

[HACKERS] commitfest timing

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 12:44 PM, Dean Rasheed wrote: > On 14 October 2010 16:42, Robert Haas wrote: >> In view of the fact that we are out of time for this CommitFest, ... > > When is the official end of this commitfest? > I remember talk at the start, that the end would be postponed (by a > wee

Re: [HACKERS] A small update for postgresql.conf.sample

2010-10-14 Thread Bruce Momjian
Robert Haas wrote: > 2010/9/27 Devrim G?ND?Z : > > On Mon, 2010-09-27 at 09:40 -0400, Robert Haas wrote: > >> > Actually, I don't see any reason why not to backpatch it. > >> > >> I was wondering if it would cause package management headaches for > >> people who had already modified their postgresq

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Bernd Helmle
--On 14. Oktober 2010 11:42:27 -0400 Robert Haas wrote: I did a sanity make clean && make && make check before applying the patch and all the tests passed.  After applying the patch and doing make clean && make && make check, I got a number of failures of the form “FAILED (test process exit

Re: [HACKERS] duplicate connection failure messages

2010-10-14 Thread Peter Eisentraut
On tor, 2010-10-14 at 07:30 +0200, Magnus Hagander wrote: > And I agree it's not very friendly in this specific case - I > wonder if we should log it as "localhost (127.0.0.1) and "localhost > (::1)" (and similar for any other case that returns more than one > address). That looks good. -- Sent

Re: [HACKERS] Per-column collation, work in progress

2010-10-14 Thread Peter Eisentraut
On ons, 2010-10-13 at 19:15 -0400, Robert Haas wrote: > What's the status of this patch? I would appreciate some more review of the basic architecture. -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Josh Berkus
Sure. I just lose comments. I'll live with that. Actually, as part of this scheme, it would be nice if pg_settings had a "comment" column, which would be optionally set with SET PERMANENT. Not required, but nice to have. If we had that, I suspect that a lot fewer people would want a hand

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Dean Rasheed
On 14 October 2010 16:42, Robert Haas wrote: > In view of the fact that we are out of time for this CommitFest, ... > When is the official end of this commitfest? I remember talk at the start, that the end would be postponed (by a week?) due to time spent on the git migration. Is that still the c

Re: [HACKERS] [GENERAL] pg_filedump binary for CentOS

2010-10-14 Thread Bruce Momjian
David Boreham wrote: > > As far as I can see there is no pre-built pg_filedump binary for the > PDGD yum repository (8.3.11 for RHEL5). Before I embark on building it > from source I figured I'd ask here if I'm correct that there is no > binary hidden somewhere in the packages. [ CC to hacker

Re: [HACKERS] duplicate connection failure messages

2010-10-14 Thread Alvaro Herrera
Excerpts from Magnus Hagander's message of jue oct 14 02:30:36 -0300 2010: > And I agree it's not very friendly in this specific case - I > wonder if we should log it as "localhost (127.0.0.1) and "localhost > (::1)" (and similar for any other case that returns more than one > address). +1 -- Á

Re: [HACKERS] Extensions, this time with a patch

2010-10-14 Thread Alvaro Herrera
Excerpts from Dimitri Fontaine's message of mié oct 13 18:11:21 -0300 2010: > I like both ideas. I'd like to propose that we get back to this part of > the feature later, after the first patch is in. After all, the main goal > is to support dump&restore of extensions. Let's do that first. Okay.

Re: [HACKERS] Path question

2010-10-14 Thread Tom Lane
Robert Haas writes: > On Thu, Oct 14, 2010 at 11:34 AM, Tom Lane wrote: >> Anybody have a strong feeling about what to call these things? >> At the moment I'm leaning to sticking with MergeAppend, but if we >> decide to rename it it'd probably be better to do so before committing. > I don't like

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread David Fetter
What new public interfaces do you think are needed for 9.1 in this regard? Cheers, David. On Thu, Oct 14, 2010 at 11:10:14AM +0900, Tatsuo Ishii wrote: > Ok, it seems impossible to do that by using any public interfaces > currently available in PostgreSQL 9.0. I will create a custom C > function t

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 10:02 AM, Andrew Geery wrote: > I didn’t have much time to look at the code.  The only thing I’ll > mention is that there are a couple of XXX TODO items that should be > cleared up. [...] > Since this patch actually makes inheritance behave in a more expected > way, nothing

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread David Fetter
On Thu, Oct 14, 2010 at 08:22:21AM -0400, Robert Haas wrote: > On Thu, Oct 14, 2010 at 2:59 AM, Radosław Smogura > wrote: > > On Wed, 13 Oct 2010 21:01:06 -0400, Robert Haas > > wrote: > >> Is this a JDBC patch or a PG patch?  Are we tracking JDBC patches > >> using the CF app? > > > > It is JDBC

Re: [HACKERS] Path question

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 11:34 AM, Tom Lane wrote: > I wrote: >> I rather wonder if we don't want two separate >> execution-time node types anyway, since what Append does seems >> significantly different from Merge (and MergeAppend would be just a >> misnomer). > > I've been working on this patch,

Re: [HACKERS] Path question

2010-10-14 Thread Tom Lane
I wrote: > I rather wonder if we don't want two separate > execution-time node types anyway, since what Append does seems > significantly different from Merge (and MergeAppend would be just a > misnomer). I've been working on this patch, and have gotten the executor side split out as a new node ty

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 8:55 AM, Kevin Grittner wrote: > Robert Haas  wrote: > >> Is this a JDBC patch or a PG patch? Are we tracking JDBC patches >> using the CF app? > > If this were the only patch for setQueryTimeout in front of us I > probably wouldn't have suggested that, but this thread star

Re: [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Brendan Jurd
On 12 October 2010 23:28, Fujii Masao wrote: > On Sat, Oct 9, 2010 at 10:04 AM, Brendan Jurd wrote: >> I have just set up HS+SR for the first time, and for the most part, >> the docs were excellent.  The one exception for me was the discussion >> of archive_cleanup_command.  This is a pretty impo

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread Tatsuo Ishii
> On Thu, Oct 14, 2010 at 11:10 AM, Tatsuo Ishii wrote: >> Ok, it seems impossible to do that by using any public interfaces >> currently available in PostgreSQL 9.0. I will create a custom C >> function to be distributed along with pgpool-II. > > Could you submit the function for 9.1? Thanks :-)

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Tom Lane writes: > [ shrug... ] So don't use the option of hand-editing postgresql.conf. > You're not being forced to do that, and on the other side of the coin, > you shouldn't think that you get to force people who'd rather hand-edit > to change their habits. Sure. I just lose comments. I'll l

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Dimitri Fontaine writes: > I understand that. I just think there are already too many sources for > GUCs and would welcome that there's a single possible source file with a > complete remote editing feature. [ shrug... ] So don't use the option of hand-editing postgresql.conf. You're not being f

Re: [HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Tom Lane
Hitoshi Harada writes: > UNION DISTINCT is nothing more than UNION itself, but gram.y > definitely accept it and the SQL standard describes it as well. Should > we add DISTINCT to docs? I think it'd be hard to describe without confusing people, because while DISTINCT is a noise word there, it's d

Re: [HACKERS] First patch proposal

2010-10-14 Thread Alastair Turner
Excerpt from Hitoshi Harada - Thu, Oct 14, 2010 at 4:32 PM: > Just for information, did you pick this topic from TODO > list? If so, could you attach links to the entry or to some related > former thread? And in general it is encouraged that you'd better send > one feature per a patch, in order fo

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Tom Lane writes: >> SELECT pg_load_conf('path/to/filename.conf', permament => true); > > That seems like a pretty bizarre idea. The settings wouldn't be > persistent would they? Or are you proposing this as a substitute > way of providing input for SET PERMANENT? If so what's the value? Yeah

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Dimitri Fontaine
Tom Lane writes: > Um, other than "show work_mem" or "select from pg_settings"? > > The fact is that you cannot know the active value anyway without > checking, because what you did with SET PERMANENT might be overridden > in various session-local ways. The proposal for hand-edited versus > machi

[HACKERS] Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread David Newall
On Thu, Oct 14, 2010 at 6:53 AM, Michael Meskes wrote: You seem to be answering to an email that I didn't see and couldn't find in the archive either. Was it send in private or to the list? If it went to the list I might be lagging behind. On 14/10/10 22:51, Robert Haas wrote: I didn't g

[HACKERS] UNION DISTINCT in doc

2010-10-14 Thread Hitoshi Harada
I found PostgreSQL accepts UNION DISTINCT but documents don't mention it. http://www.postgresql.org/docs/9.0/static/sql-select.html#SQL-UNION select_statement UNION [ ALL ] select_statement UNION DISTINCT is nothing more than UNION itself, but gram.y definitely accept it and the SQL standard des

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Dimitri Fontaine writes: > I wonder if providing a system function to load some configuration > option from a file, using the current parser, would do it: > SELECT pg_load_conf('path/to/filename.conf', permament => true); That seems like a pretty bizarre idea. The settings wouldn't be persist

Re: [HACKERS] First patch proposal

2010-10-14 Thread Alastair Turner
On Thu, Oct 14, 2010 at 4:05 PM, Tom Lane wrote: > Alastair Turner writes: >> I am proposing altering psql to raise certain errors and exit before >> prompting for a password. These errors would have to be on items which >> didn't leak any information, my current list is: >>  - Does the input fil

Re: [HACKERS] First patch proposal

2010-10-14 Thread Tom Lane
Alastair Turner writes: > I am proposing altering psql to raise certain errors and exit before > prompting for a password. These errors would have to be on items which > didn't leak any information, my current list is: > - Does the input file (-f) exist and is it readable > - Do paths to the out

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Kenneth Marshall
On Thu, Oct 14, 2010 at 06:09:35AM +0200, Dennis Bj??rklund wrote: > > We have a database specification in .pgpass: > > > > hostname:port:database:username:password > > > > What is the purpose of 'database' since username/password combinations > > are global, not per database? I would like to

Re: [HACKERS] SQL command to edit postgresql.conf, with comments

2010-10-14 Thread Tom Lane
Dimitri Fontaine writes: > Allow me to insist on this some more, because there's something > important going on here. The other proposal (.auto) have a major failure > mode that I don't think is acceptable. > SET PERMANENT work_mem TO '8 MB'; > select pg_reload_conf(); > There's simply no wa

Re: [HACKERS] ask for review of MERGE

2010-10-14 Thread Greg Smith
Robert Haas wrote: Greg, are you still working on a review of this patch? Yes, just had more distractions while coming to speed up on this area than I'd hoped. I'll get a second round of looking at this done by the weekend. -- Greg Smith, 2ndQuadrant US g...@2ndquadrant.com Baltimore, M

Re: [HACKERS] First patch proposal

2010-10-14 Thread Hitoshi Harada
2010/10/14 Alastair Turner : > I am proposing altering psql to raise certain errors and exit before > prompting for a password. These errors would have to be on items which > didn't leak any information, my current list is: >  - Does the input file (-f) exist and is it readable >  - Do paths to the

Re: [HACKERS] Re: starting to review the Extend NOT NULL representation to pg_constraint patch

2010-10-14 Thread Andrew Geery
Below is my review of the latest iteration of the "Extend NOT NULL Representation to pg_constraint" patch found here: http://archives.postgresql.org/message-id/e57a252dfd60c1fca9173...@amenophis Thanks Andrew

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Kevin Grittner
Robert Haas wrote: > Is this a JDBC patch or a PG patch? Are we tracking JDBC patches > using the CF app? If this were the only patch for setQueryTimeout in front of us I probably wouldn't have suggested that, but this thread started with a patch proposal to implement the same JDBC feature thr

Re: [HACKERS] string function - "format" function proposal

2010-10-14 Thread Andrew Dunstan
On 10/14/2010 08:25 AM, Robert Haas wrote: IMHO, I like {} syntax as like as C# because the format strings are extensible. { pos [ : format ] } -- ex {3:l}, {3} (, and {l} could be also supported) Escapes: {{ => {, }} => } My personal preference (and Pavel's, I guess) is to use the C-l

Re: [HACKERS] [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Itagaki Takahiro
On Mon, Oct 11, 2010 at 7:42 AM, David Newall wrote: > Trivial program to demonstrate problem: > > main() { >    ECPGdebug(1,stderr); >    exec sql connect to postgres; >    exec sql set autocommit to off; >    exec sql start transaction; >    exec sql savepoint s; >    exec sql rollback to s; >  

Re: [HACKERS] string function - "format" function proposal

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 2:25 AM, Itagaki Takahiro wrote: >> Let's make format support %s, %i, and %l, as well as >> allowing things like %$3l (meaning, escape the third argument as a >> literal and interpolate here), and call it good. > > Your idea is: >  % [ $ pos ] format  -- ex. %$3l , %l >  Es

Re: [HACKERS] [JDBC] Support for JDBC setQueryTimeout, et al.

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 2:59 AM, Radosław Smogura wrote: > On Wed, 13 Oct 2010 21:01:06 -0400, Robert Haas > wrote: >> Is this a JDBC patch or a PG patch?  Are we tracking JDBC patches >> using the CF app? > > It is JDBC patch. I will clean it and submit on this site. I didn't know > about such a

Re: [HACKERS] [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Robert Haas
On Thu, Oct 14, 2010 at 6:53 AM, Michael Meskes wrote: > Am 14.10.2010 08:52, schrieb David Newall: >> >> On 14/10/10 12:14, Itagaki Takahiro wrote: >>> >>> Which solution is better? Or, another idea? >> >> This does seem to be an new bug in previously working code. While any >> solution that fixe

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 10:18 PM, Greg Stark wrote: > On Tue, Oct 12, 2010 at 11:50 PM, Robert Haas wrote: >> There's another problem here we should think about, too.  Suppose you >> have a master and two standbys.  The master dies.  You promote one of >> the standbys, which turns out to be behin

Re: [HACKERS] wip: functions median and percentile

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 10:37 PM, Greg Stark wrote: > On Wed, Oct 13, 2010 at 5:54 PM, Robert Haas wrote: >> Or to put it more bluntly - what is the "problem with planner and hash >> agg" that all of these functions need to solve?  And why does it need >> a flag in pg_proc?  Why can't't we leave

Re: [HACKERS] Why do we have a database specification in .pgpass?

2010-10-14 Thread Pavel Golub
Hello, Bruce. You wrote: BM> We have a database specification in .pgpass: BM> hostname:port:database:username:password BM> What is the purpose of 'database' since username/password combinations BM> are global, not per database? I would like to documents its purpose. BM> -- BM> Bruc

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Fujii Masao
On Thu, Oct 14, 2010 at 11:18 AM, Greg Stark wrote: > Why don't the usual protections kick in here? The new record read from > the location the xlog reader is expecting to find it has to have a > valid CRC and a correct back pointer to the previous record. Yep. In most cases, those protections se

Re: [HACKERS] string function - "format" function proposal

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 10:23 AM, Robert Haas wrote: > On Wed, Sep 29, 2010 at 3:59 AM, Pavel Stehule > wrote: >> [ updated patch, in response to a review from Itagaki Takahiro ] > > This patch appears to be waiting for a second round of review. > Itagaki-san, are you planning to do that? I can

Re: [HACKERS] Issues with Quorum Commit

2010-10-14 Thread Robert Haas
On Wed, Oct 13, 2010 at 5:22 AM, Fujii Masao wrote: > On Wed, Oct 13, 2010 at 3:50 PM, Robert Haas wrote: >> There's another problem here we should think about, too.  Suppose you >> have a master and two standbys.  The master dies.  You promote one of >> the standbys, which turns out to be behind

Re: [HACKERS] How to reliably detect if it's a promoting standby

2010-10-14 Thread Itagaki Takahiro
On Thu, Oct 14, 2010 at 11:10 AM, Tatsuo Ishii wrote: > Ok, it seems impossible to do that by using any public interfaces > currently available in PostgreSQL 9.0. I will create a custom C > function to be distributed along with pgpool-II. Could you submit the function for 9.1? Thanks :-) -- Ita

[HACKERS] Re: [BUGS] rollback to savepoint leads to transaction already in progress

2010-10-14 Thread Michael Meskes
Am 14.10.2010 08:52, schrieb David Newall: On 14/10/10 12:14, Itagaki Takahiro wrote: Which solution is better? Or, another idea? This does seem to be an new bug in previously working code. While any solution that fixes the problem is good, it might pay to look the code that worked before. As

Re: [DOCS] [HACKERS] Docs for archive_cleanup_command are poor

2010-10-14 Thread Robert Haas
On Tue, Oct 12, 2010 at 8:28 AM, Fujii Masao wrote: > On Sat, Oct 9, 2010 at 10:04 AM, Brendan Jurd wrote: >> Hi folks, >> >> I have just set up HS+SR for the first time, and for the most part, >> the docs were excellent.  The one exception for me was the discussion >> of archive_cleanup_command.

Re: [HACKERS] Per-column collation, work in progress

2010-10-14 Thread Robert Haas
On Fri, Sep 24, 2010 at 1:57 AM, Peter Eisentraut wrote: > On fre, 2010-09-24 at 09:32 +0900, Itagaki Takahiro wrote: >> On Wed, Sep 22, 2010 at 10:29 PM, Peter Eisentraut wrote: >> >> We could support it also on MSVC. >> >> http://msdn.microsoft.com/en-us/library/a7cwbx4t(v=VS.90).aspx -- >> >>

[HACKERS] knngist plans

2010-10-14 Thread Marios Vodas
I would like to ask in which future version of postgresql knngist is planned to be included. Is there any possibility to be included in 9.1?

  1   2   >