Re: [HACKERS] Wisconsin benchmark

2009-08-14 Thread Euler Taveira de Oliveira
Tom Lane escreveu: > I tend to agree with this opinion. That benchmark is obsolete to the > point of having zero connection to the modern world; which is why we > keep not noticing when it's busted. Anyone want to argue for keeping it > in our sources? > +1 for removing it. -- Euler Taveira

Re: [HACKERS] More cruft left behind in doc directory

2009-08-14 Thread Peter Eisentraut
On Friday 14 August 2009 21:57:37 Tom Lane wrote: > I observe that the following stuff is still being left behind after > "make distclean" in doc/src/sgml/: > > -rw-rw-r--. 1 tgl tgl 934349 Aug 14 14:27 HISTORY.html > -rw-rw-r--. 1 tgl tgl 727464 Aug 14 14:27 HISTORY > -rw-rw-r--. 1 tgl tgl 337

Re: [HACKERS] freezing tuples ( was: Why is vacuum_freeze_min_age 100m? )

2009-08-14 Thread Jeff Davis
On Fri, 2009-08-14 at 14:37 -0400, Tom Lane wrote: > I tend to agree with Josh that you do need to offer two knobs. But > expressing the second knob as a fraction (with range 0 to 1) might be > better than an independent "min" parameter. As you say, that'd be > useful to prevent people from setti

Re: [HACKERS] pg_hba.conf: samehost and samenet

2009-08-14 Thread Tom Lane
Stef Walter writes: > True. I could build compatibility getifaddrs for various systems, if the > community thought this patch was worth it, and would otherwise accept > the patch. If you can do that I think it'd remove the major objection. regards, tom lane -- Sent via

Re: [HACKERS] pg_hba.conf: samehost and samenet

2009-08-14 Thread Stef Walter
Tom Lane wrote: > Magnus Hagander writes: >> On Fri, Aug 14, 2009 at 00:50, Stef Walter wrote: >>> It would be great if, in the cidr-address field of pg_hba.conf, we could >>> specify "samehost" and "samenet". > >> Seems like a reasonable feature - especially the samehost part. > > ISTM people h

Re: [HACKERS] pg_hba.conf: samehost and samenet

2009-08-14 Thread Stef Walter
Magnus Hagander wrote: > > A couple of comments on the patch: Thanks I'll keep these in mind, as things progress and for future patches. > * In general, don't include configure in the patch. Just configure.in. > Makes it easier to read, and configure is normally built by the > committer anyway.

Re: [HACKERS] Split-up ECPG patches

2009-08-14 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Mon, Aug 03, 2009 at 06:12:43PM +0200, Boszormenyi Zoltan wrote: > >> - sqlda support: >> - sqlda.c now indicates license >> - #defines inside #if 0 ... #endif are now omitted from sqltypes.h >> (both per comments from Jaime Casanova) >> > > I still owe you s

Re: [HACKERS] Split-up ECPG patches

2009-08-14 Thread Michael Meskes
On Mon, Aug 03, 2009 at 06:12:43PM +0200, Boszormenyi Zoltan wrote: > - sqlda support: > - sqlda.c now indicates license > - #defines inside #if 0 ... #endif are now omitted from sqltypes.h > (both per comments from Jaime Casanova) I still owe you some first thoughts about this part of the p

Re: [HACKERS] DECLARE doesn't set/reset sqlca after DECLARE cursor

2009-08-14 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Fri, Aug 14, 2009 at 01:02:07PM +0200, Boszormenyi Zoltan wrote: > >> Here are the two test files, with their preprocessed C output. >> Indeed, Informix emits a function call for DECLARE CURSOR. >> And it seems it's not legal to do this outside of a function. >> >

[HACKERS] More cruft left behind in doc directory

2009-08-14 Thread Tom Lane
I observe that the following stuff is still being left behind after "make distclean" in doc/src/sgml/: -rw-rw-r--. 1 tgl tgl 934349 Aug 14 14:27 HISTORY.html -rw-rw-r--. 1 tgl tgl 727464 Aug 14 14:27 HISTORY -rw-rw-r--. 1 tgl tgl 33746176 Aug 14 14:33 postgres-US.tex-pdf -rw-rw-r--. 1 tgl tgl

Re: [HACKERS] Wisconsin benchmark

2009-08-14 Thread Tom Lane
Jeff Janes writes: > The Wisconsin Benchmark in src/test/bench is broken, probably since 8.2. Again? :-( > Attached is a tested patch that fixes it. However, it might be better > to just remove src/test/bench. I tend to agree with this opinion. That benchmark is obsolete to the point of havi

Re: [HACKERS] freezing tuples ( was: Why is vacuum_freeze_min_age 100m? )

2009-08-14 Thread Tom Lane
Jeff Davis writes: > Yes. There are two ways to do the threshold: > 1. Constant fraction of vacuum_freeze_min_age > 2. Extra GUC > I lean toward #1, because it avoids an extra GUC*, and it avoids the > awkwardness when the "lower" setting is higher than the "higher" > setting. I tend to agre

Re: [HACKERS] CommitFest 2009-07: Remaining Patches

2009-08-14 Thread Alvaro Herrera
Teodor Sigaev escribió: > >so I think this is also ready to commit once the doc issues are > >addressed. > > Oleg fixed that. I think this is good ... as far as I'm concerned you can commit it if you think it's OK. Please make sure you add $PostgreSQL$ tags to all files (at least unaccent.c is m

Fwd: [HACKERS] TODO: fix priority of ordering of read and write light-weight locks

2009-08-14 Thread Jeff Janes
Sorry, I screwed up. The below was supposed to go to the list, not Tom personally. -- Forwarded message -- From: Jeff Janes Date: Thu, Aug 13, 2009 at 9:32 PM Subject: Re: [HACKERS] TODO: fix priority of ordering of read and write light-weight locks To: Tom Lane On Tue, Aug 1

Re: [HACKERS] uuid contrib don't compile in OpenSolaris

2009-08-14 Thread Emanuel Calvo Franco
> problem is that PostgreSQL uses ossp UUID which is not integrated in > OpenSolaris. Solaris has own uuid implementation which seems to me similar > but not same. Try man uuid_generate or less /usr/uuid/uuid.h > That's really interesting. I'll try this. > It should be easy to port it but it need

Re: [HACKERS] psql password passing problem

2009-08-14 Thread Serge Fonville
Hi, > I'd like to inform you about the issue of using psql in a dos batch file on > windows vista. > > On linux all is very simple, you can easily write in your script > > psql -d mydb -U myuser -f myqry.sql < passw.txt > > On windows however, psql does not seem to work like this, nor does > > t

[HACKERS] psql password passing problem

2009-08-14 Thread pascal Van Puymbroeck
Hi guys, I'd like to inform you about the issue of using psql in a dos batch file on windows vista. On linux all is very simple, you can easily write in your script psql -d mydb -U myuser -f myqry.sql < passw.txt On windows however, psql does not seem to work like this, nor does type passwd

Re: [HACKERS] pg_hba.conf: samehost and samenet

2009-08-14 Thread Tom Lane
Magnus Hagander writes: > On Fri, Aug 14, 2009 at 00:50, Stef Walter wrote: >> It would be great if, in the cidr-address field of pg_hba.conf, we could >> specify "samehost" and "samenet". > Seems like a reasonable feature - especially the samehost part. ISTM people have traditionally used 127.0

Re: [HACKERS] CommitFest 2009-07: Remaining Patches

2009-08-14 Thread Teodor Sigaev
so I think this is also ready to commit once the doc issues are addressed. Oleg fixed that. -- Teodor Sigaev E-mail: teo...@sigaev.ru WWW: http://www.sigaev.ru/ unaccent-0.7.gz Description: Unix tar archive

Re: [HACKERS] uuid contrib don't compile in OpenSolaris

2009-08-14 Thread Zdenek Kotala
Dne 24.07.09 19:23, Emanuel Calvo Franco napsal(a): Hi all, I have some issues to compile uuid contrib of 8.4 version. Touching something i see that the gmake don't find uuid.h. (pfexec gmake -d) Touching more, i add uuid.h into the uuid directory and i had a error message: missing separator.

Re: [HACKERS] Custom geometry, why slow?

2009-08-14 Thread Tom Lane
Paul Matthews writes: > The problem is, according to EXPLAIN, it still wants to do a sequential > scan and not use the index. Any pointers as to why? Can you force it with enable_seqscan = off? If so, then positionsel isn't estimating a small enough number of matches to make an indexscan look us

Re: [HACKERS] CommitFest 2009-07: Remaining Patches

2009-08-14 Thread Robert Haas
On Fri, Aug 14, 2009 at 3:51 AM, Michael Meskes wrote: > On Thu, Aug 13, 2009 at 11:27:54PM -0400, Robert Haas wrote: >> (2) ECPG dynamic cursor, SQLDA support.  I think we're still waiting >> on Michael Meskes to review this one. > > No. The first part of the patch needs some work and Zoltan is al

Re: [HACKERS] DECLARE doesn't set/reset sqlca after DECLARE cursor

2009-08-14 Thread Michael Meskes
On Fri, Aug 14, 2009 at 01:02:07PM +0200, Boszormenyi Zoltan wrote: > Here are the two test files, with their preprocessed C output. > Indeed, Informix emits a function call for DECLARE CURSOR. > And it seems it's not legal to do this outside of a function. Okay, thanks. I changed several things i

Re: [HACKERS] DECLARE doesn't set/reset sqlca after DECLARE cursor

2009-08-14 Thread Boszormenyi Zoltan
Michael Meskes írta: > On Thu, Aug 13, 2009 at 05:55:53PM +0200, Boszormenyi Zoltan wrote: > >> Okay, so it's a declarative command. But if we're in a function, >> we should still emit a call to ecpg_init, to be able to follow >> > > No, either it is declarative or it is not, but I don't se

Re: [HACKERS] Filtering dictionaries support and unaccent dictionary

2009-08-14 Thread Oleg Bartunov
Thanks, Bruce ! Oleg On Thu, 13 Aug 2009, Bruce Momjian wrote: Peter Eisentraut wrote: On Thursday 13 August 2009 18:07:51 Alvaro Herrera wrote: Oleg Bartunov wrote: Peter, how to write accented characters in sgml ? Is't not allowed to write them as is ? á for ?, etc. You can't use chara

Re: [HACKERS] pg_hba.conf: samehost and samenet

2009-08-14 Thread Magnus Hagander
On Fri, Aug 14, 2009 at 00:50, Stef Walter wrote: > I love using postgresql, and have for a long time. I'm involved with > almost a hundred postgresql installs. But this is the first time I've > gotten into the code. > > Renumbering networks happens often, and will happen more frequently as > IPv4

Re: [HACKERS] DECLARE doesn't set/reset sqlca after DECLARE cursor

2009-08-14 Thread Michael Meskes
On Thu, Aug 13, 2009 at 05:55:53PM +0200, Boszormenyi Zoltan wrote: > Okay, so it's a declarative command. But if we're in a function, > we should still emit a call to ecpg_init, to be able to follow No, either it is declarative or it is not, but I don't see a reason for different behaviour depend

Re: [HACKERS] CommitFest 2009-07: Remaining Patches

2009-08-14 Thread Michael Meskes
On Thu, Aug 13, 2009 at 11:27:54PM -0400, Robert Haas wrote: > (2) ECPG dynamic cursor, SQLDA support. I think we're still waiting > on Michael Meskes to review this one. No. The first part of the patch needs some work and Zoltan is already working on it. Michael -- Michael Meskes Michael at

Re: [HACKERS] FDW-based dblink

2009-08-14 Thread Itagaki Takahiro
Heikki Linnakangas wrote: > In fact, by using 2PC without a recovery system you > can end up with a transaction that's prepared but never committed or > aborted, requiring an admin to remove it manually, which is even worse than > not using 2PC to begin with. Yes, true. But I think "hard-to-use