Magnus Hagander wrote: > > A couple of comments on the patch: Thanks I'll keep these in mind, as things progress and for future patches.
> * In general, don't include configure in the patch. Just configure.in. > Makes it easier to read, and configure is normally built by the > committer anyway. > > * How portable is this? For starters is clearly doesn't do Windows, > which would need to be investigated for similar functionality, but how > many others support getifaddr()? From what I can tell it's not in > POSIX, at least. I'll look further into this, and about compat shims. getifaddrs() is on the BSDs, Linux and Mac OS. > Please add it to the open commitfest > (https://commitfest.postgresql.org/action/commitfest_view/open). This > will cause it to be reviewed during the next commitfest, and then you > just need to be around to answer any questions that reviewers come up > with :-) Cool, I'll do that once we've worked out the kinks here. Is the right way to go about it? Cheers, Stef -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.postgresql.org/mailpref/pgsql-hackers
