On Tue, Jun 30, 2020 at 01:13:39PM +0900, Michael Paquier wrote:
> I looked at the patch, and can confirm that client_wrongperms_tmp.key
> remains around after running 001_ssltests.pl, and client_tmp.key after
> running 002_scram.pl. The way the patch does its cleanup looks fine
> to
that looks worth
debating about is to how much to cap the data inserted at once. This
uses 64kB for all three, with a number of slots chosen based on the
size of each record, similarly to what we do for COPY.
--
Michael
diff --git a/src/include/catalog/heap.h b/src/include/catalog/heap.h
index cb
uivalent query to do this work (I actually just do that in a
bgworker monitoring repslot bloat now in some stuff I maintain
internally), and resend a patch in v14 to give the occasion for this
feature to go through one extra round of review. My 2c.
--
Michael
signature.asc
Description: PGP signature
On Tue, Jun 30, 2020 at 02:32:47PM -0400, Alvaro Herrera wrote:
> On 2020-Jun-30, Michael Paquier wrote:
>> Another question that has popped up when doing this review is what
>> would be the use-case of adding this information at SQL level knowing
>> that logical replic
ly what pglogical does with
its pglogical_xact_commit_timestamp_origin() in
pglogical_functions.c. So adding one function able to return one
tuple with the two fields, without removing the existing
pg_xact_commit_timestamp() makes the most sense, no?
--
Michael
signature.asc
Description: PGP signature
all the other
variables, and what you are suggesting here sounds much better to me,
so I have adjusted all the descriptions this way, and added the ZSTD
part.
--
Michael
signature.asc
Description: PGP signature
ion checks for her patch with SRF functions. Though there
are parts that can be simplified to reduce the differences in check
patterns before doing the overall refactoring, I think that we'd
better keep any discussion related to this topic on the other thread
rather than splitting the
'-D', "$tempdir/sigchld",
+ '-r', '32', '-d', $node->connstr('postgres')
+ ],
I would recommend the use of long options here as a matter to
self-document what this does, and add a comment explaining why
--max-rate is preferable, mainly for fast machines.
--
Michael
signature.asc
Description: PGP signature
g for the second part.
I am aware about the discussions on the parent view for the first
case and its design issues, but it does not change the fact that we'd
better address the second case on HEAD IMO.
Thoughts?
--
Michael
diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/p
On Thu, Feb 17, 2022 at 04:10:01PM +0900, Michael Paquier wrote:
> Asserting that we are in the correct memory context in when calling
> MakeFuncResultTuplestore() sounds rather sensible from here as per the
> magics done in the various json functions. Still, it really feels
> like w
seems better to group everything in a single commit as the same
areas are touched.
--
Michael
signature.asc
Description: PGP signature
xed both functions :)
You are not touching pg_stat_get_subscription_worker() because the
plan is to revert it from HEAD? I have not followed the other
discussion closely.
--
Michael
signature.asc
Description: PGP signature
On Mon, Feb 21, 2022 at 03:11:30PM +0100, Daniel Gustafsson wrote:
>On 21 Feb 2022, at 03:03, Michael Paquier wrote:
>> +is($node->poll_query_until('postgres',
>> + "SELECT pg_terminate_backend(pid) FROM pg_stat_activity WHERE " .
>> + "applica
On Fri, Feb 18, 2022 at 05:38:56PM +0800, Julien Rouhaud wrote:
> On Fri, Feb 18, 2022 at 05:22:36PM +0900, Michael Paquier wrote:
>> So, I have been looking at this problem, and I don't see a problem in
>> doing something like the attached, where we add a "regress&quo
On Mon, Feb 21, 2022 at 05:00:43PM +0530, Amit Kapila wrote:
> On Mon, Feb 21, 2022 at 4:56 PM Michael Paquier wrote:
>> That's the same thing as what I sent upthread, so that's correct to
>> me, except that I have fixed both functions :)
>
> Sorry, I hadn'
ent.
> We don't want to backpatch this to 14 as this is a catalog change and
> won't cause any user-visible issue, is that correct?
Yup, that's a HEAD-only cleanup, I am afraid.
--
Michael
signature.asc
Description: PGP signature
On Mon, Feb 21, 2022 at 04:41:17PM +0900, Michael Paquier wrote:
> So, I got my hands on this area, and found myself applying 07daca5 as
> a first piece of the puzzle. Anyway, after more review today, I have
> bumped into more pieces that could be consolidated, and finished with
> t
case for a given session to be able to report back
only its own authn through SQL?
I could still see a use case for that at a more global level with
beentrys, but it looked like there was not much interest the last time
I dropped this idea.
--
Michael
signature.asc
Description: PGP signature
parse and analyze the output generated by pgbench. Fabien,
don't you have some tools and/or wrappers doing exactly that?
--
Michael
signature.asc
Description: PGP signature
On Thu, Feb 24, 2022 at 08:30:02AM -0300, Ranier Vilela wrote:
> Thanks for the commit Michael.
No problem. For the archives, this is e77216f.
--
Michael
signature.asc
Description: PGP signature
;s not
incorrect either on HEAD, as end-of-recovery checkpoints are the same
things as shutdown checkpoints. And there is an extra argument where
back-patching would become a bit more tricky in an area that's already
a lot sensitive.
--
Michael
signature.asc
Description: PGP signature
log_hint() and one pg_log_detail() with
the log level passed as argument of the macro?
--
Michael
signature.asc
Description: PGP signature
d be worthwhile?
> E.g. certificate DNs.
Yes, src/test/ssl would handle that just fine. Now, this stuff
already looks after authn results with log_connections=on, so that
feels like a duplicate.
--
Michael
signature.asc
Description: PGP signature
teer, so I'm all in favor of you being
> CF.
Greg as CFM would be fine. It's nice to see someone volunteer.
--
Michael
signature.asc
Description: PGP signature
,
+"\"%s\" -D \"%s\" --config_file=\"%s\" -C
restore_command",
+postgres_exec_path, datadir_target, config_file);
+ }
Shouldn't this one use appendShellString() on config_file?
--
Michael
signature.asc
Description: PGP signature
nd such to
a new hbafuncs.c under adt/. Would that make sense?
--
Michael
signature.asc
Description: PGP signature
plit, renaming some of those structures and/or function with an
Hba-like prefix, for consistency.
--
Michael
signature.asc
Description: PGP signature
have to be moved to the next CF anyway. These should just
be moved to the July one rather than stay in the March one.
--
Michael
signature.asc
Description: PGP signature
past, so this does not
strike me as a problem as long as you add the new entry at the end of
the enum, while keeping things ordered on HEAD. In recent memory, I
think that only some of the extensions published by PostgresPro rely
on the enums in this area.
--
Michael
signature.asc
Description: PGP signature
On Sat, Feb 26, 2022 at 09:55:20AM +0100, Gunnar "Nick" Bluth wrote:
> Am 26.02.22 um 06:51 schrieb Michael Paquier:
>> Shouldn't this one use appendShellString() on config_file?
>
> It probably should, yes. I don't fancy this repetitive code myself.
> But t
On Sun, Feb 27, 2022 at 07:55:26PM +0800, Julien Rouhaud wrote:
> Indeed. I doubt it will make any real difference but it doesn't hurt to fix
> it.
>
> Patch looks good to me.
Yes, let's clean up that on HEAD. No objections from here. I'll do
that tomorrow or so.
one, we may visit this again but it would be another proposal.
The patch has been already withdrawn in the CF app.
--
Michael
signature.asc
Description: PGP signature
On Sun, Feb 27, 2022 at 09:08:56PM +0900, Michael Paquier wrote:
> Yes, let's clean up that on HEAD. No objections from here. I'll do
> that tomorrow or so.
And done.
--
Michael
signature.asc
Description: PGP signature
On Thu, Feb 24, 2022 at 08:25:06PM +0900, Michael Paquier wrote:
> This is the remaining piece, as attached, that I have not been able to
> poke much at yet.
So, I have finally poked at this last part of the patch set, and I
found that we can be more aggressive with the refactoring, by
s someone object or suggest better naming in the next few days I will
> take
> care of that.
I don't have an opinion to share about 0002 and 0003 yet, but 0001
seems like a good idea on its own.
--
Michael
signature.asc
Description: PGP signature
information
shown version-aware? I would choose to show the compression part only
for server versions where it is settable.
--
Michael
signature.asc
Description: PGP signature
hould we try to apply this option also in
this case?
--
Michael
signature.asc
Description: PGP signature
t would mean only a couple of lines gained, and the readability
gained is minimal, so I'd be fine to keep the code as-is. I am not
sure about the full patch set yet, but the refactoring of the commands
to use PQExpBuffer is good by itself, so I have extracted this part of
the patch and a
o use it, and its code paths are independent.
The last time I played with this area is the recent error handling
improvement with cryptohashes but MD5 has actually helped here in
detecting the problem as a patched OpenSSL would complain if trying to
use MD5 as hash function when FIPS is enabled.
--
Michael
w to describe that in a good way to
the user, which is why the section of log_connections was reworked a
bit. And we don't have yet any references to what an authenticated
identity is in the docs.
There is no need to update catversion.h in the patch, committers
usually take care of that and that's an area of the code that
conflicts a lot.
--
Michael
signature.asc
Description: PGP signature
check on an instance that has user
mappings meaning that this had better be ">= 0", no? Does this pass
on Windows where pg_regress sets some mappings for SSPI when creating
one or more roles?
--
Michael
signature.asc
Description: PGP signature
in the actual archive.
> This is done in the next commit which does introduce a new method.
That's one thing Robert was arguing about with pg_basebackup, so that
would be consistent, and the option set is backward-compatible as far
as I get it by reading the code.
--
Michael
signature.asc
Description: PGP signature
On Tue, Mar 01, 2022 at 05:19:50PM +0800, Julien Rouhaud wrote:
> On Tue, Mar 01, 2022 at 04:45:48PM +0900, Michael Paquier wrote:
>> Hmm. The diffs of 0001 are really hard to read. Do you know why this
>> is happening? Is that because some code has been moved around?
>
>
On Mon, Feb 28, 2022 at 04:49:41PM +0900, Michael Paquier wrote:
> In order to keep things pluggable at will, MakeFuncResultTuplestore()
> has been changed to access a set of bits32 flags, able to control the
> two options above. With this facility in place, I have been able to
> c
On Wed, Feb 16, 2022 at 01:58:10PM +0900, Michael Paquier wrote:
> I have been looking at how much simplicity this brings, and I have to
> admit that it is tempting to just support the loading of dumps when
> setting up the old instance to upgrade from. We'd still need to do an
>
On Tue, Mar 01, 2022 at 10:03:20PM +, Jacob Champion wrote:
> Added a first draft in v5, alongside the perltidy fixups mentioned by
> Michael.
+The authenticated identity is an immutable identifier for the user
+presented during the connection handshake; the exact format depe
On Wed, Mar 02, 2022 at 07:42:50AM +0530, Amit Kapila wrote:
> This is done as part of commit:
> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=7a85073290856554416353a89799a4c04d09b74b
Thanks for taking care of it!
--
Michael
signature.asc
Description: PGP signature
it has no need for with the usual set of checks related to
SRFs. The logic can be be simplified as of the attached.
Thoughts?
--
Michael
diff --git a/src/include/catalog/pg_proc.dat b/src/include/catalog/pg_proc.dat
index bf88858171..d8e8715ed1 100644
--- a/src/include/catalog/pg_proc.dat
+++ b
On Wed, Mar 02, 2022 at 12:01:17AM -0800, Andres Freund wrote:
> But in a bad way, because EXTRA_REGRESS_OPTS now always wins, even for stuff
> we want to override. Note how test.sh explicitly specifies port, bindir etc
> after the pre-existing EXTRA_REGRESS_OPTS.
Ah, right. Will fix.
-
_BACKUP_V2_COLS);
>> TupleDescInitEntry(tupdesc, (AttrNumber) 1, "lsn",
>> PG_LSNOID, -1, 0);
>
> I think we can use get_call_resuilt_type here.
Yes, I don't mind doing so here.
--
Michael
diff --git a/src/include/catal
nd apply the fix in a
minute using this style.
--
Michael
signature.asc
Description: PGP signature
this code gets removed, rebasing this conflict is just a matter
of removing the existing code again so that's trivial.
--
Michael
signature.asc
Description: PGP signature
ny good to get rid of the flag value.
I'd rather keep this code as-is.
--
Michael
signature.asc
Description: PGP signature
stall}))
>> +|| (!defined($ENV{olddump}) && defined($ENV{oldinstall})))
>
> Odd indentation. Spaces between parens?
Well, perltidy tells me that this is right.
>> +$newnode->init(extra => [ '--wal-segsize', '1', '--allow-group-access&
have their design flaws (backend LDAP, MD5 hashes in old backups), but
those code areas are pretty mature as well, so a simple removal could
hurt the user base of PG quite a lot IMO.
--
Michael
signature.asc
Description: PGP signature
entication data passed down by the leader when
spawning a worker. So, if we were to pass down the authn, we are
going to need a new PARALLEL_KEY_* to serialize and restore the data
passed down via a DSM like any other states as per the business in
parallel.c. Jacob, what do you think?
--
M
#define
for the number of columns originates from da2c1b8, aka 9.0. Its use
inside a function originates from a755ea3 as of 9.1 and then it has
just spread around without any undefs, so it looks like people like
that way of doing things.
--
Michael
signature.asc
Description: PGP signature
s if this code gets extended.
At the end of the day, Port is an interface used for the communication
between the postmaster with the frontends, so I'd like to say that it
is correct to not apply this concept to parallel workers because they
are not designed to contact any frontend
A comment may be in
order to explain the hows and the whys.
--
Michael
signature.asc
Description: PGP signature
create/drop.
A junction point is a directory on WIN32 as far as I recall, but
pgreadlink() is here to ensure that we get the correct path on
a source found as pgwin32_is_junction(), so we can rely on that. This
stuff has led me to the attached.
Thoughts?
--
Michael
diff --git a/src/backend/utils
making the code more complicated for such things in the
past, with reloptions. The footprint on the code is much smaller,
here, still..
0007, for ZLIB, does not make sense once one can choose between LZ4
and ZSTD.
--
Michael
signature.asc
Description: PGP signature
hat wants to improve the guarantees around tablespace
directory structures, but I have not studied this thread much to have
an opinion. And it is Friday.
--
Michael
signature.asc
Description: PGP signature
eful increment of flexibility.
Same impression here, so +1 for supporting a comma-separated list of
values here. This is already handled in parse_comma_separated_list(),
now used for multiple hosts and hostaddrs.
--
Michael
signature.asc
Description: PGP signature
e gain in compression. All of them compressed
more than LZ4, with more CPU used in each case, but the default or a
level value lower than the default gives me the impression that it
won't matter much in terms of compression gains and CPU usage.
> I agree with Michael. Your 1-off test is
On Sat, Mar 05, 2022 at 04:54:18PM +0800, Julien Rouhaud wrote:
> On Thu, Jan 06, 2022 at 05:05:32PM +0800, Julien Rouhaud wrote:
>> Anyway, the only committer that showed some interest in the feature is
>> Michael,
>> and he seemed ok in principle with the "alia
On Fri, Mar 04, 2022 at 10:12:27AM -0600, Justin Pryzby wrote:
> Is this patch targetting pg15 ?
> There's no discussion since June.
>
> Latest at 2021-06-08 21:29:25 by Jeff Davis
This is too long, so let's discard this patch for now.
--
Michael
signature.asc
Description: PGP signature
ply if there are no objections.
--
Michael
signature.asc
Description: PGP signature
On Sat, Mar 05, 2022 at 07:31:53PM +0900, Michael Paquier wrote:
> I got a short look at what was proposed in the patch a couple of
> months ago, and still found the implementation confusing with the way
> aliases are handled, particularly when it came to several layers of
> pl/pgsql
On Wed, Mar 02, 2022 at 03:43:17PM +0900, Michael Paquier wrote:
> This is actually setting up a function in the context of a single call
> where we fill the tuplestore with all its values, so instead I have
> settled down to name that SetSingleFuncCall(), to make a parallel with
>
On Mon, Mar 07, 2022 at 10:31:40AM +0800, Julien Rouhaud wrote:
> I was actually waiting a bit to make sure that Pavel could read the thread,
> since it was the weekend and right now it's 3:30 AM in Czech Republic...
Sorry about that. I have reset the state of the patch.
W, I am a bit disturbed by EnsureTopTransactionIdLogged() and its
design in 0006, where we'd finish by using a XLogFlush() call within
two SQL functions, but I have not really looked at the problem to see
if it is a viable solution or not.
--
Michael
signature.asc
Description: PGP signature
On Fri, Mar 04, 2022 at 03:44:22PM +0900, Michael Paquier wrote:
> The use may be limited to any automated testing and
> allow_in_place_tablespaces is a developer GUC, still it seems to me
> that there is an argument to allow the case rather than tweak any
> tests to hardcode a p
It seems to me that we'd better use readlink()
only for entries in pg_tlbspc/ that are PGFILETYPE_LNK on non-WIN32
and pgwin32_is_junction() on WIN32.
--
Michael
signature.asc
Description: PGP signature
ange (dblink_get_notify()) and I've done so.
This matches my impression, so applied.
--
Michael
signature.asc
Description: PGP signature
ld not read symbolic link "pg_tblspc/16384": Invalid argument
> pg_basebackup: error: tar member has empty name
>
>1 File(s) 0 bytes
> 3 Dir(s) 171,920,613,376 bytes free
That's a lot of free space.
--
Michael
signature.asc
Description: PGP signature
On Mon, Mar 07, 2022 at 10:28:08AM +0800, Julien Rouhaud wrote:
> +1
And done.
--
Michael
signature.asc
Description: PGP signature
On Sat, Mar 05, 2022 at 07:26:39PM +0900, Michael Paquier wrote:
> Repeatability and randomness of data counts, we could have for example
> one case with a set of 5~7 int attributes, a second with text values
> that include random data, up to 10~12 bytes each to count on the tuple
>
re is a trend for one of the two.
--
Michael
signature.asc
Description: PGP signature
ptions with properly quoted data directory */
> appendPQExpBufferStr(postgres_cmd, " --single -F -D ");
> appendShellString(postgres_cmd, datadir_target);
> + if (config_file != NULL)
> + {
> + appendPQExpBufferStr(postgres_cmd, " --co
zstd or lz4 are both
good in their own ways. So done, with the default level used.
--
Michael
signature.asc
Description: PGP signature
ace() returns 0 or a number strictly higher than
0, so wouldn't it be enough to stick some > 0 in your test queries?
Btw, if you want to test 32-bit builds, gcc allows that by passing
down -m32.
> Can the Perl TAP test be a good way?
That does not seem necessary here.
--
Michael
signature.a
you'd
> prefer this differently
Looks the same as v5 for me, that applies the same consistency rules
everywhere in the docs. So applied this one.
--
Michael
signature.asc
Description: PGP signature
On Fri, Mar 11, 2022 at 03:49:00PM -0600, Justin Pryzby wrote:
> While rebasing, I realized this should have bumped XLOG_PAGE_MAGIC.
>
> Also, there's a dangling "and".
Right. I'll address that a bit later today. Thanks!
--
Michael
signature.asc
Description: PGP signature
On Wed, Mar 09, 2022 at 10:50:45AM -0600, Justin Pryzby wrote:
> Rebased over 9e9858389 (Michael may want to look at the tuplestore part?).
Are you referring to the contents of 0003 here that changes the
semantics of pg_ls_dir_files() regarding its setup call?
--
Michael
signature.
directories as far as I
recall.
0006 invokes a behavior change for pg_ls_logdir(), where it makes
sense to me to fail if the directory does not exist, so I am not in
favor of that.
In the whole set, improving the docs as of 0001 makes sense, but the
change is incomplete. Most of 0002 also mak
We are not talking about files that are large either, are we?
Another thing I am a bit annoyed with in this patch is the fact that
the size of the ereport() call is doubled. The LOG currently
generated is already bloated, and this does not arrange things.
--
Michael
signature.asc
Description: PGP signature
1/2ms worth of checkpoint. So, if in most
cases this is going to be very quick, adding it to the logs won't
matter because that's not a performance bottleneck. Perhaps that's
something the patch that works on progress reporting for checkpoint
is able to track?
--
Michael
signature.asc
Description: PGP signature
are built in the backend, so I think that we'd better report either a
relative path from data_directory or an absolute path, but not an
empty string.
In any case, I'd suggest to add a regression test. What I have sent
upthread would be portable enough.
--
Michael
signature.asc
Description: PGP signature
On Mon, Mar 14, 2022 at 01:53:54PM +0900, Michael Paquier wrote:
> +select * from pg_ls_logicalmapdir() limit 0;
> +select * from pg_ls_logicalsnapdir() limit 0;
> +select * from pg_ls_replslotdir('') limit 0;
> +select * from pg_ls_tmpdir() limit 0;
> +select * fr
files moved around. If we are
talking about 100~200 files up to 10~20kB each for snapshot and
mapping files, the information has less value, worth only a portion of
one WAL segment.
--
Michael
signature.asc
Description: PGP signature
t access issues with the data directory lock file
while reading values from the control file. And that's not mandatory
to be able to get those estimations without having to allocate a large
chunk of memory, which was the primary goal discussed upthread as far
as I recall. So I would leave that as an item to potentially tackle
in future versions.
--
Michael
signature.asc
Description: PGP signature
ctory contents of replication
> slots
This main argument behind this one is monitoring, as the execution to
those functions can be granted at a granular level depending on the
roles doing the disk space lookups.
--
Michael
signature.asc
Description: PGP signature
w, in case it's useful to handle them together.
It is useful to group that together. I have gathered everything that
looked like a typo or a grammar mistake, and applied the fixes.
Thanks!
--
Michael
signature.asc
Description: PGP signature
o an entirely different discussion,
presenting patches that touch code paths unrelated to what was first
stated. Shouldn't you create a new thread with a proper $subject to
attract a more correct audience?
--
Michael
signature.asc
Description: PGP signature
On Tue, Mar 15, 2022 at 03:55:56PM +1300, Thomas Munro wrote:
> On Tue, Mar 15, 2022 at 2:50 PM Michael Paquier wrote:
>> On Tue, Mar 15, 2022 at 02:33:17PM +1300, Thomas Munro wrote:
>> > As for the complaint about pg_tablespace_location() failing, would it
>> > b
s taking raw pages in input.
--
Michael
From 588ffddf2bd2c0d1e6168a2e7093c2488caec94b Mon Sep 17 00:00:00 2001
From: Michael Paquier
Date: Tue, 15 Mar 2022 17:59:04 +0900
Subject: [PATCH] Fixes for pageinspect with page sizes
---
contrib/pageinspect/brinfuncs.c| 36 ++--
there.
I hope v16-0001 and v16-0002 are small enough (I didn't do the above)
that they can just be attached normally?
Michael
--
Michael Banck
Team Lead PostgreSQL
Project Manager
Tel.: +49 2166 9901-171
Mail: michael.ba...@credativ.de
credativ GmbH, HRB Mönchengladbach 12080
USt-ID-N
On Tue, Mar 15, 2022 at 06:56:46AM -0500, Justin Pryzby wrote:
> On Tue, Mar 15, 2022 at 06:32:44PM +0900, Michael Paquier wrote:
>> +-- Suppress the DETAIL message, to allow the tests to work across various
>> +-- default page sizes.
>
> I think you mean "various
possible to rely just on pgwin32_is_junction() to check if readlink()
should be called or not.
This leads me to the revised version attached. What do you think?
--
Michael
diff --git a/src/backend/utils/adt/misc.c b/src/backend/utils/adt/misc.c
index 4568749d23..89690be2ed 100644
--- a/src/backend/u
> tab-completion and be documented.
I think that we should have some regression tests about those command
flavors. How about adding a couple of queries to create_am.sql for
SET ACCESS METHOD and to tablespace.sql for SET TABLESPACE?
--
Michael
signature.asc
Description: PGP signature
1 - 100 of 11789 matches
Mail list logo
