Re: [HACKERS] Vacuum: allow usage of more than 1GB of work mem

2018-01-06 Thread Stephen Frost
Greetings, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, Dec 4, 2017 at 2:38 PM, Claudio Freire wrote: > > They did apply at the time, but I think major work on vacuum was > > pushed since then, and also I was traveling so out of reach. > > > > It may take some time to rebase the

Re: [HACKERS] Cached plans and statement generalization

2018-01-06 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > On 30.11.2017 04:59, Michael Paquier wrote: > >On Wed, Sep 13, 2017 at 2:11 AM, Konstantin Knizhnik > > wrote: > >>One more patch passing all regression tests with autoprepare_threshold=1. > >>I still do not think that it should

Re: [HACKERS] Surjective functional indexes

2018-01-06 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > On 15.12.2017 01:21, Michael Paquier wrote: > >On Fri, Dec 15, 2017 at 6:15 AM, Alvaro Herrera > >wrote: > >>Konstantin Knizhnik wrote: > >>>If you still thing that additional 16 bytes per relation in statistic is > >>>too >

Re: [HACKERS] Secondary index access optimizations

2018-01-06 Thread Stephen Frost
Greetings, * Konstantin Knizhnik (k.knizh...@postgrespro.ru) wrote: > On 04.12.2017 19:44, Alvaro Herrera wrote: > >Konstantin Knizhnik wrote: > >> > >>On 30.11.2017 05:16, Michael Paquier wrote: > >>>On Mon, Nov 6, 2017 at 10:13 PM, Konstantin Knizhnik > >>> wrote: > Concerning broken partiti

Re: [HACKERS] [PATCH] Overestimated filter cost and its mitigation

2018-01-06 Thread Stephen Frost
Greetings, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Nov 9, 2017 at 12:33 PM, Ashutosh Bapat > wrote: > > Looking at order_qual_clauses(), we can say that a set of quals q1 > > qn are ordered the same irrespective of the set of clauses they > > are subset of. E.g. if {q1

Re: [HACKERS] plpgsql - additional extra checks

2018-01-06 Thread Stephen Frost
Greetings Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > 2017-11-30 3:44 GMT+01:00 Michael Paquier : > > At least documentation needs patching, or this is going to generate > > warnings on HEAD at compilation. I am moving this to next CF for lack > > of reviews, and the status is waitin

Re: [HACKERS] GUC for cleanup indexes threshold.

2018-01-06 Thread Stephen Frost
Greetings Peter, * Peter Geoghegan (p...@bowt.ie) wrote: > On Sat, Jan 6, 2018 at 2:20 PM, Stephen Frost wrote: > >> > IIRC the patches that makes the cleanup scan skip has a problem > >> > pointed by Peter[1], that is that we stash an XID when a btree page is >

Re: [HACKERS] Refactoring identifier checks to consistently use strcmp

2018-01-06 Thread Stephen Frost
Greetings Michael, Daniel, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Dec 1, 2017 at 4:14 AM, Robert Haas wrote: > > I think the changes in DefineView and ATExecSetRelOptions is wrong, > > because transformRelOptions() is still using pg_strcasecmp. With the > > patch: >

Re: PATCH: Configurable file mode mask

2018-01-10 Thread Stephen Frost
David, * David Steele (da...@pgmasters.net) wrote: > On 1/8/18 8:58 PM, Peter Eisentraut wrote: > > On 1/3/18 08:11, Robert Haas wrote: > >> On Tue, Jan 2, 2018 at 11:43 AM, David Steele wrote: > > I think MakeDirectory() is a good wrapper, but isn't > MakeDirectoryPerm() sort of silly?

Re: [HACKERS] Early locking option to parallel backup

2018-01-11 Thread Stephen Frost
Lucas, Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Nov 6, 2017 at 4:43 AM, Tom Lane wrote: > > I wonder if we couldn't somehow repurpose the work that was done for > > parallel workers' locks. Lots of security-type issues to be handled > > if we're to open that up to clie

Re: [HACKERS] Restrict concurrent update/delete with UPDATE of partition key

2018-01-11 Thread Stephen Frost
Amul, * amul sul (sula...@gmail.com) wrote: > Agree, updated in the attached patch. Patch 0001 also includes your > previous review comment[1] and typo correction suggested by Alvaro[2]. Looks like this needs to be rebased (though the failures aren't too bad, from what I'm seeing), so going to m

Re: IndexTupleDSize macro seems redundant

2018-01-11 Thread Stephen Frost
Robert, all, * Robert Haas (robertmh...@gmail.com) wrote: > On Tue, Nov 21, 2017 at 9:26 AM, Amit Kapila wrote: > > +1. I was also once confused with these macros. I think this is a > > good cleanup. On a quick look, I don't see any problem with your > > changes. > > One difference between th

Re: IndexTupleDSize macro seems redundant

2018-01-11 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'll leave the patch status in 'Needs review' since there's more > > changes, but hopefully someone can take a look and we can move this > > along, seems like a pretty small and reaso

Re: IndexTupleDSize macro seems redundant

2018-01-11 Thread Stephen Frost
Greetings Tom, Robert, Ildar, all, * Stephen Frost (sfr...@snowman.net) wrote: > That said, since it's not aligned, regardless of the what craziness the > compiler might try to pull, we probably shouldn't go casting it > to something that later hackers might think will be align

Re: [HACKERS] Support to COMMENT ON DATABASE CURRENT_DATABASE

2018-01-11 Thread Stephen Frost
Greetings Jing, * Jing Wang (jingwang...@gmail.com) wrote: > I have rebased the patch on the latest version. Thanks! Looks like there's still more work to be done here, and unfortunately this ended up on a new thread somehow from the prior one. I've added this newer thread to the CF app too. >

Re: Add default role 'pg_access_server_files'

2018-01-11 Thread Stephen Frost
Thomas, * Thomas Munro (thomas.mu...@enterprisedb.com) wrote: > On Mon, Jan 1, 2018 at 8:19 AM, Stephen Frost wrote: > > This patch adds a new default role called 'pg_access_server_files' which > > allows an administrator to GRANT to a non-superuser role the ability

Re: IndexTupleDSize macro seems redundant

2018-01-11 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > Updated (combined) patch attached for review. I went through and looked > > again to make sure there weren't any cases of making an unaligned > > pointer to a struct and didn't see an

Re: [PATCH] using arc4random for strong randomness matters.

2018-01-11 Thread Stephen Frost
David, all, * David CARLIER (devne...@gmail.com) wrote: > > IIUC, what this code actually does is reseed itself from /dev/urandom > > every so often and work from a PRNG in between. That's not a layer that > > we need, because the code on top is already designed to cope with the > > foibles of /d

Re: [HACKERS] Crash on promotion when recovery.conf is renamed

2018-01-11 Thread Stephen Frost
Magnus, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, Oct 2, 2017 at 3:29 PM, Michael Paquier > wrote: > > On Mon, Oct 2, 2017 at 8:13 AM, Daniel Gustafsson wrote: > >> I’ve moved this to the next CF, but since this no longer applies cleanly > >> I’ve > >> reset it to Waiting f

Re: Possible performance regression with pg_dump of a large number of relations

2018-01-12 Thread Stephen Frost
Greetings Jeff & Luke, * Jeff Janes (jeff.ja...@gmail.com) wrote: > Sorry, that query reflects some munging I did to it. The real part added > to the query is: > > EXISTS (SELECT 1 FROM pg_attribute at LEFT JOIN pg_init_privs pip ON(c.oid > = pip.objoid AND pip.classoid = (SELECT oid FROM pg_cla

Re: proposal: alternative psql commands quit and exit

2018-01-13 Thread Stephen Frost
Vik, all, * Vik Fearing (vik.fear...@2ndquadrant.com) wrote: > On 01/09/2018 02:29 AM, Alvaro Herrera wrote: > > Everaldo Canuto wrote: > >> Change my patch will make psql different from other sql clients I use > >> (sqlplus and mysql). > > > > Well, I don't think we're too hot about copying thei

Re: proposal: alternative psql commands quit and exit

2018-01-13 Thread Stephen Frost
Vik, * Vik Fearing (vik.fear...@2ndquadrant.com) wrote: > On 01/13/2018 10:52 PM, Stephen Frost wrote: > > * Vik Fearing (vik.fear...@2ndquadrant.com) wrote: > >> On 01/09/2018 02:29 AM, Alvaro Herrera wrote: > >>> Everaldo Canuto wrote: > >>>> Change

Re: proposal: alternative psql commands quit and exit

2018-01-13 Thread Stephen Frost
Tom, Vik, all, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Vik Fearing writes: > > In particular, I currently hate how pasting a query with tabs screws > > everything up with unhelpful completions. I don't want to add to that > > with the column example Tom exposed in [1] and especially with the >

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-01-14 Thread Stephen Frost
Greetings Lætitia, Amit, * Lætitia Avrot (laetitia.av...@gmail.com) wrote: > Thanks Stephen for the suggestion. I wan't thinking globally enough. I was > planning to look at it today but Amit was faster. So thanks Amit too! This seems to have gotten lost in the shuffle, but Amit's patch still app

Re: [HACKERS] Useless code in ExecInitModifyTable

2018-01-14 Thread Stephen Frost
Fujita-san, Amit, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > On 2017/06/21 16:59, Etsuro Fujita wrote: > > Commit d3cc37f1d801a6b5cad9bf179274a8d767f1ee50 added this to > > ExecInitModifyTable: > > > > + /* The root table RT index is at the head of the partitioned_rels list > > */

Re: [HACKERS] GSoC 2017: weekly progress reports (week 4) and patch for hash index

2018-01-14 Thread Stephen Frost
Greeting Shubham, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Mon, Sep 25, 2017 at 10:34 PM, Shubham Barai > wrote: > > I have attached the rebased version of patch here. > > The patch does not apply and there has been no reviews as well. In > consequence, I am moving it to ne

Re: [PATCH] Atomic pgrename on Windows

2018-01-14 Thread Stephen Frost
Greetings Alexander, all, * Alexander Korotkov (a.korot...@postgrespro.ru) wrote: > Attached patch atomic-pgrename-windows-1.patch fixes this problem. It > appears to be possible to atomically replace file on Windows – > ReplaceFile() does that. ReplaceFiles() requires target file to exist, > th

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Jan 15, 2018 at 7:28 AM, Laurenz Albe > wrote: > > Everaldo Canuto wrote: > >> Also I don't see a consensus on this thread and I don't understand how > >> decisions are taken. > > > > It's just difficult to find consensus with many

Re: proposal: alternative psql commands quit and exit

2018-01-15 Thread Stephen Frost
Geoff, all, * Geoff Winkless (pgsqlad...@geoff.dj) wrote: > On 15 January 2018 at 16:10, Robert Haas wrote: > > > > More broadly, I think what is needed here is less C-fu than > > English-fu. If we come up with something good, we can make it print > > that thing. > > Can we not just say "ctrl-D

Re: [HACKERS] [BUGS] Bug in Physical Replication Slots (at least 9.5)?

2018-01-17 Thread Stephen Frost
Michael, Andres, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Oct 27, 2017 at 3:13 AM, Michael Paquier > wrote: > > On Thu, Oct 26, 2017 at 3:05 AM, Kyotaro HORIGUCHI > > wrote: > >> The largest obstacle to do that is that walreceiver is not > >> utterly concerned to record int

Re: [HACKERS] Another oddity in handling of WCO constraints in postgres_fdw

2018-01-17 Thread Stephen Frost
Greetings Etsuro, Robert, all, * Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote: > (2017/11/01 11:16), Robert Haas wrote: > >On Wed, Oct 4, 2017 at 5:58 PM, Ashutosh Bapat > > wrote: > >>The view with WCO is local but the modification which violates WCO is > >>being made on remote server by a

GSoC 2018 Project Ideas & Mentors - Last Call

2018-01-18 Thread Stephen Frost
Greetings! I've gone through and cleaned up our GSoC 2018 Wiki page: https://wiki.postgresql.org/wiki/GSoC_2018 Please review! If you have any last-minute items, please add them! We could use some more mentors! If you would have some time over the summer to help with mentoring a GSoC project

Re: GSoC 2018 Project Ideas & Mentors - Last Call

2018-01-18 Thread Stephen Frost
Greetings, * Atri Sharma (atri.j...@gmail.com) wrote: > I can help with the Sorting project. Great! I've added you as a mentor. Thanks! Stephen signature.asc Description: PGP signature

Re: Add default role 'pg_access_server_files'

2018-01-19 Thread Stephen Frost
Michael, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Thu, Jan 18, 2018 at 02:04:45PM +, Ryan Murphy wrote: > > I had not tried this before with my unpatched build of postgres. (In > > retrospect of course I should have). I expected my superuser to be > > able to perform th

Re: [HACKERS] WIP: Restricting pg_rewind to data/wal dirs

2018-01-22 Thread Stephen Frost
Chris, * Chris Travers (chris.trav...@adjust.com) wrote: > Attached is the patch as submitted for commitfest. This has been stuck in Waiting for Author since before the commitfest started. I'll try to kick-start it but it seems like it's stuck because there's a fundamental disagreement about if

Re: [HACKERS] Lazy hash table for XidInMVCCSnapshot (helps Zipfian a bit)

2018-01-22 Thread Stephen Frost
Greetings, * Sokolov Yura (funny.fal...@postgrespro.ru) wrote: > diff --git a/src/backend/utils/time/snapmgr.c > b/src/backend/utils/time/snapmgr.c > index 08a08c8e8f..7c3fe7563e 100644 > --- a/src/backend/utils/time/snapmgr.c > +++ b/src/backend/utils/time/snapmgr.c > @@ -662,13 +662,16 @@ CopyS

Re: [HACKERS] Proposal: generic WAL compression

2018-01-22 Thread Stephen Frost
Oleg, I'm not really sure why this is still in Needs Review as a review was posted and I don't see any follow-up. I've changed this to be Waiting for Author. * Antonin Houska (a...@cybertec.at) wrote: > Oleg Ivanov wrote: > > > In order to overcome that issue, I would like to propose the patch

Re: [HACKERS] PoC plpgsql - possibility to force custom or generic plan

2018-01-22 Thread Stephen Frost
Pavel, * Pavel Stehule (pavel.steh...@gmail.com) wrote: > here is a GUC based patch for plancache controlling. Looks so this code is > working. This really could use a new thread, imv. This thread is a year old and about a completely different feature than what you've implemented here. > It is

Re: [HACKERS] pg_serial early wraparound

2018-01-22 Thread Stephen Frost
Greetings, * Thomas Munro (thomas.mu...@enterprisedb.com) wrote: > On Wed, Jun 28, 2017 at 1:11 PM, Thomas Munro > wrote: > > On Sat, Mar 25, 2017 at 7:27 AM, Thomas Munro > > wrote: > >> On Sat, Mar 25, 2017 at 3:11 AM, Anastasia Lubennikova > >> wrote: > >>> You claim that SLRUs now support f

Re: [HACKERS] Subscription code improvements

2018-01-22 Thread Stephen Frost
Greetings, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Fri, Aug 18, 2017 at 2:09 PM, Masahiko Sawada > wrote: > > On Thu, Aug 17, 2017 at 8:17 PM, Masahiko Sawada > > wrote: > >> On Thu, Aug 17, 2017 at 9:10 AM, Peter Eisentraut > >> wrote: > >>> On 8/8/17 05:58, Masahiko Sawada

Re: [HACKERS] make async slave to wait for lsn to be replayed

2018-01-22 Thread Stephen Frost
Greetings Ivan, * Ivan Kartyshov (i.kartys...@postgrespro.ru) wrote: > Ants Aasma писал 2017-10-26 17:29: > >On Mon, Oct 23, 2017 at 12:29 PM, Ivan Kartyshov > > wrote: > >>Ants Aasma писал 2017-09-26 13:00: > >>> > >>>Exposing this interface as WAITLSN will encode that visibility order > >>>match

Re: [HACKERS] INSERT .. ON CONFLICT DO SELECT [FOR ..]

2018-01-22 Thread Stephen Frost
Greetings, * Marko Tiikkaja (ma...@joh.to) wrote: > On Thu, Nov 30, 2017 at 6:39 AM, Peter Geoghegan wrote: > > On Wed, Nov 29, 2017 at 8:34 PM, Michael Paquier > > wrote: > > > The patch does not currently apply. I am noticing as well that Peter > > > Geoghegan has registered himself as a revie

Re: [HACKERS] [PATCH] Call RelationDropStorage() for broader range of object drops.

2018-01-22 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > Unless somebody can prove convincingly that this argument is wrong and > that there are no other possible problems either, and memorialize that > argument in the form of a detailed comment, I think we should reject > this patch. > http://

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-22 Thread Stephen Frost
ready for commiter". > > On a very fast read this patch looks OK to me, but I'm a bit concerned > about whether we have consensus for it. By my count the vote is 6-3 > in favor of proceeding. > > +1: Robins Tharakan, Stephen Frost, David Fetter, Fabrizio Mello, > Mich

Re: [HACKERS] GSOC'17 project introduction: Parallel COPY execution with errors handling

2018-01-22 Thread Stephen Frost
Alexey, * Alexey Kondratov (kondratov.alek...@gmail.com) wrote: > On Fri, Dec 1, 2017 at 1:58 AM, Alvaro Herrera > wrote: > > On a *very* quick look, please use an enum to return from NextCopyFrom > > rather than 'int'. The chunks that change bool to int are very > > odd-looking. This would mo

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2018-01-22 Thread Stephen Frost
Greetings! * chenhj (chjis...@163.com) wrote: > Rebased and removed the whitespace. Thanks for working on this, I agree that it seems like a pretty cool optimization for pg_rewind. I've only read through the thread to try and understand what's going on and the first thing that comes to mind is

Re: [HACKERS] Small improvement to compactify_tuples

2018-01-22 Thread Stephen Frost
Greetings, * Юрий Соколов (funny.fal...@gmail.com) wrote: > On Wed, Nov 29, 2017 at 8:00 AM, Peter Geoghegan wrote: > > On Tue, Nov 28, 2017 at 2:41 PM, Andres Freund wrote: > >> Maybe it's a stupid question. But would we still want to have this after > >> the change? These should be just specia

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-22 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > > On Monday, January 22, 2018, Stephen Frost wrote: > >> In the end, I feel like this patch has actually been through the ringer > >> and back because it was brought up in the context of solving a problem > >> that

Re: using index or check in ALTER TABLE SET NOT NULL

2018-01-23 Thread Stephen Frost
Greetings Sergei, * Sergei Kornilov (s...@zsrv.org) wrote: > I update patch and also rebase to current head. I hope now it is better > aligned with project style Thanks for updating it and continuing to work on it. I haven't done a full review but there were a few things below that I thought co

Re: [HACKERS] PoC: full merge join on comparison clause

2018-01-23 Thread Stephen Frost
Greetings Alexander, * Alexander Kuzmenkov (a.kuzmen...@postgrespro.ru) wrote: > Here is the patch rebased to a852cfe9. Thanks for updating it. This would definitely be nice to have. Ashutosh, thanks for your previous review, would you have a chance to look at it again? Would be great to at lea

Re: documentation is now XML

2018-01-24 Thread Stephen Frost
David, Alvaro, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > David Fetter wrote: > > > Speaking of legacy things, do we want to see about deprecating LaTeX > > output for tables in psql? I haven't seen such a thing in production, > > but maybe I'm missing something important. > > I've use

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > I wrote: > > I went looking and realized that actually what we're interested in here > > is the plpgsql extension, not the plpgsql language ... and in fact the > > behavior I was thinking of is already there, except for some reason it's > > only applie

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2018-01-24 Thread Stephen Frost
Greetings, * chenhj (chjis...@163.com) wrote: > > At 2018-01-23 09:56:48, "Stephen Frost" wrote: > >I've only read through the thread to try and understand what's going on > >and the first thing that comes to mind is that you're changing > &g

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> In further testing of that, I noticed that it made the behavior of our > >> other bugaboo, the public schema, rather inconsistent. With this > &

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > I'm afraid we may still get some push-back from existing users of > > --clean since, with the change you're proposing, we wouldn't be cleaning > > up anything that's been d

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> No, if you have a nondefault ACL, that will still get applied. This > >> arrangement would drop comment changes, but I can't get excited about &g

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-24 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> Fair point, but doesn't it apply equally to non-default ACLs on any > >> other system objects? If you tweaked the permissions on say pg_ls_dir(),

Re: Possible performance regression with pg_dump of a large number of relations

2018-01-24 Thread Stephen Frost
Hi there! * Luke Cowell (lcow...@gmail.com) wrote: > Hi Stephen, thank you for putting this together. Yeah, it needs more work, which I figured out after actually hacking together a patch for it and I've just not gotten back to it yet. > > If folks get a chance to take a look at the query and/or

Re: [HACKERS] [PATCH]make pg_rewind to not copy useless WAL files

2018-01-25 Thread Stephen Frost
Michael, all, * Michael Paquier (michael.paqu...@gmail.com) wrote: > On Wed, Jan 24, 2018 at 12:43:51PM -0500, Stephen Frost wrote: > > * chenhj (chjis...@163.com) wrote: > >> At 2018-01-23 09:56:48, "Stephen Frost" wrote: > >>> I've only read th

Re: [HACKERS] Add support for tuple routing to foreign partitions

2018-01-25 Thread Stephen Frost
Etsuro, * Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote: > (2017/12/18 23:25), Alvaro Herrera wrote: > >InitResultRelInfo becomes unintelligible after this patch -- it was > >straightforward but adding partition_root makes things shaky. Please > >add a proper comment indicating what each argu

Re: Possible performance regression with pg_dump of a large number of relations

2018-01-25 Thread Stephen Frost
Luke, * Luke Cowell (lcow...@gmail.com) wrote: > > On Jan 24, 2018, at 2:56 PM, Stephen Frost wrote: > >>> ERROR: relation "pg_init_privs" does not exist > >>> LINE 139: LEFT JOIN pg_init_privs pip > > > > I certainly hope that works o

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-25 Thread Stephen Frost
Alvaro, Tom, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > Tom Lane wrote: > > > The changes in t/002_pg_dump.pl largely failed to apply, which is > > partially due to the age of the patch but IMO speaks more to the > > unmaintainability of that TAP test. It still didn't run after I'd > >

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-25 Thread Stephen Frost
Alvaro, * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > Stephen Frost wrote: > > Alvaro, Tom, > > > > * Alvaro Herrera (alvhe...@alvh.no-ip.org) wrote: > > > > Crazy idea: maybe a large fraction of that test could be replaced with > > > comparisons

Re: Boolean partitions syntax

2018-01-25 Thread Stephen Frost
Greetings Amit, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > On 2017/12/20 6:46, Mark Dilger wrote: > >> On Dec 12, 2017, at 10:32 PM, Amit Langote > >> wrote: > >> Added to CF: https://commitfest.postgresql.org/16/1410/ > > > > This compiles and passes the regression tests for me. >

Re: [HACKERS] REINDEX CONCURRENTLY 2.0

2018-01-25 Thread Stephen Frost
Craig, Michael, all, * Craig Ringer (cr...@2ndquadrant.com) wrote: > On 21 December 2017 at 11:31, Michael Paquier > wrote: > > > On Thu, Dec 21, 2017 at 11:46 AM, Alvaro Herrera > > wrote: > > > Michael Paquier wrote: > > >> Well, the idea is really to get rid of that as there are already > >

Re: Boolean partitions syntax

2018-01-26 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Jan 25, 2018 at 8:44 PM, Amit Langote > wrote: > > Attached updated patch. > > I wonder if this patch is just parser bloat without any real benefit. > It can't be very common to want to partition on a Boolean column, and > if you do,

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-26 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Thu, Jan 25, 2018 at 4:52 PM, Alvaro Herrera > wrote: > > My proposal is that instead of looking at three hundred lines, you'd > > look for 50 lines of `pg_restore -l` output -- is element XYZ in there > > or not. Quite a bit simpler for

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-26 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Jan 26, 2018 at 11:09 AM, Stephen Frost wrote: > > * Robert Haas (robertmh...@gmail.com) wrote: > >> On Thu, Jan 25, 2018 at 4:52 PM, Alvaro Herrera > >> wrote: > >> > My proposal is that in

Re: [HACKERS] Patch: Add --no-comments to skip COMMENTs with pg_dump

2018-01-26 Thread Stephen Frost
Robert, * Robert Haas (robertmh...@gmail.com) wrote: > On Fri, Jan 26, 2018 at 11:56 AM, Stephen Frost wrote: > >> I think you've chosen a terrible design and ought to throw the whole > >> thing away and start over. > > > > I'll all for throwing away

Re: [HACKERS] make async slave to wait for lsn to be replayed

2018-02-02 Thread Stephen Frost
Greetings, * Simon Riggs (si...@2ndquadrant.com) wrote: > On 22 January 2018 at 23:21, Stephen Frost wrote: > > >> It sounds reasonable. I can offer the following version. > >> > >> WAIT LSN lsn_number; > >> WAIT LSN lsn_number TIMEOUT delay; >

Re: [HACKERS] Adding column_constraint description in ALTER TABLE synopsis

2018-02-02 Thread Stephen Frost
Greetings, * Amit Langote (langote_amit...@lab.ntt.co.jp) wrote: > On 2018/01/23 8:57, Thomas Munro wrote: > > On Tue, Jan 23, 2018 at 12:41 PM, Thomas Munro > > wrote: > >> On Mon, Jan 15, 2018 at 2:32 PM, Stephen Frost wrote: > >>> If someone else woul

Re: [HACKERS] MERGE SQL Statement for PG11

2018-02-06 Thread Stephen Frost
Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > On Mon, Feb 5, 2018 at 7:56 PM, Robert Haas wrote: > > I don't think you get to make a unilateral decision to exclude > > features that work everywhere else from the scope of this patch. If > > there is agreement that those features can be lef

Re: [HACKERS] Proposal: generic WAL compression

2018-02-07 Thread Stephen Frost
Greetings, * Markus Nullmeier (dq...@uni-heidelberg.de) wrote: > On 07/02/18 18:31, David Steele wrote: > > > This proposal is still in need of review and hasn't really gotten it in > > the last few CFs. > > Agreed. > > > Since the feature does not seem like a good fit for the last CF of PG11 >

PDF Builds on borka (Debian/stretch) broken - 9.6

2018-02-07 Thread Stephen Frost
Greetings, While trying to do the PDF builds on borka for 9.6 for tomorrow's release, I'm getting: openjade -D . -D . -c /usr/share/sgml/docbook/stylesheet/dsssl/modular/catalog -d ./stylesheet.dsl -t tex -V tex-backend -i output-print -i include-index -V texpdf-output -V '%paper-type%'=A4 -o

Re: PDF Builds on borka (Debian/stretch) broken - 9.6

2018-02-07 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > While trying to do the PDF builds on borka for 9.6 for tomorrow's > > release, I'm getting: > > > openjade -D . -D . -c > > /usr/share/sgml/docbook/stylesheet/dsssl/modular/catalo

Re: PDF Builds on borka (Debian/stretch) broken - 9.6

2018-02-07 Thread Stephen Frost
Tom, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > While trying to do the PDF builds on borka for 9.6 for tomorrow's > > release, I'm getting: > > > openjade -D . -D . -c > > /usr/share/sgml/docbook/stylesheet/dsssl/modular/catalo

Re: PDF Builds on borka (Debian/stretch) broken - 9.6

2018-02-08 Thread Stephen Frost
Peter, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2/7/18 17:21, Stephen Frost wrote: > > Looks like Nov 15 (which I believe is when the stretch upgrade was done) > > it was upgraded: > > > > 2017-11-15 17:38:55 upgrade openjade:amd64 1.4de

Re: PostgreSQL 2018-02-08 Security Update Release

2018-02-08 Thread Stephen Frost
Greetings Tatsuo, * Tatsuo Ishii (is...@sraoss.co.jp) wrote: > In > https://www.postgresql.org/about/news/1829/ > > URL links to both CVE-2018-1052 and CVE-2018-1053 give me a 404 error. > I am the only one who are getting the error? Unfortunately, we don't have any control over when RedHat upda

Re: [HACKERS] FOSDEM PGDay_2018_Developer_Meeting notes

2018-02-09 Thread Stephen Frost
* Michael Paquier (mich...@paquier.xyz) wrote: > On Fri, Feb 09, 2018 at 08:55:26AM +, Pantelis Theodosiou wrote: > > On Tue, Feb 6, 2018 at 10:07 AM, Stephen Frost wrote: > >> SIDE TOPIC: > >> > >> Release date for PostgreSQL 13 agreed: Friday 13th Septemb

Re: [HACKERS] MERGE SQL Statement for PG11

2018-02-14 Thread Stephen Frost
Greetings Pavan, * Pavan Deolasee (pavan.deola...@gmail.com) wrote: > On Tue, Feb 6, 2018 at 3:37 PM, Stephen Frost wrote: > > Coming out of that, my understanding is that Simon is planning to have a > > patch which implements RLS and partitioning (though the query plans for >

Re: Google Summer of Code 2018

2018-02-14 Thread Stephen Frost
Greetings, * Ankit Raj (rajankitn...@gmail.com) wrote: > I want to participate in GSOC2018 in the PostgreSQl organization, so can > you help me out as to what I have to preapre? The best thing to do is to review the Student Guide, available here: https://g.co/gsoc/studentguide As discussed ther

Re: Proposal: Global Index

2019-10-31 Thread Stephen Frost
Greetings, * Peter Geoghegan (p...@bowt.ie) wrote: > On Wed, Oct 30, 2019 at 9:23 AM Tom Lane wrote: > > Well, the *effects* of the feature seem desirable, but that doesn't > > mean that we want an implementation that actually has a shared index. > > As soon as you do that, you've thrown away mos

Re: Allow superuser to grant passwordless connection rights on postgres_fdw

2019-11-03 Thread Stephen Frost
Greetings, * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote: > On 11/1/19 12:58 PM, Robert Haas wrote: > > On Thu, Oct 31, 2019 at 4:58 PM Andrew Dunstan > > wrote: > >> This patch allows the superuser to grant passwordless connection rights > >> in postgres_fdw user mappings. > > This is

Re: auxiliary processes in pg_stat_ssl

2019-11-04 Thread Stephen Frost
Greetings, * Robert Haas (robertmh...@gmail.com) wrote: > On Mon, Nov 4, 2019 at 8:26 AM Alvaro Herrera > wrote: > > On 2019-Sep-04, Alvaro Herrera wrote: > > > I just noticed that we list auxiliary processes in pg_stat_ssl: > > [...] > > > But this seems pointless. Should we not hide those? S

Re: v12 and pg_restore -f-

2019-11-04 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Alvaro Herrera writes: > > On 2019-Oct-17, Tom Lane wrote: > >> Stephen Frost writes: > >>> Tom, I take it your suggestion is to have '-f -' be accepted to mean > >>> 'goes to stdou

Re: cost based vacuum (parallel)

2019-11-04 Thread Stephen Frost
Greetings, * Jeff Janes (jeff.ja...@gmail.com) wrote: > On Mon, Nov 4, 2019 at 1:54 AM Amit Kapila wrote: > > For parallel vacuum [1], we were discussing what is the best way to > > divide the cost among parallel workers but we didn't get many inputs > > apart from people who are very actively in

Re: Missed check for too-many-children in bgworker spawning

2019-11-04 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-10-09 12:29:18 -0400, Robert Haas wrote: > > I would say rather that if fork() is failing on your system, you have > > a not very stable system. > > I don't think that's really true, fwiw. It's often a good idea to turn > on strict

Re: cost based vacuum (parallel)

2019-11-04 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-11-04 14:06:19 -0500, Stephen Frost wrote: > > * Jeff Janes (jeff.ja...@gmail.com) wrote: > > > On Mon, Nov 4, 2019 at 1:54 AM Amit Kapila > > > wrote: > > > > For parallel vacuum [1], we

Re: cost based vacuum (parallel)

2019-11-04 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > On 2019-11-04 14:33:41 -0500, Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > On 2019-11-04 14:06:19 -0500, Stephen Frost wrote: > > > > With parallelization across indexes, yo

Re: v12 and pg_restore -f-

2019-11-05 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-11-04 15:53, Alvaro Herrera wrote: > >>No, I'm not proposing a full revert. But there's certainly room to > >>consider reverting the part that says you*must* write "-f -" to get > >>output to stdout. > >I don't thi

Re: v12 and pg_restore -f-

2019-11-05 Thread Stephen Frost
Greetings, * Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote: > On 2019-11-05 15:11, Stephen Frost wrote: > >We don't guarantee this kind of compatibility between major versions. > > We do generally ensure compatibility of client side tools across major > vers

Re: v12 and pg_restore -f-

2019-11-05 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > In this case, not in the least: we would simply be imposing the sort > of *orderly* feature introduction that I thought was the plan from > the very beginning [1]. That is, first make "-f -" available, and > make it required only in some later v

Re: v12 and pg_restore -f-

2019-11-05 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > > * Tom Lane (t...@sss.pgh.pa.us) wrote: > >> In this case, not in the least: we would simply be imposing the sort > >> of *orderly* feature introduction that I thought was the plan from

Re: cost based vacuum (parallel)

2019-11-05 Thread Stephen Frost
Greetings, * Amit Kapila (amit.kapil...@gmail.com) wrote: > On Tue, Nov 5, 2019 at 1:42 AM Stephen Frost wrote: > > * Andres Freund (and...@anarazel.de) wrote: > > > That's quite doable independent of parallelism, as we don't have tables > > > or indexes spa

Re: Should we make scary sounding, but actually routine, errors less scary?

2019-11-06 Thread Stephen Frost
Greetings, * Andres Freund (and...@anarazel.de) wrote: > There's a few errors that we issue that are, often, much less bad than > they sound. The most common cases I immediately can recall are: Agreed. > 1) Mentioning crash, once for each backend, when shutting down > immediately. Currently the

Re: Removing pg_pltemplate and creating "trustable" extensions

2019-11-07 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Peter Eisentraut writes: > > On 2019-08-21 21:29, Tom Lane wrote: > >> Patch 0001 below addresses this problem by inventing a concept of > >> "trustable" (not necessarily trusted) extensions. An extension that > >> would normally require superu

Re: Removing pg_pltemplate and creating "trustable" extensions

2019-11-07 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Stephen Frost writes: > >> Peter Eisentraut writes: > >>> Using GUCs to control some of this creates yet another place where > >>> permission information is kept, and with it questions about how to get >

Re: Allow superuser to grant passwordless connection rights on postgres_fdw

2019-12-03 Thread Stephen Frost
Greetings, * Craig Ringer (cr...@2ndquadrant.com) wrote: > On Mon, 4 Nov 2019 at 12:20, Stephen Frost wrote: > > I've long felt that the way to handle this kind of requirement is to > > have a "trusted remote server" kind of option- where the local server > >

Re: [HACKERS] Incomplete startup packet errors

2019-12-03 Thread Stephen Frost
Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: > Jobin Augustine writes: > > However, Checking whether the port is open is resulting in error log like: > > 2019-11-25 14:03:44.414 IST [14475] LOG: invalid length of startup packet > > Yes, This is different from "Incomplete startup packet" dis

Re: Protocol problem with GSSAPI encryption?

2019-12-03 Thread Stephen Frost
Greetings, * Andrew Gierth (and...@tao11.riddles.org.uk) wrote: > > "Peter" == Peter Eisentraut writes: > > >> It seems to me that this is a bug in ProcessStartupPacket, which > >> should accept both GSS or SSL negotiation requests on a connection > >> (in either order). Maybe secure_done

<    2   3   4   5   6   7   8   9   10   11   >