Etsuro, * Etsuro Fujita (fujita.ets...@lab.ntt.co.jp) wrote: > (2017/12/18 23:25), Alvaro Herrera wrote: > >InitResultRelInfo becomes unintelligible after this patch -- it was > >straightforward but adding partition_root makes things shaky. Please > >add a proper comment indicating what each argument is. > > I was thiking that the comment I added to the definition of the > ResultRelInfo struct in execnodes.h would make that function intelligible, > but I agree on that point. Please fined attached a new version of the patch > adding such comments.
I'm afraid a good bit of this patch is now failing to apply. I don't have much else to say except to echo the performance concern that Amit Langote raised about expanding the inheritence tree twice. Thanks! Stephen
signature.asc
Description: PGP signature
