Re: PQHost() undefined behavior if connecting string contains both host and hostaddr types

2018-03-21 Thread Peter Eisentraut
d when the connection is established, it returns the host actually connected to. That seems pretty crazy. It should do only one or the other. Especially since there is, AFAICT, no way to know at run time whether the value it returned just then is one or the other. -- Peter Eisentraut

Re: [HACKERS] pg_upgrade to clusters with a different WAL segment size

2018-03-21 Thread Peter Eisentraut
OG_BLCKSZ; ControlFile.xlog_seg_size = DEFAULT_XLOG_SEG_SIZE; ControlFile.nameDataLen = NAMEDATALEN; ControlFile.indexMaxKeys = INDEX_MAX_KEYS; What do you think? Does your patch aim to do something different? -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Develop

Re: [HACKERS] MERGE SQL Statement for PG11

2018-03-21 Thread Peter Geoghegan
hat general tone is not appropriate for a committed patch. Also, what it describes doesn't seem to have much to do with MVCC rules per say. The only thing that seems to warrant discussion in mvcc.sgml is how MERGE really *isn't* a special case. ISTM that you only really need to mention how the decision to use one particular WHEN action can change repeatedly - every time you walk the UPDATE chain, you start that part from the beginning. The "you might get a duplicate violation" bit can definitely live in merge.sgml, right at the point that ON CONFLICT is mentioned (the Tip box). I don't think that you need too much on this. -- Peter Geoghegan

Re: [PoC PATCH] Parallel dump to /dev/null

2018-03-21 Thread Peter Geoghegan
n that specifically targets a heap relation (not an index), and performs verification fairly quickly, so my heapallindexed patch isn't enough. That wouldn't share much with the existing amcheck verification functions. I hope that someone else can pick that up soon. -- Peter Geoghegan

Re: Jsonb transform for pl/python

2018-03-21 Thread Peter Eisentraut
On 3/12/18 11:26, Nikita Glukhov wrote: > I have reviewed this patch. Attached new 6th version of the patch with > v5-v6 delta-patch. Thanks for the update. I'm working on committing this. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 2

Re: Create shorthand for including all extra tests

2024-01-10 Thread Peter Eisentraut
On 05.09.23 19:26, Nazir Bilal Yavuz wrote: Thanks for the feedback! I updated the patch, 'needs-private-lo' option enables kerberos, ldap, load_balance and ssl extra tests now. As was discussed, I don't think "needs private lo" is the only condition for these tests. At least kerberos and lda

Re: Synchronizing slots from primary to standby

2024-01-10 Thread Peter Smith
y different error: +# 'ERROR: replication slot is active for PID ..' + +$standby1->safe_psql('postgres', 'ALTER SYSTEM SET hot_standby_feedback = off;'); +$standby1->restart; Remove the blank line. ~~~ 28. +is($standby1->safe_psql('postgres', + q{SELECT slot_name FROM pg_replication_slots WHERE slot_name = 'lsub1_slot';}), + 'lsub1_slot', + 'synced slot retained on the new primary'); There should be some comment like: SUGGESTION # Confirm the synced slot 'lsub1_slot' is retained on the new primary ~~~ 29. +# Confirm that data in tab_int replicated on subscriber +is( $subscriber1->safe_psql('postgres', q{SELECT count(*) FROM tab_int;}), + "20", + 'data replicated from the new primary'); /replicated on subscriber/replicated on the subscriber/ == Kind Regards, Peter Smith. Fujitsu Australia

Re: Make attstattarget nullable

2024-01-11 Thread Peter Eisentraut
3 patch gets rid of it anyway. From d937c26d8c471c999aa53c96dce86c68fad71a7a Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Thu, 11 Jan 2024 10:09:02 +0100 Subject: [PATCH v3 1/3] Make attstattarget nullable This changes the pg_attribute field attstattarget into a nullable field in the var

Re: SQL:2011 application time

2024-01-11 Thread Peter Eisentraut
On 31.12.23 09:51, Paul Jungwirth wrote: On Wed, Dec 6, 2023 at 12:59 AM Peter Eisentraut wrote: > > On 02.12.23 19:41, Paul Jungwirth wrote: > > So what do you think of this idea instead?: > > > > We could add a new (optional) support function to GiST that tra

Re: Improve the connection failure error messages

2024-01-11 Thread Peter Smith
connect to the primary server: %s", appname, err))); I think your new %s should be quoted according to the guidelines at [1]. == src/test/regress/expected/subscription.out 3. Apparently, there is no existing regression test case for the ALTER "could not connect" message because

Re: pub/sub - specifying optional parameters without values.

2024-01-11 Thread Peter Smith
2). I've used text almost the same as the boilerplate text added by the previous commit [2] ~ PSA patch v4. == [0] https://www.postgresql.org/docs/devel/protocol-replication.html [1] https://www.postgresql.org/message-id/OS0PR01MB571663BCE8B28597D462FADE946A2%40OS0PR01MB5716.jpnprd01.pro

Re: Make all Perl warnings fatal

2024-01-12 Thread Peter Eisentraut
On 11.01.24 12:29, Bharath Rupireddy wrote: On Sat, Dec 30, 2023 at 12:57 AM Peter Eisentraut wrote: committed With the commit c5385929 converting perl warnings to FATAL, use of psql/safe_psql with timeout parameters [1] fail with the following error: Use of uninitialized value $ret in

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-12 Thread Peter Geoghegan
rune when vacrel-> nindexes == 0. In both cases we know that there won't be any second heap pass, and so in both cases we always call PageGetHeapFreeSpace() in the first heap pass. It's just that it's a bit harder to see that in the lazy_scan_prune case. No? -- Peter Geoghegan

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-12 Thread Peter Geoghegan
n't happen in VACUUM, that doesn't mean that the FSM is up-to-date. In short, we do these things with the free space map because it is a map of free space (which isn't crash safe) -- nothing more. I happen to agree that that general design has a lot of problems, but those seem out of scope here. -- Peter Geoghegan

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-12 Thread Peter Geoghegan
quot;recordfreespace". But lazy_scan_noprune doesn't get passed a pointer to prunestate, so clearly you'll need to detect the same condition some other way. -- Peter Geoghegan

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-12 Thread Peter Geoghegan
On Fri, Jan 12, 2024 at 1:52 PM Melanie Plageman wrote: > On Fri, Jan 12, 2024 at 1:07 PM Peter Geoghegan wrote: > > What is "space_freed"? Isn't that something from your uncommitted patch? > > Yes, I was mixing the two together. An understandable mistake. >

Re: Escape output of pg_amcheck test

2024-01-13 Thread Peter Eisentraut
On 08.01.24 16:06, Peter Eisentraut wrote: On 08.01.24 15:04, Aleksander Alekseev wrote: [...] so I quickly wrote some (wrong) instrumentation to try to test your patch. Yep, it confused me too at first. Since the encoding happens right before exit() call, maybe it's worth changing

Re: Documentation to upgrade logical replication cluster

2024-01-14 Thread Peter Smith
20a. This link to the earlier step renders badly like: On node2, Create any tables that were created in the upgraded node1 between when the subscriptions where disabled in node1 and now, e.g.: ~ 20b Also has typos "when the subscriptions where disabled" (??) ~ 20c. /Create any/create any/ == Kind Regards, Peter Smith. Fujitsu Australia

Re: automating RangeTblEntry node support

2024-01-15 Thread Peter Eisentraut
On 06.12.23 21:02, Peter Eisentraut wrote: I have been looking into what it would take to get rid of the custom_read_write and custom_query_jumble for the RangeTblEntry node type.  This is one of the larger and more complex exceptions left. (Similar considerations would also apply to the

Re: More new SQL/JSON item methods

2024-01-15 Thread Peter Eisentraut
file (which is alphabetical, I suppose). At this point I suspect we'll end up committing this whole feature set together anyway, so we might as well organize it that way. From 81e330a243d85dff7f64adf17815258e2764ea01 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Mon, 15 Jan 2024 14

Re: Make attstattarget nullable

2024-01-15 Thread Peter Eisentraut
quot; pointer-to-struct typedef either. I agree that this naming was problematic. After some introverted bikeshedding, I changed it to FormExtraData_pg_attribute. Obviously, other solutions are possible. I also removed the typedef as you suggested. From 9199be09efcbca1b906b5c41e8524e68b1

Re: Synchronizing slots from primary to standby

2024-01-15 Thread Peter Smith
RY v EPHEMERAL I noticed this ReplicationSlotPersist() from v59-0002 was reverted: - * Convert a slot that's marked as RS_EPHEMERAL to a RS_PERSISTENT slot, - * guaranteeing it will be there after an eventual crash. + * Convert a slot that's marked as RS_EPHEMERAL or RS_TEMPORARY to a + * RS_PERSISTENT slot, guaranteeing it will be there after an eventual crash. AFAIK in v61 you are still calling this function with RS_TEMPORARY which is now contrary to the current function comment if you don't change it to also mention RS_TEMPORARY. == Kind Regards, Peter Smith. Fujitsu Australia

Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan

2024-01-15 Thread Peter Geoghegan
cycles. > > +-- > > +-- Here we don't remember the scan's array keys before processing a page, > > only > > +-- after processing a page (which is implicit, it's just the scan's current > > +-- keys). So when we move the scan backwards we think that the top-level > > scan > > +-- should terminate, when in reality it should jump backwards to the leaf > > page > > +-- that we last visited. > > I notice this adds a complex test case that outputs many rows. Can we > do with less rows if we build the index after data insertion, and with > a lower (non-default) fillfactor? Probably not. It was actually very hard to come up with these test cases, which tickle the implementation in just the right way to demonstrate that the code in places like _bt_steppage() is actually required. It took me a rather long time to just prove that much. Not sure that we really need this. But thought I'd include it for the time being, just so that reviewers could understand those changes. -- Peter Geoghegan

Re: partitioning and identity column

2024-01-16 Thread Peter Eisentraut
On 09.01.24 15:10, Ashutosh Bapat wrote: Here's complete patch-set. Looks good! Committed.

Re: Improve the connection failure error messages

2024-01-16 Thread Peter Smith
;port = -1'; ...but here the subscription did not become DISABLED as I expected it would do on the next connection error iteration. It remains enabled and just continues to loop relaunch/ERROR indefinitely same as before. That looks like it may be a bug. Thoughts? == Kind Regards, Peter Smith. Fujitsu Australia

Re: Synchronizing slots from primary to standby

2024-01-16 Thread Peter Smith
committed). == Kind Regards, Peter Smith. Fujitsu Australia

Re: Synchronizing slots from primary to standby

2024-01-16 Thread Peter Smith
>plugin, &slot->data.plugin) == 0 && remote_dbid == slot->data.database && remote_slot->restart_lsn == slot->data.restart_lsn && remote_slot->catalog_xmin == slot->data.catalog_xmin && remote_slot->two_phase == slot->data.two_phase && remote_slot->failover == slot->data.failover && remote_slot->confirmed_lsn == slot->data.confirmed_flush) return false; == Kind Regards, Peter Smith. Fujitsu Australia

Re: Synchronizing slots from primary to standby

2024-01-16 Thread Peter Smith
On Tue, Jan 16, 2024 at 10:57 PM shveta malik wrote: > ... > v62-006: > Separated the failover-ready validation steps into this separate > doc-patch (which were earlier present in v61-002 and v61-003). Also > addressed some of the doc comments by Peter in [1]. > Thanks Hou-San

Re: generate syscache info automatically

2024-01-17 Thread Peter Eisentraut
nd patch, other than to update it for the code changes made in the first patch. It's still very much WIP/preview at the moment. From f77c381b9df30824e469f72f4e7754d03cb97d78 Mon Sep 17 00:00:00 2001 From: Peter Eisentraut Date: Wed, 17 Jan 2024 12:33:42 +0100 Subject: [PATCH v5 1/2] Generat

Re: More new SQL/JSON item methods

2024-01-17 Thread Peter Eisentraut
On 17.01.24 10:03, Jeevan Chalke wrote: I added unary '+' and '-' support as well and thus thought of having separate rules altogether rather than folding those in. Per SQL standard, the precision and scale arguments are unsigned integers, so unary plus and minus signs are not supported

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-17 Thread Peter Geoghegan
;s such a good idea then why not apply it all the time? That is, why not apply it independently of whether nindexes==0 in the current VACUUM operation? (You know, just like with FAILSAFE_EVERY_PAGES.) -- Peter Geoghegan

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-17 Thread Peter Geoghegan
On Wed, Jan 17, 2024 at 4:25 PM Peter Geoghegan wrote: > I tend to suspect that VACUUM_FSM_EVERY_PAGES is fundamentally the > wrong idea. If it's such a good idea then why not apply it all the > time? That is, why not apply it independently of whether nindexes==0 > in the current

modify first-word capitalisation of some messages

2024-01-17 Thread Peter Smith
Hi. PSA a small patch to adjust the first-word capitalisation of some errmsg/ errdetail/ errhint so they comply with the guidelines. == Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Error-message-capitalisation.patch Description: Binary data

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-17 Thread Peter Geoghegan
On Wed, Jan 17, 2024 at 5:47 PM Melanie Plageman wrote: > > On Wed, Jan 17, 2024 at 4:31 PM Peter Geoghegan wrote: > > > > On Wed, Jan 17, 2024 at 4:25 PM Peter Geoghegan wrote: > > > I tend to suspect that VACUUM_FSM_EVERY_PAGES is fundamentally the > > >

subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-17 Thread Peter Smith
r keeps trying to restart the apply worker and it will keep failing until the connection string is corrected or the subscription is disabled manually. I think this is a bug that needs to be handled in run_apply_worker() when disable_on_error is set. == [1] https://www.postgresql.org/message-id/CAHut%2B

Re: Improve the connection failure error messages

2024-01-17 Thread Peter Smith
worker and it > will keep failing until the connection string is corrected or the > subscription is disabled manually. > > I think this is a bug that needs to be handled in run_apply_worker() > when disable_on_error is set. > IMO, this bug-fix discussion deserves a separate thread. Thoughts? Hi Nisha, Thanks for your analysis -- it is the same as my understanding. As suggested, I have created a new thread for any further discussion related to this 'disable_on_error' topic [1]. == [1] https://www.postgresql.org/message-id/flat/CAHut%2BPuEsekA3e7ThwzWr%2BUs4x%3DLzkF7DSrED1UsZTUqNrhCUQ%40mail.gmail.com Kind Regards, Peter Smith. Fujitsu Australia

Re: Synchronizing slots from primary to standby

2024-01-17 Thread Peter Smith
ncWorker->pid was not yet reset to InvalidPid; e.g. Is the Assert above still OK? == Kind Regards, Peter Smith. Fujitsu Australia

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-17 Thread Peter Smith
ql.org/message-id/flat/CAA4eK1KsaVgkO%3DRbjj0bcXZTpeV1QVm0TGkdxZiH73MHfxf6oQ%40mail.gmail.com#d4a0db154fbeca356a494c50ac877ff1 [2] https://github.com/postgres/postgres/commit/705e20f8550c0e8e47c0b6b20b5f5ffd6ffd9e33 Kind Regards, Peter Smith. Fujitsu Australia

Re: Catalog domain not-null constraints

2024-01-17 Thread Peter Eisentraut
On 17.01.24 13:15, vignesh C wrote: One of the test has failed in CFBot at [1] with: diff -U3 /tmp/cirrus-ci-build/src/test/regress/expected/domain.out /tmp/cirrus-ci-build/src/test/regress/results/domain.out --- /tmp/cirrus-ci-build/src/test/regress/expected/domain.out 2024-01-14 15:40:01.793434

Re: Make all Perl warnings fatal

2024-01-17 Thread Peter Eisentraut
On 16.01.24 12:08, Bharath Rupireddy wrote: On Fri, Jan 12, 2024 at 9:21 PM Bharath Rupireddy wrote: On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut wrote: I would put this code my $core = $ret & 128 ? " (core dumped)" : ""; die "psql exited

Re: add function argument names to regex* functions.

2024-01-18 Thread Peter Eisentraut
On 10.01.24 15:18, jian he wrote: I put the changes into the new patch. Reading back through the discussion, I wasn't quite able to interpret the resolution regarding Oracle compatibility. From the patch, it looks like you chose not to adopt the parameter names from Oracle. Was that your i

Re: Build versionless .so for Android

2024-01-18 Thread Peter Eisentraut
On 14.01.24 12:37, Matthias Kuhn wrote: What I try to do is packaging an app with androiddeployqt which fails with an error: The bundled library lib/libpq.so.5 doesn't end with .so. Android only supports versionless libraries ending with the .so suffix. This error was introduced in response

Re: modify first-word capitalisation of some messages

2024-01-18 Thread Peter Eisentraut
On 17.01.24 23:17, Peter Smith wrote: PSA a small patch to adjust the first-word capitalisation of some errmsg/ errdetail/ errhint so they comply with the guidelines. committed, thanks

Re: speed up a logical replica setup

2024-01-18 Thread Peter Eisentraut
On 11.01.24 23:15, Euler Taveira wrote: A new tool called pg_subscriber can convert a physical replica into a logical replica. It runs on the target server and should be able to connect to the source server (publisher) and the target server (subscriber). Can we have a discussion on the name?

Re: [17] CREATE COLLATION default provider

2024-01-18 Thread Peter Eisentraut
On 15.06.23 06:47, Jeff Davis wrote: Currently, CREATE COLLATION always defaults the provider to libc. The attached patch causes it to default to libc if LC_COLLATE/LC_CTYPE are specified, otherwise default to the current database default collation's provider. That way, the provider choice at i

Re: Built-in CTYPE provider

2024-01-18 Thread Peter Eisentraut
On 12.01.24 03:02, Jeff Davis wrote: New version attached. Changes: * Named collation object PG_C_UTF8, which seems like a good idea to prevent name conflicts with existing collations. The locale name is still C.UTF-8, which still makes sense to me because it matches the behavior of the libc l

Re: Sequence Access Methods, round two

2024-01-18 Thread Peter Eisentraut
On 01.12.23 06:00, Michael Paquier wrote: Please find attached a patch set that aims at implementing sequence access methods, with callbacks following a model close to table and index AMs, with a few cases in mind: - Global sequences (including range-allocation, local caching). - Local custom com

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-18 Thread Peter Geoghegan
aluable thing. Not sure that that's possible -- the current design is at least correct on its own terms. And what you propose to do will probably be less correct on those same terms, silly though they are. -- Peter Geoghegan

Re: More new SQL/JSON item methods

2024-01-18 Thread Peter Eisentraut
On 18.01.24 15:25, Jeevan Chalke wrote: Peter, I didn't understand why the changes you did in your 0002 patch were required here. I did run the pgindent, and it didn't complain to me. So, just curious to know more about the changes. I have not merged those changes in this single patc

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-18 Thread Peter Geoghegan
lly wanted to convey is this: if you're going to go the route of ignoring LP_DEAD free space during vacuuming, you're conceding that having a high degree of precision about available free space isn't actually useful (or wouldn't be useful if it was actually possible at all). Which is something that I generally agree with. I'd just like it to be clear that you/Melanie are in fact taking one small step in that direction. We don't need to discuss possible later steps beyond that first step. Not right now. -- Peter Geoghegan

Re: Emit fewer vacuum records by reaping removable tuples during pruning

2024-01-18 Thread Peter Geoghegan
On Thu, Jan 18, 2024 at 11:46 AM Robert Haas wrote: > On Thu, Jan 18, 2024 at 11:17 AM Peter Geoghegan wrote: > > True. But the way that PageGetHeapFreeSpace() returns 0 for a page > > with 291 LP_DEAD stubs is a much older behavior. When that happens it > > is literally t

Re: minor replication slot docs edits

2024-01-18 Thread Peter Smith
IMO these should all be coded like XXX, because the resulting rendering looks much better with the GUC name using a varname font instead of just plain text that gives. I am happy to take on the task if nobody else wants to. ====== Kind Regards, Peter Smith. Fujitsu Australia

Re: Synchronizing slots from primary to standby

2024-01-18 Thread Peter Smith
On Tue, Jan 9, 2024 at 11:15 PM Zhijie Hou (Fujitsu) wrote: > > On Tuesday, January 9, 2024 9:17 AM Peter Smith wrote: > > ... > > > > 2. ALTER_REPLICATION_SLOT ... FAILOVER > > > > + > > + > >

Re: subscription disable_on_error not working after ALTER SUBSCRIPTION set bad conninfo

2024-01-18 Thread Peter Smith
On Thu, Jan 18, 2024 at 8:54 PM Amit Kapila wrote: > > On Thu, Jan 18, 2024 at 11:15 AM Peter Smith wrote: > > > > On Thu, Jan 18, 2024 at 12:55 PM Masahiko Sawada > > wrote: > > > > > ... > > > > > > Although we can improve it to han

Re: Commitfest manager January 2024

2024-01-18 Thread Peter Smith
Hi Vignesh, If you would like any assistance processing the 100s of CF entries I am happy to help in some way. == Kind Regards,, Peter Smith. Fujitsu Australia

Re: Synchronizing slots from primary to standby

2024-01-18 Thread Peter Smith
autovacuum * workers, and in background workers. */ - Assert(!IsUnderPostmaster || IsAutoVacuumWorkerProcess() || IsBackgroundWorker); + Assert(!IsUnderPostmaster || IsAutoVacuumWorkerProcess() || +IsLogicalSlotSyncWorker() || IsBackgroundWorker); Looks like this Assert has a stale comm

Re: Build versionless .so for Android

2024-01-19 Thread Peter Eisentraut
On 19.01.24 11:08, Matthias Kuhn wrote: When trying to build with meson, including the patch which was provided by Andres Freud (thanks), I am currently stuck with the following error: Configuring pg_config_ext.h using configuration ../src/tgresql-16-685bc9fc97.clean/src/include/meson.build:12

Re: generate syscache info automatically

2024-01-19 Thread Peter Eisentraut
On 19.01.24 06:28, John Naylor wrote: On Wed, Jan 17, 2024 at 7:46 PM Peter Eisentraut wrote: I updated the patch to use this style (but I swapped the first two arguments from my example, so that the thing being created is named first). I also changed the names of the output files a bit to

Re: pgsql: Clean up role created in new subscription test.

2024-01-19 Thread Peter Eisentraut
On 19.01.24 15:26, Daniel Gustafsson wrote: On 18 Jan 2024, at 01:57, vignesh C wrote: There are a lot of failures in CFBot at [1] with: More details of the same are available at [2]. Do we need to clean up the objects leftover for the reported issues in the test? Not really, these shoul

Re: Optimizing nbtree ScalarArrayOp execution, allowing multi-column ordered scans, skip scan

2024-01-19 Thread Peter Geoghegan
ttribute number subscript. > > Okay, but how about this in _bt_merge_arrays? > > +Datum *elem = elems_orig + i; > > I'm not familiar with the scan key convention, as most other places > use reference+subscripting. I meant the convention used in code like _bt_check_compare (which is what we call _bt_checkkeys on HEAD, basically). Note that the _bt_merge_arrays code that you've highlighted isn't iterating through so->keyData[] -- it is iterating through the function caller's elements array, which actually come from so->arrayKeys[]. Like every other Postgres contributor, I do my best to follow the conventions established by existing code. Sometimes that leads to pretty awkward results, where CamelCase and underscore styles are closely mixed together, because it works out to be the most consistent way of doing it overall. -- Peter Geoghegan

Re: Create shorthand for including all extra tests

2024-01-20 Thread Peter Eisentraut
On 15.01.24 09:54, Nazir Bilal Yavuz wrote: Hi, On Wed, 10 Jan 2024 at 23:48, Peter Eisentraut wrote: On 05.09.23 19:26, Nazir Bilal Yavuz wrote: Thanks for the feedback! I updated the patch, 'needs-private-lo' option enables kerberos, ldap, load_balance and ssl extra tests now

Re: Make documentation builds reproducible

2024-01-20 Thread Peter Eisentraut
On 20.01.24 03:33, vignesh C wrote: On Fri, 25 Aug 2023 at 01:23, Tristan Partin wrote: On Thu Aug 24, 2023 at 2:30 PM CDT, Tom Lane wrote: "Tristan Partin" writes: On Wed Aug 23, 2023 at 2:24 PM CDT, Peter Eisentraut wrote: Somewhere at PGCon, I forgot exactly where, maybe i

Re: Make documentation builds reproducible

2024-01-20 Thread Peter Eisentraut
On 20.01.24 17:03, Tom Lane wrote: Peter Eisentraut writes: I think there was general agreement with what this patch is doing, but I guess it's too boring to actually review the patch in detail. Let's say, if there are no objections, I'll go ahead and commit it. I re-read

Re: Evaluate arguments of correlated SubPlans in the referencing ExprState

2024-01-21 Thread Peter Smith
2024-01 Commitfest. Hi, This patch has a CF status of "Ready for Committer", but it is currently failing some CFbot tests [1]. Please have a look and post an updated version.. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4209 Kind Regards, Peter Smith.

Re: pg_rewind WAL segments deletion pitfall

2024-01-21 Thread Peter Smith
2024-01 Commitfest. Hi, This patch has a CF status of "Ready for Committer", but it is currently failing some CFbot tests [1]. Please have a look and post an updated version.. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/3874 Kind Regards, Peter Smith.

Re: Guiding principle for dropping LLVM versions?

2024-01-21 Thread Peter Smith
4640 Kind Regards, Peter Smith.

Re: [PATCH] psql: \dn+ to show size of each schema (and \dA+ for AMs)

2024-01-21 Thread Peter Smith
w" [1]. == [1] https://commitfest.postgresql.org/46/3256/ Kind Regards, Peter Smith.

Re: pg_receivewal fail to streams when the partial file to write is not fully initialized present in the wal receiver directory

2024-01-21 Thread Peter Smith
the patch and add an entry for the same. == [1] https://commitfest.postgresql.org/46/3503/ Kind Regards, Peter Smith.

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2024-01-21 Thread Peter Smith
the patch and add an entry for the same. == [1] https://commitfest.postgresql.org/46/2377/ Kind Regards, Peter Smith.

Re: WIP: Aggregation push-down - take2

2024-01-21 Thread Peter Smith
the patch and add an entry for the same. == [1] https://commitfest.postgresql.org/46/3764/ Kind Regards, Peter Smith.

Re: Temporary tables versus wraparound... again

2024-01-21 Thread Peter Smith
the patch and add an entry for the same. == [1] https://commitfest.postgresql.org/46/3358/ Kind Regards, Peter Smith.

Re: Support TZ format code in to_timestamp()

2024-01-21 Thread Peter Smith
. == [1] https://commitfest.postgresql.org/46/4362/ Kind Regards, Peter Smith.

Re: MERGE ... WHEN NOT MATCHED BY SOURCE

2024-01-21 Thread Peter Smith
d with feedback") at the end of this CF. == [1] https://commitfest.postgresql.org/46/4092/ Kind Regards, Peter Smith.

Re: Volatile write caches on macOS and Windows, redux

2024-01-21 Thread Peter Smith
be closed ("Returned with feedback") at the end of this CF. == [1] https://commitfest.postgresql.org/46/4453/ Kind Regards, Peter Smith.

Re: ALTER TABLE SET ACCESS METHOD on partitioned tables

2024-01-21 Thread Peter Smith
e CF entry will be closed ("Returned with feedback") at the end of this CF. == [1] https://commitfest.postgresql.org/46/3727/ Kind Regards, Peter Smith. Fujitsu Australia

Re: Remove unused fields in ReorderBufferTupleBuf

2024-01-21 Thread Peter Smith
hen the CF entry will be closed ("Returned with feedback") at the end of this CF. == [1] https://commitfest.postgresql.org/46/4461/ Kind Regards, Peter Smith.

Re: Incremental View Maintenance, take 2

2024-01-21 Thread Peter Smith
rus-ci.com/task/6607979311529984 Kind Regards, Peter Smith.

Re: Opportunistically pruning page before update

2024-01-21 Thread Peter Smith
2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there was some CFbot test failure last time it was run [2]. Please have a look and post an updated version if necessary. == [1] https://commitfest.postgresql.org/46/4384// [2] https://cirrus-ci.com/git

Re: Add code indentation check to cirrus-ci (was Re: Add BF member koel-like indentation checks to SanityCheck CI)

2024-01-21 Thread Peter Smith
rus-ci.com/task/5033191522697216 Kind Regards, Peter Smith.

Re: Add last_commit_lsn to pg_stat_database

2024-01-21 Thread Peter Smith
st/46/4355 Kind Regards, Peter Smith.

Re: Add new protocol message to change GUCs for usage with future protocol-only GUCs

2024-01-21 Thread Peter Smith
mitfest/46/4736 Kind Regards, Peter Smith.

Re: Avoid computing ORDER BY junk columns unnecessarily

2024-01-21 Thread Peter Smith
2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review", but it seems like there were some CFbot test failures last time it was run [1]. Please have a look and post an updated version if necessary. == [1] https://cirrus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4717

Re: Why is src/test/modules/committs/t/002_standby.pl flaky?

2024-01-21 Thread Peter Smith
2024-01 Commitfest. Hi, This patch has a CF status of "Needs Review" [1], but it seems like there were CFbot test failures last time it was run [1]. Please have a look and post an updated version if necessary. == 1[] https://commitfest.postgresql.org/46/3523/ [1] https://cirrus-ci.com/github/

Re: Removing const-false IS NULL quals and redundant IS NOT NULL quals

2024-01-21 Thread Peter Smith
com/github/postgresql-cfbot/postgresql/commitfest/46/4459 Kind Regards, Peter Smith.

Re: In-placre persistance change of a relation

2024-01-21 Thread Peter Smith
i.com/task/6050020441456640 Kind Regards, Peter Smith.

Re: Improve eviction algorithm in ReorderBuffer

2024-01-21 Thread Peter Smith
rus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4699 Kind Regards, Peter Smith.

Re: index prefetching

2024-01-21 Thread Peter Smith
rus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4351 Kind Regards, Peter Smith.

Re: [HACKERS] make async slave to wait for lsn to be replayed

2024-01-21 Thread Peter Smith
i.com/task/5618308515364864 Kind Regards, Peter Smith.

Re: Make mesage at end-of-recovery less scary.

2024-01-21 Thread Peter Smith
com/github/postgresql-cfbot/postgresql/commitfest/46/2490 Kind Regards, Peter Smith.

Re: Move walreceiver state assignment (to WALRCV_STREAMING) in WalReceiverMain()

2024-01-21 Thread Peter Smith
i.com/task/5367036042280960 Kind Regards, Peter Smith.

Re: Network failure may prevent promotion

2024-01-21 Thread Peter Smith
com/github/postgresql-cfbot/postgresql/commitfest/46/4748 Kind Regards, Peter Smith.

Re: [PATCH] New [relation] option engine

2024-01-21 Thread Peter Smith
i.com/task/5066432363364352 Kind Regards, Peter Smith.

Re: Permute underscore separated components of columns before fuzzy matching

2024-01-21 Thread Peter Smith
rus-ci.com/github/postgresql-cfbot/postgresql/commitfest/46/4282 Kind Regards, Peter Smith.

Re: Relation bulk write facility

2024-01-21 Thread Peter Smith
i.com/task/4990764426461184 Kind Regards, Peter Smith.

Re: remaining sql/json patches

2024-01-21 Thread Peter Smith
com/github/postgresql-cfbot/postgresql/commitfest/46/4377 Kind Regards, Peter Smith.

Re: SQL:2011 application time

2024-01-21 Thread Peter Smith
com/github/postgresql-cfbot/postgresql/commitfest/46/4308 Kind Regards, Peter Smith.

Re: Sequence Access Methods, round two

2024-01-21 Thread Peter Smith
i.com/task/5576959615303680 Kind Regards, Peter Smith.

Re: Statistics Import and Export

2024-01-21 Thread Peter Smith
com/github/postgresql-cfbot/postgresql/commitfest/46/4538 Kind Regards, Peter Smith.

Re: Moving forward with TDE [PATCH v3]

2024-01-21 Thread Peter Smith
i.com/task/5498215743619072 Kind Regards, Peter Smith.

Re: Transaction timeout

2024-01-21 Thread Peter Smith
i.com/task/4721191139672064 Kind Regards, Peter Smith.

<    27   28   29   30   31   32   33   34   35   36   >