On 16.01.24 12:08, Bharath Rupireddy wrote:
On Fri, Jan 12, 2024 at 9:21 PM Bharath Rupireddy
<bharath.rupireddyforpostg...@gmail.com> wrote:
On Fri, Jan 12, 2024 at 9:03 PM Peter Eisentraut <pe...@eisentraut.org> wrote:
I would put this code
my $core = $ret & 128 ? " (core dumped)" : "";
die "psql exited with signal "
. ($ret & 127)
. "$core: '$$stderr' while running '@psql_params'"
if $ret & 127;
$ret = $ret >> 8;
inside a if (defined $ret) block.
Then the behavior would be that the whole function returns undef on
timeout, which is usefully different from returning 0 (and matches
previous behavior).
WFM.
I've attached a patch for the above change.
Committed, thanks.
