On 2019-11-26 21:33, Tom Lane wrote:
Peter Eisentraut writes:
My revised proposal is to remove --disable-float8-byval as a configure
option but keep it as an option in pg_config_manual.h. It is no longer
useful as a user-facing option, but as was pointed out, it is somewhat
useful for
guess so. The patch has conflicts in the serial and parallel
schedules, so I have moved it to next CF, waiting on author for a
rebase.
Peter, are you planning to look at that again? Note: the patch has no
reviewers registered.
Here is an updated patch series.
After re-reading the discussion again
er-vendors-unite-to-end-support-for-20-year-old-tls-1-0/
[2]:
https://www.2ndquadrant.com/en/blog/setting-ssl-tls-protocol-versions-with-postgresql-12/
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
advised"?
(I'm also wondering whether the sentence about initdb is worth keeping.)
committed with those adjustments
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
se, but I think that it
would also help with the issue of passing parameters into some utility
commands later on. I will look into that some other time.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training
m so that the tests still work with very old
OpenSSL versions by default. That might be a good idea.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
users of really old systems a nudge that
they are no longer in compliance with industry best practices. You need
manual steps to set up SSL anyway, so this doesn't introduce an entirely
new kind of requirement for the latter group of users.
--
Peter Eisentraut http:/
the value into pg_config.h directly. This
also makes the standard build system match how the MSVC build system
already does it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
reports of that. I think your analysis is correct.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Tue, Nov 12, 2019 at 3:21 PM Peter Geoghegan wrote:
> * Decided to go back to turning deduplication on by default with
> non-unique indexes, and off by default using unique indexes.
>
> The unique index stuff was regressed enough with INSERT-heavy
> workloads that I was put
e the SSL connection attempt rejected and will
connect using a non-SSL connection.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
d to clean up
the tail end a bit.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
s "array length mismatch" or something like that.
I'd prefer it if we could just get rid of the second argument and show
the actual expression in the error message, like run-time assertions work.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7
On 2019-12-03 06:03, Tom Lane wrote:
Peter Eisentraut writes:
Currently, configure puts the configure args into the makefiles and
then have the makefiles pass them to the build of pg_config. That looks
like an unnecessary redirection, and indeed that method was
put in place when pg_config was
sn't fall afoul of
the existing error checks. There could be something like SELinux
lurking, for example.
Maybe some initial checking would be useful, but I think we still need
to downgrade the error check at use time a bit to not crash in the cases
that we miss.
--
Peter Eisentra
L it seems like 1.0.1a is the target, per the above
discussion.
For Python, I'll just observe that RHEL6 ships 2.6.6, so we can't
bump up to 2.7.
Yes, it would be Python 2.6.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-12-04 09:20, Michael Paquier wrote:
On Wed, Dec 04, 2019 at 09:10:04AM +0100, Peter Eisentraut wrote:
This would mean we'd stop support for RHEL 5, which is probably OK, seeing
that even the super-extended support ends in November 2020.
Sounds like a plan. I can work on the Op
EXEC_BACKEND
support?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From f790d208dc85a26585a2f5fb3042c29f8b3bbecc Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 4 Dec 2019 16:34:41 +0100
Subject: [P
g a test case for it, too.
I see this in v12 as well as HEAD. One interesting question is how come
the pg_upgrade test isn't failing --- maybe binary-upgrade mode handles
this case differently?
Binary upgrade dumps out even inherited columns, so it won't run into
the "separate&q
On 2019-12-04 20:59, Andres Freund wrote:
On 2019-12-04 20:45:25 +0100, Peter Eisentraut wrote:
In the previous discussions on backtrace support, some people asked for
backtraces in more situations. Here is a patch that prints backtraces on
SIGABRT, SIGBUS, and SIGSEGV signals. SIGABRT
commands like this, but after the recent changes to make
allow_system_table_mods easier to use, I think this has less urgency, so
I'd rather get the comment correct in the meantime.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remot
On 2019-12-02 16:13, Tom Lane wrote:
Peter Eisentraut writes:
On 2019-11-30 04:06, Tom Lane wrote:
I think the real question we have to answer is this: are we intent on
making people upgrade ancient openssl installations?
The trade-off is that this makes the defaults better for the vast
ith a source
line number, and when the developer sees the StaticAssertDecl at that source
line the cause of the error is anyway self-evident by the condition parameter.
Kind Regards
--
Peter Smith
Fujitsu Australia
port for XFS is rather immature.
How did you invoke pg_upgrade? Did you use the --link (hard link) option?
--
Peter Geoghegan
A small add-on to the generated columns feature: Add an ALTER TABLE
subcommand for dropping the generated property from a column, per SQL
standard.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Per discussion in [0], here is a patch set to remove support for Python
versions older than 2.6.
[0]:
https://www.postgresql.org/message-id/6d3b7b69-0970-4d40-671a-268c46e93...@2ndquadrant.com
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
patch to fix this (and make the output
a bit prettier). Result afterwards:
FAILURE (NormalizationTest.txt line 74):
input:U+00A8
expected: U+0020 U+0309
got: U+0020 U+0308
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Tra
ctions will throw an error with an !indisvalid
index.)
--
Peter Geoghegan
On 2019-12-09 23:22, Tom Lane wrote:
Peter Eisentraut writes:
There appear to be several off-by-more-than-one errors in norm_test.c
print_wchar_str(). Attached is a patch to fix this (and make the output
a bit prettier). Result afterwards:
I concur that this looks broken and your patch
_TABLE to
ATSimplePermissions(), so there is really no reason to keep the old
function separate.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From ca4b1eefade67af55fb16827fca9b1c3c7b1c942 Mon Sep 17 00:00:00
On 2019-12-10 17:16, Tom Lane wrote:
Peter Eisentraut writes:
Good point. Fixed in attached patch.
This one LGTM.
done, thanks
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-12-10 17:23, Tom Lane wrote:
Peter Eisentraut writes:
Good point. Done in the attached patch.
(If someone wanted to revive the original functionality, it would
nowadays probably be easier to add a flag ATT_SYSTEM_TABLE to
ATSimplePermissions(), so there is really no reason to keep the
n. It's too
obscure, especially the return value. Doesn't seem worth it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
https://www.postgresql.org/message-id/flat/20180605172252.GA2433%40fetter.org
[1]:
https://www.postgresql.org/message-id/flat/20180529153617.c72llpzbvt46chr6%40alap3.anarazel.de
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
On 2019-12-11 17:09, Daniel Gustafsson wrote:
On 11 Dec 2019, at 17:00, Peter Eisentraut
wrote:
There were a couple of recent threads that wanted to add an .editorconfig file
but never actually ended up doing so.[0][1] Here is a patch. It is meant to
match more or less what's in
On 2019-12-11 18:54, Andreas Karlsson wrote:
I have not used .editorconfig that much, but would it makes sense to add
the below?
[*]
end_of_line = lf
I think that would best be done in response to an actual need.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL
ably quite low. You still need ongoing careful
pg_hba.conf maintenance as you add more host entries.
Maybe we just need something like libpq's sslmode on the server side.
Probably not quite the same, perhaps just ssl = require.
--
Peter Eisentraut http://www.2ndQuadrant.
apply like
that.
MSYS2 doesn't ship with cygserver AFAICT, so you can't run a PostgreSQL
server, but everything else should work.
[0]:
https://www.postgresql.org/message-id/6672cebd-0c07-ce1e-36f8-6ae82c496...@2ndquadrant.com
--
Peter Eisentraut http://www.2ndQuadran
On Fri, Nov 1, 2019 at 1:19 PM Robert Haas wrote:
> On Fri, Nov 1, 2019 at 3:15 PM Peter Geoghegan wrote:
> > I don't think that those two things are equivalent at all. There may
> > even be workloads that will benefit when run on 32-bit hardware.
> > Having to palloc
t show that Python itself works correctly. Then
again, we could keep it for completeness and clarity.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
e SEGV/BUS thing can be a bit scary. We can skip it.
Are people interested in backtraces on abort()? That was asked for in
an earlier thread.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-12-12 23:06, Peter Geoghegan wrote:
Apparently Linux has almost no upstream resources for testing 32-bit
x86, and it shows:
But isn't 32-bit Windows still a thing? Or does that work differently?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development,
this was "to be
used by the installer", but I didn't find any reference in the current
installer's Git repository either. I suspect this is obsolete.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, R
columns in the apply worker. I'll work on that separately.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 94249746b2b633a1ece44527060d0de18dc1 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
it. I haven't pondered why it's done
that way, only focusing on making the resulting files match.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Wed, Nov 20, 2019 at 1:43 PM Peter Geoghegan wrote:
> My understanding is that we can trust RecentGlobalXmin to be something
> useful and current during recovery, in general, so the selfuncs.c
> index-only scan (which uses SnapshotNonVacuumable + RecentGlobalXmin)
> can be trusted
On 2019-12-16 05:39, Andrew Dunstan wrote:
On Wed, Oct 30, 2019 at 10:32 PM Peter Eisentraut
wrote:
To move this topic a long, I'll submit some preparatory patches in a
committable order.
First is the patch to deal with getpeereid() that was already included
in the previous patch s
think it's good practice: it encourages
failure to think about how such variables need to be set on Windows.
OK, here is an updated patch set that has all defines in one big Perl
hash, and also requires that all symbols in pg_config.h.in are accounted
for. (The indentation is from pgperltidy.)
not trying to interpret the names
locale -a spits out.
I think it's worth handling that separately. If we want to give it an
air of generality and not just hard-code that one locale name, we could
strip off the encoding and compare the rest with the well-known encoding
names.
ached patch.
Peter E., Petr J or anyone else, do you have comments or objections on
this patch? If none, then I am planning to commit (and backpatch)
this patch in a few days time.
The patch seems fine to me. Writing a test seems hard. Let's skip it.
The commit message has a duplicate
uld add a test that exposes "ignore OF col1" such as:
$node_publisher->safe_psql('postgres',
"UPDATE tab_fk_ref SET id = 6 WHERE id = 1;");
done
New patch attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Suppo
s.
Thoughts so far?
[0]:
https://www.postgresql.org/message-id/flat/CAFj8pRARh+r4=hnwq+hws-d6msus01dw_6zjnyur6tpk1+w...@mail.gmail.com
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From c517222f5de87961e0cebd91efc5
On 2019-12-17 05:40, Stephen Frost wrote:
* Peter Eisentraut (peter.eisentr...@2ndquadrant.com) wrote:
The idea is that if you connect over a Unix-domain socket and the local
(effective) user is the same as the server's (effective) user, then
access should be granted immediately withou
;, "src/include/pg_config.h")
+ || confess "Could not write to pg_config.h\n";
Failure to open pg_config.h.
Wouldn't it be better to remove pg_config_ext.h.win32 as well?
Yeah, good idea. Attached patch is refactored so all three header files
managed by AC_CO
#x27;ve also been able to observe increases of 15%-20% in
TPS with similar workloads (with commensurate reductions in query
latency) more recently. This was with a simple gaussian distribution
for pgbench_accounts.aid, and a non-unique index with deduplication
enabled on pgbench_accounts.abalance. (The patch helps control the
size of both indexes, especially the extra non-unique one.)
[1]
https://postgr.es/m/CAH2-WzkXHhjhmUYfVvu6afbojU97MST8RUT1U=hld2w-gc5...@mail.gmail.com
--
Peter Geoghegan
On Tue, Dec 17, 2019 at 5:18 PM Bruce Momjian wrote:
> On Tue, Dec 17, 2019 at 03:30:33PM -0800, Peter Geoghegan wrote:
> > With many real world unique indexes, the true reason behind most or
> > all B-Tree page splits is "version churn". I view these page splits as
>
On Thu, Dec 12, 2019 at 6:21 PM Peter Geoghegan wrote:
> Still waiting for some review of the first patch, to get it out of the
> way. Anastasia?
I plan to commit this first patch [1] in the next day or two, barring
any objections.
It's clear that the nbtree "pin scan" V
On 2019-12-11 17:00, Peter Eisentraut wrote:
There were a couple of recent threads that wanted to add an
.editorconfig file but never actually ended up doing so.[0][1] Here is
a patch. It is meant to match more or less what's in .dir-locals.el.
committed
--
Peter Eisen
.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 0ceb620b17b197b1effa96a46e35b6c03942ca7a Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Wed, 18 Dec 2019 09:52:10 +0100
Subject: [PATCH] Disallow drop
lready resolve an empty socket directory setting with a
default if appropriate.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 0b63a8a758d507095bf5070cec8119436c267519 Mon Sep 17 00:00:00 2001
From: Peter Eisentrau
On 2019-12-18 15:24, Hamlin, Garick L wrote:
On Wed, Dec 18, 2019 at 02:52:15PM +0100, Peter Eisentraut wrote:
To implement this, tweak things so that setting DEFAULT_PGSOCKET_DIR
to "" has the desired effect. This mostly already worked like that;
only a few places needed to b
On 2019-12-19 04:59, Michael Paquier wrote:
On Tue, Dec 17, 2019 at 11:56:17AM +0100, Peter Eisentraut wrote:
Yeah, good idea. Attached patch is refactored so all three header files
managed by AC_CONFIG_HEADERS are processed the same way.
Looks good. I just have one comment.
+ # XXX
ns, I don't think the SQL standard
allows the READ UNCOMMITTED level to behave in a way that violates the
logical requirements of the defined database schema. So if we wanted to
add this, we should probably name it something else.
--
Peter Eisentraut http://www.2ndQuadra
ut back the assignment of "opaque". The sequence of BufferGetPage()
> and PageGetSpecialPointer() is a very standard switch-our-attention-
> to-another-page locution in nbtree and other index AMs.
+1
--
Peter Geoghegan
blication "dbz_publication" does not exist
CONTEXT: slot "debezium", output plugin "pgoutput", in the change
callback, associated LSN 0/4324180
This must be something particular to Debezium.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
to the various TCP keepalive settings, but
since those are widely supported the unsupported code paths probably
haven't gotten much attention.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
operator class
BITWISE. Better to drop everything, and recreate everything, since
your indexes should be considered corrupt anyway. (Also, I don't think
that it's that hard to get it right, so this will probably never
happen.)
--
Peter Geoghegan
ated the most recent patch (_5 from Michael) so it now has your suggested
error message rewording.
PSA patch _6
Kind Regards
Peter Smith
Fujitsu Australia
ct_asserts_StaticAssertDecl_6.patch
Description: ct_asserts_StaticAssertDecl_6.patch
On 2019-12-18 16:53, Robert Haas wrote:
On Wed, Dec 18, 2019 at 3:56 AM Peter Eisentraut
wrote:
As a curious omission, DROP RULE does not check allow_system_table_mods.
Creating and renaming a rule does, and also creating, renaming, and
dropping a trigger does. The impact of this is
On 2019-12-19 08:49, Michael Paquier wrote:
On Thu, Dec 19, 2019 at 08:31:05AM +0100, Peter Eisentraut wrote:
On 2019-12-19 04:59, Michael Paquier wrote:
This part needs a comment. Like it is the equivalent of what
src/common/'s Makefile does or something like that?
This was meant
7;t be preferable to avoid this whole mess by just not creating any
collations in initdb. What do you think?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ation does not fire
per-column triggers"[0]. I'll leave my patch here while that issue is
being resolved.
[0]:
https://www.postgresql.org/message-id/flat/21673e2d-597c-6afe-637e-e8b10425b240%402ndquadrant.com
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL De
On 2019-12-04 11:30, Peter Eisentraut wrote:
On 2019-12-03 06:03, Tom Lane wrote:
Peter Eisentraut writes:
Currently, configure puts the configure args into the makefiles and
then have the makefiles pass them to the build of pg_config. That looks
like an unnecessary redirection, and indeed
.e. whether
they've been placed by the FSM for recycling) by using
contrib/pg_freespacemap.
--
Peter Geoghegan
all header in the style
that I have. I'd rather adjust the output of
generate-unicode_norm_table.pl to match those. (It's also not quite
correct to make copyright claims about automatically generated output.)
Lastly, src/common/unicode/README is outdated (and possibly no longer
u
On 2019-12-12 22:11, Peter Eisentraut wrote:
You can also build natively on MSYS2, using the existing Cygwin support.
Except that it won't work because configure doesn't recognize the
config.guess output. Attached are a couple of small patches to fix that
up. The first patch fixes
have tested this patch with MSVC and MinGW.
I've also added some comments and a documentation link to be able to
understand this business a bit better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Serv
client end
matches the owner of the postgres process. Then the behavior I'm after
can be expressed with a pg_hba.conf entry like
localowner all all trust
or similar, as one chooses.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote
trolled by the DBA. If the OS admin and the DBA are the same entity,
then peer is obviously very nice, but if not, then peer is a trap.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
;
alter table testdrop drop column i;
Here is no "m" column anymore. Possible due some forgotten dependency?
fixed -- good catch
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
namespace and make them a local concern.
Attached are two patches to remove these two symbols. STATUS_FOUND can
be replaced by a simple bool. STATUS_WAITING is replaced by a separate
enum.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support
variables, but it seems like a serious restriction and makes me
wonder whether this has actually ever been used before. It's curious
that MSYS2 ships a readline build for mingw. Is there other software
that uses it on Windows?
[0]:
https://www.postgresql.org/message-id/001101c3eb6a$3b
th USING,
i.e. above only x.bid should exists, and per-table aliases are expected to
still work for other attributes.
I took another crack at this. Attached is a new patch that addresses
the semantic comments from this and the other thread. It's all a bit
tricky, comments welco
page -- we pass that down through an insertion scankey.
We only need to determine whether or not the optimization is safe at
CREATE INDEX time. (Actually, I don't want to commit to the idea that
nbtree should only call this support function at CREATE INDEX time
right now. I'm sure that it will hardly ever need to be called,
though.)
--
Peter Geoghegan
the same issue.
[1]
https://www.postgresql.org/docs/devel/functions-comparisons.html#COMPOSITE-TYPE-COMPARISON
[2]
https://www.postgresql.org/message-id/flat/3326fc2e-bc02-d4c5-e3e5-e54da466e89a%402ndquadrant.com
--
Peter Geoghegan
On 2019-12-09 11:37, Peter Eisentraut wrote:
Per discussion in [0], here is a patch set to remove support for Python
versions older than 2.6.
[0]:
https://www.postgresql.org/message-id/6d3b7b69-0970-4d40-671a-268c46e93...@2ndquadrant.com
It appears that the removal of old OpenSSL support is
ven't done that in this patch.)
I'm aware of the pending patch to improve color support on Windows.
I'll check that one out as well, but it appears to be orthogonal to this
one.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, R
before and it works for them, so you need to
explain what's different for you, especially considering the extent of
the changes you are proposing.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ems pretty straightforward, but this
+/*
+ * Convenient shorcuts
+ */
+#define fatal pg_log_fatal
+#define error pg_log_error
+#define warning pg_log_warning
+#define info pg_log_info
+#define debug pg_log_debug
seems counterproductive. Let's just use the normal function names.
--
Peter Eisentraut
k has
been copied from _bt_delitems_vacuum().
--
Peter Geoghegan
From a383d30b3c0404ea0095ea8f130214f4c8dd4dd9 Mon Sep 17 00:00:00 2001
From: Peter Geoghegan
Date: Wed, 1 Jan 2020 12:30:26 -0800
Subject: [PATCH] Associate LP_DEAD offsets with WAL record's buffer.
Commit 558a9165e08 taught _bt_
On Thu, Jan 2, 2020 at 6:42 AM Robert Haas wrote:
> On Mon, Dec 30, 2019 at 6:58 PM Peter Geoghegan wrote:
> > I propose that we adopt the following definition: For an operator
> > class to be safe, its equality operator has to always agree with
> > datum_image_eq() (i.
On Wed, Jan 1, 2020 at 1:00 PM Peter Geoghegan wrote:
> Attached patch shows what I have in mind. The new comment block has
> been copied from _bt_delitems_vacuum().
I also think that the WAL record and function signature of
_bt_delitems_delete() should be brought closer to
_bt_delitems_
that we should just
simplify the function's API. I have no strong opinion about that.
I haven't found an explanation in this thread why it does always quote
now. That seems a bit unusual. Is there a reason for this? Can we do
without it?
--
Peter Eisentraut
On 2019-12-30 14:28, Tom Lane wrote:
Peter Eisentraut writes:
On 2019-09-29 22:55, Andrew Dunstan wrote:
It would certainly be nice to have readline-enabled psql on Windows if
possible.
I tried this out. First, it doesn't build, because readline doesn't do
the dllimport/dllexpor
On 2020-01-02 15:50, Dean Rasheed wrote:
Out of curiosity, what was the original use-case for this?
Yeah, I'm wondering, is this useful for any typical analytics or
business application? Otherwise, abstract algebra functionality seems a
bit out of scope.
--
Peter Eisen
essary for rebuilding the index itself. For re-setting the
replica identity, we can just use the internal API as you say.
Also, a few test cases would be nice for this patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
sonally, I think making the argument optional is unnecessary and
confusing, so I'd just change the documentation.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2020-01-03 11:04, Amit Kapila wrote:
On Fri, Jan 3, 2020 at 3:24 PM Peter Eisentraut
wrote:
The documentation and pgbench --help output that accompanied this patch
claims that the argument to pgbench --partition-method is optional and
defaults to "range", but that is not actuall
", PQerrorMessage(conn));
+ pg_log_error("connection to database \"%s\" failed: %s",
+dbName, PQerrorMessage(conn));
Line break here is unnecessary.
In both cases, pg_dump has similar messages that can serve as reference.
--
Peter Eisentraut
On 2020-01-03 16:22, Tom Lane wrote:
Peter Eisentraut writes:
On 2020-01-02 15:50, Dean Rasheed wrote:
Out of curiosity, what was the original use-case for this?
Yeah, I'm wondering, is this useful for any typical analytics or
business application? Otherwise, abstract al
2401 - 2500 of 10770 matches
Mail list logo
