Hello Michael,

> In short, attached is an updated version of your patch which attempts to 
> solve that.  I have tested this with some cplusplus stuff, and GCC for both 
> versions (static_assert is available in GCC >= 6, but a manual change of c.h 
> does the trick).
> I have edited the patch a bit while on it, your assertions did not use 
> project-style grammar, the use of parenthesis was inconsistent (see relpath.c 
> for example), and pgindent has complained a bit.

Thanks for your updates.

~~

Hello Andres,

>> +StaticAssertDecl(lengthof(LockTagTypeNames) == (LOCKTAG_ADVISORY + 1),
>> +                             "LockTagTypeNames array inconsistency");
>> +
> These error messages strike me as somewhat unhelpful. I'd probably just 
> reword them as "array length mismatch" or something like that.

I updated the most recent patch (_5 from Michael) so it now has your suggested 
error message rewording.

PSA patch _6

Kind Regards
----
Peter Smith
Fujitsu Australia

Attachment: ct_asserts_StaticAssertDecl_6.patch
Description: ct_asserts_StaticAssertDecl_6.patch

Reply via email to