On 1/25/18 09:07, Peter Eisentraut wrote:
> On 1/19/18 13:43, Peter Eisentraut wrote:
>> Comparing the existing {be,fe}-secure-openssl.c with the proposed
>> {be,fe}-secure-gnutls.c, and with half an eye on the previously proposed
>> Apple Secure Transport implementation, I
On 1/26/18 12:46, Robert Haas wrote:
> On Thu, Jan 25, 2018 at 10:26 PM, Peter Eisentraut
> wrote:
>>> Does the SQL spec mention the matter? How do other systems
>>> handle such cases?
>>
>> In Oracle you get the same overflow error.
>
> That seems awfu
pleased with where this leaves parallel CREATE
INDEX. I hope that Robert can review and commit this patch quickly, so
that I can use the new infrastructure. I can then post what I hope to
be the final revision of parallel CREATE INDEX. ISTM that the question
of handling things like parallel worker fork() failure is the only
real blocker to committing parallel CREATE INDEX, since we've reached
agreement on all other issues.
Thanks
--
Peter Geoghegan
one. (Logical decoding for MERGE should be quite
a lot easier, though.)
I'm willing to talk about why MERGE is different to ON CONFLICT, and
why it may not need to tick all of the same boxes. DML statements are
supposed to be highly composable things, though. That's the premise
you should start from IMV.
--
Peter Geoghegan
and throws SQLCODE =
> ERRCODE_FEATURE_NOT_SUPPORTED, with appropriate text
What specific features does it not work with already? A list would be helpful.
--
Peter Geoghegan
ainst constraint triggers is unclear. The subsequent
foreign-key patches mess with that further. It's not clear to me why
constraint triggers shouldn't be allowed like normal triggers.
Obvious missing things: documentation, pg_dump, psql updates
--
Peter Eisentraut http://www.2
: system column "oid" reference in WHEN AND condition is invalid
LINE 1: ...'foo' "data") b on a.key = b.key when matched and a.oid = 5 ...
^
LOCATION: scanRTEForColumn, parse_relation.c:738
* Wholerow vars are broken:
postgres=# merge into testoids a using (select 1 "key", 'foo' "data")
b on a.key = b.key when matched then update set data = b.*::text when
not matched then insert (key, data) values (1, 'foo');
ERROR: XX000: variable not found in subplan target lists
LOCATION: fix_join_expr_mutator, setrefs.c:2351
That's all I have for now.
--
Peter Geoghegan
ul. Not sure
> if it has consequences.
It's easier to just support them. That way we don't have to think about it.
>> * Wholerow vars are broken:
>>
>> postgres=# merge into testoids a using (select 1 "key", 'foo' "data")
>> b on a.key = b.key when matched then update set data = b.*::text when
>> not matched then insert (key, data) values (1, 'foo');
>> ERROR: XX000: variable not found in subplan target lists
>> LOCATION: fix_join_expr_mutator, setrefs.c:2351
>>
>> That's all I have for now.
>
> Good catch; that one is a valid error. I hadn't tried to either
> support them or block them.
>
> Maybe its in the SQL Standard, not sure. Support for whole row vars
> probably isn't a priority though.
I think that this needs to work, on general principle. Again, just
fixing it is much easier than arguing about it.
--
Peter Geoghegan
he SQL standard.
>
> Hmm, it's been not quite a dozen years, have there been later threads
> that followed up on this discussion?
No, I don't think anything has changed here.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ersions of Thomas' parallel hash join patch set. It worked for me
twice already, so it seems like a good strategy. It may be worth
*combining* with some other stress-testing strategy.
[1]
https://github.com/petergeoghegan/amcheck#optional-heapallindexed-verification
[2]
https://www.postgresql.org/message-id/cam3swzrwdntkhig0gyix_1muaypik3dv6-6542pye2iel-f...@mail.gmail.com
--
Peter Geoghegan
oyance, this would also include renaming libpq connection parameters
and APIs, which would be much more problematic.
I think most users actually still think about the whole topic as "SSL",
and the leading library is called "OpenSSL", so I think we're fine.
--
Peter Eisent
ould be moved to that.
I like that. Updated patch attached.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From ac2310337e4749044ee4d65fe2b762295e3ba7af Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
that's what was previously agreed. Peter is arguing
> that we don't normally issue a serialization error at READ COMMITTED
> (which I think is true) and proposed that we instead try to INSERT. I
> don't necessarily think that's different from consens
On Tue, Jan 30, 2018 at 8:56 AM, Simon Riggs wrote:
>> Peter is arguing
>> that we don't normally issue a serialization error at READ COMMITTED
>> (which I think is true) and proposed that we instead try to INSERT.
>
> Which IMHO is case 4 since it would avoid a conc
that's what was previously agreed. Peter is arguing
> that we don't normally issue a serialization error at READ COMMITTED
> (which I think is true) and proposed that we instead try to INSERT. I
> don't necessarily think that's different from consens
is not handled by the access methods.
> Currently, we are using event triggers to capture drop index. If there
> is a better way, please do suggest.
An event trigger will probably do for now. But you are venturing into
uncharted territory, so you will have to find your own best solution
these would be. But if you want to cover everything,
you'll need three values.
I think the patch can go ahead as proposed, and the other things could
be future separate additions.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
at it should be opt-in the first release... Think we
> roughly did that right for e.g. parallellism.
That sounds reasonable, for both of those reasons.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
o phase nature to WHEN
quals, which is the actual structure that Simon chose. Technically,
what you described wouldn't ever require EPQ recheck -- it might
require WHEN recheck. I think we should start being careful about
which we're talking about going forward. Hopefully Simon's MERGE wiki
page can establish a standard lexicon to talk about this stuff without
everyone becoming even more confused. That seems like it would be a
big help.
--
Peter Geoghegan
s not installed, but if set to on it'll refuse to work if not
> enabled. Similar to how huge pages work now.
But that setup also has the problem that you can't query the setting to
know whether it's actually on.
--
Peter Eisentraut http://www.2ndQuadrant.com/
Pos
arate turn-it-off-it's-broken
setting.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
33f6 and a6ef00b5 for
> the record. The last steps would be to:
> - Introduce bool8 for catalogs.
> - Address GinTernaryValue.
> - Integrate stdbool.h.
> Peter, are you planning to work on that for the next CF?
I've been testing this a bit further and during a test setup with 4-byte
g representation. Possible options have already been addressed in
earlier threads.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
e virtual columns part of a row type, which would make it
> consistent with all the other types.
That would be nice. I'm going to study this some more to see what can
be done.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
To close out this commit fest, I'm setting both of these patches as
returned with feedback, as there are apparently significant issues to be
addressed. Feel free to move them to the next commit fest when you
think they are ready to be continued.
--
Peter Eisentraut http:
Moved to next commit fest.
There is some work to be done, but there appears to be a straight path
to success.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 1/26/18 13:42, Peter Eisentraut wrote:
> Other than that, this looks pretty good to me. A logical extension of
> the previous partitioned index patch.
Moved to next CF.
Seems close to ready.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 S
tested, passed
>
> LGTM.
>
> The new status of this patch is: Ready for Committer
I've been working on polishing this a bit. I'll keep working on it. It
should be ready to commit soon.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Developmen
h Cond: (i.i = a.key)
-> Function Scan on generate_series i (cost=0.00..10.00
rows=1000 width=4) (actual time=0.009..0.010 rows=4 loops=1)
-> Hash (cost=22.70..22.70 rows=1270 width=10) (actual
time=0.021..0.021 rows=4 loops=1)
Buckets: 2048 Batches: 1 Memory Usage: 17kB
-> Seq Scan on testoids a (cost=0.00..22.70 rows=1270
width=10) (actual time=0.014..0.016 rows=4 loops=1)
Planning time: 0.202 ms
Execution time: 0.109 ms
(12 rows)
(It should be 0 rows inserted, not 4.)
--
Peter Geoghegan
s or similar.
Here is a patch to implement that idea. Do you have a way to test it
repeatedly, or do you just randomly cancel queries?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From ef275dd88fe1533fa48aea
On Thu, Feb 1, 2018 at 11:39 AM, Peter Geoghegan wrote:
> There is also the matter of subselects in the update targetlist, which
> you similarly claim is only a problem of having the wrong error
> message. The idea that those are unsupported for any principled reason
> does
On Fri, Feb 2, 2018 at 6:11 AM, Robert Haas wrote:
>> Fair enough, you can proceed with the patch.
>
> Committed. Now, on to the main event!
Thank you both.
--
Peter Geoghegan
On Fri, Feb 2, 2018 at 4:22 AM, Andrey Borodin wrote:
> I can try to do this before next CF. But ISTM that EDB and Postgres Pro
> already have various flavours of similar feature. Maybe they are planning to
> publish that?
I would definitely review that patch.
--
Peter Geoghegan
nks everyone
--
Peter Geoghegan
On Fri, Feb 2, 2018 at 10:38 AM, Peter Geoghegan wrote:
> Thanks everyone
I would like to acknowledge the assistance of Corey Huinker with early
testing of the patch (this took place in 2016, and much of it was not
on-list). Even though he wasn't credited in the commit message, he
shoul
I'm glad that we now have the
reviewer credit list, so that they can be corrected afterwards.
--
Peter Geoghegan
On Fri, Feb 2, 2018 at 10:38 AM, Peter Geoghegan wrote:
> On Fri, Feb 2, 2018 at 10:37 AM, Robert Haas wrote:
>> If you could keep an eye on the buildfarm and investigate anything
>> that breaks, I would appreciate it.
> I can keep an eye on it throughout the day.
There is
on in the grammar and then
check in post-parse analysis that it's a constant.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
akes sure that parallelism is never even attempted
from that path, to match TRUNCATE's suppression of parallel index
builds during its reindexing. It really shouldn't be a problem as
things stand, but maybe it's better to be consistent about "useless"
parallel CREATE INDEX attempts, and suppress them here too.
--
Peter Geoghegan
On Fri, Feb 2, 2018 at 4:31 PM, Peter Geoghegan wrote:
> On Fri, Feb 2, 2018 at 1:58 PM, Andres Freund wrote:
>> Not saying you're wrong, but you should include a comment on why this is
>> a benign warning. Presumably it's some padding memory somewhere, but
>>
ncurrency out of the way first.
But if you don't make some broad concessions on the secondary issues
pretty quickly, then I will have to conclude that our positions are
irreconcilable. I will have nothing further to contribute to the
discussion.
[1] https://wiki.postgresql.org/wiki/FOSDEM/PGDay_2018_Developer_Meeting#Minutes
--
Peter Geoghegan
would mean that I said
something on January 29th that I subsequently withdrew on February
1st.
--
Peter Geoghegan
that the bytes are poisoned is tracked as
they're copied around. You get the error on the write() from the
BufFile buffer, despite the fact that you can make the error go away
by using palloc0() instead of palloc() within logtape.c, and nowhere
else.
--
Peter Geoghegan
n a, but no template matches.
> Note: Writing man7/CREATE_POLICY.7
Yes, everyone is getting that. It has to do with the table that was
added to the CREATE POLICY man page. I'll look into fixing it.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
would be fairly easy. We'd only
need to copy code from nbtsort.c, and arrange for parallel workers to
verify an index each ahead of the heap scan. (There would be multiple
Bloom filters in shared memory, all of which parallel workers end up
probing.)
Thoughts?
--
Peter Geoghegan
On Mon, Feb 5, 2018 at 1:27 PM, Robert Haas wrote:
> On Mon, Feb 5, 2018 at 1:03 PM, Peter Geoghegan wrote:
>> It certainly is common. In the case of logtape.c, we almost always
>> write out some garbage bytes, even with serial sorts. The only
>> difference here is the *se
ew of those.
That just isn't part of our security model.
--
Peter Geoghegan
licated.
At this point, it might be worth more to actually try this procedure by
hand first and work out the details, e.g., how do you do the DDL sync,
how to you convert the configuration files, etc.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Here is a patch that fills in a few more information schema columns, in
particular those related to the trigger transition tables feature.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
that there
is a problem with the design itself, particularly in the optimizer.
Allowing subselects in the UPDATE part of a MERGE do not seem like
they could be written as a neat adjunct to what Simon already came up
with. If that was possible, Simon probably already would have done it.
--
Peter Geoghegan
pletes (>1s)
etc.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2/1/18 20:35, Andres Freund wrote:
> On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut
> wrote:
>>Here is a patch to implement that idea. Do you have a way to test it
>>repeatedly, or do you just randomly cancel queries?
>
> For me cancelling the long ru
On Mon, Feb 5, 2018 at 1:45 PM, Peter Geoghegan wrote:
>> So, I guess another option might be to call VALGRIND_MAKE_MEM_DEFINED
>> on the buffer. "We know what we're doing, trust us!"
>>
>> In some ways, that seems better than inserting a suppression, becau
.triggers ORDER BY
>> 1, 2;
>
> Writing those SQL queries across multiple lines would make them easier
> to read...
done
How about the attached version?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Serv
On Tue, Feb 6, 2018 at 12:39 PM, Robert Haas wrote:
> Yeah, let's get them all into one list and I'll commit the whole thing
> together.
+1
--
Peter Geoghegan
On Tue, Feb 6, 2018 at 12:53 PM, Robert Haas wrote:
>> Do you want somebody who does have a working valgrind installation
>> (ie me) to take responsibility for pushing this patch?
>
> I committed it before seeing this. It probably would've been better
> if you had d
h
-O1 at a later point, but it sounds like it's probably worth it to me.
Skink uses -Og, FWIW.
--
Peter Geoghegan
reeze() was never reached (though that's not
the only reason, it is the most obvious one).
--
Peter Geoghegan
On Wed, Jan 17, 2018 at 2:23 PM, Peter Geoghegan wrote:
> A complicating factor for this fix of mine is that mode_final() seems
> to have its own ideas about tuple memory lifetime, over and above what
> tuplesort_getdatum() explicitly promises, as can be seen here:
>
> /*
>
finitely is using, in the case of BDR and pglogical. But we can patch in a
> version check easily enough.
That won't be necessary. The WIP-kludge-fix.patch approach is never
going to be used, and was only really posted for illustrative
purposes.
--
Peter Geoghegan
was something like
(t.tgtype & (1 | 66))
but maybe it's clearer to write it all out as you did.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2/7/18 00:14, Michael Paquier wrote:
> On Tue, Feb 06, 2018 at 10:45:52PM -0500, Peter Eisentraut wrote:
>> I think what I had meant to write was something like
>>
>> (t.tgtype & (1 | 66))
>>
>> but maybe it's clearer to write it all out as you did
rt sslmode=verify-full
I have found the old way very confusing while working with several
SSL-related patches recently.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 30014a0669f9a357a7013e2ee235075196acd
nging. Once again, I suggest that a
good area for us to focus on is the semantics of READ COMMITTED
conflict handling. Maybe you'd prefer to just blast through the
simpler open items, which is fine, but do bear in mind that the EPQ
and EPQ-adjacent stuff is probably going to be the thing that makes or
breaks this patch for v11.
--
Peter Geoghegan
me tho..
You probably had the openjade1.3 package installed, and maybe it got
deleted or the alternative uninstalled during the upgrade.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Mon, Feb 5, 2018 at 12:55 PM, Peter Geoghegan wrote:
> Anyway, parallel CREATE INDEX added a new "scan" argument to
> IndexBuildHeapScan(), which caused this patch to bitrot. At a minimum,
> an additional NULL argument should be passed by amcheck. However, I
> have a bett
On Wed, Feb 7, 2018 at 4:41 PM, Tom Lane wrote:
> Peter Geoghegan writes:
>> It would be nice to get an opinion on this mode_final() + tuplesort
>> memory lifetime business from you, Tom.
>
> I'm fairly sure that that bit in mode_final() was just a hack to make
>
seem to be the general style, and I think it's more
readable the way it is now.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
t that's unclear. I should probably cut it down, and say
something like "caller can pass a random seed to make it unlikely that
the same false positives will occur from one run to the next".
--
Peter Geoghegan
actually
kind of need to know about, at least in theory. RC conflict handling
semantics could bleed into a number of other things.
I'll need to think some more about RC conflict handling (deciding what
"EPQ with a twist" actually means), since I haven't focused on MERGE
recently. Bear with me.
[1] https://www.postgresql.org/docs/current/static/ddl-rowsecurity.html
--
Peter Geoghegan
that format.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 4b24fa8aaf68327f773327269b23b6b129df858c Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Date: Thu, 8 Feb 2018 10:21:43 -0500
Subject: [PATCH]
doing
so wouldn't impact the run time significantly.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ely, while this is not required to work in ISO C, this standard
requires it to work.
FreeBSD has added a dlfunc() function as a workaround, but it apparently
hasn't spread anywhere else.
So, um, I don't know. Carry on. ;-)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
t Heroku enabled parallel query for
9.6 immediately, and it turned out fine. The first version available
as stable was probably 9.6.3 -- there or thereabouts.
There were some bugs, of course, but not to the extent that 9.6 was
looked upon as being more buggy than the average Postgres release.
--
Peter Geoghegan
against 10.0/10.1.
>
> Yea, I think the damage is done in this case, and we shouldn't make
> things even more complicated.
Yeah, lesson learned. Sorry.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2/10/18 19:46, Michael Paquier wrote:
> On Fri, Feb 09, 2018 at 08:44:38PM -0500, Peter Eisentraut wrote:
>> Hmm. I think the ldap test suite should be changed to use
>> $node->restart instead of $node->reload, so we can be sure that the
>> various pg_hba.conf lines
es.
It would perhaps be nice if that could be made to work, but as
discussed it would require a bunch more work.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
_memory_type is
> DSM_NONE. It is because plan_create_index_workers() is ignoring
> dynamic_shared_memory_type.
I think that your patch does the right thing.
plan_create_index_workers() is supposed to take care of parallel
safety, and this is a parallel safety issue.
Thanks
--
Peter Geoghegan
On 2/1/18 11:33, Pavel Stehule wrote:
> postgres=# \sf test
> ERROR: cache lookup failed for type 0
Here is a patch set that adds procedure support to \ef and \sf.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training &
nder the impression that Peter was looking into that ...
> [ digs... ] see
> https://www.postgresql.org/message-id/80ee1f5c-fa9d-7285-ed07-cff53d4f4...@2ndquadrant.com
Yeah that's still pending, but there wasn't a whole lot of reaction in
that thread.
--
Peter Eisentraut
cture
doc/src/sgml/ a bit? The intermediate directories had a meaning at some
point, but now they're mostly empty.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2/6/18 12:06, Andres Freund wrote:
> On 2018-02-06 12:01:08 -0500, Peter Eisentraut wrote:
>> On 2/1/18 20:35, Andres Freund wrote:
>>> On February 1, 2018 11:13:06 PM GMT+01:00, Peter Eisentraut
>>> wrote:
>>>> Here is a patch to implement
her in logical
decoding and publish it as an update operation. Otherwise, wrong things
happen. For example, what happens to a publication that is configured
to only publish inserts? What happens to update triggers on the
receiving table? What if the subscriber side is partitioned differe
On Wed, Feb 7, 2018 at 7:02 PM, Peter Geoghegan wrote:
> On Wed, Feb 7, 2018 at 4:41 PM, Tom Lane wrote:
>> Peter Geoghegan writes:
>>> It would be nice to get an opinion on this mode_final() + tuplesort
>>> memory lifetime business from you, Tom.
>>
&g
tcpip openssl slapd'
Then you could combine that with the actual build configuration to skip
tests that the build doesn't support.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2/12/18 21:58, Masahiko Sawada wrote:
> Attached a patch for fixing $subject.
>
> s/funcion/function/
fixed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
quot; RETURNS ");
> + print_function_rettype(&buf, proctup);
> + appendStringInfoChar(&buf, '\n');
> + }
> Could you use a separate boolean variable which is set as
> OidIsValid(prorettype), say called isfunction?
done
> Should the documentation of pg_function_is_visible also mention
> procedures?
done
and committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
I wonder how others feel about this, but the spelling of
enable_partition_wise_join feels funny to me every time I look at it. I
would write it enable_partitionwise_join.
Thoughts?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA
A small patch to tweak the tests to support output differences with
Python 3.7 (currently in beta).
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 543840cbe29653c18cce8d1ab4af4daac5c4899b Mon Sep 17 00:0
plpython_transaction test and plpython check passes.
OK, can you get some kind of stack trace or other debugging information?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
table, for the PK on the partition I get
conislocal = false, coninhcount = 1, connoinherit = true
The last part is confusing to me.
I don't know if that's really on this patch. But perhaps it could be
documented better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreS
krb5-server, or
perhaps krb5-user and krb5-kdc.
(If it appears to hang for you in the "setting up Kerberos" step, you
might need more entropy/wait a while. That problem appears to be
limited to some virtual machine setups, but the specifics are not clear.)
--
Peter Eisentraut
ialized]
>>> lts->nBlocksAllocated = lt->offsetBlockNumber + tapeblocks;
>
> FWIW, I'm not seeing that. What compiler are you using exactly?
This warning comes from using -Og instead of -O2.
It's the only such warning, so it would be nice to silence it, because
using
On 2/13/18 21:45, Michael Paquier wrote:
> On Tue, Feb 13, 2018 at 04:17:13PM -0500, Peter Eisentraut wrote:
>> A small patch to tweak the tests to support output differences with
>> Python 3.7 (currently in beta).
>
> Wouldn't it be better to wait for the version to be
uot; technique only when "_Static_assert" is
unavailable.
PSA.
Kind Regards,
---
Peter Smith
Fujitsu Australia
ct_asserts_StaticAssertDecl_3.patch
Description: ct_asserts_StaticAssertDecl_3.patch
Regards,
---
Peter Smith
Fujitsu Australia
p;UnBlockSig);
+ pg_usleep(100L);
+ PG_SETMASK(&BlockSig);
+ primary_sysid = strtoull(walrcv_identify_system(wrconn,
&primaryTLI), NULL, 10);
No more strtol with base 10 stuff please :)
Hmm, why not? What's the replacement?
--
Peter Eisentraut http://www.2ndQuad
ting PG_TRY infrastructure if the source code were like
PG_TRY();
{
...
}
PG_FINALLY();
{
...
}
PG_END_TRY();
Here is a new implementation that works just like that.
--
Peter Eisentraut http:/
This patch adds const qualifiers to internal range type APIs. It
doesn't require any new casts or remove any old ones.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Serv
ate. But
> I'd like you to take a look on the README patch first.
Thank you for working on this.
I am flying back to the USA today, and will try to take a look at what
you came up with on the way. I will definitely have some feedback in
the next few days.
--
Peter Geoghegan
2201 - 2300 of 10770 matches
Mail list logo
