On 2/13/18 03:57, Michael Paquier wrote:
> On Mon, Feb 12, 2018 at 03:19:27PM -0500, Tom Lane wrote:
>> I've not read in detail, but it looks reasonable offhand, modulo
>> that I still don't like prorettype == 0 ;-).
>>
>> I did notice a tiny typo:
>>
>> - * with. Hence prefer "$function$", but extend if needed.
>> + * with. Hence prefer "$function$"/"$procedure", but extend if needed.
>>
>> I think you want
>>
>> + * with. Hence prefer "$function$"/"$procedure$", but extend if needed.
done
> 0001 and 0002 are welcome. I have a small comment on top of Tom's for 0003.
>
> + appendStringInfoString(&buf, ")\n");
> + if (proc->prorettype)
> + {
> + appendStringInfoString(&buf, " RETURNS ");
> + print_function_rettype(&buf, proctup);
> + appendStringInfoChar(&buf, '\n');
> + }
> Could you use a separate boolean variable which is set as
> OidIsValid(prorettype), say called isfunction?
done
> Should the documentation of pg_function_is_visible also mention
> procedures?
done
and committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
