On Fri, Sep 6, 2019 at 7:02 AM Alvaro Herrera from 2ndQuadrant
wrote:
> Peter, Heikki, are you going to do [at least] one more round of
> design/functional review?
I didn't plan on it, but somebody probably should. Are you offering to
commit the patch? If not, I can take care of it.
ezfuvaymunop3nyrvvrh2up2tstk8sxvapderf8p...@mail.gmail.com
>
> To answer Magnus' question in that thread, the Mingw headers on jacana
> declare the function with WINBASEAPI which in turn is defined as
> DECLSPEC_IMPORT, as long as _KERNEL32_ isn't defined, and we don't do
&g
On Fri, Sep 6, 2019 at 2:35 PM Alvaro Herrera from 2ndQuadrant
wrote:
> I'd welcome it more if you did it; thanks.
I'll take care of it, then.
--
Peter Geoghegan
On Fri, Sep 6, 2019 at 3:22 PM Peter Geoghegan wrote:
> I'll take care of it, then.
Attached is v10, which has some comment and style fix-ups, including
the stuff Alvaro mentioned. It also adds line pointer sanitization to
match what I added to verify_nbtree.c in commit a9ce839a (we use
ing to get worse, not better, as time goes on, so I think we really
> should back-patch 7291733ac into all active branches.
OK with me.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
sts for that.
I committed this patch with some cosmetic changes and documentation updates.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
AIN; -- error
> SHOW transaction_read_only;
>
> makes more sense with READ ONLY because default_transaction_read_only is
> off at this point.
Oh you're right. Fixed.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
things up for non-msys2 environments, we
could also set MSYS2_ARG_CONV_EXCL instead; see
<https://github.com/msys2/msys2/wiki/Porting#filesystem-namespaces>.
According to that page, that would seem to be the more proper way to do it.
--
Peter Eisentraut http://www.2ndQuadrant.c
y command to
target with progress reporting infrastructure. I think that it's okay
to redefine how progress reporting works with CLUSTER now, in order to
fix the REINDEX/CLUSTER state clobbering bug.
--
Peter Geoghegan
that the "prove" program calls that installation instead of the system
one. (I just manually edited the shebang line. There is probably a
proper way to do it.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Suppo
cremental deduplication within
_bt_dedup_one_page(). The WAL logging is the the hard part, so let's
focus on that rather than worrying too much about whether or not
incrementally doing all the work (not just the WAL logging) makes
sense. It's still too early to be sure about whether or not that's a
good idea.
--
Peter Geoghegan
nbtree_wal_test.sql
Description: Binary data
l now. I will debug this myself in a few days,
though you may prefer to do it before then.
--
Peter Geoghegan
#x27;s
not expected to happen very often, and hopefully the next VACUUM will clean
it up.
"""
Why is this not a problem for the new amcheck checks? Maybe this is a
very naive question. I don't claim to be a GiST expert.
--
Peter Geoghegan
On Wed, Sep 11, 2019 at 3:09 PM Peter Geoghegan wrote:
> Hmm. So v12 seems to have some problems with the WAL logging for
> posting list splits. With wal_debug = on and
> wal_consistency_checking='all', I can get a replica to fail
> consistency checking very quickly when
The patch has been committed already.
Peter Geoghegan
(Sent from my phone)
On Wed, Sep 11, 2019 at 7:10 PM Peter Geoghegan wrote:
> The patch has been committed already.
Oh, wait. It hasn't. Andrey didn't create a new thread for his largely
independent patch, so I incorrectly assumed he created a CF entry for
his original bugfix.
--
Peter Geoghegan
? Does that work, or could it? For
example, do you see the message in French?
--
Peter Geoghegan
On Thu, Sep 12, 2019 at 11:30 AM Peter Geoghegan wrote:
> I wonder if it's possible to display a localized version of the
> display string in the NOTICE message? Does that work, or could it? For
> example, do you see the message in French?
BTW, I already know for sure that ICU supp
the variable assignments in a makefile
outside a rule or outside a makefile.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
edia.org/wiki/ISO_3166-2:CS#Codes_deleted_in_Newsletter_I-8
--
Peter Geoghegan
ment says con1 but the subsequent
dynamic statement says con2, and as a result of that, con1 is used.
This is not intuitive, I'd say, but given that there is no indication of
where this statement came from or whose idea it follows, it's unclear
how to evaluate that.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
The ecpglib major version (SO_MAJOR_VERSION) was changed in
bd7c95f0c1a38becffceb3ea7234d57167f6d4bf (Add DECLARE STATEMENT support
to ECPG.), but I don't see anything in that patch that would warrant
that. I think we should undo that change.
--
Peter Eisentraut http:
t; And I struggle to explain the reason of this.
> Do you understand what can cause the difference?
I imagine that the additional WAL volume triggered a checkpoint
earlier than in the more favorable test, which indirectly triggered
more FPIs, which contributed to triggering a checkpoint even
earlier...and so on. Synthetic test cases can avoid this. A useful
synthetic test should have no checkpoints at all, so that we can see
the broken down costs, without any second order effects that add more
cost in weird ways.
--
Peter Geoghegan
nconsistency in leakproof markings in v12
> is annoying but it's not a regression or security hazard, so
> I'm thinking it's not worth a late catversion bump to fix.
Sounds good, unless we do another catversion bump.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
I don't find this patch in any commit fest. Seems like a good addition.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
to whether equality clauses
> deduced from equivalence classes will work for them (nope, not any
> more). People using such indexes are just about certain to be
> bitterly unhappy.
Would it help if one created COLLATE "C" indexes instead of
text_pattern_ops? What are the
, so we would probably want the OpenSSH implementation
as a fallback anyway.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-09-09 14:24, Magnus Hagander wrote:
> On Sat, Sep 7, 2019 at 4:58 AM Michael Paquier <mailto:mich...@paquier.xyz>> wrote:
>
> On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote:
> > I'm not sure exactly what the upstream of mingw is th
ch is a
separate item later). This group of items could use a reshuffling.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-08-08 08:46, Mark G wrote:
> Please find attached a trivial patch making a few arrays const (in
> addition to the data they point to).
committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
gt; built with OpenLDAP vs. other LDAP libs.
I suppose it's not-Windows vs. Windows.
It's OK if we mention OpenLDAP in the release notes, but it doesn't seem
to belong in the major features section.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ial part of the
problem. "brew install perl" is probably faster than writing out this
email. But I suppose everyone has their own workflows.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
gt;
> I'm not sure I understand why that problem is a blocker for this patch.
I tried to analyze the spec for what the behavior should be here, but I
got totally lost. I'll give it another look.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
f you add a new entry, remember to ..."
* "When modifying this enum, update the table in ..."
* "Display names for enums in ..."
* etc.
But comments can be accidentally overlooked, so adding the compile-time asserts
can help eliminate human error.
Please refer to the attach
uests are always dubious because just because
Sybase behaves this way for some implementation or architectural reason
doesn't necessarily mean it makes sense for PostgreSQL too.
Why do you need to turn off replication when there is "maintenance" on a
table? What does that even mea
On 2019-09-17 22:22, Tom Lane wrote:
> Peter Eisentraut writes:
>> * Add GSSAPI encryption support (Robbie Harwood, Stephen Frost)
>> This allows TCP/IP connections to be encrypted when using GSSAPI
>> authentication without having to set up a separate encryption facility
On 2019-06-06 11:08, Masahiko Sawada wrote:
> On Tue, Apr 9, 2019 at 9:01 PM Christoph Berg wrote:
>>
>> Re: Peter Eisentraut 2019-04-09
>>
>>> I'm okay with changing it. As you indicate, I chose the name so that it
>>> doesn't look like a li
e comment block I just moved over for the time being. It should
probably be rephrased a bit.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 3b1f52e5292303cba8804ae1f6676973ef903ec0 Mon Sep 17 00:00:00 2001
hared_buffers (i.e. don't use a temp
buffer page) could pay off. As I went into at the start of this
e-mail, unnecessarily doing expensive things like copying large
posting lists around is a real concern. Even if it isn't truly useful
for _bt_dedup_one_page() to operate in a very incremental fashion,
incrementalism is probably still a good thing to aim for -- it seems
to make deduplication faster in all cases.
--
Peter Geoghegan
On Wed, Sep 18, 2019 at 10:43 AM Peter Geoghegan wrote:
> This also suggests that making _bt_dedup_one_page() do raw page adds
> and page deletes to the page in shared_buffers (i.e. don't use a temp
> buffer page) could pay off. As I went into at the start of this
> e-mail, un
it to
the next commit fest.
Kind Regards,
---
Peter Smith
Fujitsu Australia
add_more_ct_asserts.patch
Description: add_more_ct_asserts.patch
AssertDecl nearby the
array that it is asserting (e.g. just like relpath.c)
Kind Regards,
Peter Smith
---
Fujitsu Australia
add_more_ct_asserts_StaticAssertDecl.patch
Description: add_more_ct_asserts_StaticAssertDecl.patch
On 2019-09-16 15:41, Tom Lane wrote:
> Peter Eisentraut writes:
>> The ecpglib major version (SO_MAJOR_VERSION) was changed in
>> bd7c95f0c1a38becffceb3ea7234d57167f6d4bf (Add DECLARE STATEMENT support
>> to ECPG.), but I don't see anything in that patch that would wa
are features proposed for PG13, not in PG12.
So while this is an important discussion, it's not relevant to the PG12
release, right?
(If so, I'm content to close these open items.)
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-09-21 22:30, Tom Lane wrote:
> I wrote:
>> Peter Eisentraut writes:
>>>> Here is a draft patch.
>
>> Where are we on pushing that? I'm starting to get antsy about the
>> amount of time remaining before rc1. It's a low-risk fix, but still
On Mon, Sep 23, 2019 at 5:13 PM Peter Geoghegan wrote:
> I attach version 17.
I attach a patch that applies on top of v17. It adds support for
deduplication within unique indexes. Actually, this is a snippet of
code that appeared in my prototype from August 5 (we need very little
extra code
rst, then details of the contained mini-language.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
e, but if there is nothing
> to clean up, why should that be an error condition?
The alternatives seem quite error prone to me. Better be explicit.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
1_VERSION
That's not actually what this file looks like in the upstream release.
It looks like the packagers must have patched in the protocol codes for
TLS 1.1 and 1.2 themselves. Then they should also add the corresponding
SSL_OP_NO_* flags. AFAICT, these pairs of symbols are always a
in principle, if it's safe"?
Or, do we store both pieces of information together, and forbid
setting the storage parameter to on when it's known to be unsafe for
the underlying opclasses used by the index? I don't know.
I think that you can start working on this without knowing
On 2019-09-25 16:46, Liudmila Mantrova wrote:
> On 9/25/19 12:08 AM, Peter Eisentraut wrote:
>> On 2019-09-23 00:03, Tom Lane wrote:
>>> While we're whining about this, I find it very off-putting that
>>> the jsonpath stuff was inserted in the JSON functions sect
4 2018
Deprecate TLS_MAX_VERSION, DTLS_MAX_VERSION and DTLS_MIN_VERSION
Fixes: #7183
Reviewed-by: Matt Caswell
GH: #7260
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
Here is my proposed patch, currently completely untested.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
>From 35324dbe908a779c9d84b438cb54328cfd74e403 Mon Sep 17 00:00:00 2001
From: Peter Eisentraut
Da
e CASCADE/RESTRICT in DROP DATABASE.)
The WITH here seems weird to me. Why not leave it out?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
prior versions with standy_mode=on.
Or maybe we should move recovery_target_timeline to a different section?
But which one?
I don't know if recovery_target_timeline is actually useful to change in
standby mode.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Devel
derstand the code changes, and I think this
could use more and better comments. In particular, I wonder about
off *= 2;
This is new logic that isn't explained anywhere.
This whole function is commented a bit strangely. It begins with
"Otherwise", but there is nothing before it.
Yes, it seems OK to clean this up in master.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
d add a newline before the comment block as well.
ok
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-09-26 23:02, David Steele wrote:
> On 9/26/19 4:48 PM, Peter Eisentraut wrote:
>> On 2019-09-25 22:21, David Steele wrote:
>>> While testing against PG12 I noticed the documentation states that
>>> recovery targets are not valid when standby.signal is pres
s somewhat different
> between versions.
Can you bisect this? I have traced through xlog.c in both versions and
I don't see how this logic is any different in any obvious way.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
not to
> unset PGDATABASE unconditionally, let's try that and see how it
> goes.
It would be nice to get this fixed. Several people have been confused
by it at this point.
--
Peter Geoghegan
On Fri, Sep 27, 2019 at 2:39 PM Tom Lane wrote:
> I think I just forgot about this thread. Shall we change it in HEAD
> and see what happens? Maybe backpatch, but not till after 12.0 is out.
Please do.
--
Peter Geoghegan
> I recall there was another thread, but didn't manage to find it.
The thread is here:
https://www.postgresql.org/message-id/flat/cah2-wzn3ee49gmxb7v1vj3-ac8fwn-fr8pfwqebhe8ryrxt...@mail.gmail.com
--
Peter Geoghegan
nsets is very much smaller than the set that libpq
> reacts to --- we have added a ton of the latter without touching this
> list (much less the three or four other places that duplicate it).
> I wonder how problematic that is.
Only time will tell, I suspect.
--
Peter Geoghegan
tup
fun:ServerLoop
fun:PostmasterMain
fun:main
}
""""""
I suspect that the recent commit 69f94108 is involved here, but I
haven't confirmed that explanation myself.
--
Peter Geoghegan
On 2019-09-27 16:20, Michael Paquier wrote:
> On Fri, Sep 27, 2019 at 03:50:57PM +0200, Peter Eisentraut wrote:
>> On 2019-09-27 03:51, Michael Paquier wrote:
>>> Your patch does not issue a ereport(LOG/FATAL) in the event of a
>>> failure with SSL_CTX_set_max_proto_ve
re recovery target settings when not in archive recovery (meaning
+* we are in crash recovery).
+*/
+ if (!InArchiveRecovery)
+ return false;
+
info = XLogRecGetInfo(record) & ~XLR_INFO_MASK;
rmid = XLogRecGetRmid(record);
--
Peter Eis
aking a top-down approach that applies
general rules (e.g. you can only do lock coupling left to right, or
bottom to top in nbtree). Anything less than that should be assumed to
be wrong on general principle.
--
Peter Geoghegan
On 2019-09-27 17:14, David Steele wrote:
> On 9/27/19 10:36 AM, Peter Eisentraut wrote:
>> On 2019-09-26 23:02, David Steele wrote:
>>> On 9/26/19 4:48 PM, Peter Eisentraut wrote:
>>>
>>>> I don't know if recovery_target_timeline is actually useful t
On 2019-09-27 20:30, Justin Pryzby wrote:
> https://www.postgresql.org/docs/12/release-12.html
>
> |Allow modifications of system catalogs' options using ALTER TABLE (Peter
> Eisentraut)
> |Modifications of catalogs' reloptions and autovacuum settings are now
> supp
true though ArchiveRecoveryRequested is
> false because recovery.signal is missing.
>
> With the attached patch, I checked that the steps that I described
> upthread didn't reproduce the issue.
Your patch looks correct to me.
--
Peter Eisentraut http://www.2ndQuadran
On 2019-09-27 17:50, Alvaro Herrera wrote:
> On 2019-Sep-13, Alvaro Herrera wrote:
>
>> On 2019-Aug-20, Peter Eisentraut wrote:
>>
>>> The memory management of that seems too complicated. The "extra"
>>> mechanism of the check/assign hooks only
anup() is concerned with pending list pages.
> BTW we found a small bug (wraparound) in similar GiST and B-tree
> implementations.
> Probably, it's there in GIN too.
Probably, but that's much less of a problem to me.
--
Peter Geoghegan
ack to the standard AC_STRUCT_TIMEZONE
macro and do some related cleanup.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From 78597561e3f8e9119d6fd07e4106cc780e58507b Mon Sep 17 00:00:00 2001
From: Peter Eisentr
ular, I believe patch I've posted in this thread
> makes situation better not worse. That is it fixes one bug without
> introducing mode bugs. But I'm going to analyze more on this and
> document GIN concurrency better in the README. Probably, I'll spot
> more details.
Thanks.
--
Peter Geoghegan
eliminating that
factor (i.e. while setting fastupdate to off)?
Chen's example involved an INSERT that deadlocked against VACUUM --
not a SELECT. Is this just a coincidence?
--
Peter Geoghegan
a string literal used to initialize an array of known
size than there are elements in the array,
the remainder of the aggregate shall be initialized implicitly the same as
objects that have static storage duration
~
Please refer to the attached patch.
Kind Regards,
---
Peter Smith
Fujitsu
hange the bool initialisers to {false} if that becomes
a committer review issue.
Kind Regards
--
Peter Smith
Fujitsu Australia
From: Amit Kapila Sent: Tuesday, 1 October 2019 8:12
PM
> +1. This seems like an improvement. I can review and take this forward
> unless there are objections from others.
FYI - I created a Commitfest entry for this here:
https://commitfest.postgresql.org/25/2290/
Kind Regards
--
On 2019-09-30 21:36, Tom Lane wrote:
> Peter Eisentraut writes:
>> Instead of AC_STRUCT_TIMEZONE we use our own variant called
>> PGAC_STRUCT_TIMEZONE that checks for tzname even if other variants were
>> found first. But since 63bd0db12199c5df043e1dea0f2b574f622b3a4c w
updated patch.
Kind Regards
--
Peter Smith
Fujitsu Australia
c99_init_nulls_2.patch
Description: c99_init_nulls_2.patch
On Mon, Sep 30, 2019 at 7:39 PM Peter Geoghegan wrote:
> I've found that my "regular pgbench, but with a low cardinality index
> on pgbench_accounts(abalance)" benchmark works best with the specific
> heuristics used in the patch, especially over many hours.
I
nothing.
In the patch, I would skip the configure test and just do
#ifdef __GLIBC__
directly.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
os for these
partial initialisers.
Please see attachment.
Kind Regards
---
Peter Smith
Fujitsu Australia
c99_init_nulls_3.patch
Description: c99_init_nulls_3.patch
deal with.
It is what some other database systems do. Perhaps some others don't.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
define INIT_ALL_ELEMS_FALSE{false}
Kind Regards
--
Peter Smith
Fujitsu Australia
objects that have
static storage duration
*/
#define INIT_ALL_ELEMS_ZERO {0}
#define INIT_ALL_ELEMS_FALSE{false}
~~
Kind Regards,
--
Peter Smith
Fujitsu Australia
tly, such as in pg_ctl.c and win32_port.h,
leading to some compiler warnings. This should now be handled better.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
From d93b420940fe162e833d2008c681f6403d9e7b7b Mon
rt negative availMem sizes --
when huge allocations were first supported, tuplesort.c briefly used
"Size", which didn't work. Perhaps it had something to do with that.
--
Peter Geoghegan
On 2019-10-02 07:30, Peter Eisentraut wrote:
> On 2019-09-30 21:36, Tom Lane wrote:
>> Peter Eisentraut writes:
>>> Instead of AC_STRUCT_TIMEZONE we use our own variant called
>>> PGAC_STRUCT_TIMEZONE that checks for tzname even if other variants were
computed after BEFORE triggers.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
reason. But as Tom writes
nearby, it should be a straight wrapper around Assert, not elog. So
these need to be named separately.
Btw., JUnit uses the ordering convention assertEquals(expected, actual),
whereas Perl Test::More uses is(actual, expected). Let's make sure we
pick something a
On 2019-10-07 19:57, Tom Lane wrote:
> I'd just put them all in c.h. I see no reason why a new header
> is helpful.
Assert stuff is already in there, but surely stuff that calls elog()
doesn't belong in there?
--
Peter Eisentraut http://www.2ndQuadrant.com/
Postgr
list, or if we have a full row and memory is getting
* full.
- *
- * XXX using up maintenance_work_mem here is probably unreasonably
- * much, since vacuum might already be using that much.
*/
ISTM that the use of maintenance_work_mem wasn't given that much
thought originally.
--
Peter Geoghegan
attached the updated patch, which now has just 1 macro.
Kind Regards
--
Peter Smith
Fujitsu Australia
c99_init_nulls_4.patch
Description: c99_init_nulls_4.patch
On 2019-10-07 08:52, Michael Paquier wrote:
> On Fri, Oct 04, 2019 at 04:35:59PM +0200, Peter Eisentraut wrote:
>> As of d9dd406fe281d22d5238d3c26a7182543c711e74, we require MSVC 2013,
>> which means _MSC_VER >= 1800. This means that conditionals about
>> older versions of
)", I prefer f(actual, expected). CUnit
> uses CU_ASSERT_EQUAL(actual, expected).
Yes, that seems to be the dominating order outside of JUnit.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
e patch, I would skip the configure test and just do
>>
>> #ifdef __GLIBC__
>>
>> directly.
>
> Ok. Here's one like that.
Pushed that.
> Also, a WIP patch for FreeBSD.
That looks promising.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 2019-10-09 21:19, Peter Eisentraut wrote:
> On 2019-10-03 14:25, Thomas Munro wrote:
>>> The only open question on this patch was whether it's a good version to
>>> use. I think based on subsequent discussions, there was the realization
>>> that this is
to handle archive_cleanup_command? Perhaps not.
A check in recoveryApplyDelay() might be necessary.
That should cover everything then.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
1601 - 1700 of 10763 matches
Mail list logo
