On 2019-09-09 14:24, Magnus Hagander wrote: > On Sat, Sep 7, 2019 at 4:58 AM Michael Paquier <mich...@paquier.xyz > <mailto:mich...@paquier.xyz>> wrote: > > On Sat, Sep 07, 2019 at 12:11:25AM +0200, Peter Eisentraut wrote: > > I'm not sure exactly what the upstream of mingw is these days, but I > > think the original issue that led to 811be893 has long been fixed [0], > > and the other stuff in mingwcompat.c is also no longer relevant > [1]. I > > think mingwcompat.c could be removed altogether. I'm not sure to what > > extent we need to support 5+ year old mingw versions. > > On HEAD I would not be against removing that as this leads to a > cleanup of our code. For MSVC, we only support VS 2013~ on HEAD, so > saying that we don't support MinGW older than what was proposed 5 > years ago sounds sensible. > > +1, definitely.
committed -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
