On 2019-09-09 17:18, Andres Freund wrote: > I think all this implementation actually guarantees is that bzero2 is > read, but not that the copy is not elided. In practice that's *probably* > good enough, but a compiler could just check whether bzero_p points to > memset.
Are you saying that the replacement implementation we provide is not good enough? If so, I'm happy to look at alternatives. But that's the design from OpenSSH, so if that is wrong, then there are bigger problems. We could also take the OpenBSD implementation, but that has a GCC-ish dependency, so we would probably want the OpenSSH implementation as a fallback anyway. -- Peter Eisentraut http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
