Re: First-draft release notes for back branches are up

2019-05-06 Thread Jonathan S. Katz
On 5/5/19 12:24 AM, Thomas Munro wrote: > On Sun, May 5, 2019 at 2:35 PM Jonathan S. Katz wrote: >> On 5/3/19 6:29 PM, Tom Lane wrote: >>> See >>> >>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=8b3bce2017b15e05f000c3c5947653a3e2c5a29f &g

Re: PG 12 draft release notes

2019-05-12 Thread Jonathan S. Katz
Hi Bruce, On 5/11/19 4:33 PM, Bruce Momjian wrote: > I have posted a draft copy of the PG 12 release notes here: > > http://momjian.us/pgsql_docs/release-12.html > > They are committed to git. It includes links to the main docs, where > appropriate. Our official developer docs will rebui

PostgreSQL 12 Beta 1 press release draft

2019-05-21 Thread Jonathan S. Katz
Hi, Attached is a draft of the PG12 Beta 1 press release that is going out this Thursday. The primary goals of this release announcement are to introduce new features, enhancements, and changes that are available in PG12, as well as encourage our users to test and provide feedback to help ensure t

Re: PostgreSQL 12 Beta 1 press release draft

2019-05-22 Thread Jonathan S. Katz
On 5/21/19 11:39 PM, Jonathan S. Katz wrote: > Hi, > > Attached is a draft of the PG12 Beta 1 press release that is going out > this Thursday. The primary goals of this release announcement are to > introduce new features, enhancements, and changes that are available in >

Re: PostgreSQL 12 Beta 1 press release draft

2019-05-22 Thread Jonathan S. Katz
Hi Ilmari, On 5/22/19 6:52 PM, Dagfinn Ilmari Mannsåker wrote: > Hi Jonathan, > > "Jonathan S. Katz" writes: > >> If you have additional feedback please provide it before 7am EDT >> tomorrow. > > Thanks for writing this up. Below are some things I no

Re: PostgreSQL 12 Beta 1 press release draft

2019-05-23 Thread Jonathan S. Katz
On 5/23/19 1:45 AM, David Rowley wrote: > On Thu, 23 May 2019 at 15:31, Jonathan S. Katz wrote: >> Attached is >> v3 of the patch, along with a diff. > > Minor details, but this query is not valid: > >> WITH c AS MATERIALIZED ( >> SELECT * FROM a WHERE a.

Re: initdb recommendations

2019-05-23 Thread Jonathan S. Katz
On 5/23/19 12:54 PM, Peter Eisentraut wrote: > On 2019-04-06 20:08, Noah Misch wrote: I think we should just change the defaults. There is a risk of warning fatigue. initdb does warn about this, so anyone who cared could have gotten the information. >>> >>> I've been suggestin

Re: initdb recommendations

2019-05-23 Thread Jonathan S. Katz
On 5/23/19 6:47 PM, Jonathan S. Katz wrote: > On 5/23/19 12:54 PM, Peter Eisentraut wrote: >> On 2019-04-06 20:08, Noah Misch wrote: >>>>> I think we should just change the defaults. There is a risk of warning >>>>> fatigue. initdb does warn abo

Re: initdb recommendations

2019-05-24 Thread Jonathan S. Katz
On 5/24/19 8:33 AM, Stephen Frost wrote: > Greetings, > > * Magnus Hagander (mag...@hagander.net) wrote: >> The thing that will potentially hit *end users* is when the RPMs, DEBs or >> Windows Installers switch to SCRAM (because of clients with older drivers). > > Agreed. I'm not sure that our c

Re: initdb recommendations

2019-05-24 Thread Jonathan S. Katz
On 5/24/19 9:01 AM, Stephen Frost wrote: > Greetings, > > * Jonathan S. Katz (jk...@postgresql.org) wrote: >> On 5/24/19 8:33 AM, Stephen Frost wrote: >>> We need to provide better documentation about how to get from md5 to >>> SCRAM, in my view. I'm no

Re: initdb recommendations

2019-05-24 Thread Jonathan S. Katz
On 5/24/19 9:49 AM, Heikki Linnakangas wrote: > On 24/05/2019 16:01, Stephen Frost wrote: >> What I was really getting at though was the ability to have multiple >> authenticator tokens active concurrently (eg: md5 AND SCRAM), with an >> ability to use either one (idk, md5_or_scram auth method?), a

Re: initdb recommendations

2019-05-24 Thread Jonathan S. Katz
On 5/24/19 10:26 AM, Heikki Linnakangas wrote: > On 24/05/2019 17:02, Jonathan S. Katz wrote: >> On 5/24/19 9:49 AM, Heikki Linnakangas wrote: >>> It just prevents MD5 authentication in case a user forces a >>> new MD5 hash into the system e.g. by changing password_encry

Re: Segfault when creating partition with a primary key and sql_drop trigger exists

2018-10-04 Thread Jonathan S. Katz
On 10/4/18 8:34 PM, Michael Paquier wrote: > On Thu, Oct 04, 2018 at 04:54:45PM -0700, Andres Freund wrote: >> Are you suggesting we fix after RC1, or delay RC1? I'm not 100% sure >> I'm parsing your sentence correctly. > > I am suggesting to fix the issue after RC1 is released, but before GA. T

Re: Postgres 11 release notes

2018-10-05 Thread Jonathan S. Katz
p using the >> equivalent of "for the data that does not match any other partition". > > Yeah, "any other partition" is what the existing description uses too, so: > > Having a "default" partition for storing data that does not match any > other p

Re: Segfault when creating partition with a primary key and sql_drop trigger exists

2018-10-05 Thread Jonathan S. Katz
On 10/4/18 11:37 PM, Tom Lane wrote: > "Jonathan S. Katz" writes: >> On 10/4/18 8:34 PM, Michael Paquier wrote: >>> I am suggesting to fix the issue after RC1 is released, but before GA. > >> That approach would mean we would require an RC2, which would f

Re: Segfault when creating partition with a primary key and sql_drop trigger exists

2018-10-05 Thread Jonathan S. Katz
On 10/5/18 3:35 PM, Andres Freund wrote: > Hi, > > On 2018-10-05 15:31:37 -0400, Jonathan S. Katz wrote: >> On 10/4/18 11:37 PM, Tom Lane wrote: >>> "Jonathan S. Katz" writes: >>>> On 10/4/18 8:34 PM, Michael Paquier wrote: >>>>> I am

Re: Postgres 11 release notes

2018-10-05 Thread Jonathan S. Katz
On 10/5/18 5:22 PM, Bruce Momjian wrote: > On Fri, Oct 5, 2018 at 03:28:41PM -0400, Jonathan Katz wrote: >> On 9/27/18 9:21 PM, Amit Langote wrote: >>> Yeah, "any other partition" is what the existing description uses too, so: >>> >>> Having a "default" partition for storing data that does not mat

Re: fine tune v11 release notes

2018-10-13 Thread Jonathan S. Katz
nks! Jonathan From eaf42cd9f014a2420339afbd89be2e5f35cf49e7 Mon Sep 17 00:00:00 2001 From: "Jonathan S. Katz" Date: Sat, 13 Oct 2018 15:38:18 -0400 Subject: [PATCH 1/2] Updates to CREATE INDEX documentation. Includes clarifications on new functionality availability in PostgreSQL 11, as

Re: fine tune v11 release notes

2018-10-13 Thread Jonathan S. Katz
On 10/13/18 4:38 PM, Justin Pryzby wrote: > On Sat, Oct 13, 2018 at 04:34:07PM -0400, Tom Lane wrote: >> "Jonathan S. Katz" writes: >>> On 10/6/18 9:42 AM, Justin Pryzby wrote: >>>> Find below various fixes to release notes for v11, for discussion purposes.

Re: PostgreSQL 11 RC1 + GA Dates

2018-10-15 Thread Jonathan S. Katz
On 10/15/18 1:46 AM, Sandeep Thakkar wrote: > Hi, > > On Tue, Oct 2, 2018 at 7:28 PM Jonathan S. Katz <mailto:jk...@postgresql.org>> wrote: > > Hi, > > Based on the current status of the open items and where we are at in the > release cycle, the dat

Re: First-draft release notes for back-branch releases

2018-11-05 Thread Jonathan S. Katz
On 11/2/18 8:14 PM, Tom Lane wrote: > I've made a pass over the commit log up to now, and prepared draft > release note entries for everything that seemed worth documenting; > see > > https://git.postgresql.org/gitweb/?p=postgresql.git;a=commitdiff;h=65a82a7649860f8010db581a0d1f12aa92f5969b > > A

Re: First-draft release notes for back-branch releases

2018-11-05 Thread Jonathan S. Katz
On 11/5/18 9:58 PM, Amit Langote wrote: > On 2018/11/06 11:25, Noah Misch wrote: >> On Mon, Nov 05, 2018 at 04:01:59PM -0500, Jonathan S. Katz wrote: >>> Attached is a draft of the press release for review. Please let me know >>> if there are any corrections/sugge

Re: First-draft release notes for back-branch releases

2018-11-06 Thread Jonathan S. Katz
On 11/5/18 11:10 PM, Amit Langote wrote: > Hi, > > On 2018/11/06 12:49, Jonathan S. Katz wrote: >> >> I still feel inclined to elaborate on the "Prevent creation of a >> partition in a trigger attached to its parent table" but perhaps in >> future rele

Re: First-draft release notes for back-branch releases

2018-11-06 Thread Jonathan S. Katz
On 11/6/18 9:35 PM, Amit Langote wrote: > On 2018/11/07 11:28, Noah Misch wrote: >> On Mon, Nov 05, 2018 at 10:49:30PM -0500, Jonathan S. Katz wrote: >>> On 11/5/18 9:58 PM, Amit Langote wrote: >>>> On 2018/11/06 11:25, Noah Misch wrote: >>>>> On Mon,

Re: First-draft release notes for back-branch releases

2018-11-07 Thread Jonathan S. Katz
On 11/7/18 1:59 AM, Amit Langote wrote: > * Ensure that automatically created child indexes are created in the same Thanks, that is much clearer. I have made that update. Thanks again for your help! Jonathan 2018-11-08 Cumulative Update The PostgreSQL Global Develop

Re: heavily contended lwlocks with long wait queues scale badly

2024-01-11 Thread Jonathan S. Katz
On 1/10/24 10:45 PM, Michael Paquier wrote: On Wed, Jan 10, 2024 at 09:17:47PM -0600, Nathan Bossart wrote: Now that commit a4adc31 has had some time to bake and concerns about unintended consequences may have abated, I wanted to revive this back-patching discussion. I see a few possibly-relate

Re: heavily contended lwlocks with long wait queues scale badly

2024-01-16 Thread Jonathan S. Katz
On 1/16/24 1:11 AM, Michael Paquier wrote: On Thu, Jan 11, 2024 at 09:47:33AM -0500, Jonathan S. Katz wrote: I have similar data sources to Nathan/Michael and I'm trying to avoid piling on, but one case that's interesting occurred after a major version upgrade from PG10 to PG14 on

2024-02-08 release announcement draft

2024-02-05 Thread Jonathan S. Katz
Hi, Attached is a draft of the 2024-02-08 release announcement. Please review for accuracy and notable omissions. Please provide any feedback no later than 2024-02-08 12:00 UTC (and preferably sooner). Thanks, Jonathan The PostgreSQL Global Development Group has released an update to all s

Re: 2024-02-08 release announcement draft

2024-02-07 Thread Jonathan S. Katz
On 2/6/24 3:19 AM, jian he wrote: On Tue, Feb 6, 2024 at 12:43 PM Jonathan S. Katz wrote: Hi, Attached is a draft of the 2024-02-08 release announcement. Please review for accuracy and notable omissions. Please provide any feedback no later than 2024-02-08 12:00 UTC (and preferably sooner

Re: logical decoding and replication of sequences, take 2

2023-02-22 Thread Jonathan S. Katz
On 2/22/23 5:02 AM, Tomas Vondra wrote: On 2/22/23 03:28, Jonathan S. Katz wrote: Thanks for continuing to work on this patch! I tested the latest version and have some feedback/clarifications. Thanks! Also I should mention I've been testing with both async/sync logical replicati

Re: Raising the SCRAM iteration count

2023-02-22 Thread Jonathan S. Katz
On 2/22/23 8:39 AM, Daniel Gustafsson wrote: On 17 Dec 2022, at 04:27, Michael Paquier wrote: Superuser-only GUCs should be documented as such, or do you intend to make it user-settable like I suggested upthread :) ? I don't really have strong feelings, so I reverted to being user-settable

Re: logical decoding and replication of sequences, take 2

2023-02-26 Thread Jonathan S. Katz
On 2/23/23 7:56 AM, Tomas Vondra wrote: On 2/22/23 18:04, Jonathan S. Katz wrote: On 2/22/23 5:02 AM, Tomas Vondra wrote: Interestingly, in systems that tend to have higher rates of failover (I'm thinking of a few distributed systems), this may cause int4 sequences to exhaust nu

Re: Remove last traces of SCM credential auth from libpq?

2023-03-16 Thread Jonathan S. Katz
On 3/16/23 10:49 AM, Tom Lane wrote: Michael Paquier writes: libpq has kept some code related to the support of authentication with SCM credentials for some time now, code dead in the backend since 9.1. Wouldn't it be time to let it go and remove this code entirely, erroring in libpq if attemp

PostgreSQL 16 Release Management Team & Feature Freeze

2023-03-21 Thread Jonathan S. Katz
Hi, We are pleased to announce the Release Management Team (RMT) (cc'd) for the PostgreSQL 16 release: - Alvaro Herrera - Amit Kapila - Jonathan Katz You can find information about the responsibilities of the RMT here: https://wiki.postgresql.org/wiki/Release_Management_Team Addit

Re: PostgreSQL 16 Release Management Team & Feature Freeze

2023-03-21 Thread Jonathan S. Katz
On 3/21/23 1:17 PM, Roberto Mello wrote: On Tue, Mar 21, 2023 at 9:35 AM Jonathan S. Katz wrote: You can track open items for the PostgreSQL 16 release here: https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items The wiki page references April 8th, 2022, btw. Fixed :) Thanks

Re: User functions for building SCRAM secrets

2023-03-22 Thread Jonathan S. Katz
On 3/22/23 2:48 AM, Michael Paquier wrote: On Tue, Feb 14, 2023 at 06:16:18PM -0500, Jonathan S. Katz wrote: I opted for the approach in [2]. v5 contains the branching logic for the UTF8 only tests, and the corresponding output files. I tested locally on macOS against both UTF8 + C locales

Re: PostgreSQL 17 Release Management Team & Feature Freeze

2024-04-08 Thread Jonathan S. Katz
On 4/8/24 8:29 AM, Andres Freund wrote: Hi, On 2024-04-08 09:26:09 -0400, Robert Haas wrote: On Sun, Apr 7, 2024 at 6:50 PM Michael Paquier wrote: And maybe we need to think of a way to further mitigate this crush of last minute commits. e.g. In the last week, you can't have more feature commi

Re: Raising the SCRAM iteration count

2022-12-12 Thread Jonathan S. Katz
On 12/9/22 7:15 PM, Andres Freund wrote: Hi, On 2022-12-09 11:55:07 +0100, Daniel Gustafsson wrote: Our current hardcoded value for iteration count is 4096, which is based on a recommendation from RFC 7677. This is however the lower end of the scale, and is related to computing power in 2015 g

Re: Raising the SCRAM iteration count

2022-12-14 Thread Jonathan S. Katz
On 12/14/22 6:25 AM, Daniel Gustafsson wrote: On 14 Dec 2022, at 02:00, Michael Paquier wrote: On Tue, Dec 13, 2022 at 12:17:58PM +0100, Daniel Gustafsson wrote: It does raise an interesting point though, if we in the future add suppprt for SCRAM-SHA-512 (which seems reasonable to do) it's not

Re: Raising the SCRAM iteration count

2022-12-14 Thread Jonathan S. Katz
On 12/14/22 6:52 PM, Michael Paquier wrote: On Wed, Dec 14, 2022 at 01:59:04PM -0500, Jonathan S. Katz wrote: HA-256 that we will just need to pick up? The attached v2 has the GUC rename and a change to GUC_REPORT such that the frontend can use the real value rather than the default. I kept

Re: Refactor SCRAM code to dynamically handle hash type and key length

2022-12-19 Thread Jonathan S. Katz
On 12/16/22 10:08 PM, Michael Paquier wrote: On Thu, Dec 15, 2022 at 04:59:52AM +0900, Michael Paquier wrote: However, that's only half of the picture. The key length and the hash type (or just the hash type to know what's the digest/key length to use but that's more invasive) still need to be

Re: Refactor SCRAM code to dynamically handle hash type and key length

2022-12-20 Thread Jonathan S. Katz
On 12/20/22 2:25 AM, Michael Paquier wrote: On Tue, Dec 20, 2022 at 08:58:38AM +0900, Michael Paquier wrote: Thanks! I have applied for I have here.. There are other pieces to think about in this area. FYI, I have spent a few hours looking at the remaining parts of the SCRAM code that could

Re: Handle infinite recursion in logical replication setup

2023-01-09 Thread Jonathan S. Katz
On 9/12/22 1:23 AM, vignesh C wrote: On Fri, 9 Sept 2022 at 11:12, Amit Kapila wrote: On Thu, Sep 8, 2022 at 9:32 AM vignesh C wrote: The attached patch has the changes to handle the same. Pushed. I am not completely sure whether we want the remaining documentation patch in this thread

Re: Handle infinite recursion in logical replication setup

2023-01-10 Thread Jonathan S. Katz
On 1/10/23 10:17 AM, Amit Kapila wrote: On Tue, Jan 10, 2023 at 8:13 AM Jonathan S. Katz wrote: This consistently created the deadlock in my testing. Discussing with Masahiko off-list, this is due to a deadlock from 4 processes: the walsenders on A and B, and the apply workers on A and B

Re: Support logical replication of DDLs

2023-03-28 Thread Jonathan S. Katz
On 3/27/23 2:37 AM, Amit Kapila wrote: On Mon, Mar 27, 2023 at 2:52 AM Tom Lane wrote: And TBH, I don't think that I quite believe the premise in the first place. The whole point of using logical rather than physical replication is that the subscriber installation(s) aren't exactly like the

Re: Check whether binaries can be released for s390x

2023-04-04 Thread Jonathan S. Katz
Hi Namrata, On 4/4/23 8:56 AM, Namrata Bhave wrote: Hi, We are looking forward to get help from community on publishing s390x binaries. As per downloads page, apt repo supports Ubuntu on amd,arm,i386 and ppc64le. We had reached out earlier and are ready to provide infra if needed. Wanted t

Re: SQL/JSON revisited

2023-04-04 Thread Jonathan S. Katz
On 4/4/23 3:40 PM, Nikita Malakhov wrote: Hi hackers! The latest SQL standard contains dot notation for JSON. Are there any plans to include it into Pg 16? Or maybe we should start a separate thread for it? I would recommend starting a new thread to discuss the dot notation. Thanks, Jonath

Re: PostgreSQL 16 Release Management Team & Feature Freeze

2023-04-06 Thread Jonathan S. Katz
On 3/21/23 11:35 AM, Jonathan S. Katz wrote: Additionally, the RMT has set the feature freeze to be **April 8, 2023 at 0:00 AoE**[1]. This is the last time to commit features for PostgreSQL 16. In  other words, no new PostgreSQL 16 feature can be committed after April 8, 2023 at 0:00 AoE

Re: Minimal logical decoding on standbys

2023-04-07 Thread Jonathan S. Katz
On 4/8/23 12:01 AM, Andres Freund wrote: Hi, On 2023-04-08 09:15:05 +0530, Amit Kapila wrote: The new approach for invalidation looks clean. BTW, I see minor inconsistency in the following two error messages (errmsg): Thanks for checking. if (MyReplicationSlot->data.invalidated == RS_INVAL

Re: PostgreSQL 16 Release Management Team & Feature Freeze

2023-04-08 Thread Jonathan S. Katz
On 4/6/23 5:37 PM, Jonathan S. Katz wrote: On 3/21/23 11:35 AM, Jonathan S. Katz wrote: Additionally, the RMT has set the feature freeze to be **April 8, 2023 at 0:00 AoE**[1]. This is the last time to commit features for PostgreSQL 16. In  other words, no new PostgreSQL 16 feature can be

Re: Minimal logical decoding on standbys

2023-04-08 Thread Jonathan S. Katz
On 4/8/23 5:27 AM, Andres Freund wrote: Hi, On 2023-04-07 14:27:09 -0700, Andres Freund wrote: I think I'll push these in a few hours. While this needed more changes than I'd like shortly before the freeze, I think they're largely not in very interesting bits and pieces - and this feature has b

Re: When to drop src/tools/msvc support

2023-04-08 Thread Jonathan S. Katz
On 4/8/23 3:10 PM, Andres Freund wrote: Hi, I'd planned to write this soon anyway, but it was just brought up in [1]. Originally we had planned to drop src/tools/msvc support shortly after meson went in. Unfortunately, it took a bit longer than originally hoped for to merge meson support and th

Re: When to drop src/tools/msvc support

2023-04-10 Thread Jonathan S. Katz
On 4/10/23 4:50 PM, Tom Lane wrote: Magnus Hagander writes: Thus, +1 on actually keeping it up and dropping it immediately as v17 opens, giving them a year of advantage. And probably updating the docs (if anybody were to read them.. but at least then we tried) stating that it's deprecated and w

Re: longfin missing gssapi_ext.h

2023-04-10 Thread Jonathan S. Katz
On 4/10/23 11:37 AM, Tom Lane wrote: Stephen Frost writes: * Tom Lane (t...@sss.pgh.pa.us) wrote: IOW, maybe it'd be okay to de-revert 3d4fa227b and add documentation saying that --with-gssapi requires MIT Kerberos not Heimdal. I'd be happy with that and can add the appropriate documentatio

Re: When to drop src/tools/msvc support

2023-04-11 Thread Jonathan S. Katz
On 4/11/23 7:54 AM, Dave Page wrote: On Tue, 11 Apr 2023 at 11:58, Andrew Dunstan > wrote: For meson you just need to to "pip install meson ninja" in your python distro and you should be good to go (they will be installed in python's Scripts directory).

Re: When to drop src/tools/msvc support

2023-04-11 Thread Jonathan S. Katz
On 4/11/23 9:49 AM, Tom Lane wrote: Dave Page writes: On Tue, 11 Apr 2023 at 13:52, Jonathan S. Katz wrote: Do you think we'll have enough info by end of this week to make a decision on whether we can drop MSVC in v16? There's no way I can test anything this week - I'm on

Re: When to drop src/tools/msvc support

2023-04-11 Thread Jonathan S. Katz
On 4/11/23 10:12 AM, Tom Lane wrote: "Jonathan S. Katz" writes: On 4/11/23 9:49 AM, Tom Lane wrote: Sadly, I think we really have to ship both build systems in v16. But maybe we can make it clear in the release notes + docs that this is slated for deprecation and will be remove

Re: longfin missing gssapi_ext.h

2023-04-12 Thread Jonathan S. Katz
On 4/12/23 10:33 AM, Stephen Frost wrote: Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Understood. Please find attached the updated patch with changes to the commit message to indicate that we now require MIT Kerberos, an additional explicit check for gssapi_ext.h

Re: longfin missing gssapi_ext.h

2023-04-12 Thread Jonathan S. Katz
On 4/12/23 10:47 AM, Stephen Frost wrote: Greetings, * Jonathan S. Katz (jk...@postgresql.org) wrote: On 4/12/23 10:33 AM, Stephen Frost wrote: * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Understood. Please find attached the updated patch with changes to the commit

Re: longfin missing gssapi_ext.h

2023-04-12 Thread Jonathan S. Katz
On 4/12/23 12:22 PM, Stephen Frost wrote: Greetings, * Tom Lane (t...@sss.pgh.pa.us) wrote: Stephen Frost writes: Updated patch set attached. LGTM Great, thanks. I cleaned up the commit messages a bit more and added links to the discussion. If there isn't anything more then I'll plan to

Re: Should we remove vacuum_defer_cleanup_age?

2023-04-13 Thread Jonathan S. Katz
On 4/12/23 11:34 PM, Amit Kapila wrote: On Tue, Apr 11, 2023 at 11:50 PM Andres Freund wrote: On 2023-04-11 11:33:01 -0500, Justin Pryzby wrote: On Wed, Mar 22, 2023 at 10:00:48AM -0700, Andres Freund wrote: I don't know whether others think we should apply it this release, given the "late s

Re: Should we remove vacuum_defer_cleanup_age?

2023-04-13 Thread Jonathan S. Katz
On 4/13/23 11:32 AM, Jonathan S. Katz wrote: On 4/12/23 11:34 PM, Amit Kapila wrote: On Tue, Apr 11, 2023 at 11:50 PM Andres Freund +1 to do one of the above. I think there is a good chance that somebody might be doing more harm by using it so removing this shouldn't be a pr

Re: Should we remove vacuum_defer_cleanup_age?

2023-04-14 Thread Jonathan S. Katz
On 4/14/23 8:30 AM, Robert Haas wrote: On Thu, Apr 13, 2023 at 11:06 PM Laurenz Albe wrote: I am not against this in principle, but I know that there are people using this parameter; see the discussion linked in https://postgr.es/m/e1jkzxe-0006dw...@gemulon.postgresql.org I can't say if they

Re: Should we remove vacuum_defer_cleanup_age?

2023-04-14 Thread Jonathan S. Katz
On 4/14/23 1:15 PM, Laurenz Albe wrote: Let's remove vacuum_defer_cleanup_age, and put a note in the release notes that recommends using statement_timeout and hot_standby_feedback = on on the standby instead. That should have pretty much the same effect, and it is measured in time and not in the

Re: check_strxfrm_bug()

2023-04-18 Thread Jonathan S. Katz
On 4/18/23 9:19 PM, Thomas Munro wrote: On Tue, Apr 18, 2023 at 11:52 AM Michael Paquier wrote: On Mon, Apr 17, 2023 at 03:40:14PM -0700, Peter Geoghegan wrote: +1 for getting rid of TRUST_STRXFRM. +1 The situation is not improving fast, and requires hard work to follow on each OS. Clearly

Re: check_strxfrm_bug()

2023-04-22 Thread Jonathan S. Katz
On 4/19/23 9:34 PM, Thomas Munro wrote: On Wed, Apr 19, 2023 at 2:31 PM Jonathan S. Katz wrote: To be clear, is the proposal to remove both "check_strxfrm_bug" and "TRUST_STRXFRM"? Given a bunch of folks who have expertise in this area of code all agree with removing the

Re: pg_stat_io not tracking smgrwriteback() is confusing

2023-04-22 Thread Jonathan S. Katz
On 4/19/23 1:23 PM, Andres Freund wrote: Hi, I noticed that the numbers in pg_stat_io dont't quite add up to what I expected in write heavy workloads. Particularly for checkpointer, the numbers for "write" in log_checkpoints output are larger than what is visible in pg_stat_io. That partially i

Re: New committers: Nathan Bossart, Amit Langote, Masahiko Sawada

2023-04-22 Thread Jonathan S. Katz
On 4/20/23 1:40 PM, Tom Lane wrote: The Core Team would like to extend our congratulations to Nathan Bossart, Amit Langote, and Masahiko Sawada, who have accepted invitations to become our newest Postgres committers. Please join me in wishing them much success and few reverts. Congratulations

Re: pg_stat_io not tracking smgrwriteback() is confusing

2023-04-24 Thread Jonathan S. Katz
On 4/24/23 6:14 PM, Andres Freund wrote: Hi, On 2023-04-24 10:52:15 +0530, Amit Kapila wrote: On Sun, Apr 23, 2023 at 12:55 AM Jonathan S. Katz wrote: I wonder if it's worth doing so for 16? It'd give a more complete picture that way. The counter-argument I see is that we didn&#

Re: Possible regression setting GUCs on \connect

2023-04-28 Thread Jonathan S. Katz
On 4/27/23 8:04 PM, Alexander Korotkov wrote: On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov wrote: Additionally, I think if we start recording role OID, then we need a full set of management clauses for each individual option ownership. Otherwise, we would leave this new role OID without n

Re: Possible regression setting GUCs on \connect

2023-04-30 Thread Jonathan S. Katz
On 4/28/23 12:29 PM, Pavel Borisov wrote: Hi! On Fri, 28 Apr 2023 at 17:42, Jonathan S. Katz wrote: On 4/27/23 8:04 PM, Alexander Korotkov wrote: On Fri, Apr 28, 2023 at 2:30 AM Alexander Korotkov wrote: Additionally, I think if we start recording role OID, then we need a full set of

Re: Move defaults toward ICU in 16?

2023-05-03 Thread Jonathan S. Katz
On 4/17/23 2:33 PM, Tom Lane wrote: Jeff Davis writes: Is now a reasonable time to check it in and see what breaks? It looks like there are quite a few buildfarm members that specify neither -- with-icu nor --without-icu. I see you just pinged buildfarm-members again, so I'd think it's polite

Re: pg_stat_io not tracking smgrwriteback() is confusing

2023-05-03 Thread Jonathan S. Katz
On 4/27/23 11:36 AM, Melanie Plageman wrote: Thanks for the review! On Wed, Apr 26, 2023 at 10:22 PM Kyotaro Horiguchi wrote: At Wed, 26 Apr 2023 17:08:14 -0400, Melanie Plageman wrote in On Mon, Apr 24, 2023 at 9:29 PM Melanie Plageman wrote: I've yet to cook up a client backend test ca

Re: psql: Add role's membership options to the \du+ command

2023-05-03 Thread Jonathan S. Katz
On 4/13/23 8:44 AM, Pavel Luzanov wrote: P.S. If no objections I plan to add this patch to Open Items for v16 https://wiki.postgresql.org/wiki/PostgreSQL_16_Open_Items [RMT hat] I don't see why this is an open item as this feature was not committed for v16. Open items typically revolve aroun

Re: psql: Add role's membership options to the \du+ command

2023-05-03 Thread Jonathan S. Katz
On 5/3/23 12:25 PM, Tom Lane wrote: "David G. Johnston" writes: On Wed, May 3, 2023 at 9:00 AM Jonathan S. Katz wrote: I don't see why this is an open item as this feature was not committed for v16. Open items typically revolve around committed features. The argument is th

Re: pg_stat_io not tracking smgrwriteback() is confusing

2023-05-04 Thread Jonathan S. Katz
On 5/4/23 12:46 PM, Andres Freund wrote: Hi, On 2023-05-03 11:36:10 -0400, Jonathan S. Katz wrote: It'd be good if we can get this into Beta 1 if everyone is comfortable with the patch. I think we need one more iteration, then I think it can be committed. The changes are docs phrasin

2023-05-11 release announcement draft

2023-05-06 Thread Jonathan S. Katz
Hi, Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. Thanks, Jonathan The PostgreSQL Global Development Group has released an update to all s

Re: 2023-05-11 release announcement draft

2023-05-07 Thread Jonathan S. Katz
On 5/7/23 1:09 AM, Erik Rijkers wrote: Op 5/7/23 om 05:37 schreef Jonathan S. Katz: Attached is a draft of the release announcement for the upcoming update release on May 11, 2023. Please provide any suggestions, corrections, or notable omissions no later than 2023-05-11 0:00 AoE. 'le

PostgreSQL 16 Beta 1 release date

2023-05-09 Thread Jonathan S. Katz
Hi, The release date for PostgreSQL 16 Beta 1 is scheduled for May 25, 2023. Please ensure you have committed any work for Beta 1 released committed by May 21, 2023 AoE. Thank you for your efforts with resolving open items[2] as we work to stabilize PostgreSQL 16 for GA! Thanks, Jonathan [

Re: 2023-05-11 release announcement draft

2023-05-10 Thread Jonathan S. Katz
On 5/7/23 10:34 PM, David Rowley wrote: * Fix partition pruning bug with the boolean "IS NOT TRUE" and "IS NOT FALSE" conditions. NULL partitions were accidentally pruned when they shouldn't have been. Thanks for the additional explanation. I took your suggestion verbatim. Thanks, Jonathan

PostgreSQL 15 Release Management Team (RMT) + Feature Freeze

2022-03-26 Thread Jonathan S. Katz
Hi, We are pleased to announce the Release Management Team (RMT) (cc'd) for the PostgreSQL 15 release: - John Naylor - Jonathan Katz - Michael Paquier You can find information about the responsibilities of the RMT here: https://wiki.postgresql.org/wiki/Release_Management_Team Additi

Re: PostgreSQL 15 Release Management Team (RMT) + Feature Freeze

2022-04-05 Thread Jonathan S. Katz
On 3/26/22 11:10 AM, Jonathan S. Katz wrote: Additionally, the RMT has set the feature freeze date to be April 7, 2022. This is the last day to commit features for PostgreSQL 15. In other words, no new PostgreSQL 15 feature can be committed after April 8 0:00, 2022 AoE[1]. [1] https

Re: How about a psql backslash command to show GUCs?

2022-04-06 Thread Jonathan S. Katz
On 4/6/22 2:40 PM, Tom Lane wrote: Joe Conway writes: No as sure about \show though. That seems like it could be confused with showing other stuff. Maybe consistent with \sf[+] and \sv[+] we could add \sc[+]? Hmm ... my first reaction to that was "no, it should be \sp for 'parameter'". But w

Re: How about a psql backslash command to show GUCs?

2022-04-06 Thread Jonathan S. Katz
On 4/6/22 9:18 PM, David G. Johnston wrote: On Wed, Apr 6, 2022 at 6:16 PM Tom Lane I agree that \d-something makes the most sense from a functionality standpoint.  But I don't want to make the name too long, even if we do have tab completion to help. \dconf maybe? I don't ha

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Jonathan S. Katz
On 4/7/22 8:36 AM, Joe Conway wrote: On 4/6/22 23:02, Tom Lane wrote: "Jonathan S. Katz" writes: +1 for \dconf Here's a draft patch using \dconf.  No tests or docs yet. WFM -- using some form of \d makes more sense than \s, and I can't think of anything better that

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Jonathan S. Katz
On 4/7/22 11:10 AM, David G. Johnston wrote: On Thu, Apr 7, 2022 at 7:56 AM Tom Lane <mailto:t...@sss.pgh.pa.us>> wrote: "Jonathan S. Katz" mailto:jk...@postgresql.org>> writes: > Maybe to appeal to all crowds, we say "list configuration parameters

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Jonathan S. Katz
On 4/7/22 12:22 PM, Tom Lane wrote: Justin Pryzby writes: SHOW and current_setting() translate to human units, which is particularly useful for some settings, like those with units of 8k pages. Is it better to use that "cooked" version for display in the backslash command instead of the raw vie

Re: How about a psql backslash command to show GUCs?

2022-04-07 Thread Jonathan S. Katz
On 4/7/22 12:42 PM, Mark Dilger wrote: On Apr 7, 2022, at 9:37 AM, Tom Lane wrote: Maybe I'm atypical, but I'm probably going to use tab completion either way, so it's not really more keystrokes. Same here, because after tab-completing \dcon\t\t into \dconfig, I'm likely to also tab-compl

Re: How about a psql backslash command to show GUCs?

2022-04-09 Thread Jonathan S. Katz
On 4/9/22 11:58 AM, Julien Rouhaud wrote: On Sat, Apr 09, 2022 at 10:31:17AM -0400, Tom Lane wrote: Christoph Berg writes: I would think that if \dconfig showed the non-default settings only, it would be much more useful; the full list would still be available with "\dconfig *". This is in li

Re: How about a psql backslash command to show GUCs?

2022-04-09 Thread Jonathan S. Katz
On 4/9/22 12:27 PM, Tom Lane wrote: "Jonathan S. Katz" writes: -1, at least for the moment. Sometimes a user doesn't know what they're looking for coupled with being unaware of what the default value is. If a setting is set to a default value and that value is the problem

Re: Commitfest wrapup

2022-04-09 Thread Jonathan S. Katz
On 4/9/22 1:14 PM, Greg Stark wrote: On Sat, 9 Apr 2022 at 10:51, Tom Lane wrote: Sound like bugfixes to be backpatched. Yeah. I'm not sure why these have received so little love. Since bug fixes are important enough that they'll definitely get done (and can happen after feature freeze)

Re: How about a psql backslash command to show GUCs?

2022-04-11 Thread Jonathan S. Katz
On 4/11/22 3:12 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 4/9/22 12:27 PM, Tom Lane wrote: Sure, but then you do "\dconfig *". With there being several hundred GUCs (and no doubt more coming), I'm not sure that "show me every GUC" is a common use-

Re: How about a psql backslash command to show GUCs?

2022-04-11 Thread Jonathan S. Katz
On 4/11/22 4:11 PM, Tom Lane wrote: "Jonathan S. Katz" writes: My question is if we're only going to list out the settings that are customized, are we going to: 1. Hide a setting if it matches a default value, even if a user set it to be the default value? OR 2. Comment

Re: How about a psql backslash command to show GUCs?

2022-04-12 Thread Jonathan S. Katz
On 4/12/22 11:19 AM, Tom Lane wrote: "Jonathan S. Katz" writes: On 4/11/22 4:11 PM, Tom Lane wrote: This idea does somewhat address my unhappiness upthread about printing values with source = 'internal', but I see that it gets confused by some GUCs with cus

Re: How about a psql backslash command to show GUCs?

2022-04-12 Thread Jonathan S. Katz
On 4/12/22 1:00 PM, Tom Lane wrote: "Jonathan S. Katz" writes: On 4/12/22 11:19 AM, Tom Lane wrote: It'd just look like this, I think. I see from looking at guc.c that boot_val can be NULL, so we'd better use IS DISTINCT FROM. I tested it and I like this a lot better

2023-11-09 release announcement draft

2023-11-06 Thread Jonathan S. Katz
Hi, Attached is the release announcement draft for the 2023-11-09 release (16.1 et al.). Please review for accuracy and notable omissions. Please have all feedback in by 2023-11-09 08:00 UTC at the latest (albeit the sooner the better). Thanks, Jonathan The PostgreSQL Global Development G

Re: 2023-11-09 release announcement draft

2023-11-07 Thread Jonathan S. Katz
On 11/6/23 9:52 PM, Noah Misch wrote: On Mon, Nov 06, 2023 at 05:04:25PM -0500, Jonathan S. Katz wrote: The PostgreSQL Global Development Group has released an update to all supported versions of PostgreSQL, including 16.1, 15.5, 14.10, 13.13, 12.17, and 11.22 This release fixes over 55 bugs

Re: Password leakage avoidance

2023-12-24 Thread Jonathan S. Katz
On 12/24/23 10:14 AM, Joe Conway wrote: On 12/23/23 11:00, Tom Lane wrote: Joe Conway writes: The attached patch set moves the guts of \password from psql into the libpq client side -- PQchangePassword() (patch 0001). Haven't really read the patch, just looked at the docs, but here's a bit o

Re: Password leakage avoidance

2023-12-27 Thread Jonathan S. Katz
On 12/24/23 12:15 PM, Tom Lane wrote: Maybe we need a PQcreaterole that provide the mechanism to set passwords safely. It'd likely need to take all the options need for creating a role, but that would at least give the underlying mechanism to ensure we're always sending a hashed password to the

Re: Password leakage avoidance

2023-12-31 Thread Jonathan S. Katz
On 12/31/23 9:50 AM, Magnus Hagander wrote: On Wed, Dec 27, 2023 at 10:31 PM Jonathan S. Katz wrote: On 12/24/23 12:15 PM, Tom Lane wrote: Maybe we need a PQcreaterole that provide the mechanism to set passwords safely. It'd likely need to take all the options need for creating a role

<    1   2   3   4   5   6   7   >