Hi,
Commit 216a784829 change the src/backend/replication/logical/worker.c file mode
from 0644 to 0755, which is unwanted, right?
[1]
https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=216a784829c2c5f03ab0c43e009126cbb819e9b2
--
Regrads,
Japin Li.
ChengDu WenWu Information
attr(tupleDesc, attnum, isnull);
+ else
+ return fastgetattr(tup, attnum, tupleDesc, isnull);
+ }
+
+ return heap_getsysattr(tup, attnum, tupleDesc, isnull);
+}
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 24 Mar 2022 at 22:32, Alvaro Herrera wrote:
> On 2022-Mar-24, Japin Li wrote:
>
>> I want to know why we do not use the following style?
>>
>> +static inline Datum
>> +heap_getattr(HeapTuple tup, int attnum, TupleDesc tupleDesc, bool *isnull
Node) != 3 ||
+
!OidIsValid(config.filter_by_relation.spcNode) ||
+
!OidIsValid(config.filter_by_relation.relNode))
It seems we should also check the dbNode.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Fri, 25 Mar 2022 at 08:55, Thomas Munro wrote:
> On Fri, Mar 25, 2022 at 1:43 PM Japin Li wrote:
>> + printf(_(" -x, --xid=XID only show records with
>> transaction ID XID\n"));
>>
>> I think the description of transaction ID is
On Fri, 25 Mar 2022 at 17:42, Alvaro Herrera wrote:
> On 2022-Mar-24, Japin Li wrote:
>
>> Thanks for your detail explaination. I find bottomup_sort_and_shrink_cmp()
>> has smilar code
>
> ... except that bottomup_sort_and_shrink_cmp never handles the case of
> th
al size of partition tables through
the partitioned table name.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Fri, 25 Mar 2022 at 20:59, Alvaro Herrera wrote:
> On 2022-Mar-25, Japin Li wrote:
>
>> Could we provide a function to get the total size of the partition table
>> though the partitioned table name? Maybe we can extend
>> the pg_relation_size() to get the total
On Fri, 25 Mar 2022 at 21:21, Bharath Rupireddy
wrote:
> On Fri, Mar 25, 2022 at 6:23 PM Japin Li wrote:
>>
>> Hi, hackers
>>
>> When I try to get total size of partition tables though partitioned table
>> name using pg_relation_size(), it always returns zero
On Fri, 25 Mar 2022 at 21:21, Bharath Rupireddy
wrote:
> On Fri, Mar 25, 2022 at 6:23 PM Japin Li wrote:
>>
>> Hi, hackers
>>
>> When I try to get total size of partition tables though partitioned table
>> name using pg_relation_size(), it always returns zero
On Sat, 26 Mar 2022 at 22:16, Bharath Rupireddy
wrote:
> On Sat, Mar 26, 2022 at 11:35 AM Michael Paquier wrote:
>>
>> On Fri, Mar 25, 2022 at 08:52:40PM +0800, Japin Li wrote:
>> > Could we provide a function to get the total size of the partition table
>> >
for --relation, however, it has been
changed to -R, and we forgot to update the documentation.
Here is a patch for it.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/doc/src/sgml/ref/pg_waldump.sgml b/doc/src/sgml/ref/pg_waldump.sgml
index 4e86f44c5b
Hi, hackers
I found we defined PG_BINARY_R/W/A macros for opening files, however,
there are some places use the constant strings. IMO we should use
those macros instead of constant strings. Here is a patch for it.
Any thoughts?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co
On Mon, 18 Apr 2022 at 22:41, Tom Lane wrote:
> Japin Li writes:
>> I found we defined PG_BINARY_R/W/A macros for opening files, however,
>> there are some places use the constant strings. IMO we should use
>> those macros instead of constant strings. Here is a patch fo
On Tue, 19 Apr 2022 at 14:14, Michael Paquier wrote:
> On Tue, Apr 19, 2022 at 01:29:18PM +0800, Japin Li wrote:
>> On Mon, 18 Apr 2022 at 22:41, Tom Lane wrote:
>>> Japin Li writes:
>>>> I found we defined PG_BINARY_R/W/A macros for opening files, however,
>
On Tue, 19 Apr 2022 at 14:20, Tom Lane wrote:
> Japin Li writes:
>> On Mon, 18 Apr 2022 at 22:41, Tom Lane wrote:
>>> A lot of these changes look wrong to me: they are substituting "rb" for
>>> "r", etc, in places that mean to read text
On Tue, 19 Apr 2022 at 22:21, Tom Lane wrote:
> Japin Li writes:
>> On Tue, 19 Apr 2022 at 14:20, Tom Lane wrote:
>>> I think the comment's at best misleading. See e.g. 66f8687a8.
>>> It might be okay to use "rb" to read a text file when there
>&
.org/8.0.1/docs/DebuggingJITedCode.html
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
ays right.
[1]
https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/popen-wpopen?view=msvc-170
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
.34.0/IPC/Run.pm line 2951. <-- HERE
# Postmaster PID for node "main" is 219980
### Stopping node "main" using mode immediate
# Running: pg_ctl -D
/home/japin/postgres/build/src/bin/psql/tmp_check/t_010_tab_completion_main_data/pgdata
-m immediate stop
waiting for server to shut down done
server stopped
# No postmaster PID for node "main"
$ uname -a
SunOS db_build 5.11 x i86pc i386 i86pc illumos
$ perl --version
This is perl 5, version 34, subversion 0 (v5.34.0) built for
x86_64-solaris-thread-multi-64
I try to change PG_TEST_TIMEOUT_DEFAULT to 600, it also failed with timeout.
Any suggestions? Thanks in advance!
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Thu, 02 Nov 2023 at 13:01, Noah Misch wrote:
> On Wed, Nov 01, 2023 at 03:19:39PM +0800, Japin Li wrote:
>> I try to run regression test on illumos, the 010_tab_completion will
>> failed because of timeout.
>
>> Any suggestions? Thanks in advance!
>
> This test
On Thu, 02 Nov 2023 at 13:42, Japin Li wrote:
> On Thu, 02 Nov 2023 at 13:01, Noah Misch wrote:
>> On Wed, Nov 01, 2023 at 03:19:39PM +0800, Japin Li wrote:
>>> I try to run regression test on illumos, the 010_tab_completion will
>>> failed because of timeout.
>
On Thu, 02 Nov 2023 at 22:23, Tom Lane wrote:
> Japin Li writes:
>> It seems the 'SEL\t' is converted to 'SEL ' which is "SEL" with 5 spaces.
>
> That would be plausible if readline were disabled, or otherwise
> not functioning.
>
I thin
On Fri, 03 Nov 2023 at 10:03, Thomas Munro wrote:
> On Fri, Nov 3, 2023 at 2:22 PM Thomas Munro wrote:
>> On Fri, Nov 3, 2023 at 3:42 AM Japin Li wrote:
>> > I think this might be a bug comes from Illumos pseudo-tty. I can reproduce
>> > this by using pseudo-tty on
an opinion of someone
> more experienced in giving names to GUCs than me. Or, perhaps, a native
> speaker?
>
How about transaction_session_timeout? Similar to idle_session_timeout.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin wrote:
>> On 7 Dec 2023, at 06:25, Japin Li wrote:
>>
>> If idle_in_transaction_timeout is bigger than transaction_timeout,
>> the idle-in-transaction timeout don't needed, right?
> Yes, I th
On Fri, 08 Dec 2023 at 18:08, Andrey M. Borodin wrote:
>> On 8 Dec 2023, at 12:59, Japin Li wrote:
>>
>>
>> On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin wrote:
>>>> On 7 Dec 2023, at 06:25, Japin Li wrote:
>>>>
>>>> If id
On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin wrote:
>> On 8 Dec 2023, at 15:29, Japin Li wrote:
>>
>> Thanks for updating the patch. LGTM.
>
> PFA v9. Changes:
> 1. Added tests for idle_in_transaction_timeout
> 2. Suppress statement_timeout if it’s sh
On Mon, 18 Dec 2023 at 13:49, Andrey M. Borodin wrote:
>> On 16 Dec 2023, at 05:58, Japin Li wrote:
>>
>>
>> On Fri, 15 Dec 2023 at 17:51, Andrey M. Borodin wrote:
>>>> On 8 Dec 2023, at 15:29, Japin Li wrote:
>>>>
>>>> Thanks
On Mon, 18 Dec 2023 at 17:40, Andrey M. Borodin wrote:
>> On 18 Dec 2023, at 14:32, Japin Li wrote:
>>
>>
>> Thanks for updating the patch
>
> Sorry for the noise, but commitfest bot found one more bug in handling
> statement timeout. PFA v11.
>
On Windo
t is sourced in psql, rather than via CREATE EXTENSION
\echo Use "CREATE EXTENSION pair" to load this file. \quit
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
nsaction_session_timeout = '1ms'; SET
statement_timeout = '10s'; SET lock_timeout = '10s'; SET transaction_timeout =
'10s';
[1]
https://api.cirrus-ci.com/v1/artifact/task/4707530400595968/testrun/build/testrun/isolation/isolation/regression.diffs
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
, I can include a note in the general documentation to explain
> the rationale without repeating it in the individual script. What do you
> think?
Agreed.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Tue, 19 Dec 2023 at 22:06, Japin Li wrote:
> On Tue, 19 Dec 2023 at 18:27, Andrey M. Borodin wrote:
>>> On 19 Dec 2023, at 13:26, Andrey M. Borodin wrote:
>>>
>>> I don’t have Windows machine, so I hope CF bot will pick this.
>>
>> I used Github CI
On Fri, 22 Dec 2023 at 20:29, Junwang Zhao wrote:
> On Fri, Dec 22, 2023 at 1:39 PM Japin Li wrote:
>>
>>
>> On Tue, 19 Dec 2023 at 22:06, Japin Li wrote:
>> > On Tue, 19 Dec 2023 at 18:27, Andrey M. Borodin
>> > wrote:
>> >>&
On Fri, 22 Dec 2023 at 22:37, Junwang Zhao wrote:
> On Fri, Dec 22, 2023 at 10:25 PM Japin Li wrote:
>> I try to set idle_in_transaction_session_timeout after begin transaction,
>> it changes immediately, so I think transaction_timeout should also be take
>> immed
ent/plpgsql-development-tips.html and
> new section - deployment or packaging to extensions
>
> I agree so https://www.postgresql.org/docs/current/plpgsql-overview.html is
> under dimensioned, but packaging should not be there
>
It seems redundant if we add this for each PL, maybe a separate section to
describe how to package PL into extensions is better.
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Fri, 22 Dec 2023 at 23:30, Junwang Zhao wrote:
> On Fri, Dec 22, 2023 at 10:44 PM Japin Li wrote:
>>
>>
>> On Fri, 22 Dec 2023 at 22:37, Junwang Zhao wrote:
>> > On Fri, Dec 22, 2023 at 10:25 PM Japin Li wrote:
>> >> I try to set idle_in_transacti
On Sat, 23 Dec 2023 at 08:32, Japin Li wrote:
> On Fri, 22 Dec 2023 at 23:30, Junwang Zhao wrote:
>> On Fri, Dec 22, 2023 at 10:44 PM Japin Li wrote:
>>>
>>>
>>> On Fri, 22 Dec 2023 at 22:37, Junwang Zhao wrote:
>>> > On Fri, Dec 22, 2023
a
On Sat, 23 Dec 2023 at 10:40, Japin Li wrote:
> On Sat, 23 Dec 2023 at 08:32, Japin Li wrote:
>> On Fri, 22 Dec 2023 at 23:30, Junwang Zhao wrote:
>>> On Fri, Dec 22, 2023 at 10:44 PM Japin Li wrote:
>>>>
>>>>
>>>> On Fri, 22 Dec 202
owing line can fix this.
+ int64 k;
Do not need to modify the type of `n`, right?
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
d to modify the type of `n`, right?
>
> You are right. n represents the return value of pg_snprintf, which is
> the byte length of the formatted data, which is int, not int64.
>
Thanks for you confirmation! Please consider the v2 patch to review.
--
Regrads,
Japin Li
ChengDu WenWu I
On Sun, 24 Dec 2023 at 01:14, Andrey M. Borodin wrote:
>> On 22 Dec 2023, at 10:39, Japin Li wrote:
>>
>>
>> I try to split the test for transaction timeout, and all passed on my CI [1].
>
>
> I like the refactoring you did in timeout.spec. I thought it is im
> This has popped up a few times in the past, and it seems to be GCC bug
> 53119. We previously used the {{...}} approach to suppress it. Should
> we do the same here, like attached?
>
> FWIW, in the same file we initialize BlockRefTableSerializedEntry
> variables also with {{0
On Tue, 26 Dec 2023 at 18:10, Shubham Khanna
wrote:
> On Tue, Dec 26, 2023 at 3:02 PM Japin Li wrote:
>>
>>
>> Hi hacker,
>>
>> As $subject detailed, the tab-complete cannot work such as:
>>
>>CREATE SUBSCRIPTION sub CONNECTION 'dbn
On Wed, 03 Jan 2024 at 20:04, Andrey M. Borodin wrote:
>> On 3 Jan 2024, at 16:46, Andrey M. Borodin wrote:
>>
>> I do not understand why, but mailing list did not pick patches that I sent.
>> I'll retry.
>
>
> Sorry for the noise. Seems like Apple updated something in Mail.App couple of
> d
not find the explanation in gram.y easily. Would someone point
it out for me? Thanks in advance!
--
Regrads,
Japin Li
not find the explanation in gram.y easily. Would someone point
it out for me? Thanks in advance!
--
Regrads,
Japin Li
On Mon, 25 Sep 2023 at 11:17, Tom Lane wrote:
> Japin Li writes:
>> I find src/backend/utils/mb/Unicode/Makefile has the following comments:
>
>>> # Note that while each script call produces two output files, to be
>>> # parallel-make safe we need to split
Hi, hackers
When I try to update the unicode mapping table through *.xml in
src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
I find the make cannot go to this directory, what can I do to update
the mapping tables?
--
Regrads,
Japin Li
ChengDu WenWu Information Technolo
On Tue, 26 Sep 2023 at 05:58, Peter Eisentraut wrote:
> On 25.09.23 08:02, Japin Li wrote:
>> When I try to update the unicode mapping table through *.xml in
>> src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
>> I find the make cannot go to this d
On Tue, 26 Sep 2023 at 06:20, Tom Lane wrote:
> Peter Eisentraut writes:
>> On 25.09.23 08:02, Japin Li wrote:
>>> When I try to update the unicode mapping table through *.xml in
>>> src/backend/utils/mb/Unicode/, it doesn't update the *.map files.
>&
g/message-id/MEYP282MB1669AC78EE8374B3DE797A09B6FCA%40MEYP282MB1669.AUSP282.PROD.OUTLOOK.COM
--
Regrads,
Japin Li
ChengDu WenWu Information Technology Co., Ltd.
On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
> On Tue, Sep 26, 2023 at 10:43:40AM +0800, Japin Li wrote:
>> # Allow running this even without --with-python
>> PYTHON ?= python
>>
>> $(srcdir)/unaccent.rules: generate_unaccent_rules.py
>> ../../src/com
On Wed, 27 Sep 2023 at 13:46, Michael Paquier wrote:
> On Wed, Sep 27, 2023 at 09:15:00AM +0800, Japin Li wrote:
>> On Wed, 27 Sep 2023 at 08:03, Michael Paquier wrote:
>>> I am not sure that many people run this script frequently so that may
>>> not be worth a
COPY memory context, IMO, this is redundant, and can be removed safely.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/src/backend/commands/copyfrom.c b/src/backend/commands/copyfrom.c
index 0d6b34206a..7b3f5a84b8 100644
--- a/src/backend/commands/copyfrom.c
te,
> so the early switch back looks to me like trouble waiting to happen.
>
Agreed
I see you have already push this patch on master (89f059bdf52), why not
remove MemoryContextSwitchTo in the middle of BeginCopyTo in this commit?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 20 Jan 2022 at 08:50, Tom Lane wrote:
> Japin Li writes:
>> I see you have already push this patch on master (89f059bdf52), why not
>> remove MemoryContextSwitchTo in the middle of BeginCopyTo in this commit?
>
> That was a different suggestion from a differen
urceRelRTE, true, true);
Should we remove the CMD_DELETE from Assert(), since it will not happened
according to MERGE syntax?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
to use it through the copy command processing. It looks like a thinko
> from the commit c532d1 [2]. Attaching a small patch to remove this.
>
> Thoughts?
>
Thanks for the patch! Tested and passed regression tests. LGTM.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
lding XidGenLock, right?
Does there any sense to release them in reversed acquisition order in
LogStandbySnapshot like ProcArrayRemove?
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
index 7db8
tion establishment can be very frequent). And due to the above,
> we can sometimes release ProcArrayLock earlier.
>
Thanks for the explanation! Got it.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
Commit b7eda3e0e3 moves XidINMVCCSnapshot into snapmgr.{c,h},
however, it forgets the declaration of XidINMVCCSnapshot in
heapam.h.
Attached removes the redundant declaration in heapam.h.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
>F
is by
* far the bigger array, and we mostly don't know which xids are
* top-level and which are subxacts. The xip array is empty.
*
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Fri, 11 Nov 2022 at 15:23, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 12:16 PM Richard Guo wrote:
>>
>> On Fri, Nov 11, 2022 at 11:26 AM Japin Li wrote:
>>>
>>> Recently, when I read the XidInMVCCSnapshot(), and find there are some
>>> typos in
On Sat, 12 Nov 2022 at 12:12, Amit Kapila wrote:
> On Fri, Nov 11, 2022 at 2:45 PM Japin Li wrote:
>> Maybe a wrong plural in XidInMvccSnapshot().
>>
>> * Make a quick range check to eliminate most XIDs without looking at the
>> * xip arrays.
>>
&g
*from the procarray if the topxid is still running, using
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
> leaking ?
>
> Please see attached patch for my proposal.
>
> Cheers
I think we should check whether fd is NULL or not, otherwise, segmentation
fault maybe occur.
+ if (pclose(fd) != 0)
+ {
+ write_stderr(_("%s: could not close the file following command
\&qu
On Wed, 16 Nov 2022 at 10:02, Japin Li wrote:
> I think we should check whether fd is NULL or not, otherwise, segmentation
> fault maybe occur.
>
> + if (pclose(fd) != 0)
> + {
> + write_stderr(_("%s: could not close the file following command
>
using command \"%s\"\n"), progname, cmd);
exit(1);
}
Here, segfault maybe occurs if fd is NULL. I think we can remove pclose()
safely since the process will exit.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Wed, 16 Nov 2022 at 10:52, Ted Yu wrote:
> On Tue, Nov 15, 2022 at 6:35 PM Japin Li wrote:
>>
>> fd = popen(cmd, "r");
>> - if (fd == NULL || fgets(filename, sizeof(filename), fd) == NULL ||
>> pclose(fd) != 0)
>> + if (fd == N
On Wed, 16 Nov 2022 at 11:15, Ted Yu wrote:
> On Tue, Nov 15, 2022 at 7:12 PM Japin Li wrote:
>> After some rethinking, I find the origin code do not have problems.
>>
>> If fd is NULL or fgets() returns NULL, the process exits. Otherwise, we
>> call
>> pclo
On Wed, 16 Nov 2022 at 12:19, Tom Lane wrote:
> Japin Li writes:
>> Hi, hackers,
>
> ITYM pgsql-hackers, this is off-topic here.
>
Sorry for typo the email address.
>> When I'm reviewing patch [1], I find there is a memory leak in
>> adjust_data_dir()
Hi, hackers
I find some typo about xl_running_xacts in comments.
Attached a patch to fix those.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
diff --git a/src/backend/replication/logical/snapbuild.c b/src/backend/replication/logical/snapbuild.c
index 5006a5c464
On Thu, 17 Nov 2022 at 16:22, Daniel Gustafsson wrote:
>> On 17 Nov 2022, at 08:06, Japin Li wrote:
>
>> I find some typo about xl_running_xacts in comments.
>> Attached a patch to fix those.
>
> Thanks, applied!
>
>> - * might look that we could use xl_
ly \"%s\" does not exist
for access method \"%s\", skipping");
name = NameListToString(opfname);
args = strVal(linitial(castNode(List, object)));
}
}
break;
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 17 Nov 2022 at 23:06, Japin Li wrote:
> On Thu, 17 Nov 2022 at 20:12, Ted Yu wrote:
>> Hi,
>> I was looking at commit aca992040951c7665f1701cd25d48808eda7a809
>>
>> I think the check of msg after the switch statement is not necessary. The
>> variable m
_write_attrs().
> But, this change impacts on other several callers so is not as good as the
> first direction above, I think.
>
> If someone has any better idea, please let me know.
>
I think the first idea is better than the second. OTOH, can we release the
locks before SyncRepWaitForLSN(), since it already flush to local WAL files.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
The RelationIdGetRelation() comment says:
> Caller should eventually decrement count. (Usually,
> that happens by calling RelationClose().)
However, it doesn't do it in ReorderBufferProcessTXN().
I think we should close it, here is a patch that fixes it. Thoughts?
--
Regrad
st need to call RelationGetIndexList
> and then build the idattr list for relation->rd_replidindex.
Sorry, I don't know how can we build the idattr without open the index.
If we should open the index, then we should use NoLock, since the TRUNCATE
side hold AccessExclusiveLock. As Osumi points out in [1], The NoLock mode
assumes that the appropriate lock on the index is already taken.
Please let me know if I have misunderstood.
[1]
https://www.postgresql.org/message-id/OSBPR01MB488834BDBD67BFF2FB048B3DED4E9%40OSBPR01MB4888.jpnprd01.prod.outlook.com
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 15 Apr 2021 at 19:25, Amit Kapila wrote:
> On Thu, Apr 15, 2021 at 4:30 PM Japin Li wrote:
>>
>>
>> On Thu, 15 Apr 2021 at 18:22, Amit Kapila wrote:
>> > On Wed, Apr 14, 2021 at 3:31 PM Amit Kapila
>> > wrote:
>> >>
>> >
On Thu, 15 Apr 2021 at 19:25, Amit Kapila wrote:
> On Thu, Apr 15, 2021 at 4:30 PM Japin Li wrote:
>>
>>
>> On Thu, 15 Apr 2021 at 18:22, Amit Kapila wrote:
>> > On Wed, Apr 14, 2021 at 3:31 PM Amit Kapila
>> > wrote:
>> >>
>> >
On Fri, 16 Apr 2021 at 16:52, Amit Kapila wrote:
> On Fri, Apr 16, 2021 at 12:55 PM Japin Li wrote:
>>
>> On Thu, 15 Apr 2021 at 19:25, Amit Kapila wrote:
>> > On Thu, Apr 15, 2021 at 4:30 PM Japin Li wrote:
>> >>
>> >>
>> >> On T
indexes?
> Ok. No need to traverse all the indexes. Will fix this part.
>
>> 2.
>> It is better to name the function as RelationGet...
> You are right. I'll modify this in my next version.
>
I took the liberty to address review comments and provide a v2 patch on top of
your&#x
On Sat, 17 Apr 2021 at 14:09, Amit Kapila wrote:
> On Thu, Apr 15, 2021 at 4:53 PM Amit Kapila wrote:
>>
>> On Thu, Apr 15, 2021 at 4:00 PM Japin Li wrote:
>> >
>> > The RelationIdGetRelation() comment says:
>> >
>> > > Caller should eve
On Sat, 17 Apr 2021 at 12:03, osumi.takami...@fujitsu.com
wrote:
> On Saturday, April 17, 2021 12:53 AM Japin Li
>> On Fri, 16 Apr 2021 at 17:19, osumi.takami...@fujitsu.com
>> wrote:
>> > On Friday, April 16, 2021 5:50 PM Amit Kapila
>> wrote:
>>
On Fri, 23 Apr 2021 at 22:33, osumi.takami...@fujitsu.com
wrote:
> On Saturday, April 17, 2021 4:13 PM Amit Kapila
> wrote:
>> On Sat, Apr 17, 2021 at 12:05 PM Japin Li wrote:
>> >
>> > On Sat, 17 Apr 2021 at 14:09, Amit Kapila
>> wrote:
>> >
s where we get that information without
> locking the target index.
>
> We are planning not to backpatch this as there doesn't seem to be any
> field complaint about this issue since it was introduced in commit
> 5dfd1e5a in v11.
+1 for apply only on HEAD.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
bject('pg_event_trigger'::regclass,oid,0),
+ pg_identify_object_as_address('pg_event_trigger'::regclass,oid,0)
+FROM pg_event_trigger
+WHERE evtname IN ('start_rls_command','end_rls_command','sql_drop_command')
+ORDER BY evtname;
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
ns()?
+ publicationsCopy = list_copy(publications);
4) It is better wrap the word "streaming" with quote. Also, should we add
'no "validate_publication"' comment for validate_publication parameters?
NULL, NULL, /* no "binary" */
-
NULL, NULL); /* no streaming */
+
NULL, NULL, /* no streaming */
+
NULL, NULL);
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
p;err);
- if (!wrconn)
- ereport(ERROR,
- (errmsg("could not connect to the
publisher: %s", err)));
-
/* Get the table list from publisher. */
pubrel_names = fetch_table_list(wrconn, sub->publications);
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
On Thu, 06 May 2021 at 17:30, Peter Smith wrote:
> On Thu, May 6, 2021 at 7:18 PM Japin Li wrote:
>>
>>
>> On Thu, 06 May 2021 at 17:08, Peter Smith wrote:
>> > On Wed, May 5, 2021 at 12:35 PM Tom Lane wrote:
>> >>
>> >> Peter Smith writ
On Thu, 06 May 2021 at 21:52, vignesh C wrote:
> On Thu, May 6, 2021 at 9:08 AM Japin Li wrote:
>> 3) Should we free the memory when finish the check_publications()?
>> + publicationsCopy = list_copy(publications);
>
> I felt this list entries will be deleted in
not tested
>
> I have also seen this error with logical replication using pglogical
> extension, will this patch also address similar problem with pglogical?
Does there is a test case to reproduce this problem (using pglogical)?
I encountered this, however I'm not find a case to repr
uot;subscription must contain at least one publication"),
errdetail("Dropping all the publications from a subscription
is not supported")));
>> merge_publications can be called after validation of the options
>> specified, I think we should check if the options specified are
>> correct or not before checking the actual publications.
>
> +1. That was a miss in the original feature.
>
+1.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
be called after validation of the options
>> > specified, I think we should check if the options specified are
>> > correct or not before checking the actual publications.
>>
>> +1. That was a miss in the original feature.
>
> Attached patch has the changes for the same.
>
Thanks for updating the patch. I have a little comments for the new patch.
- ADD adds additional publications,
- DROP removes publications from the list of
+ ADD adds additional publications from the list of
I think, we should change the word 'from' to 'to'.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
|~^~~~
/home/japin/Codes/postgres/Debug/../src/backend/optimizer/path/joinpath.c: In
function ‘paraminfo_get_equal_hashops’:
/home/japin/Codes/postgres/Debug/../src/backend/optimizer/path/joinpath.c:378:42:
warning: unused parameter ‘root’ [-Wunused-parameter]
On Fri, 30 Sep 2022 at 22:09, Bharath Rupireddy
wrote:
> On Fri, Sep 30, 2022 at 7:30 PM Japin Li wrote:
>>
>> When I try to use -Wunused-parameter, I find there are many warnings :-( .
>
> Great!
>
> I think we can't just remove every unused parameter, f
Hi hackers,
I find there are some unnecessary commas for goto lables,
attached a patch to remove them.
--
Regrads,
Japin Li.
ChengDu WenWu Information Technology Co.,Ltd.
>From 3ac7d03e1c5d81e883406ac62fafbe7e7d32fd1e Mon Sep 17 00:00:00 2001
From: Japin Li
Date: Sun, 9 Oct 2022 07:35
On Sun, 09 Oct 2022 at 11:07, Julien Rouhaud wrote:
> Hi,
>
> On Sun, Oct 09, 2022 at 07:42:58AM +0800, Japin Li wrote:
>>
>> Hi hackers,
>>
>> I find there are some unnecessary commas for goto lables,
>> attached a patch to remove them.
>
> You me
101 - 200 of 362 matches
Mail list logo
