On Fri, 08 Dec 2023 at 18:08, Andrey M. Borodin <x4...@yandex-team.ru> wrote: >> On 8 Dec 2023, at 12:59, Japin Li <japi...@hotmail.com> wrote: >> >> >> On Thu, 07 Dec 2023 at 20:40, Andrey M. Borodin <x4...@yandex-team.ru> wrote: >>>> On 7 Dec 2023, at 06:25, Japin Li <japi...@hotmail.com> wrote: >>>> >>>> If idle_in_transaction_timeout is bigger than transaction_timeout, >>>> the idle-in-transaction timeout don't needed, right? >>> Yes, I think so. >>> >> >> Should we disable the idle_in_transaction_timeout in this case? Of cursor, >> I'm >> not strongly insist on this. > Good idea! > >> I think you forget disable transaction_timeout in AutoVacWorkerMain(). >> If not, can you elaborate on why you don't disable it? > > Seems like code in autovacuum.c was copied, but patch was not updated. I’ve > fixed this oversight. >
Thanks for updating the patch. LGTM. -- Regrads, Japin Li ChengDu WenWu Information Technology Co., Ltd.
