Re: proposal: function pg_setting_value_split() to parse shared_preload_libraries etc.

2020-12-02 Thread Ian Lawrence Barwick
2020年11月30日(月) 14:53 Craig Ringer : > > On Mon, 30 Nov 2020 at 03:24, Anastasia Lubennikova > wrote: > > > > On 23.10.2020 05:06, Ian Lawrence Barwick wrote: > > > Having just submitted this, I realised I'm focussing on the GUCs which > > > call >

Re: Feature request: Connection string parsing for postgres_fdw

2020-12-24 Thread Ian Lawrence Barwick
2020年12月23日(水) 22:05 Eric Hanson : > > I'm trying to store connection to postgres_fdw in the database I want to be > able to store the full breadth of connection styles and all the different > types of connections that libpq supports. But having some troubles. > > Postgres_fdw wants options pas

Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses

2021-02-14 Thread Ian Lawrence Barwick
2021年2月13日(土) 11:52 Michael Paquier : > On Fri, Feb 12, 2021 at 10:32:14AM +0900, Ian Lawrence Barwick wrote: > > In the documentation, the "[ NO ]" option is listed in the synopsis for > > ALTER TRIGGER and ALTER FUNCTION, but not the others. > > Trivial patch atta

Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses

2021-02-14 Thread Ian Lawrence Barwick
2021年2月13日(土) 11:52 Michael Paquier : > On Fri, Feb 12, 2021 at 10:32:14AM +0900, Ian Lawrence Barwick wrote: > > In the documentation, the "[ NO ]" option is listed in the synopsis for > > ALTER TRIGGER and ALTER FUNCTION, but not the others. > > Trivial patch atta

Re: [DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses

2021-02-15 Thread Ian Lawrence Barwick
2021年2月16日(火) 10:20 Michael Paquier : > On Mon, Feb 15, 2021 at 03:57:04PM +0900, Ian Lawrence Barwick wrote: > > Indeed it does. Not the most exciting of use cases, though I imagine it > > might come in handy for anyone developing an extension, and the > > existing implement

Re: [patch] ENUM errdetail should mention bytes, not chars

2020-10-27 Thread Ian Lawrence Barwick
2020年10月27日(火) 20:00 Peter Eisentraut : > > On 2020-10-19 06:34, Julien Rouhaud wrote: > >> ERROR: invalid enum label "ああ" > >> DETAIL: Labels must be 63 characters or less. > >> > >> Attached trivial patch changes the message to: > >> > >> DETAIL: Labels must

Re: Corner-case bug in pg_rewind

2020-11-15 Thread Ian Lawrence Barwick
2020年11月10日(火) 18:07 Pavel Borisov : > > I did some effort to review your patch which seems legit to me. Thanks for the review and feedback. > I think some minor things are better to be improved i.e. > > 1. Comment regarding > -- > 347 * Check for the possibility that the target is i

Re: Tracking cluster upgrade and configuration history

2020-11-15 Thread Ian Lawrence Barwick
2020年11月16日(月) 15:48 Bharath Rupireddy : > > On Thu, Nov 12, 2020 at 4:01 AM Mark Dilger > wrote: > > > > While supporting customers, it would frequently be useful to have more > > information about the history of a cluster. For example, which prior > > versions were ever installed and running

Re: [doc] improve tableoid description

2020-11-22 Thread Ian Lawrence Barwick
2020年11月21日(土) 16:29 Peter Eisentraut : > > On 2020-10-19 14:28, Ian Lawrence Barwick wrote: > > On further reflection, I think trying to explain all that is going to > > end up as a > > mini-tutorial which is beyond the scope of the explanation of a column, so >

Re: psql \df choose functions by their arguments

2021-01-10 Thread Ian Lawrence Barwick
Hi I tried this patch out last year but was overrolled by Other Stuff before I got around to providing any feedback, and was reminded of it just now when I was trying to execute "\df somefunction text int" or similar, which had me confused until I remembered it's not a feature yet, so it would cer

"has_column_privilege()" issue with attnums and non-existent columns

2021-01-11 Thread Ian Lawrence Barwick
Greetings Consider a table set up as follows: CREATE TABLE foo (id INT, val TEXT); ALTER TABLE foo DROP COLUMN val; When specifying the name of a dropped or non-existent column, the function "has_column_privilege()" works as expected: postgres=# SELECT has_column_privilege('foo', 'v

Re: adding wait_start column to pg_locks

2021-01-13 Thread Ian Lawrence Barwick
Hi 2021年1月4日(月) 15:04 torikoshia : > > On 2021-01-02 06:49, Justin Pryzby wrote: > > On Tue, Dec 15, 2020 at 11:47:23AM +0900, torikoshia wrote: > >> So I'm now thinking about adding a new column in pg_locks which > >> keeps the time at which locks started waiting. > >> > >> Attached a patch. > >

Re: adding wait_start column to pg_locks

2021-01-14 Thread Ian Lawrence Barwick
2021年1月15日(金) 3:45 Robert Haas : > On Wed, Jan 13, 2021 at 10:40 PM Ian Lawrence Barwick > wrote: > > It looks like the logical place to store the value is in the PROCLOCK > > structure; ... > > That seems surprising, because there's one PROCLOCK for every > com

Pg14, pg_dumpall and "password_encryption=true"

2021-01-14 Thread Ian Lawrence Barwick
Greetings Consider the following: postgres=# SELECT current_setting('server_version'); current_setting - 12.5 (1 row) postgres=# SELECT * FROM pg_db_role_setting WHERE setrole = 10; setdatabase | setrole | setconfig -+---

Re: psql \df choose functions by their arguments

2021-01-18 Thread Ian Lawrence Barwick
2021年1月15日(金) 1:46 Greg Sabino Mullane : > Thanks for the feedback: new version v5 (attached) has int8, plus the > suggested code formatting. > > Cheers, > Greg > Thanks for the update. In my preceding mail I meant we should add int2, int4 and int8 for completeness (apologies, I was a bit unclea

Re: POC: postgres_fdw insert batching

2021-01-21 Thread Ian Lawrence Barwick
Hi 2021年1月21日(木) 8:00 Tomas Vondra : > OK, pushed after a little bit of additional polishing (mostly comments). > > Thanks everyone! > There's a minor typo in the doc's version of the ExecForeignBatchInsert() declaration; is: TupleTableSlot ** ExecForeignBatchInsert(EState *estate,

Re: "has_column_privilege()" issue with attnums and non-existent columns

2021-01-28 Thread Ian Lawrence Barwick
2021年1月28日(木) 17:18 Peter Eisentraut : > On 2021-01-12 06:53, Ian Lawrence Barwick wrote: > > postgres=# SELECT has_column_privilege('foo', 999::int2, 'SELECT'); > > has_column_privilege > > -- > > t >

psql tab completion for CREATE DATABASE ... LOCALE

2021-02-04 Thread Ian Lawrence Barwick
Greetings This morning I was overcome by an urge to create a database with a specific locale, and my insufficiently caffeinated brain reminded me there was a handy LOCALE option added not so long ago, but was confused by its stubborn absence from the list of tab completion options presented by psq

Re: POC: postgres_fdw insert batching

2021-02-04 Thread Ian Lawrence Barwick
2021年1月22日(金) 14:50 Ian Lawrence Barwick : > Hi > > 2021年1月21日(木) 8:00 Tomas Vondra : > >> OK, pushed after a little bit of additional polishing (mostly comments). >> >> Thanks everyone! >> > > There's a minor typo in the doc's version

Re: POC: postgres_fdw insert batching

2021-02-04 Thread Ian Lawrence Barwick
2021年1月22日(金) 14:50 Ian Lawrence Barwick : > Hi > > 2021年1月21日(木) 8:00 Tomas Vondra : > >> OK, pushed after a little bit of additional polishing (mostly comments). >> >> Thanks everyone! >> > > There's a minor typo in the doc's version

Re: SPI: process exit in SPI_exec when table not exist. error code not return.

2021-02-04 Thread Ian Lawrence Barwick
2021年2月5日(金) 11:38 sasa su : > Hi. > > When running a query with a not exist table in SPI_exec. the process exit > with -1 in SPI_exec function. > the error code SPI_ERROR_REL_NOT_FOUND never return. > > I made a minimal reproduction code in > https://github.com/Sasasu/worker_spi_table_not_exist >

Re: psql tab completion for CREATE DATABASE ... LOCALE

2021-02-04 Thread Ian Lawrence Barwick
2021年2月5日(金) 11:51 Thomas Munro : > On Fri, Feb 5, 2021 at 2:40 PM Ian Lawrence Barwick > wrote: > > Trivialest of trivial patches attached (will add to next CF). > > Thanks, pushed. > Oh, that was quick, thanks! I hadn't even got round to adding it to the

[DOC] add missing "[ NO ]" to various "DEPENDS ON" synopses

2021-02-11 Thread Ian Lawrence Barwick
Greetings We have following syntax: ALTER THING name [ NO ] DEPENDS ON EXTENSION name for the following THINGs: - ALTER TRIGGER - ALTER FUNCTION - ALTER PROCEDURE - ALTER ROUTINE - ALTER MATERIALIZED VIEW - ALTER INDEX In the documentation, the "[ NO ]" option is listed in the synopsis for

Re: Clarifying the ImportForeignSchema API

2020-08-03 Thread Ian Lawrence Barwick
2020年8月4日(火) 12:08 David Fetter : > > Folks, > > I noticed that the API document for IMPORT FOREIGN SCHEMA states in > part: > > It should return a list of C strings, each of which must contain a > CREATE FOREIGN TABLE command. These strings will be parsed and > executed by the core ser

Re: Docs: inaccurate description about config settings

2020-09-01 Thread Ian Lawrence Barwick
2020年9月1日(火) 19:37 Li Japin : > > Hi, hackers > > When I setup a stream replication I found that the documentation says that > promote_trigger_file > parameter can only be set in the postgresql.conf file or on the server > command line, however, it > can also be put into postgresql.auto.conf. If

Re: Allow passing extra options to initdb for tests

2024-02-06 Thread Ian Lawrence Barwick
2024年2月6日(火) 19:54 Peter Eisentraut : > > I'm proposing here a way to pass extra options to initdb when run > internally during test setup in pg_regress or > PostgreSQL::Test::Cluster's init (which covers just about all test > suites other than initdb's own tests). > > For example: > > make ch

Re: Allow passing extra options to initdb for tests

2024-02-13 Thread Ian Lawrence Barwick
2024年2月7日(水) 12:51 Ian Lawrence Barwick : > > 2024年2月6日(火) 19:54 Peter Eisentraut : > > > > I'm proposing here a way to pass extra options to initdb when run > > internally during test setup in pg_regress or > > PostgreSQL::Test::Cluster's init (which cov

Have pg_basebackup write "dbname" in "primary_conninfo"?

2024-02-19 Thread Ian Lawrence Barwick
Hi Hi With the addition of "pg_sync_replication_slots()", there is now a use-case for including "dbname" in "primary_conninfo" and the docs have changed from stating [1]: Do not specify a database name in the primary_conninfo string. to [2]: For replication slot synchronization (see Secti

Re: pg_rewind race condition just after promotion

2022-12-10 Thread Ian Lawrence Barwick
2021年11月9日(火) 20:31 Daniel Gustafsson : > > > On 14 Jul 2021, at 14:03, Aleksander Alekseev > > wrote: > > > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant:

Re: [RFC] Add jit deform_counter

2022-12-10 Thread Ian Lawrence Barwick
2022年6月12日(日) 18:14 Dmitry Dolgov <9erthali...@gmail.com>: > > Hi, > > I've noticed that JIT performance counter generation_counter seems to include > actions, relevant for both jit_expressions and jit_tuple_deforming options. It > means one can't directly see what is the influence of jit_tuple_def

Re: Allow parallel plan for referential integrity checks?

2022-12-10 Thread Ian Lawrence Barwick
2022年7月26日(火) 20:58 Frédéric Yhuel : > > > > On 4/14/22 14:25, Frédéric Yhuel wrote: > > > > > > On 3/19/22 01:57, Imseih (AWS), Sami wrote: > >> I looked at your patch and it's a good idea to make foreign key > >> validation > >> use parallel query on large relations. > >> > >> It would be valuabl

Re: [PROPOSAL] new diagnostic items for the dynamic sql

2022-12-10 Thread Ian Lawrence Barwick
2022年8月3日(水) 7:56 Tom Lane : > > Jacob Champion writes: > > ...and Dinesh's email has just bounced back undelivered. :( > > > Anybody interested in running with this? If no one speaks up, I think we > > should return this as "needs more interest" before the next CF starts. > > Meh ... the last ver

Re: Proposal for internal Numeric to Uint64 conversion function.

2022-12-13 Thread Ian Lawrence Barwick
2022年10月3日(月) 1:55 Andres Freund : > > Hi, > > The patch for this CF entry doesn't apply currently, and it looks like that's > been the case for quite a while... As that's remained the case and the last update from the author was in May, we'll close this as "returned with feedback". A new entry ca

Re: [PATCH] Add function to_oct

2022-12-20 Thread Ian Lawrence Barwick
2022年12月21日(水) 7:08 Eric Radman :> > Hello! > > This patch is a new function based on the implementation of to_hex(int). > > Since support for octal integer literals was added, to_oct(int) allows > octal values to be easily stored and returned in query results. > > to_oct(0o755) = '755' > > This

Re: Add LSN along with offset to error messages reported for WAL file read/write/validate header failures

2022-12-20 Thread Ian Lawrence Barwick
2022年12月20日(火) 21:35 Bharath Rupireddy : > > On Tue, Dec 20, 2022 at 1:27 PM Magnus Hagander wrote: > > > > On Tue, Dec 20, 2022 at 5:40 AM Michael Paquier wrote: > >> > >> On Tue, Dec 20, 2022 at 09:01:02AM +0900, Michael Paquier wrote: > >> > Yeah, my mind was considering as well yesterday the

Re: [PATCH] Add function to_oct

2022-12-20 Thread Ian Lawrence Barwick
2022年12月21日(水) 10:42 Eric Radman : > > On Wed, Dec 21, 2022 at 08:36:40AM +0900, Ian Lawrence Barwick wrote: > > 2022年12月21日(水) 7:08 Eric Radman :> > > > Hello! > > > > > > This patch is a new function based on the implementation of to_hex(int). > >

Re: Getting rid of SQLValueFunction

2022-12-29 Thread Ian Lawrence Barwick
Hi 2022年11月21日(月) 18:39 Michael Paquier : > > On Sun, Nov 20, 2022 at 03:15:34PM -0800, Ted Yu wrote: > > + * timestamp. These require a specific handling with their typmod is given > > + * by the function caller through their SQL keyword. > > > > typo: typmod is given -> typmod given > > > > Oth

"CREATE RULE ... ON SELECT": redundant?

2023-05-03 Thread Ian Lawrence Barwick
Hi Commit b23cd185f [1] forbids manual creation of ON SELECT rule on a table, and updated the main rules documentation [2], but didn't update the corresponding CREATE RULE page [3]. [1] https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=b23cd185fd5410e5204683933f848d4583e34b35 [2] ht

Re: "CREATE RULE ... ON SELECT": redundant?

2023-05-03 Thread Ian Lawrence Barwick
2023年5月4日(木) 12:51 Tom Lane : > > Ian Lawrence Barwick writes: > > While poking around at an update for that, unless I'm missing something it > > is > > now not possible to use "CREATE RULE ... ON SELECT" for any kind of > > relation, > > g

Re: patch: improve "user mapping not found" error message

2023-11-19 Thread Ian Lawrence Barwick
2023年7月3日(月) 18:22 Peter Eisentraut : > > On 23.06.23 09:45, Ian Lawrence Barwick wrote: > > if (!HeapTupleIsValid(tp)) > > + { > > + ForeignServer *server = GetForeignServer(serverid); > > + > > ereport(ERROR, > &

Re: doc patch: note AttributeRelationId passed to FDW validator function

2023-12-27 Thread Ian Lawrence Barwick
2023年6月7日(水) 9:08 Ian Lawrence Barwick : > > Hi > > Here: > > https://www.postgresql.org/docs/current/fdw-functions.html > > the enumeration of OIDs which might be passed as the FDW validator function's > second argument omits "AttributeRelationId" (a

Re: doc patch: note AttributeRelationId passed to FDW validator function

2023-12-28 Thread Ian Lawrence Barwick
2023年12月28日(木) 15:37 Michael Paquier : > > On Thu, Dec 28, 2023 at 01:55:27PM +0900, Ian Lawrence Barwick wrote: > > 2023年6月7日(水) 9:08 Ian Lawrence Barwick : > >> The alternative v2 patch adds this to this list of OIDs, and also > >> formats it as an > >>

Re: pg_stat_get_backend_subxact() and backend IDs?

2023-09-17 Thread Ian Lawrence Barwick
2023年8月31日(木) 6:56 Nathan Bossart : > > On Wed, Aug 30, 2023 at 10:56:22AM -0400, Robert Haas wrote: > > On Wed, Aug 30, 2023 at 10:27 AM Nathan Bossart > > wrote: > >> I'm about to spend way too much time writing the commit message for 0002, > >> but I plan to commit both patches sometime today.

docs: pg_replication_origin_oid() description does not match behaviour

2022-01-17 Thread Ian Lawrence Barwick
Hi >From the documentation for pg_replication_origin_oid() [1]: > Looks up a replication origin by name and returns the internal ID. > If no such replication origin is found an error is thrown. However, it actually returns NULL if the origin does not exist: postgres=# SELECT * FROM pg_repli

Re: docs: pg_replication_origin_oid() description does not match behaviour

2022-01-18 Thread Ian Lawrence Barwick
2022年1月19日(水) 10:40 Michael Paquier : > > On Tue, Jan 18, 2022 at 06:20:22PM +, Bossart, Nathan wrote: > > +1 > > And done. Thanks! Ian Barwick -- EnterpriseDB: https://www.enterprisedb.com

Re: is the base backup protocol used by out-of-core tools?

2022-02-08 Thread Ian Lawrence Barwick
2022年2月9日(水) 11:21 Michael Paquier : > > On Tue, Feb 08, 2022 at 11:26:41AM -0500, Robert Haas wrote: > > From that point of view, there's no downside to removing from the > > server the old syntax for BASE_BACKUP and the old protocol for taking > > backups. We can't remove anything from pg_basebac

Re: List of all* PostgreSQL EXTENSIONs in the world

2022-02-10 Thread Ian Lawrence Barwick
2022年2月11日(金) 5:19 Joel Jacobson : > > Hi hackers, > > I've compiled a list of all* PostgreSQL EXTENSIONs in the world: > > https://gist.github.com/joelonsql/e5aa27f8cc9bd22b8999b7de8aee9d47 > > *) It's not all, but 1041, compared to the 338 found on PGXN. More precisely it's a list of all? the re

Re: [patch] Have psql's \d+ indicate foreign partitions

2022-11-06 Thread Ian Lawrence Barwick
2022年11月6日(日) 1:39 Tom Lane : > > Michael Paquier writes: > > On Mon, Oct 24, 2022 at 09:44:18PM +0900, Ian Lawrence Barwick wrote: > >> Recently I have been working a lot with partitioned tables which contain a > >> mix > >> of local and foreign partitio

Re: [patch] Have psql's \d+ indicate foreign partitions

2022-11-07 Thread Ian Lawrence Barwick
2022年11月8日(火) 14:49 Michael Paquier : > > On Mon, Nov 07, 2022 at 01:43:22AM -0500, Tom Lane wrote: > > WFM. > > Okay, applied as bd95816, then. Thanks! CF entry updated accordingly. Regards Ian Barwick

Re: Commit fest 2022-11

2022-11-14 Thread Ian Lawrence Barwick
2022年11月9日(水) 8:12 Justin Pryzby : > > On Thu, Nov 03, 2022 at 07:43:03PM -0500, Justin Pryzby wrote: > > On Thu, Nov 03, 2022 at 11:33:57AM +0900, Ian Lawrence Barwick wrote: > > > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56

Re: Commit fest 2022-11

2022-11-14 Thread Ian Lawrence Barwick
2022年11月14日(月) 22:23 James Coleman : > > On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick > wrote: > > > > 2022年11月9日(水) 8:12 Justin Pryzby : > > > > If my script is not wrong, these patches add TAP tests, but don't update > > > the requi

Re: Documentation for building with meson

2022-11-15 Thread Ian Lawrence Barwick
2022年10月20日(木) 11:43 Justin Pryzby : > > On Wed, Oct 19, 2022 at 11:35:10AM -0700, samay sharma wrote: > > Creating a new thread focussed on adding docs for building Postgres with > > meson. This is a spinoff from the original thread [1] and I've attempted to > > address all the feedback provided t

Re: logical replication restrictions

2022-11-15 Thread Ian Lawrence Barwick
2022年11月14日(月) 10:09 Takamichi Osumi (Fujitsu) : > > On Tuesday, November 8, 2022 2:27 PM Kuroda, Hayato/黒田 隼人 > wrote: > > If you could not allocate a time to discuss this problem because of other > > important tasks or events, we would like to take over the thread and modify > > your patch. > >

Re: Skipping schema changes in publication

2022-11-15 Thread Ian Lawrence Barwick
2022年11月7日(月) 22:39 vignesh C : > > On Fri, 4 Nov 2022 at 08:19, Ian Lawrence Barwick wrote: > > > > Hi > > > > cfbot reports the patch no longer applies [1]. As CommitFest 2022-11 is > > currently underway, this would be an excellent time to update the patch.

Re: Switching XLog source from archive to streaming when primary available

2022-11-15 Thread Ian Lawrence Barwick
2022年10月18日(火) 11:02 Bharath Rupireddy : > > On Tue, Oct 11, 2022 at 8:40 AM Nathan Bossart > wrote: > > > > On Mon, Oct 10, 2022 at 11:33:57AM +0530, Bharath Rupireddy wrote: > > > On Mon, Oct 10, 2022 at 3:17 AM Nathan Bossart > > > wrote: > > >> I wonder if it would be better to simply remov

Re: Testing autovacuum wraparound (including failsafe)

2022-11-15 Thread Ian Lawrence Barwick
2022年6月30日(木) 10:40 Masahiko Sawada : > > Hi, > > On Tue, Feb 1, 2022 at 11:58 AM Masahiko Sawada wrote: > > > > On Fri, Jun 11, 2021 at 10:19 AM Andres Freund wrote: > > > > > > Hi, > > > > > > On 2021-06-10 16:42:01 +0300, Anastasia Lubennikova wrote: > > > > Cool. Thank you for working on that

Re: logical decoding and replication of sequences, take 2

2022-11-15 Thread Ian Lawrence Barwick
2022年11月12日(土) 7:49 Tomas Vondra : > > Hi, > > I noticed on cfbot the patch no longer applies, so here's a rebased > version. Most of the breakage was due to the column filtering reworks, > grammar changes etc. A lot of bitrot, but mostly mechanical stuff. (...) Hi Thanks for the update patch.

Re: vacuumlo: add test to vacuumlo for test coverage

2022-11-15 Thread Ian Lawrence Barwick
2022年9月3日(土) 17:28 Dong Wook Lee : > > Hi hackers, > I write a tiny patch about vacuumlo to improve test coverage. > I hope my work is meaningful. Hi While reviewing the patch backlog, we have determined that this patch adds one or more TAP tests but has not added the test to the "meson.build" fi

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-15 Thread Ian Lawrence Barwick
2022年11月14日(月) 14:41 Michael Paquier : > > On Sat, Nov 12, 2022 at 04:13:53PM +0800, Julien Rouhaud wrote: > > It's looks good to me. I agree that file name and line number should be > > enough > > to diagnose any unexpected error. > > Thanks for checking. I have looked at 0001 and 0002 again wi

Re: Commit fest 2022-11

2022-11-16 Thread Ian Lawrence Barwick
2022年11月14日(月) 22:38 Ian Lawrence Barwick : > > 2022年11月14日(月) 22:23 James Coleman : > > > > On Mon, Nov 14, 2022 at 7:08 AM Ian Lawrence Barwick > > wrote: > > > > > > 2022年11月9日(水) 8:12 Justin Pryzby : > > > > > > If my script

Re: pglz compression performance, take two

2022-11-16 Thread Ian Lawrence Barwick
2021年11月5日(金) 14:51 Andrey Borodin : > > Thanks for the review Mark! Sorry it took too long to reply on my side. > > > 28 июня 2021 г., в 21:05, Mark Dilger > > написал(а): > > > >> #define PGLZ_HISTORY_SIZE 0x0fff - 1 /* to avoid compare in > >> iteration */ > > ... > >> static PGLZ_Hist

Re: Parallel Full Hash Join

2022-11-16 Thread Ian Lawrence Barwick
2022年4月8日(金) 20:30 Thomas Munro : > > On Wed, Jan 12, 2022 at 10:30 AM Melanie Plageman > wrote: > > On Fri, Nov 26, 2021 at 3:11 PM Thomas Munro wrote: > > > #3 0x009cf57e in ExceptionalCondition (conditionName=0x29cae8 > > > "BarrierParticipants(&accessor->shared->batch_barrier) == 1",

Re: ps command does not show walsender's connected db

2022-11-16 Thread Ian Lawrence Barwick
2022年10月11日(火) 20:06 Bharath Rupireddy : > > On Tue, Oct 11, 2022 at 2:11 PM bt22nakamorit > wrote: > > > > 2022-10-10 16:12 Bharath Rupireddy wrote: > > > Thanks. LGTM. > > Thank you for your review! > > I have this issue posted on Commitfest 2022-11 with title "show > > walsender's connected db

Re: [PATCH] Allow specification of custom slot for custom nodes

2022-11-26 Thread Ian Lawrence Barwick
2022年11月22日(火) 5:50 Alexander Korotkov : > > On Mon, Nov 21, 2022 at 4:34 PM Pavel Borisov wrote: > > The following review has been posted through the commitfest application: > > make installcheck-world: tested, passed > > Implements feature: tested, passed > > Spec compliant: not

CF 2022-11: entries "Waiting for Committer" but no recent activity

2022-11-26 Thread Ian Lawrence Barwick
Hi Apologies for the intermission in activity, among other "fun" things had a family visitation of the influenza virus, which is becoming fashionable in these parts again. In an attempt to salvage something from the situation I am having a crack at the older entries marked "Ready for Committer",

CF 2022-11: entries "Ready for Committer" with recent activity

2022-11-26 Thread Ian Lawrence Barwick
Hi This is an overview of the current patches marked "Ready for Committer" which have been actively worked on during the current CF. They largely fall into two categories: - active participation from likely committers - have been reviewed and marked as "RfC", but need committer interest Dates in

Re: Reducing power consumption on idle servers

2022-11-26 Thread Ian Lawrence Barwick
2022年11月22日(火) 5:50 Laurenz Albe : > > On Mon, 2022-11-21 at 12:11 -0500, Tom Lane wrote: > > Robert Haas writes: > > > The reason that I pushed back -- not as successfully as I would have > > > liked -- on the changes to pg_stop_backup / pg_start_backup is that I > > > know there are people using

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-26 Thread Ian Lawrence Barwick
2022年11月25日(金) 11:25 Julien Rouhaud : > > On Fri, Nov 25, 2022 at 07:41:59AM +0900, Michael Paquier wrote: > > On Thu, Nov 24, 2022 at 05:07:24PM +0800, Julien Rouhaud wrote: > > > So I went with CONF_FILE_START_DEPTH and CONF_FILE_MAX_DEPTH. Attached > > > v22 > > > that fixes it in all the plac

Re: Allow file inclusion in pg_hba and pg_ident files

2022-11-27 Thread Ian Lawrence Barwick
2022年11月27日(日) 20:04 Julien Rouhaud : > > On Sun, Nov 27, 2022 at 03:39:44PM +0800, Julien Rouhaud wrote: > > Le dim. 27 nov. 2022 à 15:31, Ian Lawrence Barwick > > > > > > > > I'm trying to reconcile open CommitFest entries with their actual > > &g

Re: Understanding, testing and improving our Windows filesystem code

2022-11-27 Thread Ian Lawrence Barwick
2022年10月25日(火) 13:12 Thomas Munro : > > I pushed the bug fixes from this series, without their accompanying > tests. Here's a rebase of the test suite, with all those tests now > squashed into the main test patch, and also the > tell-Windows-to-be-more-like-Unix patch. Registered in the > commitf

Re: Understanding, testing and improving our Windows filesystem code

2022-11-27 Thread Ian Lawrence Barwick
2022年10月25日(火) 13:12 Thomas Munro : > > I pushed the bug fixes from this series, without their accompanying > tests. Here's a rebase of the test suite, with all those tests now > squashed into the main test patch, and also the > tell-Windows-to-be-more-like-Unix patch. Registered in the > commitf

Re: Atomic rename feature for Windows.

2022-11-30 Thread Ian Lawrence Barwick
2022年10月19日(水) 6:06 Thomas Munro : > > On Wed, Apr 6, 2022 at 10:40 AM Victor Spirin wrote: > > Updated patch: we use the posix semantic features in Windows build 17763 > > and up. > > We found an issue with this feature on Windows Server 2016 without > > updates (Windows 1607 Build 14393) > > Hi

Re: daitch_mokotoff module

2022-11-30 Thread Ian Lawrence Barwick
Hi Dag 2022年2月3日(木) 23:27 Dag Lem : > > Hi, > > Just some minor adjustments to the patch: > > * Removed call to locale-dependent toupper() > * Cleaned up input normalization This patch was marked as "Waiting on Author" in the CommitFest entry [1] but I see you provided an updated version which ha

Re: pg_basebackup: add test about zstd compress option

2022-12-02 Thread Ian Lawrence Barwick
Hi I was looking at the commitfest entry for this patch [1] as it's been dormant for quite a while, with the intent of returning it with feedback. [1] https://commitfest.postgresql.org/40/3835/ 2022年8月25日(木) 16:52 Dong Wook Lee : > > On Tue, Aug 23, 2022 at 11:37 AM Michael Paquier wrote: > > >

Re: Think-o in foreign key comments

2022-12-02 Thread Ian Lawrence Barwick
2022年12月3日(土) 7:19 Paul Jungwirth : > > Hello, > > I noticed a few places in the new foreign key code where a comment says > "the ON DELETE SET NULL/DELETE clause". I believe it should say "ON > DELETE SET NULL/DEFAULT". > > These comments were added in d6f96ed94e7, "Allow specifying column list >

docs: add missing id elements for developer GUCs

2022-12-02 Thread Ian Lawrence Barwick
Hi A few of the developer option GUCs were missing the "id" attribute in their markup, making it impossible to link to them directly. Specifically the entries from "trace_locks" to "log_btree_build_stats" here: https://www.postgresql.org/docs/current/runtime-config-developer.html Patch appl

doc: add missing "id" attributes to extension packaging page

2022-12-04 Thread Ian Lawrence Barwick
Hi On this page: https://www.postgresql.org/docs/current/extend-extensions.html three of the sections are missing an "id" attribute; patch adds these. Noticed when trying to create a stable link to one of the affected sections. Regards Ian Barwick From c0dec489ec5b088d7e16b814aef9750ff271c6

Re: pg_basebackup: add test about zstd compress option

2022-12-05 Thread Ian Lawrence Barwick
2022年12月5日(月) 23:59 Robert Haas : > > On Fri, Dec 2, 2022 at 11:29 PM Ian Lawrence Barwick > wrote: > > Though on reflection maybe it's overkill and the existing tests > > suffice. Anyway leaving the patch here in the interests of pushing > > this forward in some

Re: doc: add missing "id" attributes to extension packaging page

2022-12-05 Thread Ian Lawrence Barwick
2022年12月5日(月) 18:56 Alvaro Herrera : > > On 2022-Dec-05, Ian Lawrence Barwick wrote: > > > On this page: > > > > https://www.postgresql.org/docs/current/extend-extensions.html > > > > three of the sections are missing an "id" attribute; patc

Re: docs: add missing id elements for developer GUCs

2022-12-05 Thread Ian Lawrence Barwick
2022年12月5日(月) 11:25 Michael Paquier : > > On Sat, Dec 03, 2022 at 03:58:19PM +0900, Ian Lawrence Barwick wrote: > > A few of the developer option GUCs were missing the "id" attribute > > in their markup, making it impossible to link to them directly. > > True en

Re: PG 14 release notes, first draft

2021-05-10 Thread Ian Lawrence Barwick
2021年5月10日(月) 15:03 Bruce Momjian : > > I have committed the first draft of the PG 14 release notes. You can > see the most current build of them here: > > https://momjian.us/pgsql_docs/release-14.html > > I need clarification on many items, and the document still needs its > items proper

doc: add entry for pg_get_partkeydef()

2022-10-10 Thread Ian Lawrence Barwick
Hi Small patch for $subject, as the other pg_get_XXXdef() functions are documented and I was looking for this one but couldn't remember what it was called. Regards Ian Barwick commit 1ab855e72e077abad247cc40619b6fc7f7758983 Author: Ian Barwick Date: Mon Oct 10 22:32:31 2022 +0900 doc: ad

Re: doc: add entry for pg_get_partkeydef()

2022-10-12 Thread Ian Lawrence Barwick
2022年10月12日(水) 3:29 Tom Lane : > Ian Lawrence Barwick writes: > > Small patch for $subject, as the other pg_get_XXXdef() functions are > > documented > > and I was looking for this one but couldn't remember what it was called. > > Seems reasonable. Pushed with m

[patch] Have psql's \d+ indicate foreign partitions

2022-10-24 Thread Ian Lawrence Barwick
Hi Recently I have been working a lot with partitioned tables which contain a mix of local and foreign partitions, and find it would be very useful to be able to easily obtain an overview of which partitions are foreign and where they are located. Currently, executing "\d+" on a partitioned table

Re: [patch] Have psql's \d+ indicate foreign partitions

2022-10-31 Thread Ian Lawrence Barwick
2022年10月27日(木) 16:12 Alvaro Herrera : > > On 2022-Oct-24, Justin Pryzby wrote: > > > On Mon, Oct 24, 2022 at 09:44:18PM +0900, Ian Lawrence Barwick wrote: > > > > + else if (child_relkind == > > > REL

Re: Commit fest 2022-11

2022-10-31 Thread Ian Lawrence Barwick
2022年10月31日(月) 14:42 Michael Paquier : > > Hi all, > > As per the world clock, the next commit fest will begin in 30 hours > (11/1 0:00 AoE time). I may have missed something, but it looks like > we have no CFM for this one yet. ** tumbleweed ** > Opinions, thoughts or volunteers? This is on my

Re: Commit fest 2022-11

2022-11-01 Thread Ian Lawrence Barwick
2022年11月1日(火) 13:40 Michael Paquier : > > On Tue, Nov 01, 2022 at 10:01:05AM +0900, Ian Lawrence Barwick wrote: > > This is on my bucket list of things to do some day, so I guess now is as > > bad a > > time as any :). Caveat is that this will have to be a personal >

Re: Commit fest 2022-11

2022-11-01 Thread Ian Lawrence Barwick
2022年11月1日(火) 17:59 Simon Riggs : > > On Mon, 31 Oct 2022 at 05:42, Michael Paquier wrote: > > > As per the world clock, the next commit fest will begin in 30 hours > > (11/1 0:00 AoE time). I may have missed something, but it looks like > > we have no CFM for this one yet. > > > > Opinions, thou

Re: Commit fest 2022-11

2022-11-01 Thread Ian Lawrence Barwick
2022年11月2日(水) 1:36 Magnus Hagander :> > On Tue, Nov 1, 2022 at 11:59 AM Michael Paquier wrote: >> >> On Tue, Nov 01, 2022 at 07:10:15PM +0900, Ian Lawrence Barwick wrote: >> > Yup, Monday by the looks of it. >> > >> > My community login is "barwi

Re: Commit fest 2022-11

2022-11-02 Thread Ian Lawrence Barwick
2022年11月2日(水) 19:10 Greg Stark : > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > Two people showing up to help is really great, thanks! I'll be around > > as well this month, so I'll do my share of patches, as usual. > > Fwiw I can help as well -- starting next week. I can't do much

Re: Improve description of XLOG_RUNNING_XACTS

2022-11-03 Thread Ian Lawrence Barwick
2022年11月2日(水) 15:24 Amit Kapila : > > On Tue, Nov 1, 2022 at 4:33 PM Amit Kapila wrote: > > > > On Tue, Nov 1, 2022 at 12:53 PM Michael Paquier wrote: > > > > > > On Mon, Oct 17, 2022 at 02:53:57PM +0900, Michael Paquier wrote: > > > > No objections from here if you want to go ahead with v3 and p

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Ian Lawrence Barwick
2022年10月10日(月) 18:16 Aleksander Alekseev : > > Hi hackers, > > > Sorry about that. > > No problem. > > > Thanks, Simon. Not 100% sure who exactly is invited to vote, but just > > in case here is +1 from me. These patches were "Ready for Committer" > > for several months now and are unlikely to get

Re: Add index scan progress to pg_stat_progress_vacuum

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 1:52 Imseih (AWS), Sami : > > Attached is v13-0001--Show-progress-for-index-vacuums.patch which addresses > the latest comments. The main changes are: > > 1/ Call the parallel_vacuum_progress_report inside the AMs rather than > vacuum_delay_point. > > 2/ A Boolean when set to True in

Re: [PATCH] Add native windows on arm64 support

2022-11-03 Thread Ian Lawrence Barwick
2022年9月1日(木) 13:42 Michael Paquier : > > On Wed, Aug 31, 2022 at 10:22:06PM -0400, Tom Lane wrote: > > Michael Paquier writes: > > > The input object could also be reworked so as we would not have any > > > ordering issues, say "pre&deeppost". > > > Changing only the path, you could use "/e/n2" in

Re: XID formatting and SLRU refactorings (was: Add 64-bit XIDs into PostgreSQL 15)

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 17:15 Maxim Orlov : > > Hi! > >> >> This entry was marked "Ready for committer" in the CommitFest app but cfbot >> reports the patch no longer applies. > > Thanks for the reminder. I think, this should work. Thanks for the quick update, cfbot reports no issues. I've set the CF entry

Re: Adding CommandID to heap xlog records

2022-11-03 Thread Ian Lawrence Barwick
2022年9月30日(金) 1:04 Matthias van de Meent : > > On Wed, 28 Sept 2022 at 19:40, Bruce Momjian wrote: > > > > On Thu, Sep 22, 2022 at 11:12:32PM +0200, Matthias van de Meent wrote: > > > On Thu, 8 Sept 2022 at 23:24, Tom Lane wrote: > > > > > > > > Matthias van de Meent writes: > > > > > Please fin

Re: Commit fest 2022-11

2022-11-03 Thread Ian Lawrence Barwick
2022年11月3日(木) 11:33 Ian Lawrence Barwick : > > 2022年11月2日(水) 19:10 Greg Stark : > > > > On Tue, 1 Nov 2022 at 06:56, Michael Paquier wrote: > > > > > Two people showing up to help is really great, thanks! I'll be around > > > as well this

Re: Add semi-join pushdown to postgres_fdw

2022-11-03 Thread Ian Lawrence Barwick
2022年8月30日(火) 15:58 Alexander Pyhalov : > > Ashutosh Bapat писал 2022-08-29 17:12: > > Hi Alexander, > > Thanks for working on this. It's great to see FDW join pushdown scope > > being expanded to more complex cases. > > > > I am still figuring out the implementation. It's been a while I have > > l

Re: [PATCH] Completed unaccent dictionary with many missing characters

2022-11-03 Thread Ian Lawrence Barwick
2022年7月13日(水) 19:13 Przemysław Sztoch : > > Dear Michael P., > > 3. The matter is not that simple. When I change priorities (ie > Latin-ASCII.xml is less important than Unicode decomposition), > then "U + 33D7" changes not to pH but to PH. > In the end, I left it like it was before ... > > If you

Re: Data is copied twice when specifying both child and parent table in publication

2022-11-03 Thread Ian Lawrence Barwick
2022年10月17日(月) 14:49 wangw.f...@fujitsu.com : > > On Wed, Oct 5, 2022 at 11:08 AM Peter Smith wrote: > > Hi Wang-san. Here are my review comments for HEAD_v12-0001 patch. > > Thanks for your comments. > > > == > > > > 1. Missing documentation. > > > > In [1] you wrote: > > > I think the behavi

  1   2   >