2022年12月20日(火) 21:35 Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com>: > > On Tue, Dec 20, 2022 at 1:27 PM Magnus Hagander <mag...@hagander.net> wrote: > > > > On Tue, Dec 20, 2022 at 5:40 AM Michael Paquier <mich...@paquier.xyz> wrote: > >> > >> On Tue, Dec 20, 2022 at 09:01:02AM +0900, Michael Paquier wrote: > >> > Yeah, my mind was considering as well yesterday the addition of a note > >> > in the docs about something among these lines, so fine by me. > >> > >> And applied that, after tweaking a few tiny things on a last lookup > >> with a catversion bump. Note that the example has been moved at the > >> bottom of the table for these functions, which is more consistent with > >> the surroundings. > >> > > > > Hi! > > > > Caught this thread late. To me, pg_dissect_walfile_name() is a really > > strange name for a function. Grepping our I code I see the term dissect s > > used somewhere inside the regex code and exactly zero instances elsewhere. > > Which is why I definitely didn't recognize the term...
Late to the party too, but I did wonder about the name when I saw it. > > Wouldn't something like pg_split_walfile_name() be a lot more consistent > > with the rest of our names? > > Hm. FWIW, here's the patch. Hmm, "pg_split_walfile_name()" sounds like it would return three 8 character strings. Maybe something like "pg_walfile_name_elements()" ? Regards Ian Barwick
