Re: Proposal to include --exclude-extension Flag in pg_dump

2024-03-16 Thread Ayush Vatsa
s I added, are passing. Attached is the complete patch with all the required code changes. Looking forward to your review and feedback. On Wed, 6 Mar 2024 at 16:04, Dean Rasheed wrote: > On Mon, 1 Jan 2024 at 13:28, Ayush Vatsa wrote: > > > > According to the documentat

Re: Proposal to include --exclude-extension Flag in pg_dump

2024-03-19 Thread Ayush Vatsa
x27;s gratifying to see that my patch not only introduced the intended feature but also brought other minor mistakes to light. Regards Ayush Vatsa Amazon Web services (AWS) On Tue, 19 Mar 2024 at 17:23, Daniel Gustafsson wrote: > > On 19 Mar 2024, at 12:19, Dean Rasheed wrote: > > &

Proposal to include --exclude-extension Flag in pg_dump

2023-12-25 Thread Ayush Vatsa
ve to contribute to the community by adding the --exclude-extension flag. Attached is the patch for the same. Looking forward to your feedback. Regards Ayush Vatsa Amazon Web services (AWS) v1-0001-Add-support-for-exclude-extension-in-pg_dump.patch Description: Binary data

Re: Proposal to include --exclude-extension Flag in pg_dump

2023-12-25 Thread Ayush Vatsa
Added a CF entry for the same https://commitfest.postgresql.org/46/4721/ Regards Ayush Vatsa Amazon Web Services (AWS) On Mon, 25 Dec 2023 at 15:48, Ayush Vatsa wrote: > Hi PostgreSQL Community, > Recently I have been working on pg_dump regarding my project and wanted to > exclude an

Re: Proposal to include --exclude-extension Flag in pg_dump

2023-12-25 Thread Ayush Vatsa
in the pg_dump.sgml file too? Like writing documentation of --exclude-extension with other long options? After your feedback I will update on both places in a single patch Regards, Ayush Vatsa Amazon Web Services (AWS) On Mon, 25 Dec 2023 at 16:28, Junwang Zhao wrote: > Hi > > On Mon, Dec 25,

Re: Proposal to include --exclude-extension Flag in pg_dump

2024-01-01 Thread Ayush Vatsa
Hence to include only a few we use --extension, but to exclude a few I am proposing --exclude-extension. On Mon, 1 Jan 2024 at 18:18, Ashutosh Bapat wrote: > On Mon, Dec 25, 2023 at 3:48 PM Ayush Vatsa > wrote: > > > > Hi PostgreSQL Community, > > Recently I have been wor

Re: Proposal to include --exclude-extension Flag in pg_dump

2024-06-08 Thread Ayush Vatsa
> Attached is a patch for the --filter docs, covering the omissions I can see. Thanks Dean for working on this. I have reviewed the changes and they look good to me. Regards, Ayush Vatsa Amazon Web services (AWS) On Fri, 7 Jun 2024 at 15:50, Dean Rasheed wrote: > On Tue, 19 Mar 2024 at

Proposal to have INCLUDE/EXCLUDE options for altering option values

2024-04-25 Thread Ayush Vatsa
alues on top of existing values. Attached is the patch for the same. Looking forward to your feedback. Regards Ayush Vatsa Amazon Web Services (AWS) From 322e932d21345a178ccc254e9404dea816e5 Mon Sep 17 00:00:00 2001 From: Ayush Vatsa Date: Fri, 26 Apr 2024 00:30:00 +0530 Subject: [PATCH v1]

Re: Proposal to have INCLUDE/EXCLUDE options for altering option values

2024-04-25 Thread Ayush Vatsa
Added a CF entry for the same - https://commitfest.postgresql.org/48/4955/ Regards Ayush Vatsa Amazon Web Services (AWS) On Fri, 26 Apr 2024 at 11:05, Ayush Vatsa wrote: > Hi PostgreSQL Community, > Recently I have been working on foreign servers regarding my project and > wanted to

Query Discrepancy in Postgres HLL Test

2024-05-01 Thread Ayush Vatsa
e attributed to a precision error. However, I'm reaching out to seek clarity on why this disparity is occurring and to explore potential strategies for mitigating it (as I want the behaviour to be consistent to regress test file). Regards Ayush Vatsa

Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

2024-08-26 Thread Ayush Vatsa
sql.org/message-id/CACX%2BKaMOd3HHteOJNX7fkWxO%2BR%3DuLJkfKqE2-QUK8fKmKfOwqw%40mail.gmail.com. In that thread, it was suggested that this could be considered a documentation bug, and that we might update the documentation and regression tests accordingly. Regards Ayush Vatsa AWS

Re: Proposal to have INCLUDE/EXCLUDE options for altering option values

2024-08-26 Thread Ayush Vatsa
Hello PostgreSQL Community, I noticed that my last commit needs rebase through cfbot - http://cfbot.cputube.org/ayush-vatsa.html PFA the rebased patch for the same. Regards Ayush Vatsa AWS v3-0002-fix-alter_server-alter_foreign_data_wrapper-alter.patch Description: Binary data v3-0001-Enhance

Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

2024-08-26 Thread Ayush Vatsa
small refactoring is needed to make the code cleaner and more consistent. > IMHO it would be good to establish some level of consistency here. Agree. Let me know your thoughts. Regards Ayush Vatsa AWS

Re: Proposal to have INCLUDE/EXCLUDE options for altering option values

2024-08-27 Thread Ayush Vatsa
Robert and Euler for the feedback. Ack, Initially while working on the solution I thought this can be a common problem. But I agree if the use case is small we can postpone supporting such syntax for the future. I can then withdraw the patch. Regards Ayush Vatsa AWS

Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

2024-08-29 Thread Ayush Vatsa
/5215/ Regards Ayush Vatsa AWS From 95ab0aa019e1cfec73bc94448faeafeac67b434e Mon Sep 17 00:00:00 2001 From: Ayush Vatsa Date: Thu, 29 Aug 2024 21:40:29 +0530 Subject: [PATCH v1] Introduced support for sequences back in pgstattuple extension --- contrib/pgstattuple/expected/pgstattuple.out | 24

Re: Pgstattuple on Sequences: Seeking Community Feedback on Potential Patch

2024-08-29 Thread Ayush Vatsa
For other relation kinds, verify that the AM * is heap; otherwise, raise an error. */ Please let me know if this still isn’t clear enough, then I can make further revisions in line with verify_heapam.c. The patch with all the changes is attached. Regards Ayush Vatsa AWS v1-0001-Introduc

Help Needed with Including External SQL Script in Extension Script

2024-07-26 Thread Ayush Vatsa
bjects are created when the extension script is executed? Regards Ayush Vatsa

Restricting Direct Access to a C Function in PostgreSQL

2024-08-11 Thread Ayush Vatsa
ow execution only if my_func is in the call stack (previous parent or something), and otherwise throwing an error. Is there an existing approach to achieve this, or would you recommend a specific solution? Best regards, Ayush Vatsa AWS

Re: Restricting Direct Access to a C Function in PostgreSQL

2024-08-11 Thread Ayush Vatsa
Thanks for the responses. > I would go with the GRANT approach. Make my_func() a SECURITY DEFINER function, and revoke access to my_func_extended() for all other roles. This sounds reasonable, and can be one of the options. > Dunno how complicated the logic in my_func() is, if that makes sense. A

Re: Restricting Direct Access to a C Function in PostgreSQL

2024-08-11 Thread Ayush Vatsa
Understood, Thanks for the help. Regards Ayush >

Re: Proposal to have INCLUDE/EXCLUDE options for altering option values

2024-08-14 Thread Ayush Vatsa
so I have revised it as well. The documentation for the newly proposed actions is included in a separate patch. Looking forward to your comments and feedback. Regards Ayush Vatsa AWS v2-0001-Enhance-ALTER-statement-with-extended-support-for.patch Description: Binary data v2-0002-fix-alter_server-alter_foreign_data_wrapper-alter.patch Description: Binary data

Re: Query regarding pg_prewarm extension

2024-12-30 Thread Ayush Vatsa
oesn’t seem like a common use case. For example, if a user calls prewarm(100, 200), how would they decide those specific numbers? While it’s possible to inspect the contents of those pages, as Jeremy noted, users typically don’t track the location of specific rows for prewarming purposes. Regards, Ayush Vatsa AWS Aurora

Query regarding pg_prewarm extension

2024-12-13 Thread Ayush Vatsa
REINDEX), how should I handle this when selecting the pages to prewarm? Any insights would be greatly appreciated. Regards, Ayush Vatsa [1] https://www.postgresql.org/docs/current/pgprewarm.html#PGPREWARM-FUNCS

Re: Clarification on Role Access Rights to Table Indexes

2025-02-19 Thread Ayush Vatsa
Added the CF entry for the same - https://commitfest.postgresql.org/patch/5583/ Regards, Ayush Vatsa SDE AWS >

Re: Clarification on Role Access Rights to Table Indexes

2025-02-19 Thread Ayush Vatsa
et me know if it needs any changes. Regards, Ayush Vatsa SDE AWS v1-0001-Improve-ACL-checks-in-pg_prewarm-for-indexes.patch Description: Binary data

Re: Clarification on Role Access Rights to Table Indexes

2025-02-17 Thread Ayush Vatsa
mailing list instead of general. [1] https://github.com/postgres/postgres/blob/master/contrib/pg_prewarm/pg_prewarm.c#L108-L110 Regards, Ayush Vatsa SDE AWS

Re: Clarification on Role Access Rights to Table Indexes

2025-02-17 Thread Ayush Vatsa
> I'm not sure if I'd call that a "design". Sounds like I just made a > mistake here. Thanks Robert for confirming, let me submit a patch to fix the same. Regards Ayush Vatsa ADE AWS

Re: Clarification on Role Access Rights to Table Indexes

2025-03-08 Thread Ayush Vatsa
m > with using it in pg_class_aclcheck() and get_rel_name(), either. True, I have also verified that from [1], hence I think we are safe here. Maybe we can move ahead with the patch if we can see no other concerns. [1] https://github.com/postgres/postgres/blob/master/src/backend/catalog/dependency.c#L

Re: Clarification on Role Access Rights to Table Indexes

2025-03-08 Thread Ayush Vatsa
Let me know if you agree or if you see any scenario where missing_ok = true would be preferable—I can update the condition accordingly. Thanks! Ayush Vatsa SDE AWS