> I'm concerned that some of this might be platform-dependent and make the > test unstable. Perhaps we should just select count(*) here. > Sure enough, the CI testing for 32-bit is failing here [0]. Thanks for catching that! I wasn't aware of this earlier.
> I think we should be a bit more descriptive here Regarding the comment, I've tried to make it more descriptive and simpler than the existing one in verify_heapam.c. Here’s the comment I propose: /* * Sequences implicitly use the heap AM, even though it's not explicitly * recorded in the catalogs. For other relation kinds, verify that the AM * is heap; otherwise, raise an error. */ Please let me know if this still isn’t clear enough, then I can make further revisions in line with verify_heapam.c. The patch with all the changes is attached. Regards Ayush Vatsa AWS
v1-0001-Introduced-support-for-sequences-back-in-pgstattu.patch
Description: Binary data
