Re: [HACKERS] Runtime Partition Pruning

2018-04-24 Thread Alvaro Herrera
Andres Freund wrote: > What I wonder, after skimming this change, is where the relevant > expression context is reset? That's not really related to this change > but the wider thread, I just noticed it while looking at this. Do you mean ResetExprContext? We use the plan's context, so it should

Re: Should we add GUCs to allow partition pruning to be disabled?

2018-04-24 Thread Alvaro Herrera
Jim Finnerty wrote: > The patch looks good to me, David. > Thanks for checking! It's already pushed. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: Should we add GUCs to allow partition pruning to be disabled?

2018-04-24 Thread Alvaro Herrera
Amit Langote wrote: > On 2018/04/24 6:10, Alvaro Herrera wrote: > > Not really sure how best to handle that one. For starters, I think it need > > to stop mentioning the GUC name in the title; > > Hmm, "Constraint Exclusion" that's used in the title is a c

Re: Minor comment update in execPartition.c

2018-04-24 Thread Alvaro Herrera
Amit Langote wrote: > > I think we should remove the words "if not already done" from that > > comment because 1) that function is called if the partition wasn't > > already initialized and 2) that function assumes that. Attached is a > > small patch for removing the words. > > Thanks, sounds fi

Re: perltidy version

2018-04-25 Thread Alvaro Herrera
Tom Lane wrote: > Michael Paquier writes: > > On Mon, Apr 23, 2018 at 12:40:00PM -0400, Tom Lane wrote: > >> Alvaro Herrera writes: > >>> I further vote that we change the URL in pgindent/README from > >>> sourceforge to metacpan.org, > >>&g

Re: perltidy version

2018-04-25 Thread Alvaro Herrera
Tom Lane wrote: > Alvaro Herrera writes: > > Tom Lane wrote: > >> Agreed on pointing to cpan, but that page is pretty confusing if you're > >> looking for a non-bleeding-edge version. I suggest linking to > >> https://cpan.metacpan.org/authors/id/S

Re: minor fix for acquire_inherited_sample_rows

2018-04-26 Thread Alvaro Herrera
Amit Langote wrote: > On Thu, Apr 26, 2018 at 9:54 PM, Ashutosh Bapat > wrote: > > On Thu, Apr 26, 2018 at 1:08 AM, Robert Haas wrote: > >> +1. I think we're really abusing equalTupleDescs() for purposes for > >> which it was not invented. Instead of changing it, let's invent a new > >> functio

Scariest patch tournament, PostgreSQL 11 edition

2018-04-26 Thread Alvaro Herrera
PostgreSQL hackers and community at large, In the spirit of the season, the Release Management Team would like to gather your thoughts on Fear, Risk and Data Corruption for features in PostgreSQL 11. What patch or patches committed in this cycle do you think have the highest probability of causin

Re: XML/XPath issues: text/CDATA in XMLTABLE, XPath evaluated with wrong context

2018-04-26 Thread Alvaro Herrera
Hello Markus, Markus Winand wrote: > * Patch 0001: Accept TEXT and CDATA nodes in XMLTABLE’s column_expression. > > > Column_expressions that match TEXT or CDATA nodes must return > > the contents of the node itself, not the content of the > > non-existing childs (i.e. the empty string). > > Th

Re: Adding column "mem_usage" to view pg_prepared_statements

2019-09-03 Thread Alvaro Herrera
Hello Daniel, This patch no longer applies. Please submit an updated version. Also, there's voluminous discussion that doesn't seem to have resulted in any revision of the code. Please fix that too. Thanks, -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development,

Re: [HACKERS] advanced partition matching algorithm for partition-wise join

2019-09-03 Thread Alvaro Herrera
Fujita-san, amul, CFbot complains that Fujita-san submitted a patch that doesn't apply, which makes sense since the necessary previous patch was only referred to without being resubmitted. I suggest to always post all patches together with each resubmission so that it can be checked automatically

Re: amcheck verification for GiST

2019-09-03 Thread Alvaro Herrera
On 2019-Mar-29, Andrey Borodin wrote: > Here's updated patch with AccessShareLock. > I've tried to stress this with combination of random inserts, vaccuums and > checks. This process neither failed, nor deadlocked. > The patch intentionally contains one superflous line to make gist logically > b

Re: Attempt to consolidate reading of XLOG page

2019-09-03 Thread Alvaro Herrera
Pushed 0001. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [PATCH] Opclass parameters

2019-09-03 Thread Alvaro Herrera
On 2019-Jun-11, Tomas Vondra wrote: > 1) We need a better infrastructure to parse opclass parameters. For > example the gtsvector_options does this: I think this is part of what Nikolay's patch series was supposed to address. But that one has been going way too slow. I agree we need something b

Re: WIP: BRIN multi-range indexes

2019-09-03 Thread Alvaro Herrera
On 2019-Jun-11, Tomas Vondra wrote: > Attached is this patch series, rebased on top of current master and the > opclass parameters patch [1]. I previously planned to keep those two > efforts separate for a while, but I decided to give it a try and the > breakage is fairly minor so I'll keep it thi

Re: Replication & recovery_min_apply_delay

2019-09-03 Thread Alvaro Herrera
On 2019-Aug-02, Michael Paquier wrote: > On Wed, Jul 31, 2019 at 04:43:26PM -0400, Alvaro Herrera wrote: > > As for the test module, the one I submitted takes a lot of time to run > > (well, 60s) and I don't think it's a good idea to include it as > > something

Re: Attempt to consolidate reading of XLOG page

2019-09-03 Thread Alvaro Herrera
Hi Antonin, could you please rebase again? Thanks -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: SQL/JSON: functions

2019-09-03 Thread Alvaro Herrera
On 2019-Jul-16, Nikita Glukhov wrote: > Attached 37th version of the patches rebased onto current master. > > Preliminary patch #1 contains: >  - implementation of jsonpath .datetime() method (see [1]) >  - jsonpath support for json type (should be posted later in a separate > thread) 0001 doesn

Re: Shared Memory: How to use SYSV rather than MMAP ?

2019-09-03 Thread Alvaro Herrera
On 2019-Feb-03, Thomas Munro wrote: > On Sat, Feb 2, 2019 at 12:49 AM Thomas Munro > wrote: > > I am planning to commit the 0001 patch shortly, unless there are > > objections. I attach a new version, which improves the documentation > > a bit (cross-referencing the new GUC and the section on sy

Re: shared-memory based stats collector

2019-09-03 Thread Alvaro Herrera
On 2019-Jul-11, Kyotaro Horiguchi wrote: > Hello. This is v21 of the patch. > > > CF-bot warned that it doesn't work on Windows. I'm experiencing > > an very painful time to wait for tortoise git is walking slowly > > as its name suggests. It would be fixed in the next version. > > Found a bug i

Re: Tid scan improvements

2019-09-03 Thread Alvaro Herrera
On 2019-Aug-01, Edmund Horner wrote: > Hi everyone, > > Sadly it is the end of the CF and I have not had much time to work on > this. I'll probably get some time in the next month to look at the > heapam changes. > > Should we move to CF? We have been in the CF cycle for almost a year now...

Re: [HACKERS] Transactions involving multiple postgres foreign servers, take 2

2019-09-03 Thread Alvaro Herrera
Hello Sawada-san, On 2019-Jul-02, Masahiko Sawada wrote: > On Mon, Jul 1, 2019 at 8:32 PM Thomas Munro wrote: > > Can we please have a fresh rebase? > > Thank you for the notice. Attached rebased patches. ... and again? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQ

Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

2019-09-03 Thread Alvaro Herrera
On 2019-Jul-15, Paul Guo wrote: > Thanks. Both Mkvcbuild.pm and pg_rewind/Makefile are modified to make > Windows build pass in a > local environment (Hopefully this passes the CI testing), also now > pg_rewind/Makefile does not > create soft link for backup_common.h anymore. Instead -I is used to

Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay

2019-09-03 Thread Alvaro Herrera
mp; Services >From 98eac4afa6995c57c5b8288c126f88b434268dbc Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Tue, 3 Sep 2019 18:17:11 -0400 Subject: [PATCH v2] Fix a delay in PostgreSQL shutdown caused by logical replication Due to a race with WAL writing during shutdown, if logical walsende

Re: Commit fest 2019-09

2019-09-03 Thread Alvaro Herrera
Hi Ibrar On 2019-Sep-04, Ibrar Ahmed wrote: > On Mon, Sep 2, 2019 at 6:47 PM Alvaro Herrera > wrote: > > There's an embarrasingly large number of patches in the "Bug Fixes" > > section. I encourage reviewers to look at those that "Need Review" so

Re: Proposal: roll pg_stat_statements into core

2019-09-03 Thread Alvaro Herrera
On 2019-Sep-03, Stephen Frost wrote: > Greetings, > > * David Fetter (da...@fetter.org) wrote: > > I'd like to $Subject, on by default, with a switch to turn it off for > > those really at the outer edges of performance. Some reasons include: > > Sure, half of contrib should really be in core (a

Re: remove "msg" parameter from convert_tuples_by_name

2019-09-03 Thread Alvaro Herrera
On 2019-Sep-04, Amit Langote wrote: > On Wed, Sep 4, 2019 at 3:52 AM Alvaro Herrera > wrote: > > > > On 2019-Aug-07, Amit Langote wrote: > > > > > If we're reducing the message string to occur only once in the source > > > code, can we maybe writ

auxiliary processes in pg_stat_ssl

2019-09-04 Thread Alvaro Herrera
I just noticed that we list auxiliary processes in pg_stat_ssl: 55432 13devel 28627=# select * from pg_stat_ssl ; pid │ ssl │ version │ cipher │ bits │ compression │ client_dn │ client_serial │ issuer_dn ───┼─┼─┼┼──┼─┼───

Re: [PATCH] Connection time for \conninfo

2019-09-04 Thread Alvaro Herrera
On 2019-Sep-04, Michael Paquier wrote: > On Tue, Sep 03, 2019 at 10:13:57PM -0400, Rodrigo Ramírez Norambuena wrote: > > I've work in the a little patch to add into the \conninfo of psql > > command the connection time against a server backend > > > > Maybe could add after, the precheck to if th

Re: [Patch] Invalid permission check in pg_stats for functional indexes

2019-09-04 Thread Alvaro Herrera
BTW you labelled this in the CF app as targetting "stable", but I don't think this is backpatchable. I think we should fix it in master and call it a day. Changing system view definitions in stable versions is tough. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Devel

Re: [Patch] Invalid permission check in pg_stats for functional indexes

2019-09-04 Thread Alvaro Herrera
On 2019-Sep-03, Pierre Ducroquet wrote: > > IIUC, the patch introduces an additional privilege check for the > > underlying objects involved in the expression/functional index. If the > > user has 'select' privileges on all of the columns/objects included in > > the expression/functional index, th

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2019-09-04 Thread Alvaro Herrera
Attached v3 again, for CFbot's benefit. No changes from last time. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From 018077d786f874cb314b5f61b5ef85f42c62bbe5 Mon Sep 17 00:00:00 2001 From: Masahiko Sawada Da

Re: pg_basebackup ignores the existing data directory permissions

2019-09-04 Thread Alvaro Herrera
On 2019-Apr-03, Robert Haas wrote: > I am not sure what solution is best here, but it is hard to imagine > that the status quo is the right thing. This patch has been dormant for months. There's been at lot of discussion but it doesn't seem conclusive; it doesn't look like we know what we actual

Re: [HACKERS] WIP: Aggregation push-down

2019-09-04 Thread Alvaro Herrera
This stuff seems very useful. How come it sits unreviewed for so long? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: using explicit_bzero

2019-09-04 Thread Alvaro Herrera
On 2019-Aug-24, Peter Eisentraut wrote: > On 2019-08-14 05:00, Michael Paquier wrote: > > On Tue, Aug 13, 2019 at 10:30:39AM +0200, Peter Eisentraut wrote: > >> Another patch, to attempt to fix the Windows build. > > > > I have not been able to test the compilation, but the changes look > > good

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2019-09-04 Thread Alvaro Herrera
On 2019-Sep-04, Alvaro Herrera wrote: > Attached v3 again, for CFbot's benefit. No changes from last time. According to CFbot, the Windows build fails with this patch. Please fix. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Re

Re: progress report for ANALYZE

2019-09-04 Thread Alvaro Herrera
There were some minor problems in v5 -- bogus Docbook as well as outdated rules.out, small "git diff --check" complaint about whitespace. This v6 (on today's master) fixes those, no other changes. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support,

Re: Index Skip Scan

2019-09-04 Thread Alvaro Herrera
Surely it isn't right to add members prefixed with "ioss_" to struct IndexScanState. I'm surprised about this "FirstTupleEmitted" business. Wouldn't it make more sense to implement index_skip() to return the first tuple if the scan is just starting? (I know little about executor, apologies if th

Re: unexpected rowlock mode when trigger is on the table

2019-09-04 Thread Alvaro Herrera
On 2019-Sep-03, Tomáš Záluský wrote: > postgres=# begin; > BEGIN > postgres=# update master set detail_id=null, name='y' where id=1000; > UPDATE 1 > > In another psql console, I run: > > postgres=# select * from pgrowlocks('master'); > locked_row | locker | multi | xids | modes | pids > ---

Re: Two pg_rewind patches (auto generate recovery conf and ensure clean shutdown)

2019-09-05 Thread Alvaro Herrera
Thank for rebasing. I didn't like 0001 very much. * It seems now would be the time to stop pretending we're using a file called recovery.conf; I know we still support older server versions that use that file, but it sounds like we should take the opportunity to rename the function to be less misl

Re: Plug-in common/logging.h with vacuumlo and oid2name

2019-09-05 Thread Alvaro Herrera
Patch looks good to me, please push. Generally speaking I find the 'progname' handling a bit silly (since we have it both as a variable in each program and also in logging.c separately), but that's not the fault of this patch, and this patch doesn't make it worse. That said, I think some other me

Re: unexpected rowlock mode when trigger is on the table

2019-09-05 Thread Alvaro Herrera
On 2019-Sep-05, Tomáš Záluský wrote: > Thanks for response. > > > I think there should be no overlap (PK is column "id", not modified) > > The update command sets the detail_id column which has unique constraint. Oh, I see, yeah that explains it. > What is unclear to me, why FOR NO KEY UPDATE

changing wal segsize with pg_resetwal

2019-09-05 Thread Alvaro Herrera
On 2019-Aug-28, Pavel Demidov wrote: > I hear that not recommended to set pg_resetwal with --wal-segsize for wal > increasing. Are any more detailed information exists about it? What an > effects could be? Does it possible change it due full offline? The manual contains a warning about it:

Re: [PATCH] Race condition in logical walsender causes long postgresql shutdown delay

2019-09-11 Thread Alvaro Herrera
On 2019-Sep-03, Alvaro Herrera wrote: > On 2019-Jul-25, Craig Ringer wrote: > > > Patch attached. > > Here's a non-broken version of this patch. I have not done anything > other than reflowing the new comment. Reading over this code, I noticed that the detection of

Re: Run-time pruning for ModifyTable

2019-09-11 Thread Alvaro Herrera
Here's a rebased version of this patch (it had a trivial conflict). No further changes. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services diff --git a/contrib/postgres_fdw/postgres_fdw.c b/contrib/postgres_fdw/post

Re: base backup client as auxiliary backend process

2019-09-11 Thread Alvaro Herrera
On 2019-Aug-30, Peter Eisentraut wrote: > Attached is an updated patch for this. I have changed the initdb option > name per suggestion. The WAL receiver is now started concurrently with > the base backup. There is progress reporting (ps display), fsyncing. > Configuration files are not copied

Re: Do not check unlogged indexes on standby

2019-09-11 Thread Alvaro Herrera
On 2019-Aug-15, Andrey Borodin wrote: > PFA V1 of this check retry. CFbot complains that this doesn't apply; can you please rebase? -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] [PATCH] Generic type subscripting

2019-09-11 Thread Alvaro Herrera
On 2019-Jul-11, Dmitry Dolgov wrote: > > On Thu, Jul 11, 2019 at 9:47 AM David Fetter wrote: > > > > Looks great! > > > > The tutorial piece has bit-rotted slightly. Please find attached a > > patch atop yours that fixes it. > > Indeed, I've missed this change, thank you! Although there supposed

Re: POC: Cleaning up orphaned files using undo logs

2019-09-11 Thread Alvaro Herrera
On 2019-Sep-06, vignesh C wrote: > Hi Thomas, > > While testing one of the recovery scenarios I found one issue: > FailedAssertion("!(logno == context->recovery_logno) I marked this patch Waiting on Author. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 2

Re: Amcheck: do rightlink verification with lock coupling

2019-09-12 Thread Alvaro Herrera
On 2019-Sep-12, Andrey Borodin wrote: > This patch violates one of amcheck design principles: current code > does not ever take more than one page lock. I do not know: should we > hold this rule or should we use more deep check? The check does seem worthwhile to me. As far as I know, in btree yo

Re: Misleading comment in tuplesort_set_bound

2019-09-12 Thread Alvaro Herrera
On 2019-Sep-05, James Coleman wrote: > Yes, planning on it, just a bit behind right now so will likely be a > few more days at least. [ shrug ] It seemed to require no further work, so I just pushed Tom's proposed change. I added an empty line after the new combined assertion, which makes clear

Re: Runtime pruning problem

2019-09-12 Thread Alvaro Herrera
On 2019-Jul-30, Tom Lane wrote: > I wrote: > > This may be arguing for a change in ruleutils' existing behavior, > > not sure. But when dealing with traditional-style inheritance, > > I've always thought that Vars above the Append were referring to > > the parent rel in its capacity as the parent

Re: logical decoding : exceeded maxAllocatedDescs for .spill files

2019-09-12 Thread Alvaro Herrera
On 2019-Sep-12, Tomas Vondra wrote: > On Wed, Sep 11, 2019 at 09:51:40AM -0300, Alvaro Herrera from 2ndQuadrant > wrote: > > On 2019-Sep-11, Amit Khandekar wrote: > > I think doing this all the time would make restore very slow -- there's a > > reason we keep the fi

Re: psql - improve test coverage from 41% to 88%

2019-09-12 Thread Alvaro Herrera
I think the TestLib.pm changes should be done separately, not together with the rest of the hacking in this patch. Mostly, because I think they're going to cause trouble. Adding a parameter in the middle of the list may cause trouble for third-party users of TestLib. I propose that we make the r

Re: Implementing Incremental View Maintenance

2019-09-12 Thread Alvaro Herrera
On 2019-Aug-06, Tatsuo Ishii wrote: > It's not mentioned below but some bugs including seg fault when > --enable-casser is enabled was also fixed in this patch. > > BTW, I found a bug with min/max support in this patch and I believe > Yugo is working on it. Details: > https://github.com/sraoss/pg

Re: [PATCH] Incremental sort (was: PoC: Partial sort)

2019-09-12 Thread Alvaro Herrera
On 2019-Jul-30, Tomas Vondra wrote: > On Sun, Jul 21, 2019 at 01:34:22PM +0200, Tomas Vondra wrote: > > > > I wonder if we're approaching this wrong. Maybe we should not reverse > > engineer queries for the various places, but just start with a set of > > queries that we want to optimize, and the

Re: Create collation reporting the ICU locale display name

2019-09-12 Thread Alvaro Herrera
On 2019-Sep-12, Daniel Verite wrote: > Michael Paquier wrote: > > > On Wed, Sep 11, 2019 at 04:53:16PM +0200, Daniel Verite wrote: > > > I think it would be nice to have CREATE COLLATION report this > > > information as feedback in the form of a NOTICE message. > > > PFA a simple patch impl

Re: pglz performance

2019-09-12 Thread Alvaro Herrera
I just noticed we had two CF items pointing to this thread, https://commitfest.postgresql.org/24/2119/ https://commitfest.postgresql.org/24/2180/ so I marked the newer one as withdrawn. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DB

Re: psql - add SHOW_ALL_RESULTS option

2019-09-12 Thread Alvaro Herrera
This v6 is just Fabien's v5, rebased over a very minor conflict, and pgindented. No further changes. I've marked this Ready for Committer. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services diff --git a/contrib/pg_

Re: Fix XML handling with DOCTYPE

2019-09-12 Thread Alvaro Herrera
Hi Chapman, On 2019-Sep-05, Chapman Flack wrote: > Are these on your radar to maybe backpatch in this round of activity? > > The latest patches I did for 11 and 10 are in > https://www.postgresql.org/message-id/5D45A44F.8010803%40anastigmatix.net Thanks! I just pushed these to those branches.

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Michael Paquier wrote: > Attached is a patch to fix your suggestions. This also removes the > use of HEAP_XMAX_IS_LOCKED_ONLY which did not make completely sense > either as a "raw" flag. While on it, the order of the flags can be > improved to match more the order of htup_detail

Re: psql - improve test coverage from 41% to 88%

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Fabien COELHO wrote: > Hello Alvaro, > > > I think the TestLib.pm changes should be done separately, not together > > with the rest of the hacking in this patch. > > > > Mostly, because I think they're going to cause trouble. Adding a > > parameter in the middle of the list may

Re: [PATCH] Speedup truncates of relation forks

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Fujii Masao wrote: > On Mon, Sep 9, 2019 at 3:52 PM Jamison, Kirk wrote: > > > Please add a preliminary patch that removes the function. Dead code is > > > good, > > > as long as it is gone. We can get it pushed ahead of the rest of this. > > > > Alright. I've attached a separ

Re: pgbench - allow to create partitioned tables

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Amit Kapila wrote: > On Fri, Sep 13, 2019 at 1:50 PM Fabien COELHO wrote: > > >>> Is there a reason why we treat "partitions = 0" as a valid value? > > >> > > >> Yes. It is an explicit "do not create partitioned tables", which differ > > >> from 1 which says "create a partitionned

Re: pgbench - allow to create partitioned tables

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Amit Kapila wrote: > I would like to take inputs from others as well for the display part > of this patch. After this patch, for a simple-update pgbench test, > the changed output will be as follows (note: partition method and > partitions): > pgbench.exe -c 4 -j 4 -T 10 -N postg

Re: errbacktrace

2019-09-13 Thread Alvaro Herrera
with each piece. -- Álvaro Herrerahttps://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services >From 7341310cd75722fbfe7cb7996516b0b50d83bb1f Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Fri, 13 Sep 2019 12:51:13 -0300 Subject

Re: [HACKERS] CLUSTER command progress monitor

2019-09-13 Thread Alvaro Herrera
Hello Tatsuro, On 2019-Aug-13, Tatsuro Yamada wrote: > On 2019/08/02 3:43, Alvaro Herrera wrote: > > Hmm, I'm trying this out now and I don't see the index_rebuild_count > > ever go up. I think it's because the indexes are built using parallel > > index bu

Re: Duplicated LSN in ReorderBuffer

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-10, Alvaro Herrera from 2ndQuadrant wrote: > Here's a couple of patches. > > always_decode_assignment.patch is Masahiko Sawada's patch, which has > been confirmed to fix the assertion failure. I pushed this one to all branches. Thanks Ildar for reporting and

Re: [HACKERS] CLUSTER command progress monitor

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Robert Haas wrote: > On Fri, Sep 13, 2019 at 2:49 AM Michael Paquier wrote: > > On Fri, Sep 06, 2019 at 08:10:58AM -0400, Robert Haas wrote: > > > It's fine if things are updated as well -- it's just you need to make > > > sure that those places know whether or not they are suppos

Re: Allow to_date() and to_timestamp() to accept localized names

2019-09-13 Thread Alvaro Herrera
On 2019-Aug-22, Juan José Santamaría Flecha wrote: > On Sun, Aug 18, 2019 at 10:42 AM Juan José Santamaría Flecha > wrote: > > > > Going through the current items in the wiki's todo list, I have been > > looking into: "Allow to_date () and to_timestamp () to accept > > localized month names". >

Re: [PATCH][PROPOSAL] Add enum releation option type

2019-09-13 Thread Alvaro Herrera
On 2019-Sep-13, Nikolay Shaplov wrote: > I've played with it around, and did some googling, but without much success. > If we are moving this way (an this way seems to be good one), I need you > help, > because this thing is beyond my C knowledge, I will not manage it myself. Well, you need to

Re: Psql patch to show access methods info

2019-09-13 Thread Alvaro Herrera
On 2019-Aug-06, Alexander Korotkov wrote: > Revised patch is attached. Changes to \dA+ command are reverted. It > also contains some minor improvements. > > Second patch looks problematic for me, because it provides index > description alternative to \d+. IMHO, if there is something really > u

Re: allow_system_table_mods stuff

2019-09-13 Thread Alvaro Herrera
On 2019-Jun-28, Peter Eisentraut wrote: > Here is a new patch after the discussion. > > - Rename allow_system_table_mods to allow_system_table_ddl. > > (This makes room for a new allow_system_table_dml, but it's not > implemented here.) > > - Make allow_system_table_ddl SUSET. > > - Add regres

Re: [HACKERS] CLUSTER command progress monitor

2019-09-16 Thread Alvaro Herrera
On 2019-Sep-16, Tattsu Yama wrote: > I should have explained the API changes more. I added cmdtype as a given > parameter for all functions (See below). > Therefore, I suppose that my patch is similar to the following fix as you > mentioned on -hackers. Is this fix strictly necessary for pg12, or

Re: [HACKERS] [PATCH] pageinspect function to decode infomasks

2019-09-16 Thread Alvaro Herrera
On 2019-Sep-16, Michael Paquier wrote: > On Mon, Sep 16, 2019 at 11:46:16AM +0530, Amit Kapila wrote: > > I don't see much use of separating information for infomask and infomask2. > > Okay, using two separate columns leads to the attached. Any thoughts? > This also includes a fix for cases with

Re: Commit fest 2019-09

2019-09-16 Thread Alvaro Herrera
The third week for this commitfest starts. The numbers now: statusstring │ week1 │ week2 │ week3 ┼───┼───┼─── Needs review │ 165 │ 138 │ 116 Waiting on Author │30 │44 │51 Ready for Committer│11 │ 5 │

Re: [proposal] de-TOAST'ing using a iterator

2019-09-16 Thread Alvaro Herrera
On 2019-Sep-10, Binguo Bao wrote: > +/* > + * Support for de-TOASTing toasted value iteratively. "need" is a pointer > + * between the beginning and end of iterator's ToastBuffer. The marco > + * de-TOAST all bytes before "need" into iterator's ToastBuffer. > + */ > +#define PG_DETOAST_ITERATE(ite

Re: [PATCH][PROPOSAL] Add enum releation option type

2019-09-16 Thread Alvaro Herrera
On 2019-Sep-13, Nikolay Shaplov wrote: > I've played with it around, and did some googling, but without much success. > If we are moving this way (an this way seems to be good one), I need you > help, > because this thing is beyond my C knowledge, I will not manage it myself. So I kinda did it

Re: [HACKERS] CLUSTER command progress monitor

2019-09-16 Thread Alvaro Herrera
On 2019-Sep-17, Tatsuro Yamada wrote: > On 2019/09/16 23:12, Alvaro Herrera wrote: > > Is this fix strictly necessary for pg12, or is this something that we > > can leave for pg13? > > Not only me but many DBA needs this progress report feature on PG12, > therefore I

Re: [PATCH][PROPOSAL] Add enum releation option type

2019-09-17 Thread Alvaro Herrera
I decided I didn't dislike that patch all that much anyway, so I cleaned it up a little bit and here's v8. The add_enum_reloption stuff is still broken. Please fix it and resubmit. I'm marking this Waiting on Author now. Thanks, -- Álvaro Herrerahttps://www.2ndQuadrant.com/ Po

Re: Allow an alias to be attached directly to a JOIN ... USING

2019-09-17 Thread Alvaro Herrera
On 2019-Aug-01, Thomas Munro wrote: > Indeed, that seems like a problem, and it's a good question. You can > see this on unpatched master with SELECT x.filler FROM > (pgbench_tellers AS t JOIN b USING (bid)) AS x. I'm not sure I understand why that problem is a blocker for this patch. -- Álvar

Re: Psql patch to show access methods info

2019-09-17 Thread Alvaro Herrera
It seems strange that there's a way to display AMs, and a way to display ops and procs in an opfamily; but there's no way to list what opfamilies exist (possibly given an AM as pattern). Should we add that too? We had \dAf in the original submission, but that seems to have lost along the way, not

Re: [HACKERS] Restricting maximum keep segments by repslots

2019-09-17 Thread Alvaro Herrera
Hello I have a couple of API-level reservation about this patch series. Firstly, "behind" when used as a noun refers to buttocks. Therefore, the ReplicationSlotsEnumerateBehinds function name seems funny (I think when used as a preposition you wouldn't put it in plural). I don't suggest a subst

Re: Attempt to consolidate reading of XLOG page

2019-09-17 Thread Alvaro Herrera
I was confused by the struct name XLogSegment -- the struct is used to represent a WAL segment while it's kept open, rather than just a WAL segment in abstract. Also, now that we've renamed everything to use the term WAL, it seems wrong to use the name XLog for new structs. I propose the name WAL

Re: [HACKERS] CLUSTER command progress monitor

2019-09-17 Thread Alvaro Herrera
On 2019-Sep-18, Michael Paquier wrote: > So, with the clock ticking and the release getting close by, what do > we do for this set of issues? REINDEX, CREATE INDEX and CLUSTER all > try to build indexes and the current infrastructure is not really > adapted to hold all that. Robert, Alvaro and P

Re: Psql patch to show access methods info

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-18, Alexander Korotkov wrote: > On Tue, Sep 17, 2019 at 9:01 PM Alvaro Herrera > wrote: > > I think \dAf is just as critical as \dAo; the former lets you know which > > opfamilies you can use in CREATE INDEX, while the latter lets you know > > which oper

Re: pg_upgrade check fails on Solaris 10

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-17, Marina Polyakova wrote: > Hello, hackers! > > We got an error for pg_upgrade check on the branch REL_11_STABLE (commit > 40ad4202513c72f5c1beeb03e26dfbc8890770c0) on Solaris 10 because IIUC the > argument to the sed command is not enclosed in quotation marks (see [1]): Hmm, I'm s

Re: Commit fest 2019-09

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-16, Alvaro Herrera wrote: > The third week for this commitfest starts. The numbers now: > > statusstring │ week1 │ week2 │ week3 > ┼───┼───┼─── > Needs review │ 165 │ 138 │ 116 > Waiting on Author

Re: log bind parameter values on error

2019-09-18 Thread Alvaro Herrera
SQL Development, 24x7 Support, Remote DBA, Training & Services >From 19c80d631694366e8098a564ba347fb1e937056b Mon Sep 17 00:00:00 2001 From: Alvaro Herrera Date: Wed, 18 Sep 2019 16:56:42 -0300 Subject: [PATCH v10] Allow logging of portal parameters on error --- do

Re: Optimization of some jsonb functions

2019-09-18 Thread Alvaro Herrera
On 2019-Jul-26, Joe Nelson wrote: > Thomas Munro wrote: > > This doesn't apply -- to attract reviewers, could we please have a rebase? > > To help the review go forward, I have rebased the patch on 27cd521e6e. > It passes `make check` for me, but that's as far as I've verified the > correctness.

Re: Optimization of some jsonb functions

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-18, Alvaro Herrera wrote: > Well, I think that was useless, so I rebased again -- attached. ... which is how you find out that 0001 as an independent patch is not really a valid one, since it depends on an API change that does not happen until 0005. -- Álvaro Herr

Re: Optimization of some jsonb functions

2019-09-18 Thread Alvaro Herrera
On 2019-Sep-19, Alvaro Herrera wrote: > On 2019-Sep-18, Alvaro Herrera wrote: > > > Well, I think that was useless, so I rebased again -- attached. > > ... which is how you find out that 0001 as an independent patch is not > really a valid one, since it depends on an API

Re: Allow CLUSTER, VACUUM FULL and REINDEX to change tablespace on the fly

2019-09-20 Thread Alvaro Herrera
On 2019-Sep-19, Robert Haas wrote: > So, earlier in this thread, I suggested making this part of ALTER > TABLE, and several people seemed to like that idea. Did we have a > reason for dropping that approach? Hmm, my own reading of that was to add tablespace changing abilities to ALTER TABLE *in a

Re: [HACKERS] CLUSTER command progress monitor

2019-09-20 Thread Alvaro Herrera
On 2019-Sep-18, Michael Paquier wrote: > On Tue, Sep 17, 2019 at 10:50:22PM -0300, Alvaro Herrera wrote: > > On 2019-Sep-18, Michael Paquier wrote: > >> So, with the clock ticking and the release getting close by, what do > >> we do for this set of issues? REINDEX, C

Re: log bind parameter values on error

2019-09-20 Thread Alvaro Herrera
Hi, thanks for looking. On 2019-Sep-20, Andres Freund wrote: > On 2019-09-18 17:58:53 -0300, Alvaro Herrera wrote: > > + > xreflabel="log_parameters_on_error"> > > + log_parameters_on_error > > (boolean) > > + > > + log

Re: subscriptionCheck failures on nightjar

2019-09-20 Thread Alvaro Herrera
On 2019-Sep-20, Tom Lane wrote: > Actually, what I did was as attached [1], and I am getting traces like > [2]. The problem seems to occur only when there are two or three > processes concurrently creating the same snapshot file. It's not > obvious from the debug trace, but the snapshot file *do

Re: Optimization of some jsonb functions

2019-09-20 Thread Alvaro Herrera
I pushed the first few parts. The attached is a rebased copy of the last remaining piece. However, I didn't quite understand what this was doing, so I refrained from pushing. I think there are two patches here: one that adapts the API of findJsonbValueFromContainer and getIthJsonbValueFromContai

Re: Wrong results using initcap() with non normalized string

2019-09-20 Thread Alvaro Herrera
On 2019-Sep-20, Tom Lane wrote: > =?UTF-8?Q?Juan_Jos=C3=A9_Santamar=C3=ADa_Flecha?= > writes: > > I have come around a strange situation when using a unicode string > > that has non normalized characters. The attached script 'initcap.sql' > > can reproduce the problem. For illustration purposes

Re: Index Skip Scan

2019-09-22 Thread Alvaro Herrera
On 2019-Sep-22, Dmitry Dolgov wrote: > > I think multiplying two ScanDirections to watch for a negative result is > > pretty ugly: > > Probably, but the only alternative I see to check if directions are opposite > is > to check that directions come in pairs (back, forth), (forth, back). Is there

Re: Commit fest 2019-09

2019-09-23 Thread Alvaro Herrera
Hello The fourth week of this commitfest begins with these numbers: statusstring │ week1 │ week2 │ week3 │ week4 ┼───┼───┼───┼─── Needs review │ 165 │ 138 │ 116 │ 118 Waiting on Author │30 │44 │51 │44 Rea

<    5   6   7   8   9   10   11   12   13   14   >