On 2019-Sep-13, Michael Paquier wrote: > Attached is a patch to fix your suggestions. This also removes the > use of HEAP_XMAX_IS_LOCKED_ONLY which did not make completely sense > either as a "raw" flag. While on it, the order of the flags can be > improved to match more the order of htup_details.h
A thought I had as I fell asleep last night is to include the derivate flags in a separate output column altogether. So heap_tuple_infomask_flags() could be made to return two columns, one with the straight one-flag-per-bit, and another one with the compound flags. That way we always have the raw ones available, and we avoid any confusion about strange cases such as LOCK_UPGRADED and IS_LOCKED_ONLY. -- Álvaro Herrera https://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
