Re: Add header support to text format and matching feature

ith tabulation: " text); + +copy copytest4 from stdin (header); +this is just a line full of junk that would error out if parsed +1 a +2 b +\. + +copy copytest4 to stdout (header); + -- test copy from with a partitioned table create table parted_copytest ( a int, diff --git a/src/test/regress/o

Re: Include access method in listTables output

On Sat, Aug 1, 2020 at 8:12 AM vignesh C wrote: > > > > > > +-- access method column should not be displayed for sequences > > > +\ds+ > > > > > > - List of relations > > > > > > > >

Re: Parallel copy

On Thu, Aug 27, 2020 at 8:24 AM Amit Kapila wrote: > > On Thu, Aug 27, 2020 at 8:04 AM Greg Nancarrow wrote: > > > > > I have attached new set of patches with the fixes. > > > Thoughts? > > > > Hi Vignesh, > > > > I don't really have any further comments on the code, but would like > > to share s

Re: Improvements in Copy From

risedb.com From a343fe1f8fdf4293d2ef6841e243390b99f29e28 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Sun, 30 Aug 2020 12:31:12 +0530 Subject: [PATCH v2] Improvements in copy from. There are couple of improvements for copy from in this patch which is detailed below: a) copy from stdin copies lesser amount of data to buffer even

Re: Parallel copy

On Thu, Aug 27, 2020 at 8:04 AM Greg Nancarrow wrote: > - Parallel Copy with 1 worker ran slower than normal Copy in a couple > of cases (I did question if allowing 1 worker was useful in my patch > review). Thanks Greg for your review & testing. I had executed various tests with 1GB, 2GB & 5GB w

describe-config issue

nfig this value is not updated. I felt printing boot_val is more appropriate in this case. Attached patch for the same. Thoughts? Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com From 847406e95ed35b5ce77c407a4b1b990e42e49125 Mon Sep 17 00:00:00 2001 From: Vignesh C Date: Wed, 2 Sep 2020

Re: Parallel copy

On Tue, Sep 1, 2020 at 3:39 PM Greg Nancarrow wrote: > > Hi Vignesh, > > >Can you share with me the script you used to generate the data & the ddl of > >the table, so that it will help me check that >scenario you faced the > >>problem. > > Unfortunately I can't directly share it (considered comp

Re: describe-config issue

On Wed, Sep 2, 2020 at 8:06 PM Tom Lane wrote: > Please defend that claim. Otherwise this seems like a pretty > random change. I had seen that there is discrepancy in postgres --describe-config & the value displayed from pg_settings like in the below case: postgres=# select name,min_val, max_va

Re: Parallel copy

On Tue, Sep 1, 2020 at 3:39 PM Greg Nancarrow wrote: > > Hi Vignesh, > > >Can you share with me the script you used to generate the data & the ddl of > >the table, so that it will help me check that >scenario you faced the > >>problem. > > Unfortunately I can't directly share it (considered comp

Re: Improvements in Copy From

On Mon, Sep 7, 2020 at 1:19 PM Surafel Temesgen wrote: > > > Hi Vignesh > > On Wed, Jul 1, 2020 at 3:46 PM vignesh C wrote: >> >> Hi, >> >> While reviewing copy from I identified few improvements for copy from >> that can be done : >> a) cop

Re: Improvements in Copy From

On Wed, Sep 9, 2020 at 12:24 PM Peter Smith wrote: > > My basic understanding of first part of your patch is that by > adjusting the "minread" it now allows it to loop multiple times > internally within the CopyGetData rather than calling CopyLoadRawBuf > for every N lines. There doesn't seem to b

Re: Added schema level support for publication.

On Fri, Oct 8, 2021 at 4:34 PM Amit Kapila wrote: > > On Thu, Oct 7, 2021 at 5:19 PM Amit Kapila wrote: > > > > On Wed, Oct 6, 2021 at 11:12 AM vignesh C wrote: > > > > > > Attached v37 patch has the changes for the same. > > > > > > > F

Re: Added schema level support for publication.

On Mon, Oct 11, 2021 at 7:46 AM tanghy.f...@fujitsu.com wrote: > > > On Friday, October 8, 2021 7:05 PM Amit Kapila > > wrote: > > > > v37-0003-Tests-for-FOR-ALL-TABLES-IN-SCHEMA-publication > > 3. > > --- a/src/bin/pg_dump/t/002_pg_dump.pl > > +++ b/src/bin/pg_dump/t/002_pg_dump.pl > > .. > > +

Re: Added schema level support for publication.

On Mon, Oct 11, 2021 at 1:21 PM Greg Nancarrow wrote: > > On Mon, Oct 11, 2021 at 5:39 PM vignesh C wrote: > > > > These comments are fixed in the v38 patch attached. > > > > Thanks for the updates. > I noticed that these patches don't apply on the latest

Re: Added schema level support for publication.

On Tue, Oct 19, 2021 at 11:23 AM tanghy.f...@fujitsu.com wrote: > > On Tuesday, October 19, 2021 12:57 PM Amit Kapila > wrote: > > > > On Tue, Oct 19, 2021 at 9:15 AM tanghy.f...@fujitsu.com > > wrote: > > > > > > On Monday, October 18, 2021 8:23 PM

Re: Added schema level support for publication.

On Thu, Oct 21, 2021 at 3:29 PM Greg Nancarrow wrote: > > On Thu, Oct 21, 2021 at 3:25 AM vignesh C wrote: > > > > Attached v44 patch as the fixes for the same. > > > > In the v44-0001 patch, I have some doubts about the condition guarding > the following

Re: Added schema level support for publication.

On Fri, Oct 22, 2021 at 11:59 AM Greg Nancarrow wrote: > > On Fri, Oct 22, 2021 at 12:41 PM Greg Nancarrow wrote: > > > > I was also previously concerned about what the behavior should be when > > only including just the partitions of a partitioned table in a > > publication using ALL TABLES IN S

Re: Added schema level support for publication.

On Fri, Oct 22, 2021 at 1:03 PM Masahiko Sawada wrote: > > On Fri, Oct 22, 2021 at 2:25 PM Amit Kapila wrote: > > > > On Thu, Oct 21, 2021 at 6:47 PM vignesh C wrote: > > > > > > > > > Thanks for the comments, the attached v45 patch has the fix f

Re: Added schema level support for publication.

On Thu, Oct 28, 2021 at 8:12 AM Amit Kapila wrote: > > On Mon, Oct 25, 2021 at 3:09 PM Amit Kapila wrote: > > > > On Mon, Oct 25, 2021 at 1:11 PM vignesh C wrote: > > > > > > I have fixed this in the v47 version attached. > > > > > > > Th

Re: Skipping logical replication transactions on subscriber side

On Thu, Oct 21, 2021 at 10:30 AM Masahiko Sawada wrote: > > On Wed, Oct 20, 2021 at 12:33 PM Greg Nancarrow wrote: > > > > On Mon, Oct 18, 2021 at 12:34 PM Masahiko Sawada > > wrote: > > > > > > I've attached updated patches that incorporate all comments I got so far. > > > > > > > Minor commen

Re: Added schema level support for publication.

On Wed, Nov 3, 2021 at 8:30 AM Amit Kapila wrote: > > On Tue, Nov 2, 2021 at 8:13 PM Tomas Vondra > wrote: > > > > > > > > > > Yeah, that is also true. So maybe at this, we can just rename the few > > > types as suggested by you and we can look at it later if we anytime > > > have more number of

Re: Added schema level support for publication.

On Wed, Nov 3, 2021 at 11:37 AM Peter Smith wrote: > > While you are changing these, maybe also change: > > Before: PUBLICATIONOBJ..._CURRSCHEMA > After: PUBLICATIONOBJ..._CUR_SCHEMA > > Which seems more readable to me. Thanks for the comment, the attached patch has the changes for the same. Reg

Re: Added schema level support for publication.

On Wed, Nov 3, 2021 at 11:07 AM houzj.f...@fujitsu.com wrote: > > On Wed, Nov 3, 2021 12:25 PM vignesh C wrote: > > On Wed, Nov 3, 2021 at 8:30 AM Amit Kapila > > wrote: > > > > > > On Tue, Nov 2, 2021 at 8:13 PM Tomas Vondra > > > wrote: > >

Re: Added schema level support for publication.

On Thu, Nov 4, 2021 at 5:41 AM Peter Smith wrote: > > FYI - I found a small problem with one of the new PublicationObjSpec > parser error messages that was introduced by the recent schema > publication commit [1]. > > The error message text is assuming that the error originates from > CREATE PUBLI

Re: Skipping logical replication transactions on subscriber side

On Fri, Oct 29, 2021 at 10:55 AM Masahiko Sawada wrote: > > On Thu, Oct 28, 2021 at 7:40 PM Amit Kapila wrote: > > > > On Thu, Oct 28, 2021 at 10:36 AM Masahiko Sawada > > wrote: > > > > > > On Wed, Oct 27, 2021 at 7:02 PM Amit Kapila > > > wrote: > > > > > > > > On Thu, Oct 21, 2021 at 10:29

Re: Failed transaction statistics to measure the logical replication progress

On Fri, Nov 5, 2021 at 1:42 PM osumi.takami...@fujitsu.com wrote: > > On Thursday, November 4, 2021 9:54 AM Greg Nancarrow > wrote: > > On Tue, Nov 2, 2021 at 12:18 AM osumi.takami...@fujitsu.com > > wrote: > > > > > > On Thursday, October 28, 2021 11:19 PM I wrote: > > > > I've created a new

Re: Optionally automatically disable logical replication subscriptions on error

On Tue, Nov 2, 2021 at 4:12 PM osumi.takami...@fujitsu.com wrote: > > On Monday, June 28, 2021 1:47 PM Masahiko Sawada > wrote: > > On Mon, Jun 21, 2021 at 11:26 AM Mark Dilger > > wrote: > > > > On Jun 20, 2021, at 7:17 PM, Masahiko Sawada > > wrote: > > > > > > > > I will submit the patch. >

Re: Printing backtrace of postgres processes

On Thu, Nov 4, 2021 at 4:06 PM Daniel Gustafsson wrote: > > > On 26 Aug 2021, at 16:56, vignesh C wrote: > > > The previous patch was failing because of the recent test changes made > > by commit 201a76183e2 which unified new and get_new_node, attached > > patch

Re: Printing backtrace of postgres processes

On Tue, Oct 12, 2021 at 10:47 AM bt21tanigaway wrote: > > Hi, > > > The previous patch was failing because of the recent test changes made > > by commit 201a76183e2 which unified new and get_new_node, attached > > patch has the changes to handle the changes accordingly. > > Thanks for your update!

Re: Identify missing publications from publisher while create/alter subscription.

On Tue, Sep 28, 2021 at 7:49 AM Jaime Casanova wrote: > > On Thu, Aug 26, 2021 at 07:49:49PM +0530, vignesh C wrote: > > On Thu, Jul 15, 2021 at 5:57 PM vignesh C wrote: > > > > > > On Tue, Jul 6, 2021 at 8:09 PM vignesh C wrote: > > > > > > >

Removed unused import modules from tap tests

Hi, While trying to add some new tests, I found that PostgreSQL::Test::Utils is not required. I felt PostgreSQL::Test::Utils can be removed from a lot of tap tests which do not require it. I removed it, ran the tests and found the tests to be executing fine. I have made a patch including the chang

Re: Skipping logical replication transactions on subscriber side

On Sun, Nov 7, 2021 at 7:50 PM Masahiko Sawada wrote: > > On Wed, Nov 3, 2021 at 12:41 PM Amit Kapila wrote: > > > > On Tue, Nov 2, 2021 at 2:17 PM Masahiko Sawada > > wrote: > > > > > > On Tue, Nov 2, 2021 at 2:35 PM Amit Kapila > > > wrote: > > > > > > > > On Mon, Nov 1, 2021 at 7:18 AM Mas

Re: Failed transaction statistics to measure the logical replication progress

On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com wrote: > Yes. I've rebased and updated the patch, paying attention to this point. > Attached the updated version. Thanks for the updated patch, few comments: 1) you could rename PgStat_StatSubWorkerPreparedXact to PgStat_SW_PreparedXactKe

Re: Removed unused import modules from tap tests

On Wed, Nov 10, 2021 at 6:07 PM Alvaro Herrera wrote: > > On 2021-Nov-10, Michael Paquier wrote: > > > I would not have bothered changing things if the names of the modules > > were the same across stable branches to minimize merge conflicts. > > > > However, everything has changed on HEAD, so the

Re: Printing backtrace of postgres processes

On Wed, Nov 10, 2021 at 12:17 PM Bharath Rupireddy wrote: > > On Tue, Nov 9, 2021 at 4:45 PM vignesh C wrote: > > Thanks for reporting this, the attached v9 patch has the changes for the > > same. > > Thanks for the v9 patch. I have some comments: > > 1) I th

Re: Failed transaction statistics to measure the logical replication progress

On Wed, Nov 10, 2021 at 3:43 PM vignesh C wrote: > > On Tue, Nov 9, 2021 at 5:05 PM osumi.takami...@fujitsu.com > wrote: > > Yes. I've rebased and updated the patch, paying attention to this point. > > Attached the updated version. > > Thanks for the updated patc

Re: Optionally automatically disable logical replication subscriptions on error

On Thu, Nov 11, 2021 at 2:50 PM osumi.takami...@fujitsu.com wrote: > > On Wednesday, November 10, 2021 1:23 PM Greg Nancarrow > wrote: > > On Wed, Nov 10, 2021 at 12:26 PM osumi.takami...@fujitsu.com > > wrote: > > > > > > On Monday, Novembe

Re: Identify missing publications from publisher while create/alter subscription.

On Wed, Nov 10, 2021 at 11:16 AM Bharath Rupireddy wrote: > > On Tue, Nov 9, 2021 at 9:27 PM vignesh C wrote: > > Attached v12 version is rebased on top of Head. > > Thanks for the patch. Here are some comments on v12: > > 1) I think ERRCODE_TOO_MANY_ARGUMENTS isn

Re: Printing backtrace of postgres processes

On Fri, Nov 12, 2021 at 5:15 PM Bharath Rupireddy wrote: > > On Thu, Nov 11, 2021 at 12:14 PM vignesh C wrote: > > Thanks for the comments, the attached v10 patch has the fixes for the same. > > Thanks for the patches. Here are some comments: > > 1) In the docs

Re: Printing backtrace of postgres processes

On Fri, Nov 12, 2021 at 6:11 PM Bharath Rupireddy wrote: > > On Fri, Nov 12, 2021 at 5:15 PM Bharath Rupireddy > wrote: > > > > On Thu, Nov 11, 2021 at 12:14 PM vignesh C wrote: > > > Thanks for the comments, the attached v10 patch has the fixes for the >

Re: Printing backtrace of postgres processes

On Mon, Nov 15, 2021 at 7:37 AM Bharath Rupireddy wrote: > > On Sun, Nov 14, 2021 at 8:49 PM vignesh C wrote: > > > 7) Do we need TAP tests for this function? I think it is sufficient to > > > test the function in misc_functions.sql, please remove > > > 002_pr

Re: Printing backtrace of postgres processes

On Mon, Nov 15, 2021 at 11:00 AM Bharath Rupireddy wrote: > > On Mon, Nov 15, 2021 at 10:34 AM vignesh C wrote: > > > 2) I think "which is enough because the target process for logging of > > > backtrace is a backend" isn't valid anymore with 0002, righi

Re: Skipping logical replication transactions on subscriber side

On Mon, Nov 15, 2021 at 2:48 PM Masahiko Sawada wrote: > > On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow wrote: > > > > On Mon, Nov 15, 2021 at 1:49 PM Masahiko Sawada > > wrote: > > > > > > I've attached an updated patch that incorporates all comments I got so > > > far. Please review it. > >

Re: Printing backtrace of postgres processes

On Mon, Nov 15, 2021 at 11:37 AM Dilip Kumar wrote: > > On Mon, Nov 15, 2021 at 10:34 AM vignesh C wrote: > > > > > Thanks for the comments, the attached v12 patch has the changes for the > > same. > > I have reviewed this patch and have some comments on v12-000

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy wrote: > > On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy > wrote: > > PSA v2 patch and review it. > > I've modified the docs part a bit, please consider v3 for review. Thanks for the update patch, Few comments: 1) Should we change "CHECK_FOR_

Re: Added schema level support for publication.

On Tue, Nov 9, 2021 at 2:51 PM Amit Kapila wrote: > > On Tue, Nov 9, 2021 at 7:20 AM Peter Smith wrote: > > > > FYI - I spotted a trivial SQL mistake (?) of the schema publication patch > > [1]. > > > > See the file describe.c, function describeOneTableDetails. > > The new SQL has a 3rd UNION t

Re: Skipping logical replication transactions on subscriber side

On Tue, Nov 16, 2021 at 12:01 PM Masahiko Sawada wrote: > > On Mon, Nov 15, 2021 at 11:43 PM vignesh C wrote: > > > > On Mon, Nov 15, 2021 at 2:48 PM Masahiko Sawada > > wrote: > > > > > > On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow > > &g

Re: Skipping logical replication transactions on subscriber side

On Tue, Nov 16, 2021 at 12:01 PM Masahiko Sawada wrote: > > On Mon, Nov 15, 2021 at 11:43 PM vignesh C wrote: > > > > On Mon, Nov 15, 2021 at 2:48 PM Masahiko Sawada > > wrote: > > > > > > On Mon, Nov 15, 2021 at 4:49 PM Greg Nancarrow > > &g

Re: Printing backtrace of postgres processes

On Tue, Nov 16, 2021 at 1:12 AM Justin Pryzby wrote: > > On Mon, Nov 15, 2021 at 09:12:49PM +0530, vignesh C wrote: > > The idea here is to implement & expose pg_print_backtrace function, > > internally > > This patch is closely related to this one > https://co

Re: Failed transaction statistics to measure the logical replication progress

On Tue, Nov 16, 2021 at 6:04 PM osumi.takami...@fujitsu.com wrote: > > On Monday, November 15, 2021 9:14 PM I wrote: > > I've conducted some update for this. > > (The rebased part is only C code and checked by pgindent) > I'll update my patches since a new skip xid patch > has been shared in [1].

Re: Skipping logical replication transactions on subscriber side

On Fri, Nov 19, 2021 at 9:22 AM Amit Kapila wrote: > > On Thu, Nov 18, 2021 at 5:10 PM Masahiko Sawada wrote: > > > > On Thu, Nov 18, 2021 at 5:45 PM tanghy.f...@fujitsu.com > > wrote: > > > > > > On Tuesday, November 16, 2021 2:31 PM Masahiko Sawada > > > wrote: > > > > > > > > Right. I've fi

Re: Skipping logical replication transactions on subscriber side

On Fri, Nov 19, 2021 at 12:22 PM Amit Kapila wrote: > > On Fri, Nov 19, 2021 at 11:09 AM vignesh C wrote: > > > > On Fri, Nov 19, 2021 at 9:22 AM Amit Kapila wrote: > > > > > > On Thu, Nov 18, 2021 at 5:10 PM Masahiko Sawada > > > wrote: &g

Re: Printing backtrace of postgres processes

On Thu, Nov 18, 2021 at 9:52 PM Justin Pryzby wrote: > > On Wed, Nov 17, 2021 at 08:12:44PM +0530, vignesh C wrote: > > Attached v14 patch has the fixes for the same. > > Thanks for updating the patch. > > I cleaned up the docs and comments. I think this could be nearly

Re: Failed transaction statistics to measure the logical replication progress

On Fri, Nov 19, 2021 at 7:41 PM Masahiko Sawada wrote: > > On Thu, Nov 18, 2021 at 12:26 PM Amit Kapila wrote: > > > > On Wed, Nov 17, 2021 at 7:12 PM osumi.takami...@fujitsu.com > > wrote: > > > > > > On Wednesday, November 17, 2021 10:00 PM Amit Kapila > > > wrote: > > > > > > > > Can you pl

Re: Optionally automatically disable logical replication subscriptions on error

On Thu, Nov 18, 2021 at 12:52 PM osumi.takami...@fujitsu.com wrote: > > On Thursday, November 18, 2021 2:08 PM Greg Nancarrow > wrote: > > A minor comment: > Thanks for your comments ! > > > doc/src/sgml/ref/alter_subscription.sgml > > (1) disable_on_err? > > > > + disable_on_err. > > > > T

Re: row filtering for logical replication

On Thu, Nov 18, 2021 at 7:04 AM Peter Smith wrote: > > PSA new set of v40* patches. Few comments: 1) When a table is added to the publication, replica identity is checked. But while modifying the publish action to include delete/update, replica identity is not checked for the existing tables. I f

Re: row filtering for logical replication

On Tue, Nov 23, 2021 at 4:58 PM Ajin Cherian wrote: > > Attaching a new patchset v41 which includes changes by both Peter and myself. Few comments on v41-0002 patch: 1) Tab completion should be handled for completion of "WITH(" in "create publication pub1 for table t1 where (c1 > 10)": @@ -2757,1

Re: row filtering for logical replication

On Tue, Nov 23, 2021 at 4:58 PM Ajin Cherian wrote: > > Attaching a new patchset v41 which includes changes by both Peter and myself. > > Patches v40-0005 and v40-0006 have been merged to create patch > v41-0005 which reduces the patches to 6 again. Few comments: 1) I'm not sure if we will be abl

Re: Skipping logical replication transactions on subscriber side

On Wed, Nov 24, 2021 at 5:14 PM Masahiko Sawada wrote: > > On Wed, Nov 17, 2021 at 8:14 PM Amit Kapila wrote: > > > > On Tue, Nov 16, 2021 at 12:01 PM Masahiko Sawada > > wrote: > > > > > > Right. I've fixed this issue and attached an updated patch. One very minor comment: conflict can be move

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On Mon, Nov 15, 2021 at 10:27 PM Bharath Rupireddy wrote: > > On Mon, Nov 15, 2021 at 10:04 PM vignesh C wrote: > > > > On Mon, Nov 15, 2021 at 7:47 AM Bharath Rupireddy > > wrote: > > > > > > On Fri, Nov 5, 2021 at 11:12 AM Bharath Rupireddy > &

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On Sun, Nov 28, 2021 at 12:25 PM Bharath Rupireddy wrote: > > On Sun, Nov 28, 2021 at 12:22 PM vignesh C wrote: > > > Attaching v4 patch, please review it further. > > > > One small comment: > > 1) There should be a space in between "LOGmessage level&quo

Re: enhance pg_log_backend_memory_contexts() to log memory contexts of auxiliary processes

On Sun, Nov 28, 2021 at 7:15 PM Bharath Rupireddy wrote: > > On Sun, Nov 28, 2021 at 5:21 PM vignesh C wrote: > > Thanks for the updated patch, one comment: > > 1) The function can be indented similar to other functions in the same > > file: > > +CREATE FUN

Re: Optionally automatically disable logical replication subscriptions on error

On Fri, Nov 26, 2021 at 8:06 PM osumi.takami...@fujitsu.com wrote: > > On Monday, November 22, 2021 3:53 PM vignesh C wrote: > > Few comments: > Thank you so much for your review ! > > > 1) Changes to handle pg_dump are missing. It should be done in > > dumpSub

Re: Skipping logical replication transactions on subscriber side

On Mon, Nov 29, 2021 at 9:13 AM Amit Kapila wrote: > > On Mon, Nov 29, 2021 at 7:12 AM Masahiko Sawada wrote: > > > > On Sat, Nov 27, 2021 at 7:56 PM Amit Kapila wrote: > > > > > > > Thank you for updating the patch! > > > > > I have made a number of changes in the attached patch which includes

Re: row filtering for logical replication

> > previous code without using an additional variable. > > > > Fixed. > > > 2. > > +typedef struct { > > + Relation rel; > > + bool check_replident; > > + Bitmapset *bms_replident; > > +} > > +rf_context; > > > > Add rf_conte

Re: row filtering for logical replication

On Tue, Nov 30, 2021 at 12:33 PM Ajin Cherian wrote: > > On Thu, Nov 25, 2021 at 2:22 PM Peter Smith wrote: > > > > Thanks for all the review comments so far! We are endeavouring to keep > > pace with them. > > > > All feedback is being tracked and we will fix and/or reply to everything > > ASAP

Re: Skipping logical replication transactions on subscriber side

On Tue, Nov 30, 2021 at 7:09 PM Masahiko Sawada wrote: > > On Tue, Nov 30, 2021 at 8:41 PM Masahiko Sawada wrote: > > > > On Tue, Nov 30, 2021 at 6:28 PM Amit Kapila wrote: > > > > > > On Mon, Nov 29, 2021 at 11:38 AM vignesh C wrote: > > > > >

Re: Optionally automatically disable logical replication subscriptions on error

On Tue, Nov 30, 2021 at 5:34 PM osumi.takami...@fujitsu.com wrote: > > On Tuesday, November 30, 2021 1:10 PM Greg Nancarrow > wrote: > > On Sat, Nov 27, 2021 at 1:36 AM osumi.takami...@fujitsu.com > > wrote: > > > > > > This v7 uses v26 of skip xid patch [1] > > This patch no longer applies on

Re: POC: Cleaning up orphaned files using undo logs

Hi Thomas, While testing one of the recovery scenarios I found one issue: FailedAssertion("!(logno == context->recovery_logno) The details of the same is mentioned below: The context's try_location was not updated in UndoLogAllocateInRecovery, in PrepareUndoInsert the try_location was updated wit

Re: psql - improve test coverage from 41% to 88%

On Thu, Sep 12, 2019 at 11:56 AM Fabien COELHO wrote: > > > On Wed, Sep 11, 2019 at 10:52:01PM +0200, Fabien COELHO wrote: > >> AFAICR this is because the coverage was not the same:-) Some backslash > >> commands just skip silently to the end of the line, so that intermediate > >> \commands on the

Re: psql - improve test coverage from 41% to 88%

On Thu, Sep 12, 2019 at 2:15 PM Fabien COELHO wrote: > > > >> Ok. Rebased version added, with some minor changes to improve readability > >> (comments, variables). > > > > Few comments: [...] > > > > Commented line can be removed > > Commented lines can be removed > > ??? can be changed to some su

Re: block-level incremental backup

On Mon, Sep 9, 2019 at 4:51 PM Jeevan Chalke wrote: > > > > On Tue, Aug 27, 2019 at 4:46 PM vignesh C wrote: >> >> Few comments: >> Comment: >> + buf = (char *) malloc(statbuf->st_size); >> + if (buf == NULL) >> + ereport(ERROR, >> + (e

Re: Psql patch to show access methods info

On Sat, Sep 14, 2019 at 1:45 PM Alexander Korotkov < a.korot...@postgrespro.ru> wrote: > > On Sat, Sep 14, 2019 at 10:39 AM Alexander Korotkov > wrote: > > On Sat, Sep 14, 2019 at 12:36 AM Alvaro Herrera > > wrote: > > > On 2019-Aug-06, Alexander Korotkov wrote: > > > > > > > Revised patch is att

Re: psql - improve test coverage from 41% to 88%

On Thu, Sep 12, 2019 at 4:49 PM Fabien COELHO wrote: > > > >> Here is a v5. > > > Few more in icommand_checks subroutine: > > Few unwanted code can be removed. > > Indeed, more debug and test code. > > Attached v6 fixes these, and I checked for remaining scrubs without > finding any. > Few comment

Re: progress report for ANALYZE

On Thu, Sep 5, 2019 at 2:31 AM Alvaro Herrera wrote: > > There were some minor problems in v5 -- bogus Docbook as well as > outdated rules.out, small "git diff --check" complaint about whitespace. > This v6 (on today's master) fixes those, no other changes. > + + The command is preparin

Re: dropdb --force

On Wed, Sep 18, 2019 at 8:30 AM Pavel Stehule wrote: > > Hi Pavel, One Comment: In the documentation we say drop database will fail after 60 seconds FORCE Attempt to terminate all existing connections to the target database. This will fail, if current use

Re: dropdb --force

On Wed, Sep 18, 2019 at 9:41 AM Pavel Stehule wrote: > > > > st 18. 9. 2019 v 5:59 odesílatel vignesh C napsal: >> >> On Wed, Sep 18, 2019 at 8:30 AM Pavel Stehule >> wrote: >> > >> > >> Hi Pavel, >> >> One Comment: >&

Re: Option to dump foreign data in pg_dump

On Mon, Jul 15, 2019 at 6:09 PM Luis Carril wrote: > > On 15.07.19 12:06, Daniel Gustafsson wrote: > Few comments: As you have specified required_argument in above: + {"include-foreign-data", required_argument, NULL, 11}, The below check may not be required: + if (strcmp(optarg, "") == 0) + { +

Re: Option to dump foreign data in pg_dump

On Thu, Sep 19, 2019 at 3:08 PM vignesh C wrote: > > On Mon, Jul 15, 2019 at 6:09 PM Luis Carril wrote: > > > > On 15.07.19 12:06, Daniel Gustafsson wrote: > > > Few comments: > > As you have specified required_argument in above: > + {"include-foreign-dat

Re: dropdb --force

On Thu, Sep 19, 2019 at 12:14 AM Pavel Stehule wrote: > > Hi > > I am sending updated version - the changes against last patch are two. I use > pg_terminate_backed for killing other terminates like Tom proposed. I am not > sure if it is 100% practical - on second hand the necessary right to kill

Re: dropdb --force

On Thu, Sep 19, 2019 at 11:41 PM Pavel Stehule wrote: > > > > čt 19. 9. 2019 v 13:52 odesílatel vignesh C napsal: >> >> On Thu, Sep 19, 2019 at 12:14 AM Pavel Stehule >> wrote: >> > >> > Hi >> > >> > I am sending upd

Re: psql - add SHOW_ALL_RESULTS option

On Fri, Sep 13, 2019 at 1:01 AM Alvaro Herrera wrote: > > This v6 is just Fabien's v5, rebased over a very minor conflict, and > pgindented. No further changes. I've marked this Ready for Committer. > Should we add function header for the below function to maintain the common standard of this fi

Re: psql - add SHOW_ALL_RESULTS option

On Fri, Sep 20, 2019 at 1:41 PM Fabien COELHO wrote: > > > > Should we add function header for the below function to maintain the > > common standard of this file: > > Yes. Attached v6 does that. > Thanks for fixing it. The below addition can be removed, it seems to be duplicate: @@ -3734,6 +3734

Re: dropdb --force

On Tue, Sep 24, 2019 at 6:22 PM Amit Kapila wrote: > > On Sat, Sep 21, 2019 at 10:09 PM Pavel Stehule > wrote: > > > > Thank you for check. I am sending updated patch > > > Session termination in case of drop database is solved. Some typos: + /* + * Similar code to pg_terminate_backend, but we c

Re: dropdb --force

On Sat, Sep 21, 2019 at 10:09 PM Pavel Stehule wrote: > fixed > > Thank you for check. I am sending updated patch > Thanks for fixing all the comments. Couple of suggestions: -DROP DATABASE [ IF EXISTS ] name +DROP DATABASE [ ( option [, ...] ) ] [ IF EXISTS ] name + +where option can be one of: +

Re: backup manifests

On Sat, Sep 21, 2019 at 12:25 AM Robert Haas wrote: > Some comments: Manifest file will be in plain text format even if compression is specified, should we compress it? May be this is intended, just raised the point to make sure that it is intended. +static void +ReceiveBackupManifestChunk(size_t

Ordering of header file inclusion

Hi, I noticed that some of the header files inclusion is not ordered as per the usual standard that is followed. The attached patch contains the fix for the order in which the header files are included. Let me know your thoughts on the same. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.

Re: dropdb --force

On Wed, Oct 2, 2019 at 10:21 PM Pavel Stehule wrote: > > Thank you for careful review. I hope so all issues are out. > > Thanks Pavel for fixing the comments. Few comments: The else part cannot be hit in DropDatabase function as gram.y expects FORCE. + + if (strcmp(opt->defname, "force") == 0) + f

Re: dropdb --force

On Thu, Oct 3, 2019 at 11:18 PM vignesh C wrote: > > On Wed, Oct 2, 2019 at 10:21 PM Pavel Stehule wrote: > > > > Thank you for careful review. I hope so all issues are out. > > > > > Thanks Pavel for fixing the comments. > Few comments: > The else part ca

Re: [HACKERS] Block level parallel vacuum

On Fri, Oct 4, 2019 at 4:18 PM Amit Kapila wrote: > > On Wed, Oct 2, 2019 at 7:29 PM Masahiko Sawada wrote: >> >> On Sat, Sep 21, 2019 at 9:31 PM Amit Kapila wrote: >> > One comment: We can check if parallel_workers is within range something within MAX_PARALLEL_WORKER_LIMIT. + int parallel_worke

Updated some links which are not working with new links

Hi, There are some links referred in the source files which are currently not working. The below link: is updated with: The below links: http://www-01.ibm.com/support/knowledgecenter/SSGH2K_11.1.0/com.ibm.xlc111.aix.doc/

Non-Active links being referred in our source code

Hi, There are few links present in our source files for which the web links are no more active. Details for the same is given below: Sl No Link Referred File 1 http://h21007.www2.hp.com/portal/download/files/unprot/Itanium/inline_assem_ERS.pdf

Re: dropdb --force

On Fri, Oct 4, 2019 at 9:54 PM Pavel Stehule wrote: > > > > čt 3. 10. 2019 v 19:48 odesílatel vignesh C napsal: >> >> On Wed, Oct 2, 2019 at 10:21 PM Pavel Stehule >> wrote: >> > >> > Thank you for careful review. I hope so all issues are out. &

Re: Updated some links which are not working with new links

On Sat, Oct 5, 2019 at 7:13 AM vignesh C wrote: > > Hi, > > There are some links referred in the source files which are currently > not working. > > The below link: > <http://www.UNIX-systems.org/online.html> > is updated with: > <http://www.unix.org/online.

Re: Updated some links which are not working with new links

On Mon, Oct 7, 2019 at 1:18 PM Michael Paquier wrote: > > Hi Vignesh, > > On Mon, Oct 07, 2019 at 09:38:41AM +0530, vignesh C wrote: > > The attached patch in previous mail contain the changes for the updated > > links requested in [1]. It is not the complete set, but it

Re: Updated some links which are not working with new links

On Tue, Oct 8, 2019 at 11:06 AM Michael Paquier wrote: > > On Mon, Oct 07, 2019 at 02:14:05PM +0530, vignesh C wrote: > > Sorry Michael for the miscommunication, the patch was present in the > > first mail of this mail thread. > > I'm re-attaching the patch in

Re: Non-Active links being referred in our source code

On Tue, Oct 8, 2019 at 10:35 AM Michael Paquier wrote: > > On Mon, Oct 07, 2019 at 05:11:40PM +0200, Juan José Santamaría Flecha wrote: > > About the broken links in win32_port.h, they are all referring to > > ntstatus. As for first case that shows the code groups, there is an up > > to date alter

Re: Ordering of header file inclusion

On Wed, Oct 16, 2019 at 8:10 AM Amit Kapila wrote: > > Thanks for working on this. I will look into this in the coming few > days or during next CF. Can you please register it for the next CF > (https://commitfest.postgresql.org/25/)? > Thanks, I have added it to the commitfest. Regards, Vignes

Re: Proposal: Make use of C99 designated initialisers for nulls/values arrays

On Tue, Oct 8, 2019 at 4:43 AM Smith, Peter wrote: > > From: Amit Kapila Sent: Friday, 4 October 2019 4:50 > PM > > >>How about I just define them both the same? > >>#define INIT_ALL_ELEMS_ZERO {0} > >>#define INIT_ALL_ELEMS_FALSE{0} > > > >I think using one define would be preferred, bu

Re: Ordering of header file inclusion

On Sun, Oct 20, 2019 at 1:20 AM Peter Eisentraut wrote: > > diff --git a/contrib/bloom/blcost.c b/contrib/bloom/blcost.c > index f9fe57f..6224735 100644 > --- a/contrib/bloom/blcost.c > +++ b/contrib/bloom/blcost.c > @@ -12,10 +12,10 @@ > */ > #include "postgres.h" > > +#include "bloom.h" > #i

<    1   2   3   4   5   6   7   8   9   10   >