On Fri, Sep 20, 2019 at 1:41 PM Fabien COELHO <coe...@cri.ensmp.fr> wrote: > > > > Should we add function header for the below function to maintain the > > common standard of this file: > > Yes. Attached v6 does that. > Thanks for fixing it.
The below addition can be removed, it seems to be duplicate: @@ -3734,6 +3734,11 @@ listTables(const char *tabtypes, const char *pattern, bool verbose, bool showSys translate_columns[cols_so_far] = true; } + /* + * We don't bother to count cols_so_far below here, as there's no need + * to; this might change with future additions to the output columns. + */ + /* * We don't bother to count cols_so_far below here, as there's no need * to; this might change with future additions to the output columns. Regards, Vignesh EnterpriseDB: http://www.enterprisedb.com
