On Tue, Oct 19, 2021 at 11:23 AM tanghy.f...@fujitsu.com <tanghy.f...@fujitsu.com> wrote: > > On Tuesday, October 19, 2021 12:57 PM Amit Kapila <amit.kapil...@gmail.com> > wrote: > > > > On Tue, Oct 19, 2021 at 9:15 AM tanghy.f...@fujitsu.com > > <tanghy.f...@fujitsu.com> wrote: > > > > > > On Monday, October 18, 2021 8:23 PM vignesh C <vignes...@gmail.com> > > wrote: > > > > > > > > Thanks for the comments, the attached v42 patch has the fixes for the > > > > same. > > > > > > Thanks for your new patch. > > > > > > I tried your patch and found that the permission check for superuser > > > didn't work. > > > > > > For example: > > > postgres=# create role r1; > > > CREATE ROLE > > > postgres=# grant all privileges on database postgres to r1; > > > GRANT > > > postgres=# set role r1; > > > SET > > > postgres=> create schema s1; > > > CREATE SCHEMA > > > postgres=> create publication pub for all tables in schema s1; > > > CREATE PUBLICATION > > > > > > Role r1 is not superuser, but this role could create publication for all > > > tables in > > schema > > > successfully, I think it is related the following change. List > > > schemaidlist was > > > not assigned yet. I think we should check it later. > > > > > > > It seems this got broken in yesterday's patch version. Do you think it > > is a good idea to add a test for this case? > > > > Agreed. Thanks for your suggestion. > > I tried to add this test to publication.sql, a patch diff file for this test > is attached.
Thanks for the test case, I have merged it to the v43 version patch attached at [1]. [1] - https://www.postgresql.org/message-id/CALDaNm2pJ49wAv%3DgEZrAP5%3D_apAzv_rgK3zjX-wfwCY%2BWWfT9w%40mail.gmail.com Regards, Vignesh
