de::get_free_port()).
. in the inner loop we should probably exit the loop if we set found to
0. There's no point testing other addresses in that case. Something like
"last unless found;" would do the trick.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
e "ago" part every minute,
> and show the absoulte time as a tooltip, which is what pretty much every
> other website does.
>
The code for the page is here:
<https://github.com/PGBuildFarm/server-code/blob/master/templates/status.tt>
Patches welcome.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
he column to contain time of receipt of the buildfarm report
> at the server, less the measured runtime of the test.
That might be possible. I'll put it on my list of things to do. It's not
happening any time soon, though.
cheers
andrew
--
Andrew Dunstanhttps
me. I can much easier
> make sense of an absolute local time: I can compare that to the clock in
> the corner of the screen, and I can compare that, say, to a commit
> timestamp.
>
Maybe.
TBH the whole buildfarm UI is rather dated and clunky. But it needs work
from a web m
On 8/21/19 11:07 AM, Andrew Dunstan wrote:
> On 8/21/19 9:55 AM, Tom Lane wrote:
>> The real problem with that column though is that it relies on run start
>> times that are self-reported by the buildfarm clients, and some of them
>> have system clocks that are many hours of
omplained about this a year ago:
<https://postgr.es/m/9f4f22be-f9f1-b350-bc06-521226b87...@dunslane.net>
+1 for fixing it by any reasonable means.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 8/21/19 4:16 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> What I have done quickly is to store a measure of the clock skew. We
>> already calculated it but we didn't store it. Initial indications are
>> that only a few have significant skew.
> Oh, I didn&#
r": 1,
> "Actual Startup Time": 1468.256,
> "Actual Total Time": 2012.744,
> "Actual Rows": 2684443,
> "Actual Loops": 1
> }
> ],
Yes, that's really awful.
...
> I think that the text format should stay as is.
>
> For the JSON format however it would be better in my opinion if
> "Workers" data is merged. Parsing should not imply anything else than
> "var myObj = JSON.parse(theJsonString);".
>
> What do you think?
>
Maybe a simpler fix would be to rename one set of nodes to
"Sort-Workers" or some such.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 8/21/19 10:52 AM, Andrew Dunstan wrote:
>>
>> The Javscript could also be made to update the "ago" part every minute,
>> and show the absoulte time as a tooltip, which is what pretty much every
>> other website does.
>>
>
> The code for the p
On 8/25/19 4:23 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 8/20/19 8:59 AM, Peter Eisentraut wrote:
>>> Running the regression tests on mingw32, I get the following diff in
>>> circle.out:
>>> - | <(3,5),0> | <(1,2),3&g
On 8/26/19 2:55 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 8/21/19 4:16 PM, Tom Lane wrote:
>>> Andrew Dunstan writes:
>>>> Still, if we simply added the skew to the snapshot time that might be
>>>> enough to achieve what you want. That w
On 8/27/19 4:33 AM, Tom Turelinckx wrote:
> On Mon, Aug 26, 2019, at 9:08 PM, Andrew Dunstan wrote:
>> I think this is the problem:
>>
>> 'scmrepo' => '/home/pgbf/pgmirror.git',
>>
>> Probably this isn't updated often enough. It prob
On 8/27/19 8:45 AM, Andrew Dunstan wrote:
> On 8/27/19 4:33 AM, Tom Turelinckx wrote:
>> On Mon, Aug 26, 2019, at 9:08 PM, Andrew Dunstan wrote:
>>> I think this is the problem:
>>>
>>> 'scmrepo' => '/home/pgbf/pgmirror.git',
>&g
On 8/27/19 10:15 AM, Tom Lane wrote:
> "Tom Turelinckx" writes:
>> On Mon, Aug 26, 2019, at 9:08 PM, Andrew Dunstan wrote:
>>> I think this is the problem:
>>> 'scmrepo' => '/home/pgbf/pgmirror.git',
>>> Probably this isn
On 12/12/2017 02:13 PM, Andrew Dunstan wrote:
>
> On 12/06/2017 11:26 AM, Andrew Dunstan wrote:
>>> In general, you need to be thinking about this in terms of making sure
>>> that it's impossible to accidentally not update code that needs to be
>>> updat
On 12/31/2017 06:48 PM, Andrew Dunstan wrote:
>
> Here is a new version of the patch. It separates the missing values
> constructs and logic from the default values constructs and logic. The
> missing values now sit alongside the default values in tupleConstr. In
> some places
o try to support a "window procedure".
>
Yeah, but these things don't feel like they belong in the same category.
The fact that we have to ask this question is a symptom of that. A
boolean feels more natural to me here, although I acknowledge it will
result in a ti
On 01/02/2018 02:14 PM, Robert Haas wrote:
> On Tue, Jan 2, 2018 at 1:57 PM, Andrew Dunstan
> wrote:
>> Yeah, but these things don't feel like they belong in the same category.
>> The fact that we have to ask this question is a symptom of that.
> Well, that&#
ing.
I'm not 100% clear on why we're adding jsonpathx as an extension,
though. Do we not think most json users will want to use map, reduce etc.?
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 01/02/2018 03:48 PM, Pavel Stehule wrote:
>
>
> 2018-01-02 21:39 GMT+01:00 Andrew Dunstan
> mailto:andrew.duns...@2ndquadrant.com>>:
>
>
>
> On 01/02/2018 02:44 PM, Oleg Bartunov wrote:
> > On Tue, Jan 2, 2018 at 10:47 AM, Pavel Stehule
>
her
Those seem like digestible pieces.
Also, there is a spurious BOM at the start of
src/test/regress/sql/sqljson.sql in patch 7. Please fix that.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 01/03/2018 11:04 AM, Oleg Bartunov wrote:
>
>
> On 3 Jan 2018 00:23, "Andrew Dunstan" <mailto:andrew.duns...@2ndquadrant.com>> wrote:
>
>
>
> On 01/02/2018 05:04 PM, Nikita Glukhov wrote:
> >
> > I have removed all extra featu
ON
stuff anyway.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/doc/src/sgml/func.sgml b/doc/src/sgml/func.sgml
index 4dd9d02..3978747 100644
--- a/doc/src/sgml/func.sgml
On 01/03/2018 01:34 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> This small and simple standalone patch extracted from the SQL/JSON work
>> would allow the user to supply a string with a time zone specified as
>> hh:mm thus:
>> SELECT to_timestamp('2011-
otocol, you can change
them to use https by changing the appropriate line in the repo's config
file, so
url = git://git.postgresql.org/git/postgresql.git
would become
url = https://git.postgresql.org/git/postgresql.git
Enjoy
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
now present.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 01/03/2018 02:21 PM, Andrew Dunstan wrote:
>
> On 01/03/2018 01:34 PM, Tom Lane wrote:
>> Andrew Dunstan writes:
>>> This small and simple standalone patch extracted from the SQL/JSON work
>>> would allow the user to supply a string with a time zo
On 01/07/2018 03:00 PM, Pavel Stehule wrote:
>
>
> 2018-01-07 20:31 GMT+01:00 Andrew Dunstan
> mailto:andrew.duns...@2ndquadrant.com>>:
>
>
> Next up in the proposed SQL/JSON feature set I will review the three
> jsonpath patches. These are attached
On 01/07/2018 03:16 PM, Pavel Stehule wrote:
>
>
> 2018-01-07 21:14 GMT+01:00 Andrew Dunstan
> mailto:andrew.duns...@2ndquadrant.com>>:
>
>
>
> On 01/07/2018 03:00 PM, Pavel Stehule wrote:
> >
> >
> > 2018-01-07 20:31 GMT+01:00
ight be for me to revive my other 32 bit Cygwin instance,
cockatiel.
I'll look into that.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
How would they be affected if they did?
Anyway, marking ready for committer.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
portalContext, and then clean up some
> surrounding APIs.
>
Seems reasonable - 100% cosmetic AFAICT. Marking ready for committer.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
h you have
checked? Did you check the one that also implements to_char functionality?
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 01/09/2018 01:57 PM, Pavel Stehule wrote:
>
>
> 2018-01-09 19:52 GMT+01:00 Andrew Dunstan
> mailto:andrew.duns...@2ndquadrant.com>>:
>
>
>
> On 01/09/2018 01:46 PM, Pavel Stehule wrote:
> >
> >
> > I checked this patch and I thin
On 01/02/2018 05:23 PM, Andrew Dunstan wrote:
>
> On 01/02/2018 05:04 PM, Nikita Glukhov wrote:
>> I have removed all extra features from the patch set, they can be
>> found in our
>> github repository:
>> https://github.com/postgrespro/sqljson/tree/sqljson_ext.
n. I have difficulty with design of documentation, since
> it's unclear to me how detailed it should be. I'm inclining to follow
> xml style of documentation, which is quite formal and could be more
> easy to write.
OK, good. The sooner the better though. Err on the side of
t;>> Ready to go, waiting for animal assignment. For now, I can confirm that it
>>> works, that is, the buildfarm --test run is successful.
>> Thanks!
> Did the animal assignment come through? I don't see such an animal reporting.
Looks like it's still in the
dard double. So I think we should treat them the same way we do for
plain scalar arguments.
(This also suggests that the tests are a bit deficient in not testing
jsonb with large numeric values.)
I'm going to set this back to waiting on author pending discussion.
cheers
andrew
--
And
ption handlers."
The patch has bitrotted slightly in src/backend/commands/portalcmds.c
The plperl expected file needs updating. Also, why does spi_commit() in
a loop result in an error message but not spi_rollback()?
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
mit it shortly.
The next three expose a bit more of the date/time API. I'm still
reviewing those.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 01/16/2018 12:13 AM, David Rowley wrote:
> On 2 January 2018 at 05:01, Andrew Dunstan
> wrote:
>> New version of the patch that fills in the remaining piece in
>> equalTupleDescs.
> This no longer applies to current master. Can send an updated patch?
>
Yea
modules (company stuff). The buildfarm code has also followed the pace,
>> which really helps a lot, thanks to Andrew Dunstan.
>>
>> Developers and committers are more pro-active if they can see automated
>> tests failing in the central community place. And buildfarm animals
&g
On 01/16/2018 10:16 AM, Peter Eisentraut wrote:
> On 1/15/18 12:57, Andrew Dunstan wrote:
>> This confused me slightly:
>>
>> + Transactions cannot be ended inside loops through query results
>> or inside
>> + blocks with exception handlers
On 01/15/2018 07:24 PM, Andrew Dunstan wrote:
>
> On 01/10/2018 05:42 PM, Nikita Glukhov wrote:
>> Attached new 8th version of jsonpath related patches. Complete
>> documentation is still missing.
>>
>> The first 4 small patches are necessary datetime hand
entially
critical situations, still (hospitals, for example). I can, if people
want, keep the machine running just building the back branches.
I should probably look at setting up a modern 32-bit replacement (say
Windows 10 Pro-32).
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
7;d be much welcome.
It's probably going to have to wait a couple of months, and at least a
couple of weeks.
It's worth noting that the last Windows Server edition that supported
342bit architectures was WS2008. That's quite old now. I wonder how long
they will continue to suppo
On 01/17/2018 04:01 PM, Andrew Dunstan wrote:
>
> On 01/15/2018 07:24 PM, Andrew Dunstan wrote:
>> On 01/10/2018 05:42 PM, Nikita Glukhov wrote:
>>> Attached new 8th version of jsonpath related patches. Complete
>>> documentation is still missing.
>>>
>
On Thu, Jan 25, 2018 at 6:10 PM, Thomas Munro
wrote:
> On Wed, Jan 17, 2018 at 2:21 AM, Andrew Dunstan
> wrote:
>> Yeah, got caught by the bki/pg_attribute changes on Friday. here's an
>> updated version. Thanks for looking.
>
> A boring semi-automated update: t
On Mon, Feb 5, 2018 at 7:19 AM, Thomas Munro
wrote:
> On Fri, Jan 26, 2018 at 1:23 PM, Andrew Dunstan
> wrote:
>> Yeah, thanks. revised patch attached
>
> FYI the identity regression test started failing recently with this
> patch applied
On Mon, Feb 5, 2018 at 7:49 AM, Andrew Dunstan
wrote:
> On Mon, Feb 5, 2018 at 7:19 AM, Thomas Munro
> wrote:
>> On Fri, Jan 26, 2018 at 1:23 PM, Andrew Dunstan
>> wrote:
>>> Yeah, thanks. revised patch attached
>>
>> FYI the identity regression test star
>
> I see the patch does not update the ALTER TABLE docs section which
> discusses table rewrites and it seems like it should.
>
Umm it changes the second and third paras of the Notes section, which
refer to rewrites. Not sure what else it should change.
cheers
andrew
--
Andrew Dun
explicit additions to the dictionary, to be of practical use for the
jsonb case, I believe.
I hadn't thought about this as a sort of super enum that was usable
directly by users, but it makes sense.
I have no idea how hard or even possible it would be to implement.
cheers
andrew
--
nfig setting. It would be up to the owner to ensure
that there was a suitable test environment available.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On Fri, Feb 9, 2018 at 3:54 PM, Andrew Dunstan
wrote:
> On Mon, Feb 5, 2018 at 7:49 AM, Andrew Dunstan
> wrote:
>> On Mon, Feb 5, 2018 at 7:19 AM, Thomas Munro
>> wrote:
>>> On Fri, Jan 26, 2018 at 1:23 PM, Andrew Dunstan
>>> wrote:
>>>> Yeah
nstance of it, but
> I've both seen and written queries where you need to use it a bunch of
> times, and that can get really annoying.
How about instead of new operators we just provide a nice shorthand way
of saying these? e.g. ARE and AINT :-)
cheers
andrew
--
Andrew Dunstan
On 10/21/19 9:28 AM, Andrew Dunstan wrote:
> On 10/21/19 2:07 AM, Tomas Vondra wrote:
>> On Sun, Oct 20, 2019 at 06:51:05PM -0400, Andrew Dunstan wrote:
>>>> I think the general premise of this thread is that the application
>>>> developer does not realize that
modified slightly.
There is a test attached that builds and uses one trivial
implementation, which just takes a configuration setting and rot13's it
before supplying the result as the passphrase.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
Postg
the call to IPC::Run.
Some patches I will be submitting shortly rely on this enhancement.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/src/test/perl/TestLib.pm b/src/test/pe
ser can already GRANT superrole TO
normalrole, so it's not any sort of new power.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/contrib/postgres_fdw/connection.
here's no user
input available.
Applications may also override or extend SSL password fetching with
their own
callback.
There is deliberately no environment variable equivalent for the
sslpassword
option.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadra
This time with attachment.
On 10/31/19 6:33 PM, Andrew Dunstan wrote:
> This patch provides for an sslpassword parameter for libpq, and a hook
> that a client can fill in for a callback function to set the password.
>
>
> This provides similar facilities to those already availa
On 10/31/19 6:34 PM, Andrew Dunstan wrote:
> This time with attachment.
>
>
> On 10/31/19 6:33 PM, Andrew Dunstan wrote:
>> This patch provides for an sslpassword parameter for libpq, and a hook
>> that a client can fill in for a callback function to set the password
This patch achieves $SUBJECT and also provides some testing of the
sslpassword setting.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/contrib/postgres_fdw/expe
On 11/1/19 11:01 AM, Robert Haas wrote:
> On Thu, Oct 31, 2019 at 11:37 AM Andrew Dunstan
> wrote:
>> This patch provides a hook for a function that can supply an SSL
>> passphrase. The hook can be filled in by a shared preloadable module. In
>> order for that to be effe
On 11/1/19 12:58 PM, Robert Haas wrote:
> On Thu, Oct 31, 2019 at 4:58 PM Andrew Dunstan
> wrote:
>> This patch allows the superuser to grant passwordless connection rights
>> in postgres_fdw user mappings.
> This is clearly something that we need, as the current code seem
in32API::File so as the file is opened in shared
> mode, we would do the same as what our frontend/backend code does (see
> $uShare):
> https://metacpan.org/pod/Win32API::File
Hmm. What would that look like? (My eyes glazed over a bit reading that
page - probably ENOTENOUGHCAFFEINE)
c
over the
> TAP tests? I'm not sure I believe that slurp_file is the only place
> with a problem.
>
>
In any case, the patch will fail as written - on the Msys 1 system I
just tested Win32::API is not available to the DTK perl we need to use
to run TAP
On 11/7/19 3:42 AM, Juan José Santamaría Flecha wrote:
>
> On Thu, Nov 7, 2019 at 1:57 AM Andrew Dunstan
> <mailto:andrew.duns...@2ndquadrant.com>> wrote:
>
>
> In any case, the patch will fail as written - on the Msys 1 system I
> just tested Win32::API is
On 11/7/19 8:53 AM, Alvaro Herrera wrote:
> On 2019-Nov-07, Andrew Dunstan wrote:
>
>> The test I'm running is:
>>
>> perl -MWin32::API -e ';'
>>
>> And perl reports it can't find the module.
> That's a curious test to try, give
On 11/7/19 9:12 AM, Alvaro Herrera wrote:
> On 2019-Nov-07, Andrew Dunstan wrote:
>
>> On 11/7/19 8:53 AM, Alvaro Herrera wrote:
>>> That's a curious test to try, given that the module is called
>>> Win32API::File.
>> The patch says:
>>
>>
mainder
of the patch doesn't use this at all, AFAICT.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
0.64071
I think this updated patch should fix things.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
diff --git a/src/backend/libpq/be-secure-openssl.c b/src/backend/libpq/be-secure
On 11/8/19 1:16 AM, Craig Ringer wrote:
> On Fri, 8 Nov 2019 at 06:28, Mark Dilger <mailto:hornschnor...@gmail.com>> wrote:
>
>
>
> On 10/31/19 10:02 AM, Andrew Dunstan wrote:
> >
> > This small patch authored by my colleague Cra
On 11/8/19 11:25 AM, Mark Dilger wrote:
>
>
> On 11/8/19 6:33 AM, Andrew Dunstan wrote:
>>
>> On 11/8/19 1:16 AM, Craig Ringer wrote:
>>> On Fri, 8 Nov 2019 at 06:28, Mark Dilger >> <mailto:hornschnor...@gmail.com>> wrote:
>>>
>&
On 11/8/19 4:40 PM, Mark Dilger wrote:
>
>
> On 11/8/19 9:22 AM, Andrew Dunstan wrote:
> ...
>> This will need to be rewritten in light of the above, but see
>> <https://www.postgresql.org/message-id/87b1e36b-e36a-add5-1a9b-9fa34914a...@2ndquadrant.com>
>>
&
On 11/9/19 8:25 AM, Andrew Dunstan wrote:
> OK, I agree that we're getting rather baroque here. I could go with your
> suggestion of YA function, or possibly a solution that simple passes any
> extra arguments straight through to IPC::Run::run(), e.g.
>
> command_fails_like
On 11/7/19 12:30 PM, Andrew Dunstan wrote:
> On 11/4/19 4:43 PM, Thomas Munro wrote:
>> It looks like the new declarations in libpq-be.h are ifdef'd out in a
>> non-USE_SSL build, but then we still try to build the new test module
>> and it fails:
>>
>> http
On 11/11/19 1:27 PM, Mark Dilger wrote:
>
>
> On 11/11/19 8:48 AM, Andrew Dunstan wrote:
>>
>> On 11/9/19 8:25 AM, Andrew Dunstan wrote:
>>> OK, I agree that we're getting rather baroque here. I could go with
>>> your
>>> suggestion of Y
discussion. I would agree with your point if it
were thousands of lines instead of 20 or so lines of core code.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
er more complex implementations.
I'm quite open to suggestions, but I want things to be tolerably clean.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
ad
the library and lookup the symbol. Do we really think it's worth it?
Leveraging shared_preload_libraries makes this comparatively simple.
Also, calling this 'ssl_passphrase_command' seems a little odd.
A simpler way to handle it might be simply to error out and refuse to
On 11/14/19 3:21 PM, Alvaro Herrera wrote:
> On 2019-Nov-14, Andrew Dunstan wrote:
>
>> I guess this would work. There would have to be a deal of code to load
>> the library and lookup the symbol. Do we really think it's worth it?
>> Leveraging shared_preload_libra
Any other looks well, and this function can be very handy.
>
>
Thanks for the review. I will add some docco.
What would be a better error message? "null jsonb replacement not
permitted"?
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
along closely, but why do we need a
cryptographic checksum here instead of, say, a CRC? Do we think that
somehow the checksum might be forged? Use of cryptographic hashes as
general purpose checksums has become far too common IMNSHO.
cheers
andrew
--
Andrew Dunstanhttps://www.
On 11/20/19 3:40 PM, Thomas Munro wrote:
> On Fri, Nov 8, 2019 at 3:41 AM Andrew Dunstan
> wrote:
>> On 11/7/19 9:12 AM, Alvaro Herrera wrote:
>>>> The patch says:
>>>>
>>>> +require Win32::API;
>>>> +Win32::API-&
st patch an outing on
the buildfarm and verify that the issues seen with slurp_file disappear.
That shouldn't take us more than a week or two to see - drongo has had 6
such failures in the last 11 days on master. After that we can discuss
how much further we might want to take it.
cheers
andr
On 11/23/19 3:13 AM, Tels wrote:
>
> Without the strong hashes it would be pointless to sign the manifest.
>
>
I guess I must have missed where we are planning to add a cryptographic
signature.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.co
On 11/22/19 3:46 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> I think the best course is for us to give your latest patch an outing on
>> the buildfarm and verify that the issues seen with slurp_file disappear.
>> That shouldn't take us more than a week or two
On 11/24/19 6:46 PM, Tom Lane wrote:
> Andrew Dunstan writes:
>> On 11/22/19 3:46 PM, Tom Lane wrote:
>>> Andrew Dunstan writes:
>>>> I think the best course is for us to give your latest patch an outing on
>>>> the buildfarm and verify that the issues
,
>>> and then used everywhere that IPC::Run::run currently is used.
>>
>>
>>
>> I don't think we need to do that. In the case of the PostgresNode.pm
>> uses we know what the executable is, unlike the the TestLib.pm cases.
>> They are our own ex
On 11/25/19 1:56 PM, Mark Dilger wrote:
>
>
> On 11/25/19 5:08 AM, Andrew Dunstan wrote:
>>
>> On 11/11/19 4:28 PM, Mark Dilger wrote:
>>>
>>>
>>>>>>>
>>>>>>
>>>>>> On further consideration, I
On 10/31/19 7:27 PM, Andrew Dunstan wrote:
> On 10/31/19 6:34 PM, Andrew Dunstan wrote:
>> This time with attachment.
>>
>>
>> On 10/31/19 6:33 PM, Andrew Dunstan wrote:
>>> This patch provides for an sslpassword parameter for libpq, and a hook
>>
On Sun, Nov 10, 2019 at 4:35 AM Craig Ringer wrote:
>
> On Mon, 4 Nov 2019 at 12:20, Stephen Frost wrote:
>>
>> Greetings,
>>
>> * Andrew Dunstan (andrew.duns...@2ndquadrant.com) wrote:
>> > On 11/1/19 12:58 PM, Robert Haas wrote:
>> >
On 11/25/19 4:09 PM, Andrew Dunstan wrote:
> On 10/31/19 7:27 PM, Andrew Dunstan wrote:
>> On 10/31/19 6:34 PM, Andrew Dunstan wrote:
>>> This time with attachment.
>>>
>>>
>>> On 10/31/19 6:33 PM, Andrew Dunstan wrote:
>>>> This patch pr
atch is waiting on input from you for a couple of days
> now.
>
Will get to this on Friday - tomorrow is Thanksgiving so I'm unlikely to
get to it then.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
allback, callback delegation
> - PEM/DER keys
>
>
Thanks, nice thorough review.
Here's an updated patch that I think fixes all the things you mentioned.
I plan to commit this tomorrow.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Developmen
On 11/30/19 8:48 PM, Michael Paquier wrote:
> On Thu, Oct 31, 2019 at 07:54:41PM -0400, Andrew Dunstan wrote:
>> This patch achieves $SUBJECT and also provides some testing of the
>> sslpassword setting.
> The patch does not apply anymore, so a rebase is needed. As it has
>
> back-patch down to 9.4 where the issue can show up.
>
> Any objections?
Looks reasonable. I wonder if there are other test sets where we need to
set the port.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
rd which run on
bare metal W10Pro haven't seen this problem.
(BTW, from next week I'm going to be down under for 3 months, and my
ability to test Windows things will be somewhat reduced.)
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
eemed like an easy
> thing to test. For this to fix it, you'd have to suppose that we
> never do a CHECK_FOR_INTERRUPTS during a COMMIT command, which is
> improbable at best.
>
You win your bet. Tried this on frogmouth and it still failed.
cheers
andrew
--
Andrew Dunstanhttps://www.2ndQuadrant.com
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
501 - 600 of 2812 matches
Mail list logo
