On 11/1/19 11:01 AM, Robert Haas wrote: > On Thu, Oct 31, 2019 at 11:37 AM Andrew Dunstan > <andrew.duns...@2ndquadrant.com> wrote: >> This patch provides a hook for a function that can supply an SSL >> passphrase. The hook can be filled in by a shared preloadable module. In >> order for that to be effective, the startup order is modified slightly. >> There is a test attached that builds and uses one trivial >> implementation, which just takes a configuration setting and rot13's it >> before supplying the result as the passphrase. > It seems to me that it would be a lot better to have an example in > contrib that does something which might be of actual use to users, > such as running a shell command and reading the passphrase from > stdout. > > Features that are only accessible by writing C code are, in general, > not as desirable as features which can be accessed via SQL or > configuration. >
Well, I tried to provide the most trivial and simple test I could come up with. Running a shell command can already be accomplished via the ssl_passphrase_command setting. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services