On 01/16/2018 10:16 AM, Peter Eisentraut wrote: > On 1/15/18 12:57, Andrew Dunstan wrote: >> This confused me slightly: >> >> + Transactions cannot be ended inside loops through query results >> or inside >> + blocks with exception handlers. >> >> I suggest: "A transaction cannot be ended inside a loop over query >> results, nor inside a block with exception handlers." > fixed > >> The patch has bitrotted slightly in src/backend/commands/portalcmds.c > merged > >> The plperl expected file needs updating. Also, why does spi_commit() in >> a loop result in an error message but not spi_rollback()? > This is all changed now after the patch for portal pinning in PL/Perl > and PL/Python has been committed. The attached patch behaves better. >
Looks good. Marking ready for committer. cheers andrew -- Andrew Dunstan https://www.2ndQuadrant.com PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
