Re: Huge commitfest app update upcoming: Tags, Draft CF, Help page, and automated commitfest creat/open/close

2025-06-18 Thread Jelte Fennema-Nio
On Wed, 18 Jun 2025 at 05:58, Peter Eisentraut wrote: > Can you explain the motivation for this change a bit more? A few main reasons (from important to unimportant): 1. For new/irregular contributors the old names were really not obvious IMO. It took me 3+ years to get the mental association wit

Re: [PATCH] Add additional extended protocol commands to psql: \parse and \bindx

2025-06-18 Thread Jelte Fennema-Nio
On Wed, 18 Jun 2025 at 08:23, Anthonin Bonnefoy wrote: > > On Tue, Jun 17, 2025 at 4:05 PM Jelte Fennema-Nio wrote: > > > > Agreed. My vote is for \closeprepared as that aligns with the libpq > > function. > > Since \bind_named is also new, we can also rename it to make it > consistent with clos

Re: pg_dump misses comments on NOT NULL constraints

2025-06-18 Thread Álvaro Herrera
On 2025-Jun-18, Fujii Masao wrote: > On 2025/06/18 9:13, Fujii Masao wrote: > > In v18, we can now add comments on NOT NULL constraints. However, I noticed > > that pg_dump doesn't include those comments in its output. For example: This is definitely a bug, thanks for reporting. > I ran into an

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

2025-06-18 Thread Ranier Vilela
Em qua., 18 de jun. de 2025 às 07:29, Etsuro Fujita escreveu: > On Tue, Jun 17, 2025 at 11:03 PM Fujii Masao > wrote: > > On 2025/06/17 20:37, Ranier Vilela wrote: > > > Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita < > etsuro.fuj...@gmail.com > escreveu: >

Re: amcheck support for BRIN indexes

2025-06-18 Thread Andrey Borodin
> On 18 Jun 2025, at 11:33, Arseniy Mukhin wrote: > > Interesting, I used btree check as reference when started > writing brin check, and in btree check there 53 > ERRCODE_INDEX_CORRUPTED ereports and only 1 ERRCODE_DATA_CORRUPTED > ereport. So it was very hard to do, but I managed to pick the

Re: pg_dump misses comments on NOT NULL constraints

2025-06-18 Thread Álvaro Herrera
On 2025-Jun-18, jian he wrote: > Similarly we don't need to worry about not-null constraints that are > dumped separately. > dumpConstraint, dumpTableConstraintComment will do the job. Right. > dumpTableSchema handles dumping of table column definitions, and tells us > which > column print_notn

Fixes inconsistent behavior in vacuum when it processes multiple relations

2025-06-18 Thread shihao zhong
Hi team, One of our customers recently encountered an issue with PostgreSQL's pg_cron and VACUUM ANALYZE. They had configured a table with vacuum_truncate=false to prevent exclusive lock contention, assuming this would apply globally. However, VACUUM ANALYZE executed across the entire database doe

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

2025-06-18 Thread shveta malik
On Wed, Jun 18, 2025 at 2:39 PM Bertrand Drouvot wrote: > > Hi, > > On Tue, Jun 10, 2025 at 02:00:55PM -0700, Masahiko Sawada wrote: > > > > > > > 0001 patch allows us to create a logical slot without WAL > > > > > > > reservation. > > Thanks for the patch and sorry to be late in this conversatio

Re: Proposal: Global Index for PostgreSQL

2025-06-18 Thread Dilip Kumar
On Wed, Jun 18, 2025 at 4:38 AM Masahiko Sawada wrote: > > On Sat, Jun 14, 2025 at 2:32 AM Dilip Kumar wrote: > > Thanks for your opinion, Sawada-San. > Does it need to keep holding dead TIDs for each partition until it > completes vacuuming all partitions that are covered by the global > index

Re: Non-reproducible AIO failure

2025-06-18 Thread Andres Freund
Hi, On 2025-06-18 10:32:08 +0300, Konstantin Knizhnik wrote: > On 17/06/2025 6:08 pm, Andres Freund wrote: > > > > I don't think it can - this must be an independent bug from the one that Tom > > and I were encountering. > I see... It's a pity. Indeed. Konstantin, Alexander, can you share what

Re: CHECKPOINT unlogged data

2025-06-18 Thread Nathan Bossart
I broke this up into several small patches. Notable changes are as follows: * Adjusted to the tab completion code to work more like the VACUUM utility options. * Introduced a new ExecCheckpoint() function in checkpointer.c and moved the privilege check and options parsing there. * Removed t

Re: minimum Meson version

2025-06-18 Thread Robert Haas
On Wed, Jun 18, 2025 at 9:35 AM Jelte Fennema-Nio wrote: > And what I just don't understand about this whole discussion: What I just don't understand about this discussion is a bunch of smart people thinking that a bunch of other smart people have completely lost their minds, while the second gro

Re: minimum Meson version

2025-06-18 Thread Jelte Fennema-Nio
On Wed, 18 Jun 2025 at 07:38, Peter Eisentraut wrote: > That's probably ok for developers, but then again, probably no one > develops PostgreSQL master on RHEL 8. But production RPM builds need to > be done "in system", with the build tools being provided by > vendor-supplied RPMs themselves, wit

Re: Non-reproducible AIO failure

2025-06-18 Thread Konstantin Knizhnik
On 17/06/2025 6:08 pm, Andres Freund wrote: I don't think it can - this must be an independent bug from the one that Tom and I were encountering. I see... It's a pity. By the way, I have a questions concerning using interrupts in AIO. The comments say: pgaio_io_release(PgAioHandle *ioh)  

RE: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-06-18 Thread Hayato Kuroda (Fujitsu)
Dear Vitaly, I've been working on the bug... > This assert was introduced in the patch. Now, I think, it is a wrong one. Let > me > please explain one of the possible scenarios when it can be triggered. In case > of physical replication, when walsender receives a standby reply message, it > call

Re: POC: Parallel processing of indexes in autovacuum

2025-06-18 Thread Daniil Davydov
Hi, On Wed, Jun 18, 2025 at 5:37 AM Masahiko Sawada wrote: > > On Sun, May 25, 2025 at 10:22 AM Daniil Davydov <3daniss...@gmail.com> wrote: > > > > Thanks everybody for feedback! I attach a v4 patch to this letter. > > Main features : > > 1) 'parallel_autovacuum_workers' reloption - integer valu

Re: confusing message in check_tuple

2025-06-18 Thread Bertrand Drouvot
Hi, On Tue, Jun 17, 2025 at 07:21:13AM +0200, Peter Eisentraut wrote: > On 12.06.25 08:26, jian he wrote: > > in contrib/amcheck/verify_heapam.c, check_tuple > > report_corruption(ctx, > >psprintf("number of attributes %u exceeds > > maximum expected for table

Re: Avoid possible dereference null pointer (contrib/postgres_fdw/postgres_fdw.c)

2025-06-18 Thread Etsuro Fujita
On Tue, Jun 17, 2025 at 11:03 PM Fujii Masao wrote: > On 2025/06/17 20:37, Ranier Vilela wrote: > > Em ter., 17 de jun. de 2025 às 06:09, Etsuro Fujita > > mailto:etsuro.fuj...@gmail.com>> escreveu: > > On Tue, Jun 17, 2025 at 2:38 PM Fujii Masao > > mailto:masao.fu...@oss.nttdata.com>> wrot

Re: pg_dump --with-* options

2025-06-18 Thread Nathan Bossart
On Wed, Jun 18, 2025 at 08:29:16AM -0700, Jeff Davis wrote: > Actually, I take that back, we can't just remove --no-statistics. > Remember that statistics currently default to "on" for pg_restore even > though they default "off" for pg_dump. > > So pg_restore still needs a way to turn stats off.

Re: minimum Meson version

2025-06-18 Thread Peter Eisentraut
On 17.06.25 19:36, Peter Eisentraut wrote: meson.build currently says # We want < 0.56 for python 3.5 compatibility on old platforms. EPEL for # RHEL 7 has 0.55. < 0.54 would require replacing some uses of the fs # module, < 0.53 all uses of fs. So far there's no need to go to >=0.56. meson_vers

Re: Improve CRC32C performance on SSE4.2

2025-06-18 Thread Andy Fan
John Naylor writes: Hi, >> Just be curious, what kind of optimization (like what -O2 does) could >> mask this issue? > > In case Andy is asking about "how" rather than "under what > circumstances", my guess is: -O1+ may have just chosen instructions > that also happen to zero-extend, which are

Re: pg_dump misses comments on NOT NULL constraints

2025-06-18 Thread jian he
On Wed, Jun 18, 2025 at 8:13 AM Fujii Masao wrote: > > I'm aware of a related open item [1] affecting both v17 and v18, > but this seems like a separate issue, since it relates to a new v18 feature... > Or we should treat them the same? > I think they are separate issues. for check constraint tha

Re: Replication slot is not able to sync up

2025-06-18 Thread Amit Kapila
On Wed, Jun 18, 2025 at 8:52 AM shveta malik wrote: > > On Tue, Jun 17, 2025 at 12:01 PM Amit Kapila wrote: > > > > This whole paragraph sounds like a duplicate of its previous section, > > and the line alignment in the first paragraph has some issues. > > > > Sorry for the wrong upload, duplicac

Re: [BUG] temporary file usage report with extended protocol and unnamed portals

2025-06-18 Thread Frédéric Yhuel
On 4/26/25 20:57, Sami Imseih wrote: I found several issues with v4. It does not deal correctly with pipelining, and we should only really be concerned with dropping an unnamed portal only. So, v5 now moves the DropPortal call after the unnamed portal was executed to completion ( as v4 was doi

Re: amcheck support for BRIN indexes

2025-06-18 Thread Arseniy Mukhin
On Mon, Jun 9, 2025 at 1:16 AM Tomas Vondra wrote: > > On 6/8/25 14:39, Arseniy Mukhin wrote: > > Hi, > > > > Here is a new version. > > > > TAP tests were added. Tried to reproduce more or less every violation. > > I don't include 2 tests where disk representation ItemIdData needs to > > be chang

Re: [PATCH] Add an ldflags_sl meson build option

2025-06-18 Thread Peter Eisentraut
On 18.06.25 08:40, Matt Smith (matts3) wrote: Yes I understand what you're saying. I know Meson tries to set some of these flags. But I want the source of truth for my flags for each target type to be outside Meson.  Which Meson is not designed to do. When you're building many 3^rd  party deps

Re: pg_dump --with-* options

2025-06-18 Thread Jeff Davis
On Thu, 2025-06-12 at 08:58 -0700, Jeff Davis wrote: > On Thu, 2025-06-12 at 09:52 -0500, Nathan Bossart wrote: > > If the idea is to remove all options for default behavior, we'd be > > removing > > --no-statistics, --with-data, and --with-schema at this point. > > That's OK with me. Actually, I

Re: POC: enable logical decoding when wal_level = 'replica' without a server restart

2025-06-18 Thread Bertrand Drouvot
Hi, On Tue, Jun 10, 2025 at 02:00:55PM -0700, Masahiko Sawada wrote: > > > > > > 0001 patch allows us to create a logical slot without WAL > > > > > > reservation. Thanks for the patch and sorry to be late in this conversation. The thing that worry me a bit with this is that that could be easy

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-06-18 Thread vignesh C
On Wed, 18 Jun 2025 at 14:35, Vitaly Davydov wrote: > > Dear Hayato, > > > To confirm, can you tell me the theory why the walsender received old LSN? > > It is sent by the walreceiver, so is there a case that > > LogstreamResult.Flush can go backward? > > Not sure we can accept the situation. > >

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

2025-06-18 Thread Mihail Nikalayeu
Hello, Sergey! > In patch v20-0006-Add-STIR-access-method-and-flags-related-to-auxi.patch, > within the "StirMarkAsSkipInserts" function, a critical section appears to be > left unclosed. This resulted in an assertion failure during ANALYZE of a > table containing a leftover STIR index. Thanks,

Re: minimum Meson version

2025-06-18 Thread Tom Lane
I wrote: > In the context of RHEL, it says here [1] that RHEL8 maintenance > support runs through May 2029 while extended support runs through > May 2031. That would still mean we're supporting RHEL8 for another > four years. I'm not sure what the corresponding dates are for > other LTS vendors.

Re: Document NULL

2025-06-18 Thread David G. Johnston
On Wed, Jun 18, 2025, 11:25 Marcos Pegoraro wrote: > Em ter., 11 de mar. de 2025 às 12:52, David G. Johnston < >> david.g.johns...@gmail.com> escreveu: >> > I'm mostly indifferent and it is very simple to change. It seemed >> desirable to have the main topic of this page display as something tha

Re: Fixes inconsistent behavior in vacuum when it processes multiple relations

2025-06-18 Thread shihao zhong
>> That leads me to think (1) might be the better option, although I'm not too >> wild about the subtlety of the fix. Thanks for your feedback. New patch is attached. I also updated the signature of do_analyze_rel for the same reason. On Wed, Jun 18, 2025 at 12:31 PM Nathan Bossart wrote: > > On

Re: Add CASEFOLD() function.

2025-06-18 Thread Vik Fearing
On 17/06/2025 20:14, Jeff Davis wrote: On Tue, 2025-06-17 at 17:37 +0200, Vik Fearing wrote: If the character set of is UTF8, UTF16, or UTF32, then FR is replaced by Case: i) If the S IS NORMALIZED evaluates to True, then NORMALIZE (FR) ii) Otherwise, FR. I read th

Re: minimum Meson version

2025-06-18 Thread Andres Freund
Hi, On 2025-06-18 13:20:54 -0400, Jesper Pedersen wrote: > On 6/18/25 1:07 PM, Robert Haas wrote: > > Since any policy > > that anyone is likely to actually propose falls somewhere between > > those two extremes, half of us are then bitterly unhappy with it. > > > > Which is why I tried to add D

Re: Slot's restart_lsn may point to removed WAL segment after hard restart unexpectedly

2025-06-18 Thread Alexander Korotkov
On Wed, Jun 18, 2025 at 6:50 PM Vitaly Davydov wrote: > > I think, it is a good idea. Once we do not use the generated data, it is ok > > just to generate WAL segments using the proposed function. I've tested this > > function. The tests worked as expected with and without the fix. The > > attach

Re: pg_dump --with-* options

2025-06-18 Thread Nathan Bossart
On Wed, Jun 18, 2025 at 09:53:01AM -0700, Jeff Davis wrote: > On Wed, 2025-06-18 at 10:43 -0500, Nathan Bossart wrote: >> IIUC the current proposal is to: >> >> * Dump/restore stats by default. > > IIUC some people still object to this. Turning stats off by default was > on the Open Items list. A

Re: Fix copy-and-past thinko (src/interfaces/libpq/fe-cancel.c)

2025-06-18 Thread Ranier Vilela
Em ter., 17 de jun. de 2025 às 10:42, Daniel Gustafsson escreveu: > > On 17 Jun 2025, at 15:40, Ranier Vilela wrote: > > > In the function *PQcancelCreate* there is a copy-and-past thinko. > > The pointer that must be checked is cancelConn. > > > > Trivial patch attached. > > Nice catch, will fi

Re: pg_dump --with-* options

2025-06-18 Thread Jeff Davis
On Wed, 2025-06-18 at 10:43 -0500, Nathan Bossart wrote: > IIUC the current proposal is to: > > * Dump/restore stats by default. > * Keep the --no-statistics, --no-schema, and --no-data options. > * Keep the --statistics-only, --schema-only, and --data-only options. > * Remove the --with-statistic

Re: pg_dump --with-* options

2025-06-18 Thread Jeff Davis
On Wed, 2025-06-18 at 10:43 -0500, Nathan Bossart wrote: > IIUC the current proposal is to: > > * Dump/restore stats by default. IIUC some people still object to this. Turning stats off by default was on the Open Items list. At this point I think we need a pretty strong consensus to override that

Re: minimum Meson version

2025-06-18 Thread Tom Lane
Peter Eisentraut writes: > On 18.06.25 19:53, Andres Freund wrote: >> 1) We don't remove support for OS versions unless they block something > Maybe it's worth clarifying the interpretation of this. > For example, for the purpose of this thread, I wouldn't consider RHEL8 > to be blocking anythi

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

2025-06-18 Thread Sergey Sargsyan
My bad, my fork's based on pg15, and over there tuplestore_end() does this, void tuplestore_end(Tuplestorestate *state) { int i; if (state->myfile) BufFileClose(state->myfile); if (state->memtuples) { for (i = state->memtupdeleted; i < state->memtupcount; i++) pfree(state->memtuples[i]); pfree(st

Re: Fwd: dsm_registry: Add detach and destroy features

2025-06-18 Thread Nathan Bossart
On Wed, Jun 18, 2025 at 09:03:59AM +0900, Sungwoo Chang wrote: > I created a new patch that throws an exception if we try to call > destroy on a dsm segment that is still in use. > I added a function in dsm.h that returns a refcnt of a given dsm > segment. The destroy function uses that refcnt > ge

Re: Non-reproducible AIO failure

2025-06-18 Thread Thomas Munro
On Thu, Jun 19, 2025 at 4:08 AM Andres Freund wrote: > Konstantin, Alexander, can you share what commit you're testing and what > precise changes have been applied to the source? I've now tested this on a > significant number of apple machines for many many days without being able to > reproduce

Re: minimum Meson version

2025-06-18 Thread Devrim Gündüz
Hi, On Wed, 2025-06-18 at 09:35 +0200, Jelte Fennema-Nio wrote: > Okay, so maybe pip install is not what they want. But they could still > create a recent ninja & meson RPM themselves right. It could be doable if we were talking about just two packages and then there are a lot of dependencies an

Re: minimum Meson version

2025-06-18 Thread Tom Lane
Robert Haas writes: > On Wed, Jun 18, 2025 at 9:35 AM Jelte Fennema-Nio wrote: >> And what I just don't understand about this whole discussion: > What I just don't understand about this discussion is a bunch of smart > people thinking that a bunch of other smart people have completely > lost the

Re: Fixes inconsistent behavior in vacuum when it processes multiple relations

2025-06-18 Thread Nathan Bossart
On Wed, Jun 18, 2025 at 11:15:31AM -0400, shihao zhong wrote: > I investigated the code and found a small bug with how we're passing > the VacuumParams pointer. > > The call flow is > ExecVacuum -> vacuum -> vacuum_rel > > The initial VaccumParams pointer is set in ExecVacuum > In vacuum_rel, thi

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

2025-06-18 Thread Sergey Sargsyan
Hi, Today I encountered a segmentation fault caused by the patch v20-0007-Add-Datum-storage-support-to-tuplestore.patch. During the merge phase, I inserted some tuples into the table so that STIR would have data for the validation phase. The segfault occurred during a call to tuplestore_end(). Th

Re: minimum Meson version

2025-06-18 Thread Andres Freund
Hi, On 2025-06-18 12:27:44 -0400, Tom Lane wrote: > Robert Haas writes: > > On Wed, Jun 18, 2025 at 9:35 AM Jelte Fennema-Nio > > wrote: > >> And what I just don't understand about this whole discussion: > > > What I just don't understand about this discussion is a bunch of smart > > people th

Re: CHECKPOINT unlogged data

2025-06-18 Thread Christoph Berg
Re: Nathan Bossart > I broke this up into several small patches. Notable changes are as > follows: > > * Adjusted to the tab completion code to work more like the VACUUM utility > options. > > * Introduced a new ExecCheckpoint() function in checkpointer.c and moved > the privilege check and

Re: pg_dump/pg_dumpall help synopses and terminology

2025-06-18 Thread Robert Treat
On Tue, Jun 17, 2025 at 3:32 AM Peter Eisentraut wrote: > On 10.06.25 13:51, Ashutosh Bapat wrote: > > Since we are using "a PostgreSQL database" and "a PostgreSQL cluster" > > with pg_dump and pg_dumpall respectively, it makes sense to use the same > > wording for pg_restore. Th description at [1

Re: pg18: Virtual generated columns are not (yet) safe when superuser selects from them

2025-06-18 Thread Peter Eisentraut
On 05.06.25 12:49, Peter Eisentraut wrote: On 23.05.25 10:43, Feike Steenbergen wrote: Attached is a sample exploit, that achieves this, key components: - the GENERATED column uses a user defined immutable function - this immutable function cannot ALTER ROLE (needs volatile) - therefore this im

Re: Revisiting {CREATE INDEX, REINDEX} CONCURRENTLY improvements

2025-06-18 Thread Mihail Nikalayeu
Hello, Sergey! > Today I encountered a segmentation fault caused by the patch > v20-0007-Add-Datum-storage-support-to-tuplestore.patch. During the merge > phase, I inserted some tuples into the table so that STIR would have data for > the validation phase. The segfault occurred during a call to

Re: minimum Meson version

2025-06-18 Thread Andres Freund
Hi, On 2025-06-18 19:07:32 +0200, Robert Haas wrote: > On Wed, Jun 18, 2025 at 6:27 PM Tom Lane wrote: > But it seems impossible to have rational discussions about this, > because - if I may exaggerate slightly for effect - some of us think > everyone with half a brain should upgrade within a wee

Re: Document NULL

2025-06-18 Thread David G. Johnston
On Tue, Mar 11, 2025 at 8:51 AM David G. Johnston < david.g.johns...@gmail.com> wrote: > Version 7 > https://wiki.postgresql.org/wiki/Documenting_NULL > https://commitfest.postgresql.org/patch/5086/ > > The only item that came up that I'm unable to address myself is discussion > comparing a NOT NU

Re: minimum Meson version

2025-06-18 Thread Tom Lane
Andres Freund writes: > I think we should have a policy roughly along these lines: > 1) We don't remove support for OS versions unless they block something > 2) We don't remove support for OS versions in minor releases > 3) If support for an old OS version makes something harder, it can be remo

Re: minimum Meson version

2025-06-18 Thread Peter Eisentraut
On 18.06.25 19:53, Andres Freund wrote: 1) We don't remove support for OS versions unless they block something Maybe it's worth clarifying the interpretation of this. For example, for the purpose of this thread, I wouldn't consider RHEL8 to be blocking anything at the moment. It's technicall

Re: minimum Meson version

2025-06-18 Thread Greg Sabino Mullane
On Wed, Jun 18, 2025 at 3:35 AM Jelte Fennema-Nio wrote: > And what I just don't understand about this whole discussion: We're > talking about people who want to be frozen in time for 5 years > straight during this "maintenance support" window by the vendor (whom they > are paying), with only acc

Making Row Comparison NULL row member handling more robust during skip scans

2025-06-18 Thread Peter Geoghegan
There's one aspect of my recent bugfix commit 5f4d98d4 that still doesn't sit well with me: the way that it taught _bt_set_startikey to completely back out of applying any of its optimization in the presence of a RowCompare. Without this "row compare back out" behavior, there are obscure cases wher

Re: Add CASEFOLD() function.

2025-06-18 Thread Jeff Davis
On Wed, 2025-06-18 at 19:09 +0200, Vik Fearing wrote: > I don't know.  I am just pointing out what the Standard says.  I > think > we should either comply, or say that we don't do it for LOWER and > UPPER > so let's keep things implementation-consistent. For the standard, I see two potential phi

Re: Add CASEFOLD() function.

2025-06-18 Thread Thom Brown
On Thu, 19 Jun 2025, 03:53 Jeff Davis, wrote: > On Wed, 2025-06-18 at 19:09 +0200, Vik Fearing wrote: > > I don't know. I am just pointing out what the Standard says. I > > think > > we should either comply, or say that we don't do it for LOWER and > > UPPER > > so let's keep things implementat

Re: Add progressive backoff to XactLockTableWait functions

2025-06-18 Thread Xuneng Zhou
Hi Andres, Thanks for looking into this! On Tue, Jun 17, 2025 at 10:17 PM Andres Freund wrote: > Hi, > > On 2025-06-08 22:33:39 +0800, Xuneng Zhou wrote: > > This patch implements progressive backoff in XactLockTableWait() and > > ConditionalXactLockTableWait(). > > > > As Kevin reported in thi

Re: Document NULL

2025-06-18 Thread Marcos Pegoraro
> > Em ter., 11 de mar. de 2025 às 12:52, David G. Johnston < > david.g.johns...@gmail.com> escreveu: > I'm mostly indifferent and it is very simple to change. It seemed > desirable to have the main topic of this page display as something that > isn't invisible though. And NULL was unappealing si

Correct docs about partitions and EXCLUDE constraints

2025-06-18 Thread Paul Jungwirth
Hi Hackers, In pg17 we added support for cross-partition EXCLUDE constraints, as long as they included all partition key columns and compared them with equality (see 8c852ba9a4). I updated the docs for exclusion constraints, but I missed that the docs for CREATE TABLE still said that they were

Re: minimum Meson version

2025-06-18 Thread Devrim Gündüz
Hi, On Wed, 2025-06-18 at 13:27 -0400, Andres Freund wrote: > On 2025-06-18 13:20:54 -0400, Jesper Pedersen wrote: > > On 6/18/25 1:07 PM, Robert Haas wrote: > > > Since any policy > > > that anyone is likely to actually propose falls somewhere between > > > those two extremes, half of us are then

Re: minimum Meson version

2025-06-18 Thread Robert Haas
On Wed, Jun 18, 2025 at 6:27 PM Tom Lane wrote: > Indeed. I think the compromise we've usually settled on is "we'll > support release X as long as there's somebody willing to do the work". > If it's not costing you personally any effort, why object to someone > else wanting to spend effort on suc

Re: minimum Meson version

2025-06-18 Thread Jesper Pedersen
Hi On 6/18/25 1:07 PM, Robert Haas wrote: Since any policy that anyone is likely to actually propose falls somewhere between those two extremes, half of us are then bitterly unhappy with it. Which is why I tried to add Devrim to the thread. What builds on yum.postgresql.org are using meson ?

Re: [WIP]Vertical Clustered Index (columnar store extension) - take2

2025-06-18 Thread Peter Smith
On Tue, Jun 10, 2025 at 6:02 PM Peter Smith wrote: > > Hi Timur. > > On Wed, Jun 4, 2025 at 11:47 PM Timur Magomedov > wrote: > > > > Hello Peter, > > > > I've tried running VCI, the idea looks great to me. Thank you and > > Iwata-san for working on this feature. Looked at the source code of VCI

Re: Adding a '--clean-publisher-objects' option to 'pg_createsubscriber' utility.

2025-06-18 Thread Amit Kapila
On Wed, Jun 18, 2025 at 10:32 AM David G. Johnston wrote: > >> >> The list can be longer than one or two. We may need to provide similar >> options for other objects, such as replication slots (synced failover >> replication slots on the physical standby), user-defined functions, >> triggers, view

Re: Add RESPECT/IGNORE NULLS and FROM FIRST/LAST options

2025-06-18 Thread Tatsuo Ishii
> Here is the v12 patch to implement the optimization on top of Oliver's > v11 patch. Only src/backend/executor/nodeWindowAgg.c was modified > (especially ignorenulls_getfuncarginframe). In the patch I created > 2-bit not null information array, representing following status for > each row: > > UN

Re: Fix slot synchronization with two_phase decoding enabled

2025-06-18 Thread shveta malik
On Tue, Jun 17, 2025 at 5:17 AM Masahiko Sawada wrote: > > On Wed, Jun 11, 2025 at 9:50 PM shveta malik wrote: > > > > On Wed, Jun 11, 2025 at 11:31 PM Masahiko Sawada > > wrote: > > > > > > > > BTW have we addressed the point Amit mentioned before[1]? > > > > > > > The one more combination to

Re: minimum Meson version

2025-06-18 Thread Nazir Bilal Yavuz
Hi, On Wed, 18 Jun 2025 at 11:58, Peter Eisentraut wrote: > > On 17.06.25 19:36, Peter Eisentraut wrote: > > meson.build currently says > > > > # We want < 0.56 for python 3.5 compatibility on old platforms. EPEL for > > # RHEL 7 has 0.55. < 0.54 would require replacing some uses of the fs > > #

Re: Add CASEFOLD() function.

2025-06-18 Thread Jeff Davis
On Thu, 2025-06-19 at 05:03 +0100, Thom Brown wrote: > Late to the party, but is there an argument for porting this to the > citext type? Or supplementing the extension with an additional type > ("cftext"? *shrug*). CASEFOLD() addresses a lot of the problems with using LOWER(), so that sounds like

libxml2 author overwhelmed with security requests

2025-06-18 Thread Bruce Momjian
This blog post explains the serious problems the single libxml2 author is having in maintaining the library: https://socket.dev/blog/libxml2-maintainer-ends-embargoed-vulnerability-reports There are few learnings from this: * libxml2 is even less production-ready than we thought * man

Re: pg_dump misses comments on NOT NULL constraints

2025-06-18 Thread jian he
On Wed, Jun 18, 2025 at 11:05 PM Álvaro Herrera wrote: > > I agree that this is roughly the right approach, but I think you're > doing it harder than it needs to be -- it might be easier to add a JOIN > to pg_description to the big query in getTableAttrs(), and add a pointer > to the returned stri

Re: pg_dump misses comments on NOT NULL constraints

2025-06-18 Thread jian he
On Wed, Jun 18, 2025 at 10:21 AM Fujii Masao wrote: > > I ran into another issue related to comments on NOT NULL constraints. > When using CREATE TABLE ... (LIKE ... INCLUDING ALL), the NOT NULL constraints > are copied, but their comments are not. For example: > >

Re: Logical Replication of sequences

2025-06-18 Thread Nisha Moond
Hi, Here are my review comments for v20250610 patches: Patch-0005:sequencesync.c 1) report_error_sequences() In case there are both missing and mismatched sequences, the ERROR message logged is - ``` 2025-05-28 14:22:19.898 IST [392259] ERROR: logical replication sequence synchronization fail