On Wed, Jun 18, 2025 at 6:50 PM Vitaly Davydov <v.davy...@postgrespro.ru> wrote: > > I think, it is a good idea. Once we do not use the generated data, it is ok > > just to generate WAL segments using the proposed function. I've tested this > > function. The tests worked as expected with and without the fix. The > > attached > > patch does the change. > > Sorry, forgot to attach the patch. It is created on the current master branch. > It may conflict with your corrections. I hope, it could be useful.
Thank you. I've integrated this into a patch to improve these tests. Regarding assertion failure, I've found that assert in PhysicalConfirmReceivedLocation() conflicts with restart_lsn previously set by ReplicationSlotReserveWal(). As I can see, ReplicationSlotReserveWal() just picks fresh XLogCtl->RedoRecPtr lsn. So, it doesn't seems there is a guarantee that restart_lsn never goes backward. The commit in ReplicationSlotReserveWal() even states there is a "chance that we have to retry". Thus, I propose to remove the assertion introduced by ca307d5cec90. Any objection from backpatching 0001 though 17 and pushing 0002 to the head? ------ Regards, Alexander Korotkov Supabase
v4-0002-Remove-excess-assert-from-InvalidatePossiblyObsol.patch
Description: Binary data
v4-0001-Improve-runtime-and-output-of-tests-for-replicati.patch
Description: Binary data
