On Tue, Jun 25, 2024 at 1:19 PM Nathan Bossart
wrote:
> On Tue, Jun 25, 2024 at 04:04:03PM -0400, Robert Haas wrote:
> > Looking at this again, how happy are you with the way you've got
> > several roles per instead of one for each? I realize
> > that was probably part of the intent of the chang
On Tue, Jun 25, 2024, at 3:24 AM, Amit Kapila wrote:
> On Tue, Jun 25, 2024 at 3:38 AM Noah Misch wrote:
> >
> > On Mon, Jun 24, 2024 at 05:20:21PM +0530, Amit Kapila wrote:
> > > On Sun, Jun 23, 2024 at 11:52 AM Noah Misch wrote:
> > > >
> > > > > +static void
> > > > > +create_publication(PGcon
=?UTF-8?Q?Andr=C3=A9_Verwijs?= writes:
> retrieve information from database:
> column "daticulocale" does not exist
> LINE 5: datconnlimit, daticulocale, daticurules, datcollversion,
> ^
> HINT: Perhaps you meant to reference the column "db.datlocale".
I'm guessing you need to complain to the pga
On Tue, Jun 25, 2024 at 5:36 PM André Verwijs wrote:
> psql (PostgreSQL) 17beta2 (Debian 17~beta2-1.pgdg+~20240625.1534.g23c5a0e)
> column "daticulocale" does not exist
> LINE 5: datconnlimit, daticulocale, daticurules, datcollversion,
> ^
> HINT: Perhaps you meant to reference the column "db.d
On Tue, Jun 25, 2024 at 5:30 PM Michael Paquier wrote:
> On Tue, Jun 25, 2024 at 11:55:03AM -0500, Nathan Bossart wrote:
> > On Tue, Jun 25, 2024 at 08:10:24AM +0200, Joel Jacobson wrote:
> > > On Tue, Jun 25, 2024, at 07:11, Michael Paquier wrote:
> > >> v1 is fine without the "privileges list"
On Mon, Jun 24, 2024 at 10:11 PM Michael Paquier
wrote:
> On Tue, Jun 25, 2024 at 12:20:20AM +0200, Joel Jacobson wrote:
> > Thanks, much better. New version attached.
>
> + The PostgreSQL documentation, and code,
> refers
> + to the specifications within the ACL as "privileges". This
On Tue, Jun 25, 2024 at 4:11 PM Tom Lane wrote:
> James Coleman writes:
> > On Tue, Jun 25, 2024 at 4:59 PM Tom Lane wrote:
> >> Uh ... what? I recall something about that with respect to certain
> >> features such as nextval(), but you're making it sound like there
> >> is something generic g
On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila wrote:
>
> On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada
> wrote:
> >
> > On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila wrote:
> > >
> >
> > > So, my
> > > preference is in order as follows: synchronized_standby_slots,
> > > wait_for_standby_slots, l
On Mon, Jun 24, 2024, at 3:47 AM, Hayato Kuroda (Fujitsu) wrote:
> > pg_createsubscriber fails on a dbname containing a space. Use
> > appendConnStrVal() here and for other params in get_sub_conninfo(). See the
> > CVE-2016-5424 commits for more background. For one way to test this
> > scenario,
On Tue, Jun 25, 2024 at 05:52:47PM -0700, David G. Johnston wrote:
> On Tue, Jun 25, 2024 at 5:36 PM André Verwijs wrote:
>
> psql (PostgreSQL) 17beta2 (Debian 17~beta2-1.pgdg+~20240625.1534.g23c5a0e)
>
>
> column "daticulocale" does not exist
> LINE 5: datconnlimit, daticulocale, d
On Tue, Jun 25, 2024 at 09:10:06AM -0700, Noah Misch wrote:
> I think your last sentence is what Heikki is saying should happen, and I
> agree. Yes, it matters. As written, InjectionPointRun() could cache an
> entry_by_name->function belonging to a different injection point.
That's true, we coul
Hi Shlok. Here are my review comments for patch v10-0003
==
General.
1.
The patch has lots of conditions like:
if (att->attgenerated && (att->attgenerated !=
ATTRIBUTE_GENERATED_STORED || !include_generated_columns))
continue;
IMO these are hard to read. Although more verbose, please consid
FYI - I created a CF entry [1] for this because AFAIK the patch is
just waiting for a committer to check if it is OK to be pushed, but
maybe nobody has noticed it.
==
[1] https://commitfest.postgresql.org/48/5075/
Kind Regards,
Peter Smith.
Fujitsu Australia
On Wed, Jun 26, 2024 at 12:00 PM Tom Lane wrote:
> Thomas Munro writes:
> > I know how to find out which darwin version is running: uname -r | sed
> > 's/\..*//'. What I don't know is how to find the darwin version for a
> > macports installation.
>
> "port platform"?
Thanks, that's exactly wha
On Wed, Jun 26, 2024 at 7:21 AM Euler Taveira wrote:
>
> On Mon, Jun 24, 2024, at 3:47 AM, Hayato Kuroda (Fujitsu) wrote:
>
> > pg_createsubscriber fails on a dbname containing a space. Use
> > appendConnStrVal() here and for other params in get_sub_conninfo(). See the
> > CVE-2016-5424 commits
Thomas Munro writes:
> But I thought of an easier way: instead of trying to do my own cache
> invalidation with shell script and duct tape, I can include the
> current OS major version in the cache key used to carry the
> macports directory between CI runs. Hopefully Cirrus's cache machinery
> is
Bruce Momjian writes:
> On Tue, Jun 25, 2024 at 05:52:47PM -0700, David G. Johnston wrote:
>> We seem to be missing a release note item for the catalog breakage done in
>> f696c0c
>> https://git.postgresql.org/gitweb/?p=postgresql.git;a=commit;h=f696c0cd5f
> It seemed too internal to mention in t
On Wednesday, June 26, 2024 9:40 AM Masahiko Sawada
wrote:
>
> On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila
> wrote:
> >
> > On Tue, Jun 25, 2024 at 12:30 PM Masahiko Sawada
> wrote:
> > >
> > > On Tue, Jun 25, 2024 at 1:54 PM Amit Kapila
> wrote:
> > > >
> > >
> > > > So, my
> > > > preferenc
Hi,
On Wed, Jun 26, 2024 at 04:17:45AM +, Zhijie Hou (Fujitsu) wrote:
> On Wednesday, June 26, 2024 9:40 AM Masahiko Sawada
> wrote:
> >
> > On Tue, Jun 25, 2024 at 5:32 PM Amit Kapila
> > wrote:
> > >
> > > I feel synchronized better indicates the purpose because we ensure
> > > such slot
On Wed, 26 Jun 2024 at 13:31, David G. Johnston
wrote:
> I'd suggest adding to:
>
> DEFAULT default_expr
> The DEFAULT clause assigns a default data value for the column whose column
> definition it appears within. The value is any variable-free expression (in
> particular, cross-references to o
David Rowley writes:
> If people don't properly understand these special timestamp input
> values, then maybe the documentation in [1] needs to be improved. At
> the moment the details are within parentheses. Namely "(In particular,
> now and related strings are converted to a specific time value
On Tue, Jun 25, 2024 at 9:50 PM David Rowley wrote:
> On Wed, 26 Jun 2024 at 13:31, David G. Johnston
> wrote:
> > I'd suggest adding to:
> >
> > DEFAULT default_expr
> > The DEFAULT clause assigns a default data value for the column whose
> column definition it appears within. The value is any
Andy Fan writes:
>
>> - Longrunning transaction prevents increasing relfrozenxid, we run autovacuum
>> over and over on the same relation, using up the whole cost budget. This is
>> particularly bad because often we'll not autovacuum anything else, building
>> up a larger and larger backlog
On Tue, Jun 25, 2024 at 05:01:55PM +0200, Anthonin Bonnefoy wrote:
> During backend initialisation, pgStat DSA is attached using
> dsa_attach_in_place with a NULL segment. The NULL segment means that
> there's no callback to release the DSA when the process exits.
> pgstat_detach_shmem only calls d
On Tue, Jun 25, 2024 at 12:40 AM Jeff Davis wrote:
>
> On Wed, 2024-06-19 at 08:53 +0530, Ashutosh Sharma wrote:
> > For standalone functions, users can easily adjust the search_path
> > settings as needed. However, managing this becomes challenging for
> > functions created via extensions. Extens
On Tue, Jun 25, 2024 at 10:12 PM Tom Lane wrote:
> David Rowley writes:
> > If people don't properly understand these special timestamp input
> > values, then maybe the documentation in [1] needs to be improved. At
> > the moment the details are within parentheses. Namely "(In particular,
> > n
Dear Amit, Euler,
Thanks for giving comment! 0001 was modified per suggestions.
> Yeah, it is a good idea to add a new option for two_phase but that
> should be done in the next version. For now, I suggest updating the
> docs and probably raising a warning (if max_prepared_transactions !=
> 0) as
> On 26 Jun 2024, at 05:46, Peter Smith wrote:
>
> FYI - I created a CF entry [1] for this because AFAIK the patch is
> just waiting for a committer to check if it is OK to be pushed, but
> maybe nobody has noticed it.
Thanks, always good to have a CF entry to track it with. It’s not forgotten
On Wed, Jun 26, 2024 at 10:19 AM Bertrand Drouvot
wrote:
>
>
> 2
>
> Should we rename StandbySlotNamesConfigData too?
>
How about SyncStandbySlotsConfigData?
> 3
>
> Should we rename SlotExistsInStandbySlotNames too?
>
Similarly SlotExistsInSyncStandbySlots?
> 4
>
> Should we re
On Wed, Jun 26, 2024 at 11:39:45AM +0530, Amit Kapila wrote:
> --- a/doc/src/sgml/release-17.sgml
> +++ b/doc/src/sgml/release-17.sgml
> @@ -1325,7 +1325,7 @@ Author: Michael Paquier
>
>
Hi,
On Wed, Jun 26, 2024 at 11:39:45AM +0530, Amit Kapila wrote:
> On Wed, Jun 26, 2024 at 10:19 AM Bertrand Drouvot
> wrote:
> >
> >
> > 2
> >
> > Should we rename StandbySlotNamesConfigData too?
> >
>
> How about SyncStandbySlotsConfigData?
>
> > 3
> >
> > Should we rename SlotExist
> On Mon, 24 Jun 2024 at 04:38, wrote:
> >
> > In my local PoC patch, I have modified the output as follows, what do you
> > think?
> >
> > =# EXPLAIN (VERBOSE, ANALYZE) SELECT * FROM test WHERE id1 = 1 AND id2 =
> 101;
> >QUERY PLAN
> > ---
On Wed, Jun 26, 2024 at 7:40 AM Michael Paquier wrote:
>
> Very good catch! It looks like you have seen that in the field, then.
> Sad face.
Yeah, this happened last week on one of our replicas (version 15.5)
last week that had 134 days uptime. We are doing a lot of parallel
queries on this clus
> +1 for the idea.
Thanks! I was interested in the test result that you shared.
Regards,
--
Masahiro Ikeda
NTT DATA CORPORATION
101 - 134 of 134 matches
Mail list logo
