On 07.03.24 08:30, Michael Paquier wrote:
On Thu, Mar 07, 2024 at 01:37:36PM +1300, Thomas Munro wrote:
+1
Looking at the patch, nice cleanup.
Committed, thanks.
Thanks for diagnosing this!
On 10/03/2024 08:23, Thomas Munro wrote:
On Sun, Mar 10, 2024 at 6:48 PM Thomas Munro wrote:
I won't be surprised if the answer is: if you're holding a reference,
you have to get a pin (referring to bulk_write.c).
Ahhh, on second thoughts, I take that back, I thin
Hi Peter,
thank you for so thoughtful review.
> On 6 Mar 2024, at 12:13, Peter Eisentraut wrote:
>
> I have various comments on this patch:
>
>
> - doc/src/sgml/func.sgml
>
> The documentation of the new functions should be broken up a bit.
> It's all one paragraph now. At least make it sev
On Fri, Mar 8, 2024 at 10:47 AM Michael Banck wrote:
>
> Hi,
>
> On Fri, Jan 12, 2024 at 10:14:38PM +, Cary Huang wrote:
> > I think it is good to warn the user about the increased allocation of
> > memory for certain parameters so that they do not abuse it by setting
> > it to a huge number w
When including tables with the new pg_dump functionality, it fails to
error out if a table is missing, but only if more than one table is
specified.
E.g., if table foo exist, but not bar:
pg_dump --table bar
pg_dump: error: no matching tables were found
with file "myfilter" containing just "tabl
Hi,
On Sun, Mar 10, 2024 at 09:58:25AM -0400, Robert Treat wrote:
> On Fri, Mar 8, 2024 at 10:47 AM Michael Banck wrote:
> > On Fri, Jan 12, 2024 at 10:14:38PM +, Cary Huang wrote:
> > > I think it is good to warn the user about the increased allocation of
> > > memory for certain parameters
> On 10 Mar 2024, at 15:22, Magnus Hagander wrote:
> Not having looked into the code, but it looks to me like some variable
> isn't properly reset, or perhaps there is a check for existence rather
> than count?
Thanks for the report, I'll have a look later today when back.
--
Daniel Gustafsson
one more issue.
+ case JSON_VALUE_OP:
+ /* Always omit quotes from scalar strings. */
+ jsexpr->omit_quotes = (func->quotes == JS_QUOTES_OMIT);
+
+ /* JSON_VALUE returns text by default. */
+ if (!OidIsValid(jsexpr->returning->typid))
+ {
+ jsexpr->returning->typid = TEXTOID;
+ jsexpr->returning->t
Hi
ne 10. 3. 2024 v 15:23 odesílatel Magnus Hagander
napsal:
> When including tables with the new pg_dump functionality, it fails to
> error out if a table is missing, but only if more than one table is
> specified.
>
> E.g., if table foo exist, but not bar:
>
> pg_dump --table bar
> pg_dump: er
On Fri, Mar 8, 2024 at 12:06 PM Corey Huinker wrote:
>
> Anyway, here's v7. Eagerly awaiting feedback.
Thanks for working on this. It looks useful to have the ability to
restore the stats after upgrade and restore. But, the exported stats
are valid only until the next ANALYZE is run on the table.
> On 10 Mar 2024, at 17:59, Andrey M. Borodin wrote:
>
> I tried to "make docs", but it gives me gazilion of errors... Is there an
> easy way to see resulting HTML?
Oops, CFbot expectedly found a problem...
Sorry for the noise, this version, I hope, will pass all the tests.
Thanks!
Best reg
On Wed, Mar 6, 2024 at 6:47 PM Melanie Plageman
wrote:
>
> Performance results:
>
> The TL;DR of my performance results is that streaming read vacuum is
> faster. However there is an issue with the interaction of the streaming
> read code and the vacuum buffer access strategy which must be address
On Sun, Mar 10, 2024 at 4:51 PM Pavel Stehule wrote:
>
> Hi
>
> ne 10. 3. 2024 v 15:23 odesílatel Magnus Hagander
> napsal:
>>
>> When including tables with the new pg_dump functionality, it fails to
>> error out if a table is missing, but only if more than one table is
>> specified.
>>
>> E.g.,
On Sun, Mar 10, 2024 at 11:57 AM Bharath Rupireddy <
bharath.rupireddyforpostg...@gmail.com> wrote:
> On Fri, Mar 8, 2024 at 12:06 PM Corey Huinker
> wrote:
> >
> > Anyway, here's v7. Eagerly awaiting feedback.
>
> Thanks for working on this. It looks useful to have the ability to
> restore the s
On 10/03/2024 11:20, Heikki Linnakangas wrote:
On 10/03/2024 08:23, Thomas Munro wrote:
On Sun, Mar 10, 2024 at 6:48 PM Thomas Munro wrote:
I won't be surprised if the answer is: if you're holding a reference,
you have to get a pin (referring to bulk_write.c).
Ahhh, on second thoughts, I tak
On Mon, Mar 11, 2024 at 9:30 AM Heikki Linnakangas wrote:
> Barring objections, I'll commit the attached.
+1
I guess the comment for smgrreleaseall() could also be updated. It
mentions only PROCSIGNAL_BARRIER_SMGRRELEASE, but I think sinval
overflow (InvalidateSystemCaches()) should also be men
On Mon, Mar 11, 2024 at 9:59 AM Thomas Munro wrote:
> On Mon, Mar 11, 2024 at 9:30 AM Heikki Linnakangas wrote:
> > Hmm, I'm not sure if we need even smgrreleaseall() here anymore. It's
> > not required for correctness AFAICS. We don't do it in single-rel
> > invalidation in RelationCacheInvalida
On Fri, 8 Mar 2024 at 23:14, Richard Guo wrote:
> I've looked at this patch a bit. I once wondered why we don't check
> pathkey->pk_eclass->ec_has_const with EC_MUST_BE_REDUNDANT to see if the
> pathkey is not needed. Then I realized that a child member would not be
> marked as constant even if
> Maybe we could go with :{+...} or the like?
> or maybe :{{ ... }}
Tab completion didn't work for :{?} and I noted that the same problem
would arise for :{+ or :{{ (and tab completion would be more important
here). So I fixed that on:
https://www.postgresql.org/message-id/flat/CAGRrpzZU48F2oV3d8
On Mon, Feb 26, 2024 at 04:29:44PM +0900, Etsuro Fujita wrote:
> Will do. (I was thinking you would get busy from now on.)
Fujita-san, have you been able to look at this thread?
--
Michael
signature.asc
Description: PGP signature
On Sat, Mar 9, 2024 at 3:53 AM Dean Rasheed wrote:
>
>
> Attached is a new patch, now with docs (no other code changes).
>
Hi,
some issues I found, while playing around with
support-returning-old-new-v2.patch
doc/src/sgml/ref/update.sgml:
[ RETURNING [ WITH ( { OLD | NEW } AS output_alias [,
On Thu, Mar 07, 2024 at 07:45:01AM +0900, Michael Paquier wrote:
> That's nice. You would be able to shave quite a bit of code. If
> there are no objections, I propose to apply the change of this thread
> to have this standard explain wrapper at the beginning of next week.
> If others have any co
Here also is a first attempt at improving the memory allocation and
memory layout.
I wonder if bulk logging should trigger larger WAL writes in the "Have
to write it ourselves" case in AdvanceXLInsertBuffer(), since writing
8kB of WAL at a time seems like an unnecessarily degraded level of
perform
On Fri, Mar 8, 2024 at 8:23 AM Sutou Kouhei wrote:
>
>
> This shows that the v17 approach doesn't affect the current
> text/csv/binary implementations. (The v17 approach just adds
> 2 new structs, Copy{From,To}Rountine, without changing the
> current text/csv/binary implementations.)
>
> Can we pu
On Sun, Mar 10, 2024 at 04:58:19PM +1300, David Steele wrote:
> No doubt there are many other recovery log messages that could be improved,
> but I'd rather not bog down the patch.
Fair argument, and these additions are useful when taken
independently. I've applied your suggestions for now.
--
Mi
On Sat, Mar 9, 2024 at 4:38 PM Magnus Hagander wrote:
> Per the docs, the sync_time, write_time and buffers_written only apply
> to checkpoints, not restartpoints. Is this correct? AFAICT from a
> quick look at the code they include both checkpoints and restartpoints
> in which case I think the do
Hi,
In
"Re: Make COPY format extendable: Extract COPY TO format implementations" on
Mon, 11 Mar 2024 08:00:00 +0800,
jian he wrote:
> Hi, here are my cents:
> Currently in v17, we have 3 extra functions within DoCopyTo
> CopyToStart, one time, start, doing some preliminary work.
> CopyToOn
On 2024/3/4 15:48, jian he wrote:
Maybe we can tolerate LOG, first output the query plan then statement.
It is more appropriate to let the extension solve its own problems.
Of course, this change is not easy to implement.
Due to the way XID is assigned, there seems to be no good solution at
On Thu, Mar 7, 2024 at 11:07 AM Alexander Korotkov wrote:
> On Thu, Mar 7, 2024 at 9:53 AM Egor Chindyaskin wrote:
> >
> > > 6 march 2024 г., at 19:17, Alexander Korotkov
> > > wrote:
> > >
> > > The revised set of remaining patches is attached.
> > >
> > > 0001 Turn tail recursion into iterati
On Sat, 2024-03-09 at 14:03 +0100, Laurenz Albe wrote:
> Here is a patch that implements this.
And here is patch v2 that fixes a bug and passes the regression tests.
Yours,
Laurenz Albe
From 6c72ea7d0aa1df569a4e53f54fcb1a11542ac0ef Mon Sep 17 00:00:00 2001
From: Laurenz Albe
Date: Mon, 11 Mar 20
On Mon, Mar 11, 2024 at 5:31 AM Melanie Plageman
wrote:
> On Wed, Mar 6, 2024 at 6:47 PM Melanie Plageman
> wrote:
> > Performance results:
> >
> > The TL;DR of my performance results is that streaming read vacuum is
> > faster. However there is an issue with the interaction of the streaming
> >
On Thu, Mar 7, 2024 at 10:35 PM Masahiko Sawada wrote:
>
> I've attached the remaining patches for CI. I've made some minor
> changes in separate patches and drafted the commit message for
> tidstore patch.
>
> While reviewing the tidstore code, I thought that it would be more
> appropriate to pla
On Sun, Mar 10, 2024 at 10:57 PM jian he wrote:
>
> one more issue.
Hi
one more documentation issue.
after applied V42, 0001 to 0003,
there are 11 appearance of `FORMAT JSON` in functions-json.html
still not a single place explained what it is for.
json_query ( context_item, path_expression [ PA
On Fri, Mar 08, 2024 at 07:46:26PM +0900, Michael Paquier wrote:
> Sounds good to me.
I've applied the patch of this thread as b36fbd9f8da1, though I did
not see a huge point in backpatching as at the end this is just a
consistency improvement.
--
Michael
signature.asc
Description: PGP signature
On 11.03.2024 03:39, Alexander Korotkov wrote:
Now that we distinguish stats for checkpoints and
restartpoints, we need to update the docs. Please, check the patch
attached.
Maybe bring the pg_stat_get_checkpointer_buffers_written() description in
consistent with these changes?
Like that:
--
On Sat, 9 Mar 2024 at 00:56, Tomas Vondra wrote:
>
>
>
> On 3/8/24 10:44, Hayato Kuroda (Fujitsu) wrote:
> > Dear Tomas, Euler,
> >
> > Thanks for starting to read the thread! Since I'm not an original author,
> > I want to reply partially.
> >
> >> I decided to take a quick look on this patch tod
On Sat, Feb 24, 2024 at 5:21 AM Tristen Raab wrote:
>
> I've reviewed your patch, it applies correctly and the documentation builds
> without any errors. As for the content of the patch itself, I think so far
> it's good but would make two modifications. I like how the patch was worded
> origin
Dear Vignesh,
Thanks for updating the patch, but cfbot still got angry [1].
Note that two containers (autoconf and meson) failed at different place,
so I think it is intentional one. It seems that there may be a bug related with
32-bit build.
We should see and fix as soon as possible.
[1]: http
On 7/3/2024 21:51, Alexander Korotkov wrote:
Hi!
On Tue, Mar 5, 2024 at 9:59 AM Andrei Lepikhov
mailto:a.lepik...@postgrespro.ru>> wrote:
> On 5/3/2024 12:30, Andrei Lepikhov wrote:
> > On 4/3/2024 09:26, jian he wrote:
> ... and the new version of the patchset is attached.
I made some rev
On Thu, 7 Mar 2024 at 22:50, David Rowley wrote:
>
> On Thu, 7 Mar 2024 at 15:24, Tender Wang wrote:
> >
> > Andrei Lepikhov 于2024年3月6日周三 11:37写道：
> >> I think, it is a bug. Should it be fixed (and back-patched) earlier?
> >
> > Agreed. Need David to review it as he knows this area best.
>
> T
David Rowley 于2024年3月11日周一 13:25写道：
> On Thu, 7 Mar 2024 at 22:50, David Rowley wrote:
> >
> > On Thu, 7 Mar 2024 at 15:24, Tender Wang wrote:
> > >
> > > Andrei Lepikhov 于2024年3月6日周三 11:37写道：
> > >> I think, it is a bug. Should it be fixed (and back-patched) earlier?
> > >
> > > Agreed. Nee
On Sat, Mar 09, 2024 at 12:01:49AM +0530, Bharath Rupireddy wrote:
> If NOTICE per attribute and incrementing num_errors per row is
> implemented, it ends up erroring out with ERROR: missing data for
> column "m" for all-column-empty-row. Shall we treat this ERROR softly
> too if on_error ignore
On Fri, Mar 8, 2024 at 8:08 PM Bharath Rupireddy
wrote:
>
> On Wed, Mar 6, 2024 at 4:28 PM Amit Kapila wrote:
> >
> > IIUC, the current conflict_reason is primarily used to determine
> > logical slots on standby that got invalidated due to recovery time
> > conflict. On the primary, it will also
On Fri, Mar 8, 2024 at 7:43 AM David Rowley wrote:
> On Fri, 8 Mar 2024 at 00:54, Ashutosh Bapat
> wrote:
> >
> > On Thu, Mar 7, 2024 at 4:39 PM David Rowley
> wrote:
> >> I think the fix should go in appendOrderByClause(). It's at that
> >> point we look for the EquivalenceMember for the rela
Here are some review comments for v8-0003
==
0. GENERAL -- why the state enum?
This patch introduced a new ReorderBufferMemTrackState with 2 states
(REORDER_BUFFER_MEM_TRACK_NO_MAXHEAP,
REORDER_BUFFER_MEM_TRACK_MAINTAIN_MAXHEAP)
It's the same as having a boolean flag OFF/ON, so I didn't see
> On 20 Jan 2024, at 07:46, vignesh C wrote:
>
> I have changed the status of the commitfest entry to "Waiting on
> Author" as there was no follow-up on Alexander's queries. Feel free to
> address them and change the commitfest entry accordingly.
Thanks Vignesh!
At the moment it’s obvious th
On Wed, Mar 06, 2024 at 07:11:19PM +, Dagfinn Ilmari Mannsåker wrote:
> I just noticed that commit d93627bc added a bunch of pg_fatal() calls
> using %s and strerror(errno), which could be written more concisely as
> %m. I'm assuming this was done because the surrounding code also uses
> this
On Fri, Mar 8, 2024 at 11:31 AM David Rowley wrote:
> On Fri, 8 Mar 2024 at 00:39, Richard Guo wrote:
> > I would like to have another look, but it might take several days.
> > Would that be too late?
>
> Please look. Several days is fine. I'd like to start looking on Monday
> or Tuesday next we
48 matches
Mail list logo
