On 09.02.23 08:23, Tom Lane wrote:
Um ... why are you using PG_TRY here at all? It seems like
you have full control of the actually likely error cases.
The only plausible error out of the StringInfo calls is OOM,
and you probably don't want to trap that at all.
My intention was to catch any un
On Thu, Feb 9, 2023 at 10:45 AM Kyotaro Horiguchi
wrote:
>
> At Wed, 8 Feb 2023 09:03:03 +, "Hayato Kuroda (Fujitsu)"
> wrote in
> > Thank you for reviewing! PSA new version.
>
> + if (statusinterval_ms > 0 && diffms > statusinterval_ms)
>
> The next expected feedback time is m
On Thu, Feb 9, 2023 at 5:50 AM David Rowley wrote:
> Attached updated patch.
Looks good at a glance, just found a spurious word:
+ "by forcing the planner into to generate plans which contains nodes "
--
John Naylor
EDB: http://www.enterprisedb.com
On 2023/02/09 11:50, Kyotaro Horiguchi wrote:
Hello.
While looking a patch, I found that pqSocketPoll passes through the
result from poll(2) to the caller and throws away revents. If I
understand it correctly, poll() *doesn't* return -1 nor errno by the
reason it has set POLLERR, POLLHUP, POL
On 06.02.23 11:11, Heikki Linnakangas wrote:
On 06/02/2023 11:54, Peter Eisentraut wrote:
Instead of defining the same set of macros several times, define it once
in an appropriate header file. In passing, convert to inline functions.
Looks good to me. Did you consider moving PG_GETARG_ITEMPO
Hi,
On Wed, Feb 8, 2023 at 6:47 PM Hayato Kuroda (Fujitsu)
wrote:
>
> >
> > Dear Horiguchi-san,
> >
> > Thank you for checking the patch! PSA new version.
>
> PSA rebased patch that supports updated time-delayed patch[1].
>
Thank you for the patch! Here are some comments on v5 patch:
+/*
+ * Op
On 03.02.23 11:41, Pavel Stehule wrote:
We can simply allow an access to backend process id thru psql variable.
I propose the name "BACKEND_PID". The advantages of usage are simple
accessibility by command \set, and less typing then using function
pg_backend_pid, because psql variables are supp
čt 9. 2. 2023 v 9:57 odesílatel Peter Eisentraut <
peter.eisentr...@enterprisedb.com> napsal:
> On 03.02.23 11:41, Pavel Stehule wrote:
> > We can simply allow an access to backend process id thru psql variable.
> > I propose the name "BACKEND_PID". The advantages of usage are simple
> > accessibi
On 08.02.2023 21:23, Alvaro Herrera wrote:
On 2023-Feb-08, Amit Langote wrote:
On Wed, Feb 8, 2023 at 16:19 Alvaro Herrera wrote:
I think we should also patch ExecCheckPermissions to use forboth(),
scanning the RTEs as it goes over the perminfos, and make sure that the
entries are consisten
When we try to generate qual variants with different nullingrels in
deconstruct_distribute_oj_quals, we traverse all the JoinTreeItems and
adjust qual nulling bits as we crawl up the join tree. For a
SpecialJoinInfo which commutes with current sjinfo from below left, in
the next level up it would
Tomas Vondra writes:
> On 2/8/23 15:31, Dag Lem wrote:
>> Alvaro Herrera writes:
>>
>>> On 2023-Jan-17, Dag Lem wrote:
>>>
+ * Daitch-Mokotoff Soundex
+ *
+ * Copyright (c) 2021 Finance Norway
+ * Author: Dag Lem
>>>
>>> Hmm, I don't think we accept copyright lines that are
Hi,
On Thu, Feb 9, 2023 at 14:44 Sergey Shinderuk
wrote:
> On 08.02.2023 21:23, Alvaro Herrera wrote:
> > On 2023-Feb-08, Amit Langote wrote:
> >
> >> On Wed, Feb 8, 2023 at 16:19 Alvaro Herrera
> wrote:
> >
> >>> I think we should also patch ExecCheckPermissions to use forboth(),
> >>> scannin
Hi,
On Thursday, February 9, 2023 4:56 PM Amit Kapila
wrote:
> On Thu, Feb 9, 2023 at 12:17 AM Peter Smith
> wrote:
> >
> > On Wed, Feb 8, 2023 at 8:03 PM Hayato Kuroda (Fujitsu)
> > wrote:
> > >
> > ...
> > > > ==
> > > >
> > > > src/backend/replication/logical/worker.c
> > > >
> > > > 2
On 2023-Feb-08, Justin Pryzby wrote:
> I don't think it makes sense to run postgres -C huge_pages_active,
> however, so I see no issue that that would always returns "false".
Hmm, I would initialize it to return "unknown" rather than "off" — and
make sure it turns "off" at the appropriate time.
On 1/23/23 08:50, David Rowley wrote:
On Thu, 19 Jan 2023 at 06:01, Vik Fearing wrote:
Thank you for the review. Attached is a new version rebased to d540a02a72.
I've only a bunch of nit-picks, personal preferences and random
thoughts to offer as a review:
1. I'd be inclined *not* to mentio
Hi,
> Yes, and the fact is that cmin == cmax is something that we don't normally
> produce
Not sure if this is particularly relevant to this discussion but I
can't resist noticing that the heap doesn't even store cmin and
cmax... There is only HeapTupleHeaderData.t_cid and flags. cmin/cmax
are me
Dear Osumi-san,
Thank you for reviewing! PSA new version.
> (1)
>
> + Decides the condition for exiting the walsender process.
> + 'wait_flush', which is the default, the
> walsender
> + will wait for all the sent WALs to be flushed on the subscriber
> side,
> +
Dear Sawada-san,
Thank you for reviewing!
> +/*
> + * Options for controlling the behavior of the walsender. Options can be
> + * specified in the START_STREAMING replication command. Currently only one
> + * option is allowed.
> + */
> +typedef struct
> +{
> +WalSndShutdownMode shutdown_
Hi,
```
=# commit;
=# SELECT xmin, xmax, cmin, cmax, * FROM t;
xmin | xmax | cmin | cmax | a | b
--+--+--+--+---+---
731 |0 |0 |0 | 1 | 0
732 | 732 |1 |1 | 2 | 0
732 | 732 |1 |1 | 3 | 0
```
Oops, you got me :) This of course isn't right - the x
On Thu, Feb 9, 2023 at 11:21 AM Amit Kapila wrote:
>
>
> How about renaming ProcessPendingWrites to WaitToSendPendingWrites or
> WalSndWaitToSendPendingWrites?
>
How about renaming WalSndUpdateProgress() to
WalSndUpdateProgressAndSendKeepAlive() or
WalSndUpdateProgressAndKeepAlive()?
One thing t
Hi,
On 2023-02-09 13:06:04 +0300, Aleksander Alekseev wrote:
> > Yes, and the fact is that cmin == cmax is something that we don't normally
> > produce
>
> Not sure if this is particularly relevant to this discussion but I
> can't resist noticing that the heap doesn't even store cmin and
> cmax..
On 02.02.23 21:35, Jim Jones wrote:
This small patch introduces a XML pretty print function. It basically
takes advantage of the indentation feature of xmlDocDumpFormatMemory
from libxml2 to format XML strings.
I suggest we call it "xmlformat", which is an established term for this.
Hi hackers,
Please find attached a patch proposal for $SUBJECT.
The idea has been raised in [1] by Andres: it would allow to simplify even more
the work done to
generate pg_stat_get_xact*() functions with Macros.
Indeed, with the reconciliation done in find_tabstat_entry() then all the
pg_sta
Hi,
> And yet my review did figure out that your patch would have visibility
> problems, which you did end up having, as you noticed yourself downthread :)
Yep, this particular implementation turned out to be buggy.
>> I don't buy your argument about DO UPDATE needing to be brought into
>> line
Hi Andres,
> > So to clarify, are we talking about tuple-level compression? Or
> > perhaps page-level compression?
>
> Tuple level.
> although my own patch proposed attribute-level compression, not
> tuple-level one, it is arguably closer to tuple-level approach than
> page-level one
Just wanted
I happened to notice that MINVFUNC in 0003 displays like this
"fmt": "MINVFUNC==%{type}T",
in some cases; this appears in the JSON that's emitted by the regression
tests at some point. How can we detect this kind of thing, so that
these mistakes become self-evident? I thought the intention
Hi,
On February 9, 2023 2:50:57 AM PST, Aleksander Alekseev
wrote:
>Hi Andres,
>
>> > So to clarify, are we talking about tuple-level compression? Or
>> > perhaps page-level compression?
>>
>> Tuple level.
>
>> although my own patch proposed attribute-level compression, not
>> tuple-level one,
On Thu, Feb 9, 2023 at 2:08 PM Masahiko Sawada
wrote:
> I think it's still important for lazy vacuum that an iteration over a
> TID store returns TIDs in ascending order, because otherwise a heap
> vacuum does random writes. That being said, we can have
> RT_ITERATE_NEXT() return key-value pairs i
On 07.02.23 21:14, Sergei Kornilov wrote:
It seems a little strange to me that with const_merge_threshold = 1, such a
test case gives the same result as with const_merge_threshold = 2
What is the point of making this a numeric setting? Either you want to
merge all values or you don't want to
On Thu, Feb 9, 2023 at 12:33 PM Andres Freund wrote:
>
> Hi,
Thanks for looking at this.
> On 2023-02-09 12:21:51 +0530, Bharath Rupireddy wrote:
> > @@ -1105,18 +1105,22 @@ CREATE VIEW pg_stat_archiver AS
> >
> > CREATE VIEW pg_stat_bgwriter AS
> > SELECT
> > -pg_stat_get_bgwriter
On Wed, Feb 8, 2023 at 7:24 PM Nathan Bossart wrote:
> On Thu, Feb 09, 2023 at 08:56:24AM +0900, Michael Paquier wrote:
> > On Wed, Feb 08, 2023 at 02:25:54PM -0800, Nathan Bossart wrote:
> >> These are all good points. Perhaps there could be a base archiver
> >> implementation that shell_archive
On Mon, Feb 6, 2023 at 11:40 PM Amit Kapila wrote:
> Use appropriate wait event when sending data in the apply worker.
>
> Currently, we reuse WAIT_EVENT_LOGICAL_PARALLEL_APPLY_STATE_CHANGE in the
> apply worker while sending data to the parallel apply worker via a shared
> memory queue. This is n
On 2/9/23 10:03, Hans Buschmann wrote:
> Hello Tomas,
>
>
> Thank you for looking at.
>
>
> First, I miscalculated the factor which should be about 50, not 500. Sorry.
>
> Then I want to show you the table definitions (simple, very similar,
> ommited child_tables and additional indexes, her
On 08.02.23 23:18, Tom Lane wrote:
I pushed the discussed documentation improvements, and changed the
behavior of "ninja docs" to only build the HTML docs.
I don't like this change. Now the default set of docs is different
between the make builds and the meson builds. And people will be less
Dear Horiguchi-san,
Thank you for checking! The patch will be attached to another mail.
> At Fri, 27 Jan 2023 06:57:01 +, "Hayato Kuroda (Fujitsu)"
> wrote in
> > I found cfbot failure, PSA fixed version.
>
> + Unlike , this function checks socket
> + health. This check is perfo
Dear Katsuragi-san,
Thank you for reviewing! PSA new version patches.
> 0001:
> + while (result < 0 && errno == EINTR);
> +
> + if (result < 0)
> + return -1;
>
> this `return -1` is not indented properly.
This part is no longer needed. Please see another discu
On 08.02.23 08:59, Jeff Davis wrote:
The overall benefit here is that we keep our catalogs consistently
using an independent standard format for ICU locale strings, rather
than whatever the user specifies. That makes it less likely that ICU
needs to use any fallback logic when trying to open a co
Peter Eisentraut writes:
> On 08.02.23 23:18, Tom Lane wrote:
>> I pushed the discussed documentation improvements, and changed the
>> behavior of "ninja docs" to only build the HTML docs.
> I don't like this change. Now the default set of docs is different
> between the make builds and the mes
> On Tue, Feb 07, 2023 at 11:14:52PM +0300, Sergei Kornilov wrote:
> Hello!
Thanks for reviewing.
> Unfortunately, rebase is needed again due to recent changes in
> queryjumblefuncs ( 9ba37b2cb6a174b37fc51d0649ef73e56eae27fc )
Yep, my favourite game, rebaseball. Will post a new version soon, af
> On Thu, Feb 09, 2023 at 02:30:34PM +0100, Peter Eisentraut wrote:
> On 07.02.23 21:14, Sergei Kornilov wrote:
> > It seems a little strange to me that with const_merge_threshold = 1, such a
> > test case gives the same result as with const_merge_threshold = 2
>
> What is the point of making this
Hi,
On 2/8/23 13:30, Peter Eisentraut wrote:
If you feel that your patch is ready, please add it to the commit
fest. I look forward to reviewing it.
Thanks! Commit fest entry link: https://commitfest.postgresql.org/42/4173/
Regards,
Nazir Bilal Yavuz
Microsoft
Hi,
I was looking at bug mentioned at
https://www.postgresql.org/message-id/flat/201010112055.o9BKtZf7011251%40wwwmaster.postgresql.org
Issue appears to be in gbt_inet_compress which doesn't store inet
details like ip_family and netmask details in inetKEY and
gbt_inet_consistent which does
Robert Haas writes:
> I think that we could certainly, as Michael suggests, have people
> provide their own background worker rather than having the archiver
> invoke the user-supplied code directly. As long as the functions that
> you need in order to get the necessary information can be called f
>
> FWIW I suggest you provide the data in a form that's easier to use (like
> a working SQL script). More people are likely to look and help than when
> they have to extract stuff from an e-mail, fill in missing pieces etc.
>
BTW if anyone wants to play with this, here are the SQL scripts I use
On Wed, Feb 8, 2023 at 2:59 AM Jeff Davis wrote:
> We do check that the value is accepted by ICU, but ICU seems to accept
> anything and use some fallback logic. Bogus strings will typically end
> up as the "root" locale (spelled "root" or "").
I've noticed this, and I think it's really frustrati
Richard Guo writes:
> It seems to me there is oversight here. Actually in next level up this
> othersj would null all the relids in its syn_righthand, not only the
> relids in its min_righthand.
Good point. I think this code originated before it was clear to me
that nullingrels would need to fo
On Thu, Feb 9, 2023 at 10:51 AM Tom Lane wrote:
> I'm fairly concerned about the idea of making it common for people
> to write their own main loop for the archiver. That means that, if
> we have a bug fix that requires the archiver to do X, we will not
> just be patching our own code but trying
I wrote:
> Richard Guo writes:
>> It seems to me there is oversight here. Actually in next level up this
>> othersj would null all the relids in its syn_righthand, not only the
>> relids in its min_righthand.
> Good point. I think this code originated before it was clear to me
> that nullingrel
On Wed, Feb 8, 2023 at 11:17 PM Robert Haas wrote:
> On Sun, Feb 5, 2023 at 3:57 AM Himanshu Upadhyaya
> wrote:
> > Thanks, yes it's working fine with Prepared Transaction.
> > Please find attached the v9 patch incorporating all the review comments.
>
> I don't know quite how we're still going a
On Thu, Feb 09, 2023 at 11:12:21AM -0500, Robert Haas wrote:
> On Thu, Feb 9, 2023 at 10:51 AM Tom Lane wrote:
>> If we think we need primitives to let the archiver hooks get all
>> the pending files, or whatever, by all means add those. But don't
>> cede fundamental control of the archiver. The
On Wed, Feb 08, 2023 at 09:16:19PM -0800, Andres Freund wrote:
> Pushed. Thanks!
Thanks!
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
On 2023-Feb-09, Dmitry Dolgov wrote:
> > On Thu, Feb 09, 2023 at 02:30:34PM +0100, Peter Eisentraut wrote:
> > What is the point of making this a numeric setting? Either you want
> > to merge all values or you don't want to merge any values.
>
> At least in theory the definition of "too many co
Hi,
On 2023-02-09 09:57:42 -0500, Tom Lane wrote:
> Peter Eisentraut writes:
> > On 08.02.23 23:18, Tom Lane wrote:
> >> I pushed the discussed documentation improvements, and changed the
> >> behavior of "ninja docs" to only build the HTML docs.
>
> > I don't like this change. Now the default s
On 2023-02-08 We 21:29, Shinoda, Noriyoshi (PN Japan FSIP) wrote:
Hi,
I tried the committed pgindent.
The attached small patch changes spaces in the usage message to tabs.
Options other than --commit start with a tab.
Thanks, pushed.
cheers
andrew
--
Andrew Dunstan
EDB:https://www.enter
Andres Freund writes:
> I think this misunderstanding is again due to the confusion between the 'all'
> target in doc/src/sgml and the default target, just like earlier in the thread
> / why I ended up with the prior set of targets under 'docs'.
> # Make "html" the default target, since that is
Currently, meson has a test suite named "setup". According to the
Wiki, this is needed to get something equivalent to "make check", by
running "meson test -v --suite setup --suite regress".
Some questions about this:
* Isn't it confusing that we have a suite by that name, given that we
also need
On Wed, Feb 8, 2023 at 5:12 PM Michael Paquier wrote:
> At the end, I have just done this stuff down to ~12, 11 does not seem
> worth the trouble as the next stable version to go out of support.
> I'll reduce gokiburi's script a bit, as a result, until the oldest
> version support is v12.
For the
On Thu, Feb 09, 2023 at 10:40:13AM +0100, Alvaro Herrera wrote:
> On 2023-Feb-08, Justin Pryzby wrote:
>> I don't think it makes sense to run postgres -C huge_pages_active,
>> however, so I see no issue that that would always returns "false".
>
> Hmm, I would initialize it to return "unknown" rath
Hi,
On 2023-02-09 11:12:21 -0500, Robert Haas wrote:
> On Thu, Feb 9, 2023 at 10:51 AM Tom Lane wrote:
> > I'm fairly concerned about the idea of making it common for people
> > to write their own main loop for the archiver. That means that, if
> > we have a bug fix that requires the archiver to
rebased for cfbot
--
Nathan Bossart
Amazon Web Services: https://aws.amazon.com
>From ea6339276c6863f260572dfc816f9dd27ac7b516 Mon Sep 17 00:00:00 2001
From: Nathan Bossart
Date: Fri, 27 Jan 2023 21:01:22 -0800
Subject: [PATCH v9 1/3] s/ArchiveContext/ArchiveCallbacks
---
src/backend/postmaste
> On Thu, Feb 09, 2023 at 06:26:51PM +0100, Alvaro Herrera wrote:
> On 2023-Feb-09, Dmitry Dolgov wrote:
>
> > > On Thu, Feb 09, 2023 at 02:30:34PM +0100, Peter Eisentraut wrote:
>
> > > What is the point of making this a numeric setting? Either you want
> > > to merge all values or you don't want
Hi,
On 2023-02-09 11:39:17 -0800, Nathan Bossart wrote:
> rebased for cfbot
I think this nearly ready. Michael, are you planning to commit this?
Personally I'd probably squash these into a single commit.
> diff --git a/doc/src/sgml/archive-modules.sgml
> b/doc/src/sgml/archive-modules.sgml
>
On Thu, 9 Feb 2023 at 21:20, John Naylor wrote:
> Looks good at a glance, just found a spurious word:
>
> + "by forcing the planner into to generate plans which contains nodes "
Thanks for looking. I'll fix that.
Likely the hardest part to get right here is the new name. Can anyone
think of any
Hi,
On 2023-02-09 13:48:46 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I think this misunderstanding is again due to the confusion between the
> > 'all'
> > target in doc/src/sgml and the default target, just like earlier in the
> > thread
> > / why I ended up with the prior set of targe
Hi,
On 2023-02-09 11:01:31 -0800, Peter Geoghegan wrote:
> Currently, meson has a test suite named "setup". According to the
> Wiki, this is needed to get something equivalent to "make check", by
> running "meson test -v --suite setup --suite regress".
Yep.
> Some questions about this:
>
> * Is
I just found myself carefully counting the zeros in a call to pg_usleep().
Besides getting my eyes checked, perhaps there should be a wrapper called
pg_ssleep() than can be used for multisecond sleeps. Or maybe the
USECS_PER_SEC macro should be used more widely. I attached a patch for the
former
Hi,
On 2023-02-09 13:30:30 -0500, Tom Lane wrote:
> 0003 lacks meson support (anyone want to help with that?)
I'll give it a go, unless somebody else wants to.
Do we expect pg_bsd_indent to build / work on windows, right now? If it
doesn't, do we want to make that a hard requirement?
I'll have
On Thu, 2023-02-09 at 15:44 +0100, Peter Eisentraut wrote:
> One use case is that if a user specifies a locale, say, of 'de-AT',
> this
> might canonicalize to 'de' today,
Canonicalization should not lose useful information, it should just
rearrange it, so I don't see a risk here based on what I
Hi,
On 2023-02-09 12:59:29 -0800, Nathan Bossart wrote:
> I just found myself carefully counting the zeros in a call to pg_usleep().
> Besides getting my eyes checked, perhaps there should be a wrapper called
> pg_ssleep() than can be used for multisecond sleeps. Or maybe the
> USECS_PER_SEC macr
Andres Freund writes:
> On 2023-02-09 13:30:30 -0500, Tom Lane wrote:
>> 0003 lacks meson support (anyone want to help with that?)
> I'll give it a go, unless somebody else wants to.
Thanks.
> Do we expect pg_bsd_indent to build / work on windows, right now?
It would be desirable, for sure. I
On 2/6/23 08:22, Robert Haas wrote:
> I don't think that's quite the right concept. It seems to me that the
> client is responsible for informing the server of what the situation
> is, and the server is responsible for deciding whether to allow the
> connection. In your scenario, the client is not
On Thu, 2023-02-09 at 10:53 -0500, Robert Haas wrote:
> Unfortunately, I have no idea whether your specific ideas about how
> to
> make that happen are any good or not. But I hope they are, because
> the
> current situation is pessimal.
It feels like BCP 47 is the right catalog representation. We
Andres Freund writes:
> Did that in the attached.
Thanks.
> I didn't convert the test though, due to the duplicating it'd create. Perhaps
> we should just move it to a shell script? Or maybe it just doesn't matter
> enough to bother with?
We could move it to a shell script perhaps, but that see
Hi,
On 2023-02-09 13:55:32 -0800, Andres Freund wrote:
> ../src/tools/pg_bsd_indent/args.c(179): error C2065: 'PATH_MAX': undeclared
> identifier
> ../src/tools/pg_bsd_indent/args.c(179): error C2057: expected constant
> expression
> ../src/tools/pg_bsd_indent/args.c(179): error C2466: cannot al
Andres Freund writes:
> The trivial fix of using MAXPGPATH made it build, without warnings. That
> doesn't say anything about actually working. So I guess porting the test would
> make sense.
> Opinions on whether it would make sense as a shell script?
Hmmm .. a shell script would be fine by me,
> The comment adjustment suggested by Peter-san above
> was also included in this v33.
> Please have a look at the attached patch.
Patch v33 LGTM.
--
Kind Regards,
Peter Smith.
Fujitsu Australia
On Thu, Feb 09, 2023 at 12:18:55PM -0800, Andres Freund wrote:
> On 2023-02-09 11:39:17 -0800, Nathan Bossart wrote:
> Personally I'd probably squash these into a single commit.
done
> I'd probably mention that this should typically be of server lifetime / a
> 'static const' struct. Tableam docum
On Wed, Feb 08, 2023 at 03:47:51PM +0900, Michael Paquier wrote:
> This one was intentional to let extensions play with jumbling of such
> nodes, but perhaps you are right that it makes little sense at this
> stage. If there is an ask for it later, though.. Using
> shared_preload_libraries = pg_s
On Thu, Feb 09, 2023 at 01:30:27PM -0800, Andres Freund wrote:
> On 2023-02-09 12:59:29 -0800, Nathan Bossart wrote:
>> I just found myself carefully counting the zeros in a call to pg_usleep().
>> Besides getting my eyes checked, perhaps there should be a wrapper called
>> pg_ssleep() than can be
On Fri, Feb 10, 2023 at 08:15:21AM +1300, Thomas Munro wrote:
> For the record, according to [1] it's not necessary to use
> --reset-author when back-patching. (Maybe a little confusingly,
> because it's not quite clear whether our policies consider the author
> field to be meaningful or not.)
>
Hi,
On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
> Andres Freund writes:
> > The trivial fix of using MAXPGPATH made it build, without warnings. That
> > doesn't say anything about actually working. So I guess porting the test
> > would
> > make sense.
>
> > Opinions on whether it would make s
Michael Paquier writes:
> Tom, did you get a chance to look at what is proposed here and expand
> the use of query_jumble_ignore in the definitions of the nodes rather
> than have an enforced per-file policy in gen_node_support.pl?
Sorry, didn't look at it before.
I'm okay with the pathnodes.h c
Andres Freund writes:
> On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
>> Hmmm .. a shell script would be fine by me, but it won't help in
>> testing a Windows build. Maybe we need to make it a Perl script?
> At least for casual testing a shell script actually mostly works, due to git
> it's easy
On Thu, Feb 9, 2023 at 12:56 PM Andres Freund wrote:
> > * Isn't it confusing that we have a suite by that name, given that we
> > also need to use the unrelated --setup flag for some nearby testing
> > recipes?
>
> Hm. I don't find it particularly confusing, but I don't think I'm a good judge
> o
On 2/9/23 23:09, Jeff Davis wrote:
I do like the ICU format locale IDs from a readability standpoint.
"en_US@colstrength=primary" is more meaningful to me than "en-US-u-ks-
level1" (the equivalent language tag). And the format is specified[1],
even though it's not an independent standard. But I t
>> Oops. Thank you for pointing it out. BTW, just out of curiosity, do
>> you have etags on you Mac?
>
> Yes.
>
> $ etags --version
> etags (GNU Emacs 28.2)
> Copyright (C) 2022 Free Software Foundation, Inc.
> This program is distributed under the terms in ETAGS.README
Ok. Probably that was ins
Hi,
On 2023-02-09 18:19:06 -0500, Tom Lane wrote:
> Andres Freund writes:
> > On 2023-02-09 17:19:22 -0500, Tom Lane wrote:
> >> Hmmm .. a shell script would be fine by me, but it won't help in
> >> testing a Windows build. Maybe we need to make it a Perl script?
>
> > At least for casual testi
Andres Freund writes:
> On 2023-02-09 18:19:06 -0500, Tom Lane wrote:
>> I thought about registering it, but that won't teach us anything unless
>> we make it built-by-default, which was not my intention. I guess we
>> could temporarily include it in the build.
> The meson patch I sent did build
Hi,
On 2023-02-09 15:34:34 -0800, Peter Geoghegan wrote:
> Why not change the suite name to tmp_install? That immediately reminds
> me of what's really going on here, since I'm used to seeing that
> directory name. And it clashes with "--suite setup" in a way that
> seems useful.
The individual t
On 2023-02-09 19:20:37 -0500, Tom Lane wrote:
> Andres Freund writes:
> > I'm fine either way. It's barely noticeable compared to the rest of
> > postgres.
>
> Yeah, build-by-default isn't really a big deal. Install-by-default
> is more of a problem...
Perhaps we should install it, just not in
Andres Freund writes:
> Perhaps we should install it, just not in bin/, but alongside pgxs/, similar
> to pg_regress et al?
For my own purposes, I really don't want it anywhere in the --prefix
tree. That's not necessarily present when I'm using the program.
(Hmm, clarify: it wouldn't matter if
Hi,
On 2023-02-09 19:00:00 +0530, Bharath Rupireddy wrote:
> On Thu, Feb 9, 2023 at 12:33 PM Andres Freund wrote:
> > On 2023-02-09 12:21:51 +0530, Bharath Rupireddy wrote:
> > > @@ -1105,18 +1105,22 @@ CREATE VIEW pg_stat_archiver AS
> > >
> > > CREATE VIEW pg_stat_bgwriter AS
> > > SELECT
At Thu, 9 Feb 2023 13:26:19 +0530, Amit Kapila wrote
in
amit.kapila16> On Thu, Feb 9, 2023 at 12:17 AM Peter Smith
wrote:
> > I understand in theory, your code is more efficient, but in practice,
> > I think the overhead of a single variable assignment every loop
> > iteration (which is doing
At Thu, 9 Feb 2023 13:48:52 +0530, Amit Kapila wrote
in
> On Thu, Feb 9, 2023 at 10:45 AM Kyotaro Horiguchi
> wrote:
> >
> > At Wed, 8 Feb 2023 09:03:03 +, "Hayato Kuroda (Fujitsu)"
> > wrote in
> > > Thank you for reviewing! PSA new version.
> >
> > + if (statusinterval_ms
On Thu, Feb 9, 2023 at 4:33 PM Andres Freund wrote:
> The individual test is actually named tmp_install. I thought it might be
> useful to add further things to the setup "stage", hence the more general
> name.
I did notice that, but only after sitting with my initial confusion for a while.
> I
Mmm. A part of the previous mail have gone anywhere for a uncertain
reason and placed by a mysterious blank lines...
At Fri, 10 Feb 2023 09:57:22 +0900 (JST), Kyotaro Horiguchi
wrote in
> At Thu, 9 Feb 2023 13:48:52 +0530, Amit Kapila
> wrote in
> > On Thu, Feb 9, 2023 at 10:45 AM Kyotaro Ho
On Thu, Feb 9, 2023 at 7:17 PM Jim Jones wrote:
>
> On 09.02.23 08:23, Tom Lane wrote:
> > Um ... why are you using PG_TRY here at all? It seems like
> > you have full control of the actually likely error cases.
> > The only plausible error out of the StringInfo calls is OOM,
> > and you probably
Hi,
On 2023-02-09 17:00:48 -0800, Peter Geoghegan wrote:
> On Thu, Feb 9, 2023 at 4:33 PM Andres Freund wrote:
> > I e.g. have a not-quite-done patch that creates a "template initdb", which
> > pg_regress and tap tests automatically use (except if non-default options
> > are
> > required), which
On Fri, 2023-02-10 at 01:04 +0100, Andreas Karlsson wrote:
> I have the same feeling one is readable and the other unreadable but
> the
> unreadable one is standardized. Hard call.
>
> And in general I agree, if we are going to make ICU default it needs
> to
> be more user friendly than it is no
On Wed, Feb 8, 2023 at 7:18 PM Andres Freund wrote:
> > This is a good thing for performance, of course, but it also makes VACUUM
> > VERBOSE show information that makes sense to users, since things actually
> > happen in a way that makes a lot more sense. I'm quite happy about the fact
> > that t
1 - 100 of 126 matches
Mail list logo
