RE: Support logical replication of DDLs

2022-06-23 Thread houzj.f...@fujitsu.com
On Thursday, June 23, 2022 6:22 AM Zheng Li wrote: Hi, > > > Here are some points in my mind about the two approaches discussed here. > > > > 1) search_patch vs schema qualify > > > > Again, I still think it will bring more flexibility and security by > > schema qualify the objects in DDL comma

Re: gcc -ftabstop option

2022-06-23 Thread Peter Eisentraut
On 22.06.22 21:48, Daniel Gustafsson wrote: On 21 Jun 2022, at 12:49, Peter Eisentraut wrote: Second, it enables the compiler's detection of confusingly indented code to work more correctly. Wouldn't we also need to add -Wmisleading-indentation for this to trigger any warnings? That is

Fix typo in pg_publication.c

2022-06-23 Thread Peter Smith
PSA trivial patch fixing a harmless #define typo. -- Kind Regards, Peter Smith. Fujitsu Australia v1-0001-Fix-typo-in-pg_publication.c.patch Description: Binary data

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-06-23 Thread Michael Paquier
On Tue, Jun 21, 2022 at 05:41:07PM -0400, Andrew Dunstan wrote: > On 2022-06-21 Tu 17:25, Andres Freund wrote: >> On 2022-06-21 17:11:33 -0400, Andrew Dunstan wrote: >>> I and a couple of colleagues have looked it over. As far as it goes the >>> json fix looks kosher to me. I'll play with it some m

Re: fix crash with Python 3.11

2022-06-23 Thread Markus Wanner
On 6/21/22 18:33, Tom Lane wrote: My inclination at this point is to not back-patch the second change 12d768e70 ("Don't use static storage for SaveTransactionCharacteristics"). It's not clear that the benefit would be worth even a small risk of somebody being unhappy about the API break. Actua

Re: Fix typo in pg_publication.c

2022-06-23 Thread Michael Paquier
On Thu, Jun 23, 2022 at 05:35:37PM +1000, Peter Smith wrote: > PSA trivial patch fixing a harmless #define typo. Thanks, done. -- Michael signature.asc Description: PGP signature

Re: pltcl crash on recent macOS

2022-06-23 Thread Peter Eisentraut
On 20.06.22 12:36, Peter Eisentraut wrote: On 14.06.22 05:05, Tom Lane wrote: I'd be okay with just dropping the -lc from pl/tcl/Makefile and seeing what the buildfarm says.  The fact that we needed it in 1998 doesn't mean that we still need it on supported versions of Tcl; nor was it ever any

Re: Make COPY extendable in order to support Parquet and other formats

2022-06-23 Thread Aleksander Alekseev
Andres, Tom, > > I suspect that we'd first need a patch to refactor the existing copy code a > > good bit to clean things up. After that it hopefully will be possible to > > plug > > in a new format without being too intrusive. > > I think that step 1 ought to be to convert the existing formats i

Re: Perform streaming logical transactions by background workers and parallel apply

2022-06-23 Thread Amit Kapila
On Thu, Jun 23, 2022 at 12:51 PM wangw.f...@fujitsu.com wrote: > > On Mon, Jun 20, 2022 at 11:00 AM Amit Kapila wrote: > > I have improved the comments in this and other related sections of the > > patch. See attached. > Thanks for your comments and patch! > Improved the comments as you suggested

RE: Use fadvise in wal replay

2022-06-23 Thread Jakub Wartak
>> > On 21 Jun 2022, at 16:59, Jakub Wartak wrote: >> Oh, wow, your benchmarks show really impressive improvement. >> >> > I think that 1 additional syscall is not going to be cheap just for >> > non-standard OS configurations >> Also we can reduce number of syscalls by something like >> >> #if

Re: Use fadvise in wal replay

2022-06-23 Thread Andrey Borodin
> 23 июня 2022 г., в 13:50, Jakub Wartak написал(а): > > Thoughts? The patch leaves 1st 128KB chunk unprefetched. Does it worth to add and extra branch for 120KB after 1st block when readOff==0? Or maybe do + posix_fadvise(readFile, readOff + XLOG_BLCKSZ, RACHUNK, POSIX_FADV_WI

RE: Use fadvise in wal replay

2022-06-23 Thread Jakub Wartak
Hey Andrey, > > 23 июня 2022 г., в 13:50, Jakub Wartak > написал(а): > > > > Thoughts? > The patch leaves 1st 128KB chunk unprefetched. Does it worth to add and extra > branch for 120KB after 1st block when readOff==0? > Or maybe do > + posix_fadvise(readFile, readOff + XLOG_BLCKSZ, R

Re: [PATCH] audo-detect and use -moutline-atomics compilation flag for aarch64

2022-06-23 Thread Alexander Korotkov
Hi! On Mon, Sep 7, 2020 at 1:12 AM Zidenberg, Tsahi wrote: > First, I apologize for taking so long to answer. This e-mail regretfully got > lost in my inbox. > > On 24/07/2020, 4:17, "Andres Freund" wrote: > > > What does "not significantly affected" exactly mean? Could you post the >

Re: Support logical replication of DDLs

2022-06-23 Thread Amit Kapila
On Wed, Jun 22, 2022 at 11:09 AM Masahiko Sawada wrote: > > I've attached a WIP patch for adding regression tests for DDL deparse. > The patch can be applied on > v9-0001-Functions-to-deparse-DDL-commands.patch Hou recently > submitted[1]. The basic idea is to define the event trigger to deparse >

Re: Handle infinite recursion in logical replication setup

2022-06-23 Thread vignesh C
On Thu, Jun 23, 2022 at 7:05 AM shiy.f...@fujitsu.com wrote: > > On Mon, Jun 20, 2022 7:55 PM vignesh C wrote: > > > > Thanks for the comment, the v22 patch attached has the changes for the > > same. > > Thanks for updating the patch, here are some comments on 0003 patch. > > 1. 032_origin.pl > +

Re: Custom tuplesorts for extensions

2022-06-23 Thread Pavel Borisov
I've bumped into this case in RUM extension. The need to build it with tuplesort changes in different PG versions led me to reluctantly including different tuplesort.c versions into the extension code. So I totally support the intention of this patch and I'm planning to invest some time to review i

Re: some aspects of our qsort might not be ideal

2022-06-23 Thread John Naylor
On Fri, Jun 3, 2022 at 10:44 AM Peter Geoghegan wrote: > What about dual-pivot quicksort, which is used in Java 7+? That is the > defacto successor to Bentley & McIlroy. In fact, Jon Bentley himself > collaborated with its author, and provided benchmarking input. The > underlying philosophy is es

Re: Custom tuplesorts for extensions

2022-06-23 Thread Pavel Borisov
> > Some PostgreSQL extensions need to sort their pieces of data. Then it > worth to re-use our tuplesort. But despite our tuplesort having > extensibility, it's hidden inside tuplesort.c. There are at least a > couple of examples of how extensions deal with that. > > 1. RUM table access method: ht

Fix instability in subscription regression test

2022-06-23 Thread houzj.f...@fujitsu.com
Hi, I noticed BF member wrasse failed in 028_row_filter.pl. # Failed test 'check publish_via_partition_root behavior' # at t/028_row_filter.pl line 669. # got: '' # expected: '1|100 # ... Log: 2022-06-23 11:27:42.387 CEST [20589:3] 028_row_filter.pl LOG: statement:

Re: Pluggable toaster

2022-06-23 Thread Nikita Malakhov
Hi hackers, We're currently working on rebase along other TOAST improvements, hope to do it in time for July CF. Thank you for your patience. -- Best regards, Nikita Malakhov On Fri, Jun 17, 2022 at 5:33 PM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi hackers, > > > For a pluggabl

Re: O(n) tasks cause lengthy startups and checkpoints

2022-06-23 Thread Simon Riggs
On Fri, 18 Feb 2022 at 20:51, Nathan Bossart wrote: > > > On Thu, Feb 17, 2022 at 03:12:47PM -0800, Andres Freund wrote: > >>> > The improvements around deleting temporary files and serialized > >>> > snapshots > >>> > afaict don't require a dedicated process - they're only relevant during > >>>

Re: Replica Identity check of partition table on subscriber

2022-06-23 Thread Amit Kapila
On Wed, Jun 22, 2022 at 5:05 PM houzj.f...@fujitsu.com wrote: > > On Wednesday, June 22, 2022 7:06 PM Amit Kapila > wrote: > > > > On Wed, Jun 22, 2022 at 10:09 AM Amit Langote > > wrote: > > > > > > On Wed, Jun 22, 2022 at 12:02 PM houzj.f...@fujitsu.com > > > wrote: > > > > Since the patch h

Re: [PATCH] Completed unaccent dictionary with many missing characters

2022-06-23 Thread Przemysław Sztoch
Michael Paquier wrote on 23.06.2022 06:39: That'd leave just DEGREE CELSIUS and DEGREE FAHRENHEIT. Not sure how to kill those last two special cases -- they should be directly replaced by their decomposition. [1] https://unicode-org.atlassian.net/browse/CLDR-11383 I patch v3 support for cirili

TOAST - moving Compression into Toast for oversized Tuples

2022-06-23 Thread Nikita Malakhov
Hi hackers, Along with major TOAST improvement with Pluggable TOAST we see the really important smaller one - moving compression functionality when dealing with oversized Tuples into Toast, because Toast is meant to deal with how oversized Tuple is stored and it is logical to make it responsible fo

Re: doc: Clarify Savepoint Behavior

2022-06-23 Thread Simon Riggs
On Thu, 9 Jun 2022 at 16:41, David G. Johnston wrote: > > On Thu, Jun 9, 2022 at 8:36 AM David G. Johnston > wrote: >> >> Hi, >> >> Reposting this on its own thread. >> >> https://www.postgresql.org/message-id/flat/CAKFQuwby1aMsJDMeibaBaohgoaZhivAo4WcqHC1%3D9-GDZ3TSng%40mail.gmail.com >> >> Pres

Query about free Volunteer Development for a PostgreSQL extension development.

2022-06-23 Thread sminervini.prism
I have been trying to find active interest for volunteer development of a GPL license style PostgreSQL extension (or default PostgreSQL additions), complete and available, on Sourceforge, PGXN and the public internet, that will support the following: High Precision Arithmetic and Elementary Fun

Re: WIP Patch: Add a function that returns binary JSONB as a bytea

2022-06-23 Thread Jelte Fennema
(reviving an old thread) On Thu, 23 Jun 2022 at 13:29, Merlin Moncure wrote: > I'll still stand other point I made though; I'd > really want to see some benchmarks demonstrating benefit over > competing approaches that work over the current formats. That should > frame the argument as to whether

Re: WIP Patch: Add a function that returns binary JSONB as a bytea

2022-06-23 Thread Jelte Fennema
(attached is the flamegraph of the profile, in case others are interested) On Thu, 23 Jun 2022 at 13:33, Jelte Fennema wrote: > > (reviving an old thread) > > On Thu, 23 Jun 2022 at 13:29, Merlin Moncure wrote: > > I'll still stand other point I made though; I'd > > really want to see some bench

Re: Support logical replication of DDLs

2022-06-23 Thread Alvaro Herrera
On 2022-Jun-15, houzj.f...@fujitsu.com wrote: > On Wednesday, June 15, 2022 8:14 AM Zheng Li wrote: > > How does the deparser deparses CREATE FUNCTION STATEMENT? Will it > > schema qualify > > objects inside the function definition? > > The current deparser doesn't schema qualify objects inside

Re: Custom tuplesorts for extensions

2022-06-23 Thread Alexander Korotkov
Hi, Pavel! Thank you for your feedback. On Thu, Jun 23, 2022 at 2:26 PM Pavel Borisov wrote: >> Some PostgreSQL extensions need to sort their pieces of data. Then it >> worth to re-use our tuplesort. But despite our tuplesort having >> extensibility, it's hidden inside tuplesort.c. There are at

Re: Custom tuplesorts for extensions

2022-06-23 Thread Alexander Korotkov
Hi, Maxim! On Thu, Jun 23, 2022 at 3:12 PM Maxim Orlov wrote: > I've reviewed the patchset and noticed some minor issues: > - extra semicolon in macro (lead to warnings) > - comparison of var isWorker should be done in different way > > Here is an upgraded version of the patchset. Thank you for

Re: fix crash with Python 3.11

2022-06-23 Thread Tom Lane
Markus Wanner writes: > Actually, the backport of 2e517818f ("Fix SPI's handling of errors") > already broke the API for code using SPICleanup, as that function had > been removed. Granted, it's not documented, but still exported. Under what circumstances would it be OK for outside code to call

Re: Pluggable toaster

2022-06-23 Thread Aleksander Alekseev
Hi Nikita, > We're currently working on rebase along other TOAST improvements, hope to do > it in time for July CF. > Thank you for your patience. Just to clarify, does it include the dependent "CREATE TABLE ( .. STORAGE .. )" patch [1]? I was considering changing the patch according to the feed

Re: O(n) tasks cause lengthy startups and checkpoints

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 7:58 AM Simon Riggs wrote: > Having a central cleanup process makes a lot of sense. There is a long > list of potential tasks for such a process. My understanding is that > autovacuum already has an interface for handling additional workload > types, which is how BRIN index

Re: some aspects of our qsort might not be ideal

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 6:13 AM John Naylor wrote: > Here is a *rough* first pass at dual-pivot quicksort. I haven't > changed the regression tests to adjust for qsort being an unstable > sort, ... Hmm. I thought we had some reasons for preferring a stable sort algorithm. -- Robert Haas EDB: ht

Re: Pluggable toaster

2022-06-23 Thread Nikita Malakhov
Hi, Alexander, thank you for your feedback and willingness to help. You can send a suggested fixup in this thread, I'll check the issue you've mentioned. Best regards, Nikita Malakhov On Thu, Jun 23, 2022 at 4:38 PM Aleksander Alekseev < aleksan...@timescale.com> wrote: > Hi Nikita, > > > We're

Re: Skipping logical replication transactions on subscriber side

2022-06-23 Thread Robert Haas
On Wed, Jun 22, 2022 at 10:48 PM Noah Misch wrote: > Here's a more-verbose description of (2), with additions about what it does > and doesn't achieve: > > 2. On systems where double alignment differs from int64 alignment, require >NAMEDATALEN%8==0. Modify the test from commits 79b716c and c1

Re: WIP Patch: Add a function that returns binary JSONB as a bytea

2022-06-23 Thread Andres Freund
Hi, On 2022-06-23 13:33:24 +0200, Jelte Fennema wrote: > (reviving an old thread) > > On Thu, 23 Jun 2022 at 13:29, Merlin Moncure wrote: > > I'll still stand other point I made though; I'd > > really want to see some benchmarks demonstrating benefit over > > competing approaches that work over

Re: Use fadvise in wal replay

2022-06-23 Thread Justin Pryzby
On Thu, Jun 23, 2022 at 09:49:31AM +, Jakub Wartak wrote: > it would be nice if we had some advanced/deep/hidden parameters , but there > isn't such thing. There's DEVELOPER_OPTIONS gucs, although I don't know if this is a good fit for that. -- Justin

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Andres Freund
Hi, On 2022-06-03 13:28:16 +0700, John Naylor wrote: > 1. That would require putting the name physically closer to the end of > the column list. To make this less annoying for users, we'd need to > separate physical order from display order (at least/at first only for > system catalogs). FWIW, it

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 6:13 AM Julien Rouhaud wrote: > While some problem wouldn't happen if we restricted the feature to system > catalogs only (e.g. with renamed / dropped attributes, inheritance...), a lot > would still exist and would have to be dealt with initially. However I'm not > sure w

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 10:17 AM Andres Freund wrote: > > This would require: > > > > - changing star expansion in SELECTs (expandRTE etc) > > - adjusting pg_dump, \d, etc > > > > That much seems clear and agreed upon. > > FWIW, I don't agree that this is a reasonable way to tackle changing > NAME

refactor some protocol message sending in walsender and basebackup

2022-06-23 Thread Peter Eisentraut
Some places in walsender.c and basebackup_copy.c open-code the sending of RowDescription and DataRow protocol messages. But there are already more compact and robust solutions available for this, using DestRemoteSimple and associated machinery, already in use in walsender.c. The attached patc

Re: some aspects of our qsort might not be ideal

2022-06-23 Thread Matthias van de Meent
On Thu, 23 Jun 2022 at 15:52, Robert Haas wrote: > > On Thu, Jun 23, 2022 at 6:13 AM John Naylor > wrote: > > Here is a *rough* first pass at dual-pivot quicksort. I haven't > > changed the regression tests to adjust for qsort being an unstable > > sort, ... > > Hmm. I thought we had some reasons

Re: some aspects of our qsort might not be ideal

2022-06-23 Thread Peter Geoghegan
On Thu, Jun 23, 2022 at 7:51 AM Matthias van de Meent wrote: > I think that mostly has to do with reliability / stability of ORDER BY > in combination with LIMIT and OFFSET, even though right now we cannot > fully guarantee such stability due to unstable results from underlying > plan nodes. The

Re: some aspects of our qsort might not be ideal

2022-06-23 Thread Matthias van de Meent
On Thu, 23 Jun 2022 at 17:04, Peter Geoghegan wrote: > > On Thu, Jun 23, 2022 at 7:51 AM Matthias van de Meent > wrote: > > I think that mostly has to do with reliability / stability of ORDER BY > > in combination with LIMIT and OFFSET, even though right now we cannot > > fully guarantee such sta

Re: allow specifying action when standby encounters incompatible parameter settings

2022-06-23 Thread Simon Riggs
On Wed, 13 Apr 2022 at 22:35, Nathan Bossart wrote: > As of 15251c0, when a standby encounters an incompatible parameter change, > it pauses replay so that read traffic can continue while the administrator > fixes the parameters. Once the server is restarted, replay can continue. > Before this c

Re: [PATCH] Compression dictionaries for JSONB

2022-06-23 Thread Simon Riggs
On Thu, 2 Jun 2022 at 14:30, Aleksander Alekseev wrote: > > I saw there was some previous discussion about dictionary size. It > > looks like this approach would put all dictionaries into a shared OID > > pool. Since I don't know what a "standard" use case is, is there any > > risk of OID exhaust

Re: O(n) tasks cause lengthy startups and checkpoints

2022-06-23 Thread Simon Riggs
On Thu, 23 Jun 2022 at 14:46, Robert Haas wrote: > > On Thu, Jun 23, 2022 at 7:58 AM Simon Riggs > wrote: > > Having a central cleanup process makes a lot of sense. There is a long > > list of potential tasks for such a process. My understanding is that > > autovacuum already has an interface for

Re: O(n) tasks cause lengthy startups and checkpoints

2022-06-23 Thread Nathan Bossart
On Thu, Jun 23, 2022 at 09:46:28AM -0400, Robert Haas wrote: > I do agree that a general mechanism for getting cleanup tasks done in > the background could be a useful thing to have, but I feel like it's > hard to see exactly how to make it work well. We can't just allow it > to spin up a million n

Re: [PoC] Let libpq reject unexpected authentication requests

2022-06-23 Thread Jacob Champion
On Wed, Jun 22, 2022 at 5:56 PM David G. Johnston wrote: > That just makes me want to not implement OR'ing... > > The existing set of individual parameters doesn't work as an API for > try-and-fallback. > > Something like would be less problematic when it comes to setting multiple > related opti

Re: allow specifying action when standby encounters incompatible parameter settings

2022-06-23 Thread Nathan Bossart
Thanks for chiming in. On Thu, Jun 23, 2022 at 04:19:45PM +0100, Simon Riggs wrote: > I don't understand why you need this patch at all. > > Since you have automation, you can use that layer to automatically > restart all standbys at once, if you choose, without any help or > hindrance from Postg

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Tom Lane
Robert Haas writes: > On Thu, Jun 23, 2022 at 10:17 AM Andres Freund wrote: >> FWIW, I don't agree that this is a reasonable way to tackle changing >> NAMEDATALEN. It'd be nice to have, but it to me it seems a pretty small >> fraction of the problem of making Names variable length. You'll still h

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 2:07 PM Tom Lane wrote: > Sounds worth investigating, anyway. It'd also get us out from under > C-struct-related problems such as the nearby AIX alignment issue. Yeah. > The extra cost of the deforming step could also be repaid, in some > cases, by not having to use SysC

Re: Race condition in TransactionIdIsInProgress

2022-06-23 Thread Heikki Linnakangas
On 12/02/2022 05:42, Andres Freund wrote: On 2022-02-11 16:41:24 -0800, Andres Freund wrote: FWIW, I've indeed reproduced this fairly easily with such a setup. A pgbench r/w workload that's been modified to start 70 savepoints at the start shows pgbench: error: client 22 script 0 aborted in com

Re: CI and test improvements

2022-06-23 Thread Justin Pryzby
On Sat, May 28, 2022 at 10:37:41AM -0500, Justin Pryzby wrote: > I'm "joining" a bunch of unresolved threads hoping to present them better > since > they're related and I'm maintaining them together anyway. This resolves an error with libpq tests in an intermediate commit, probably caused by reba

Re: fix crash with Python 3.11

2022-06-23 Thread Markus Wanner
On 6/23/22 15:34, Tom Lane wrote: Under what circumstances would it be OK for outside code to call SPICleanup? For the same reasons previous Postgres versions called SPICleanup: from a sigsetjmp handler that duplicates most of what Postgres does in such a situation. However, I think that's

making relfilenodes 56 bits

2022-06-23 Thread Robert Haas
[ changing subject line so nobody misses what's under discussion ] For a quick summary of the overall idea being discussed here and some discussion of the problems it solves, see http://postgr.es/m/ca+tgmobm5fn5x0u3tsponvk_tzpfcdbchxsxcoy1ytn1dxr...@mail.gmail.com For discussion of the proposed r

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Bagga, Rishu
Hi Andres, Thanks for your response. To answer your questions: >> 3. A flag to identify if the page is a relational or BufferedObject >Why is this needed in the page header? Now that we are dealing with two different type of page headers, we need to know how to interpret any given page. We need

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Robert Haas
On Wed, Jun 22, 2022 at 5:06 PM Bagga, Rishu wrote: > We are suggesting a minimal BufferedObject page header > to be the following, overlapping with the key fields near the beginning > of the regular PageHeaderData: > > typedef struct BufferedObjectPageHeaderData > { > PageXLogRecPtr pd_lsn; >

Re: tablesync copy ignores publication actions

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 2:13 AM Amit Kapila wrote: > The patch looks good to me as well. I will push this patch in HEAD (as > per option (a)) tomorrow unless I see any more suggestions/comments. The example seems to demonstrate the point quite well but one thing that I notice is that it is quite

Re: CI and test improvements

2022-06-23 Thread Thomas Munro
[Resending -- sorry if you receive this twice. Jacob's mail server has apparently offended the list management software so emails bounce if he's in CC.] On Fri, Jun 24, 2022 at 7:23 AM Justin Pryzby wrote: > Freebsd uploads an artifact 3x smaller than the size ccache reports, because > its ccach

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Andres Freund
Hi, On 2022-06-23 20:25:21 +, Bagga, Rishu wrote: > >> 3. A flag to identify if the page is a relational or BufferedObject > >Why is this needed in the page header? > > Now that we are dealing with two different type of page headers, we need to > know how to interpret any given page. We need

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Andres Freund
Hi, On 2022-06-23 14:42:17 -0400, Robert Haas wrote: > On Thu, Jun 23, 2022 at 2:07 PM Tom Lane wrote: > > The extra cost of the deforming step could also be repaid, in some > > cases, by not having to use SysCacheGetAttr etc later on to fetch > > variable-length fields. That is, I'm imagining t

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Robert Haas
On Thu, Jun 23, 2022 at 5:49 PM Andres Freund wrote: > I was thinking we'd basically do it wherever we do a GETSTRUCT() today. > > A first step could be to transform code like > (Form_pg_attribute) GETSTRUCT(tuple) > into >GETSTRUCT(pg_attribute, tuple) > > then, in a subsequent step, we'd

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread Tom Lane
Robert Haas writes: > On Thu, Jun 23, 2022 at 5:49 PM Andres Freund wrote: >> I was thinking we'd basically do it wherever we do a GETSTRUCT() today. > That seems a little fraught, because you'd be turning what's now > basically a trivial operation into a non-trivial operation involving > memory

Re: fix crash with Python 3.11

2022-06-23 Thread Tom Lane
Markus Wanner writes: > On 6/23/22 15:34, Tom Lane wrote: >> Under what circumstances would it be OK for outside code to call >> SPICleanup? > For the same reasons previous Postgres versions called SPICleanup: from > a sigsetjmp handler that duplicates most of what Postgres does in such a > sit

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Bagga, Rishu
Hi Andres, >When do we need to do so? We should never need to figure out whether an >on-disk block is for an SLRU or something else, without also knowing >which >relation / SLRU it is in. You are correct that we wouldn’t need to rely on the pd_flag bit to determine page type for any access to a

Re: SLRUs in the main buffer pool - Page Header definitions

2022-06-23 Thread Andres Freund
Hi, On 2022-06-24 00:39:41 +, Bagga, Rishu wrote: > >When do we need to do so? We should never need to figure out whether an > >on-disk block is for an SLRU or something else, without also knowing >which > >relation / SLRU it is in. > > You are correct that we wouldn’t need to rely on the pd_

Re: Race condition in TransactionIdIsInProgress

2022-06-23 Thread Andres Freund
Hi, On 2022-06-23 22:03:27 +0300, Heikki Linnakangas wrote: > On 12/02/2022 05:42, Andres Freund wrote: > > The only reason I'm so far not succeeding in turning it into an > > isolationtester spec is that a transaction waiting for SyncRep doesn't count > > as waiting for isolationtester. > > > > B

Re: Make COPY extendable in order to support Parquet and other formats

2022-06-23 Thread Andres Freund
Hi, On 2022-06-23 11:38:29 +0300, Aleksander Alekseev wrote: > > I know little about parquet - can it support FROM STDIN efficiently? > > Parquet is a compressed binary format with data grouped by columns > [1]. I wouldn't assume that this is a primary use case for this > particular format. IMO

Re: PG 15 (and to a smaller degree 14) regression due to ExprEvalStep size

2022-06-23 Thread Andres Freund
Hi, On 2022-06-23 16:38:12 +0900, Michael Paquier wrote: > On Tue, Jun 21, 2022 at 05:41:07PM -0400, Andrew Dunstan wrote: > > On 2022-06-21 Tu 17:25, Andres Freund wrote: > >> On 2022-06-21 17:11:33 -0400, Andrew Dunstan wrote: > >>> I and a couple of colleagues have looked it over. As far as it

Re: Fix instability in subscription regression test

2022-06-23 Thread Masahiko Sawada
On Thu, Jun 23, 2022 at 8:28 PM houzj.f...@fujitsu.com wrote: > > Hi, > > I noticed BF member wrasse failed in 028_row_filter.pl. > > # Failed test 'check publish_via_partition_root behavior' > # at t/028_row_filter.pl line 669. > # got: '' > # expected: '1|100 > # ..

Re: Fix instability in subscription regression test

2022-06-23 Thread Amit Kapila
On Thu, Jun 23, 2022 at 4:58 PM houzj.f...@fujitsu.com wrote: > > Hi, > > I noticed BF member wrasse failed in 028_row_filter.pl. > > # Failed test 'check publish_via_partition_root behavior' > # at t/028_row_filter.pl line 669. > # got: '' > # expected: '1|100 > # ..

RE: Fix instability in subscription regression test

2022-06-23 Thread houzj.f...@fujitsu.com
> -Original Message- > From: Amit Kapila > Sent: Friday, June 24, 2022 10:28 AM > To: Hou, Zhijie/侯 志杰 > Cc: PostgreSQL Hackers > Subject: Re: Fix instability in subscription regression test > > On Thu, Jun 23, 2022 at 4:58 PM houzj.f...@fujitsu.com > wrote: > > > > Hi, > > > > I not

Re: Support logical replication of DDLs

2022-06-23 Thread Masahiko Sawada
On Thu, Jun 23, 2022 at 7:00 PM Amit Kapila wrote: > > On Wed, Jun 22, 2022 at 11:09 AM Masahiko Sawada > wrote: > > > > I've attached a WIP patch for adding regression tests for DDL deparse. > > The patch can be applied on > > v9-0001-Functions-to-deparse-DDL-commands.patch Hou recently > > sub

Re: NAMEDATALEN increase because of non-latin languages

2022-06-23 Thread John Naylor
On Thu, Jun 23, 2022 at 9:17 PM Andres Freund wrote: > > Hi, > > On 2022-06-03 13:28:16 +0700, John Naylor wrote: > > 1. That would require putting the name physically closer to the end of > > the column list. To make this less annoying for users, we'd need to > > separate physical order from disp

Re: amcheck is using a wrong macro to check compressed-ness

2022-06-23 Thread Michael Paquier
On Wed, Jun 22, 2022 at 01:14:57PM -0400, Robert Haas wrote: > Oops, I missed this thread. I think the patch is correct, so I have > committed it. Thanks, Robert. -- Michael signature.asc Description: PGP signature

Re: pg_ls_tmpdir to show directories and shared filesets (and pg_ls_*)

2022-06-23 Thread Justin Pryzby
This thread has been going for 2.5 years, so here's a(nother) recap. This omits the patches for recursion, since they're optional and evidently a distraction from the main patches. On Fri, Dec 27, 2019 at 11:02:20AM -0600, Justin Pryzby wrote: > The goal is to somehow show tmpfiles (or at least d

Re: Handle infinite recursion in logical replication setup

2022-06-23 Thread Peter Smith
Here are my review comments for the v23* patch set. v23-0001 No comments. LGTM V23-0002 2.1 src/backend/commands/subscriptioncmds.c + opts->origin = defGetString(defel); + + if ((strcmp(opts->origin, LOGICALREP_ORIGIN_LOCAL) != 0) && + (strcmp(opts->origin,

Postgres do not allow to create many tables with more than 63-symbols prefix

2022-06-23 Thread Andrey Lepikhov
Moved from the pgsql-bugs mailing list [1]. On 6/23/22 07:03, Masahiko Sawada wrote: > Hi, > > On Sat, Jun 4, 2022 at 4:03 AM Andrey Lepikhov > wrote: >> >> According to subj you can try to create many tables (induced by the case >> of partitioned table) with long prefix - see 6727v.sql for repr

Re: Postgres perl module namespace

2022-06-23 Thread Noah Misch
On Wed, Jun 22, 2022 at 11:03:22AM -0400, Andrew Dunstan wrote: > On 2022-06-22 We 03:21, Noah Misch wrote: > > On Tue, Apr 19, 2022 at 07:24:58PM -0400, Andrew Dunstan wrote: > >> On 2022-04-19 Tu 18:39, Michael Paquier wrote: > >>> +*generate_ascii_string = *TestLib::generate_ascii_string; > >>>