Re: Duplicate history file?

2021-06-08 Thread Tatsuro Yamada
Hi Horiguchi-san, On 2021/06/09 11:47, Kyotaro Horiguchi wrote: On 2021/06/08 18:19, Tatsuro Yamada wrote: I've tried your patch. Unfortunately, it didn't seem to have any good effect on the script I sent to reproduce the problem. Oops! The patch forgot about history files. I checked the att

Re: Adjust pg_regress output for new long test names

2021-06-08 Thread Noah Misch
On Wed, Jun 09, 2021 at 03:21:36PM +1200, Thomas Munro wrote: > On Wed, Jun 9, 2021 at 2:44 PM Tom Lane wrote: > > ... or we could shorten those file names. I recall an episode > > awhile ago where somebody complained that their version of "tar" > > couldn't handle some of the path names in our t

Re: Refactor "mutually exclusive options" error reporting code in parse_subscription_options

2021-06-08 Thread Peter Smith
On Wed, Jun 2, 2021 at 10:41 PM Bharath Rupireddy wrote: > > On Wed, Jun 2, 2021 at 11:43 AM Peter Smith wrote: > > Yes, it looks better, but (since the masks are all 1 bit) I was only > > asking why not do like: > > > > if (supported_opts & SUBOPT_CONNECT) > > if (supported_opts & SUBOPT_ENABLED

Re: alter table set TABLE ACCESS METHOD

2021-06-08 Thread Michael Paquier
On Tue, Jun 08, 2021 at 05:33:31PM -0700, Jeff Davis wrote: > New version attached, with the detoasting code removed. Could use > another round of validation/cleanup in case I missed something during > the merge. This looks rather sane to me, thanks. /* Create the transient table that will re

Re: Fix dropped object handling in pg_event_trigger_ddl_commands

2021-06-08 Thread Michael Paquier
On Mon, Jun 07, 2021 at 12:44:42PM +0300, Aleksander Alekseev wrote: > I confirm that the bug still exists in master (be57f216). The patch > fixes it and looks good to me. I changed the wording a little and > added a regression test. The updated patch is in the attachment. I > added this thread to

Re: Decoding speculative insert with toast leaks memory

2021-06-08 Thread Amit Kapila
On Tue, Jun 8, 2021 at 5:16 PM Dilip Kumar wrote: > > Based on the off list discussion, I have modified the test based on > the idea showed in > "isolation/specs/insert-conflict-specconflict.spec", other open point > we had about the race condition that how to ensure that when we unlock > any sess

Re: [HACKERS] logical decoding of two-phase transactions

2021-06-08 Thread Amit Kapila
On Wed, Jun 9, 2021 at 10:34 AM Ajin Cherian wrote: > > On Tue, Jun 8, 2021 at 4:19 PM Peter Smith wrote: > > > > 3. > > > @@ -432,10 +432,19 @@ CreateInitDecodingContext(const char *plugin, > > > MemoryContextSwitchTo(old_context); > > > > > > /* > > > - * We allow decoding of prepared trans

Re: [HACKERS] logical decoding of two-phase transactions

2021-06-08 Thread Amit Kapila
On Wed, Jun 9, 2021 at 9:58 AM Greg Nancarrow wrote: > > (5) src/backend/access/transam/twophase.c > > Question: > > Is: > > + * do this optimization if we encounter many collisions in GID > > meant to be: > > + * do this optimization if we encounter any collisions in GID > No, it should be fine

Re: Fdw batch insert error out when set batch_size > 65535

2021-06-08 Thread Tom Lane
Bharath Rupireddy writes: >> I've added a simple regression test to postgres_fdw, testing that batch >> sizes > 65535 work fine, and pushed the fix. > I was earlier thinking of adding one, but stopped because it might > increase the regression test execution time. It looks like that's true > - wi

Re: logical decoding bug: segfault in ReorderBufferToastReplace()

2021-06-08 Thread Amit Kapila
On Wed, Jun 9, 2021 at 11:37 AM Drouvot, Bertrand wrote: > > On 6/9/21 5:33 AM, Amit Kapila wrote: > > On Wed, Jun 9, 2021 at 12:06 AM Jeremy Schneider > > wrote: > >> On 6/4/21 23:42, Amit Kapila wrote: > >> > >> On 2021-Jun-04, Jeremy Schneider wrote: > >> > >> ERROR: XX000: could not open rel

RE: [bug?] Missed parallel safety checks, and wrong parallel safety

2021-06-08 Thread houzj.f...@fujitsu.com
On Tuesday, June 8, 2021 10:51 PM Robert Haas > On Mon, Jun 7, 2021 at 11:33 PM Amit Kapila > wrote: > > Note the error is raised after applying the patch, without the patch, > > the above won't show any error (error message could be improved here). > > Such cases can lead to unpredictable behavi

Re: Fdw batch insert error out when set batch_size > 65535

2021-06-08 Thread Tom Lane
I wrote: > Bharath Rupireddy writes: >>> I've added a simple regression test to postgres_fdw, testing that batch >>> sizes > 65535 work fine, and pushed the fix. >> I was earlier thinking of adding one, but stopped because it might >> increase the regression test execution time. It looks like tha

RE: locking [user] catalog tables vs 2pc vs logical rep

2021-06-08 Thread osumi.takami...@fujitsu.com
On Wednesday, June 9, 2021 12:06 PM Amit Kapila wrote: > On Tue, Jun 8, 2021 at 6:24 PM vignesh C wrote: > > > > Thanks for the updated patch. > > > > I have few comments: > > 1) Should we list the actual system tables like pg_class,pg_trigger, > > etc instead of any other catalog table? > > User

Re: [bug?] Missed parallel safety checks, and wrong parallel safety

2021-06-08 Thread Tom Lane
"houzj.f...@fujitsu.com" writes: > On Tuesday, June 8, 2021 10:51 PM Robert Haas > wrote: >> In my opinion, you're basically taking too pure a view of this. We're >> not trying to create a system that does such a good job checking >> parallel safety markings that nobody can possibly find a thing

Re: Race condition in recovery?

2021-06-08 Thread Dilip Kumar
On Wed, Jun 9, 2021 at 2:07 AM Robert Haas wrote: > Then I tried to get things working on 9.6. There's a patch attached to > back-port a couple of PostgresNode.pm methods from 10 to 9.6, and also > a version of the main patch attached with the necessary wal->xlog, > lsn->location renaming. Unfort

Re: Duplicate history file?

2021-06-08 Thread Tatsuro Yamada
Hi Thank you for fixing the patch. The new patch works well in my environment. :-D This may not be important at this time since it is a PoC patch, but I would like to inform you that there was a line that contained multiple spaces instead of tabs. $ git diff --check src/backend/access/transam

<    1   2