Bharath Rupireddy <bharath.rupireddyforpostg...@gmail.com> writes: >> I've added a simple regression test to postgres_fdw, testing that batch >> sizes > 65535 work fine, and pushed the fix.
> I was earlier thinking of adding one, but stopped because it might > increase the regression test execution time. It looks like that's true > - with and without the test case it takes 17 sec and 4 sec > respectively on my dev system which is 4X slower. I'm not sure if this > is okay. The cost, versus the odds of ever detecting a problem, doesn't seem like a good tradeoff. regards, tom lane