On 2018-11-16 22:59, Alvaro Herrera wrote:
On 2018-Sep-05, Marina Polyakova wrote:
v11-0001-Pgbench-errors-use-the-RandomState-structure-for.patch
- a patch for the RandomState structure (this is used to reset a
client's
random seed during the repeating of transactions after
serialization/dea
po 19. 11. 2018 v 3:42 odesílatel Michael Paquier
napsal:
> On Sun, Nov 18, 2018 at 11:17:37PM -0300, Alvaro Herrera wrote:
> > To be certain I'm not going against some old decision, I digged up
> > Amit's old patches. Turns out he submitted psql's describe.c using the
> > term "partitioned tabl
Hello,
Can I skip function ResolveRecoveryConflictWithSnapshot if setting
hot_standby_feedback=on all the time?
As I know, function ResolveRecoveryConflictWithSnapshot is used for resolving
conflicts once master cleans dead tuples. But if I set hot_standby_feedback to
on, it will not appear con
Hi,
In [1], there was a plan to do the trigger tuple slotification
changes as a separate patch, and not include them in the pluggable
storage changes. I have come up with such a patch by extracting the
trigger-specific changes from the pluggable storage changes proposed
in [1]. I used this reposi
On Mon, Nov 19, 2018 at 6:52 AM Tomas Vondra
wrote:
>
> Hi,
>
> It seems we have pretty annoying problem with logical decoding when
> performing VACUUM FULL / CLUSTER on a table with toast-ed data.
>
> The trouble is that the rewritten heap is WAL-logged using XLOG/FPI
> records, the TOAST data is
On Wed, 14 Nov 2018 at 05:00, Andres Freund wrote:
> After this, I hope Amit Khandekar will rebase a patch he's sent me
> internally that converts triggers to use slots. I'll work on rebasing
> the pluggable storage patch ontop of this.
Shared this patch in a separate mail thread :
https://www.po
> Thanks, it makes difference and keep us motivated for making progress.
+1
Is it intended behavior that a database can not be dropped when undo apply is
running in the background?
zheap=# update pgbench_accounts set filler = 'bbb' where mod(aid,10) = 0;
UPDATE 100
zheap=# rollback;
ROLLBAC
On 11/19/18 10:28 AM, Masahiko Sawada wrote:
On Mon, Nov 19, 2018 at 6:52 AM Tomas Vondra
wrote:
Hi,
It seems we have pretty annoying problem with logical decoding when
performing VACUUM FULL / CLUSTER on a table with toast-ed data.
The trouble is that the rewritten heap is WAL-logged using
On Mon, Nov 19, 2018 at 3:59 PM Daniel Westermann
wrote:
>
> > Thanks, it makes difference and keep us motivated for making progress.
> +1
>
> Is it intended behavior that a database can not be dropped when undo apply is
> running in the background?
>
Yes, we need to connect to the database for
On 11/19/18, Amit Kapila wrote:
> On Mon, Nov 19, 2018 at 7:30 AM John Naylor wrote:
>> Let's say we have to wait to acquire a relation extension lock,
>> because another backend had already started extending the heap by 1
>> block. We call GetPageWithFreeSpace() and now the local map looks like
On Mon, Nov 19, 2018 at 4:40 PM John Naylor wrote:
>
> On 11/19/18, Amit Kapila wrote:
> > On Mon, Nov 19, 2018 at 7:30 AM John Naylor wrote:
> >> Let's say we have to wait to acquire a relation extension lock,
> >> because another backend had already started extending the heap by 1
> >> block.
On 11/17/18 4:53 PM, Alvaro Herrera wrote:
Here are versions for branches 10 and 11. The main change is that the
COPY test didn't have the partitioned table, because it was recently
introduced (0d5f05cde011) so I backpatched that part also. It's a bit
useless, but I'd rather backpatch the same
>Yes, we need to connect to the database for performing rollback
>actions. Once the rollback for that database is over, undo apply
>worker will exit and you should be able to drop the database.
Thank you, Amit.
Can you have a look at this one?
create table t1 ( a text ) partition by list (a);
cr
В письме от 2 октября 2018 13:46:13 пользователь Michael Paquier написал:
> On Fri, Sep 14, 2018 at 09:30:25PM +0300, Nikolay Shaplov wrote:
> > BTW this commit shows why do this patch is important: 857f9c36 adds new
> > option for b-tree indexes. But thanks to the StdRdOptions this option
> > will
I tried below function as which can be used as default to column. But every
time we need to created 2 sequences, 1st one takes care of the first 8
bytes and 2nd takes care of the 2nd part of the UUID. I have not tested
index and space utilization. I have to examine this. This might not be
completel
On 11/19/18 2:57 AM, Michael Paquier wrote:
On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
Since it's hard to come up with a concise name that will mention sampling rate
in the context of min_duration_statement, I think it's fine to name this
configuration "log_sample_rate", a
On 11/18/18 10:52 AM, Adrien Nayrat wrote:
...
Alors, I wonder if we should use the same logic for other parameters, such as
log_statement_stats
log_parser_stats
log_planner_stats
log_executor_stats
> It was mentioned in this thread
>
https://www.postgresql.org/message-id/20180710183828.GB3
> On Mon, Nov 19, 2018 at 2:40 PM Tomas Vondra
> wrote:
>
> On 11/19/18 2:57 AM, Michael Paquier wrote:
> > On Sun, Nov 18, 2018 at 12:18:33PM +0100, Dmitry Dolgov wrote:
> >> Since it's hard to come up with a concise name that will mention sampling
> >> rate
> >> in the context of min_duration_
On 2018-Nov-19, Tomas Vondra wrote:
> On 11/17/18 4:53 PM, Alvaro Herrera wrote:
> > Here are versions for branches 10 and 11. The main change is that the
> > COPY test didn't have the partitioned table, because it was recently
> > introduced (0d5f05cde011) so I backpatched that part also. It's
Hi,
A system monitoring tool like "nc -vz localhost 5432" to monitor the
database server is causing the warning, any way way to filter or ignore
messages in postgresql log file
LOG: incomplete startup packet
Many thanks in advance,
Adelino.
This patch adds verification of the connection with the client during
the execution of the SQL query. The feature enables using the GUC
variable ‘client_connection_check_interval’. The default check interval
is 1 second. If you set the value of ‘client_connection_check_interval’
to 0, then the
Greetings,
* Adelino Silva (adelino.j.si...@googlemail.com) wrote:
> A system monitoring tool like "nc -vz localhost 5432" to monitor the
> database server is causing the warning, any way way to filter or ignore
> messages in postgresql log file
>
> LOG: incomplete startup packet
Not today. Yo
On 2018-Nov-17, Fabien COELHO wrote:
> Here is the updated v2
>
> - libpq internal function getHostaddr get a length,
>and I added an assert about it.
> - added a few braces on if/if/else/if/else/else
> - added an UNKNOWN_HOST macro to hide "???"
> - moved host_addr[] declaration earlier
> On Tue, Jul 24, 2018 at 5:52 PM Dave Cramer wrote:
>
> Back in 2016 a patch was proposed that seems to have died on the vine. See
> https://www.postgresql.org/message-id/flat/cafgjrd3hdyoa33m69tbeofnner2bzbwa8ffjt2v5vfztbvu...@mail.gmail.com
> for the history and https://commitfest.postgresql.o
On 2018-Nov-19, Marina Polyakova wrote:
> On 2018-11-16 22:59, Alvaro Herrera wrote:
> > On 2018-Sep-05, Marina Polyakova wrote:
> >
> > > v11-0001-Pgbench-errors-use-the-RandomState-structure-for.patch
> > > - a patch for the RandomState structure (this is used to reset a
> > > client's
> > > ra
On Mon, Nov 19, 2018 at 6:54 AM Adelino Silva <
adelino.j.si...@googlemail.com> wrote:
> A system monitoring tool like "nc -vz localhost 5432" to monitor the
> database server is causing the warning, any way way to filter or ignore
> messages in postgresql log file
> LOG: incomplete startup packe
I noticed that buildfarm member quokka (RHEL 7 / ppc64) has started
failing configure in the 9.4 and 9.5 branches. This appears to be
because configure is not detecting the need to use "-pthread" to get
thread-related functions. We didn't change anything in that area
ourselves, so I'm guessing th
On Sun, Nov 18, 2018 at 9:43 PM Amit Langote
wrote:
> On 2018/11/17 9:06, Michael Paquier wrote:
> > On Fri, Nov 16, 2018 at 09:38:40AM -0500, Robert Haas wrote:
> >> OK, but it seems to me that your version of my patch rearranges the
> >> code more than necessary.
> >>
> >> How about the attached
Pushed, thanks.
--
Álvaro Herrerahttps://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
On 19/11/2018 19:12, Tom Lane wrote:
I noticed that buildfarm member quokka (RHEL 7 / ppc64) has started
failing configure in the 9.4 and 9.5 branches. This appears to be
because configure is not detecting the need to use "-pthread" to get
thread-related functions. We didn't change anything in
Heikki Linnakangas writes:
> On 19/11/2018 19:12, Tom Lane wrote:
>> It looks to me like the reason it's okay in 9.6 and up is
>> commit e97af6c8b ("Replace our hacked version of ax_pthread.m4 with
>> latest upstream version") plus a few followup fixes. I propose to
>> back-patch those into 9.5 a
Hello,
I am Jinho Jung, PhD student at Georgia Tech and I am conducting DB performance
research. I am sending our evaluation result to get the feedback regarding our
findings.
We found several performance regression queries. Attached files are three of
them that we confirmed performance regre
Hi,
On Sun, Oct 14, 2018 at 10:59:02AM +0900, Michael Paquier wrote:
> On Sat, Oct 13, 2018 at 05:53:00PM -0400, Andrew Dunstan wrote:
> > It occurred to me that a pretty simple fix could just be to blacklist
> > everything that didn't start with a digit. The whitelist approach is
> > probably pre
Hi
I am playing with plpgsql profiling and and plpgsql plugin API. I found so
callback stmt_beg and stmt_end was not called for top statement due direct
call exec_stmt_block function.
<-->estate.err_text = NULL;
<-->estate.err_stmt = (PLpgSQL_stmt *) (func->action);
<-->rc = exec_stmt_block(&esta
Disclaimer: I had never seen this patch before. I did not participate
in this feature design. I did not discuss this review with the author
or anybody in 2ndQuadrant. I do not have any particular affective bonds
with its author. I did not receive payment nor goods in exchange for
this review.
Hello Alvaro,
- libpq internal function getHostaddr get a length,
and I added an assert about it.
- added a few braces on if/if/else/if/else/else
- added an UNKNOWN_HOST macro to hide "???"
- moved host_addr[] declaration earlier to avoid some braces
You forgot to free(conn->connip) d
Hello Alvaro,
I also think that the pgbench_error() patch should go in before the main
one. It seems a bit pointless to introduce code using a bad API only to
fix the API together with all the new callers immediately afterwards.
I'm not that keen on this part of the patch, because ISTM that
On 2018-Nov-19, Fabien COELHO wrote:
>
> Hello Alvaro,
>
> > I also think that the pgbench_error() patch should go in before the main
> > one. It seems a bit pointless to introduce code using a bad API only to
> > fix the API together with all the new callers immediately afterwards.
>
> I'm no
Feel free to update a patch status to "needs review" yourself after
submitting a new version that in your opinion respond to a reviewer's
comments.
Sure, I do that. But I will not switch any of my patch to "Ready". AFAICR
the concerns where mostly about imprecise comments in the code, and a
Hi,
On 2018-11-01 22:52:19 +0100, Fabien COELHO wrote:
>
> > > > Their commit r265375 fixed the ability to compile itself, but built
> > > > PostgreSQL binaries remain broken there and thereafter.
> > > >
> > > > |...]
> > >
> > > Thanks a lot for this investigation! I can fill in a gcc bug rep
Etsuro Fujita writes:
> I agree that it's better to keep the BeginCopyFrom API as-is. Also, I
> think your version would handle SIGPIPE in COPY FROM PROGRAM more
> properly than what I proposed. So, +1 from me.
Thanks for reviewing! I've pushed it now, though at the last minute
I reconsidere
Andres Freund writes:
> FWIW, it seems that gcc's trunk works again. But I'm not sure this isn't
> just an accident and the optimization's introduced in the above revision
> aren't still broken.
> https://buildfarm.postgresql.org/cgi-bin/show_history.pl?nm=moonjelly&br=HEAD
Yeah, I saw that moonj
Hi,
On 2018-11-19 17:32:37 -0500, Tom Lane wrote:
> Andres Freund writes:
> > FWIW, it seems that gcc's trunk works again. But I'm not sure this isn't
> > just an accident and the optimization's introduced in the above revision
> > aren't still broken.
> > https://buildfarm.postgresql.org/cgi-bi
On 2018-Nov-17, Fabien COELHO wrote:
>
> > Attached is a v3, where I have updated inaccurate comments.
>
> Attached v4 is a rebase after 409231919443984635b7ae9b7e2e261ab984eb1e
Attached v5. I thought that separating the part that executes the
command was an obvious readability improvement. T
On 2018-11-19 14:38:04 -0800, Andres Freund wrote:
> Hi,
>
>
> On 2018-11-19 17:32:37 -0500, Tom Lane wrote:
> > Andres Freund writes:
> > > FWIW, it seems that gcc's trunk works again. But I'm not sure this isn't
> > > just an accident and the optimization's introduced in the above revision
> >
On Mon, Nov 19, 2018 at 07:11:19PM +0100, Michael Banck wrote:
> First off, I think those fail_corrupt files should have different
> filenames than the empty ones above (I left `9_vm.123' as an
> example of a duplicated file).
A comment about that is a good idea. So added.
> So either we rem
On Mon, Nov 19, 2018 at 09:33:58AM +0100, Pavel Stehule wrote:
> po 19. 11. 2018 v 3:42 odesílatel Michael Paquier
> napsal:
>> Sorry for degressing, but could you also update \di at the same time so
>> as it shows "partitioned index"? listTables() should be switched to use
>> partitioned tables
On Mon, Nov 19, 2018 at 10:48:06AM +0500, Andrey Lepikhov wrote:
> According to my experience, I clarify some comments to avoid this mistakes
> in the future (see attachment).
No objections from here.
> - * The returned pointer (or *errormsg) points to an internal buffer that's
> - * valid until
On 20.11.2018 6:30, Michael Paquier wrote:
On Mon, Nov 19, 2018 at 10:48:06AM +0500, Andrey Lepikhov wrote:
According to my experience, I clarify some comments to avoid this mistakes
in the future (see attachment).
No objections from here.
- * The returned pointer (or *errormsg) points to
Greetings,
* David Steele (da...@pgmasters.net) wrote:
> On 10/30/18 11:59 AM, Stephen Frost wrote:
> > * Kyotaro HORIGUCHI (horiguchi.kyot...@lab.ntt.co.jp) wrote:
> >> So I'm +1 for the Michael's current patch as (I think) we can't
> >> make visible or large changes.
> >>
> >> That said, I agree
Hi Peter, Alvaro, All,
(Peter, this is your change, Alvaro, you're the objectaddress.c master)
While looking through my oids removal patch I noticed that the
objectaddress.c ObjectProperty entry for transforms looks wrong:
typedef struct
{
Oid class_oid;
On 2018-11-19 17:53:22 -0800, Andres Freund wrote:
> Hi Peter, Alvaro, All,
>
> (Peter, this is your change, Alvaro, you're the objectaddress.c master)
>
> While looking through my oids removal patch I noticed that the
> objectaddress.c ObjectProperty entry for transforms looks wrong:
>
> typede
On Mon, Nov 19, 2018 at 08:45:29PM -0500, Stephen Frost wrote:
> Michael, this obviously didn't happen and instead we ended up releasing
> 11.1 with your changes, but I don't feel like this issue is closed and
> I'm a bit disappointed that there hasn't been any further responses or
> discussions on
Greetings Michael,
* Michael Paquier (mich...@paquier.xyz) wrote:
> I am still a fan of the whitelist approach as there is no actual point
> in restricting what people can do with Postgres in terms of
> extensibility (relying on tablespace paths for storage plugin looks like
> an important thing t
Hi,
On 2018-11-19 21:18:43 -0500, Stephen Frost wrote:
> As has been mentioned elsewhere, there's really a 'right' way to do
> things and allowing PG to be 'extensible' by simply ignoring random
> files showing up isn't that- if we want PG to be extensible in this way
> then we need to provide a m
On Mon, Nov 19, 2018 at 6:36 PM Daniel Westermann
wrote:
>
> >Yes, we need to connect to the database for performing rollback
> >actions. Once the rollback for that database is over, undo apply
> >worker will exit and you should be able to drop the database.
>
> Thank you, Amit.
> Can you have a
On Mon, Nov 19, 2018 at 10:48 AM Haribabu Kommi
wrote:
> On Mon, Nov 19, 2018 at 1:37 PM Alvaro Herrera
> wrote:
>>
>> On 2018-Nov-19, Michael Paquier wrote:
>>
>> > On Mon, Nov 19, 2018 at 10:41:22AM +1100, Haribabu Kommi wrote:
>> > > So 6 new functions needs to be added to cover all the above
Greetings,
* Andres Freund (and...@anarazel.de) wrote:
> On 2018-11-19 21:18:43 -0500, Stephen Frost wrote:
> > As has been mentioned elsewhere, there's really a 'right' way to do
> > things and allowing PG to be 'extensible' by simply ignoring random
> > files showing up isn't that- if we want PG
Hi,
It seems to me that EquivalenceClass, the struct/type name, has been
misspelled as 'EquivalenceClasses' a couple of times in the comment above
its definition.
Attached fixes that.
Thanks,
Amit
diff --git a/src/include/nodes/relation.h b/src/include/nodes/relation.h
index 6fd24203dd..a695012c
On Mon, Nov 19, 2018 at 01:39:58PM +0900, Michael Paquier wrote:
> I was just coming by to look at bit at the patch series, and bumped
> into that:
So I have been looking at the last patch series 0001-0004 posted on this
thread, and coming from here:
https://postgr.es/m/20181025.215518.189844649.h
On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote:
> It seems to me that EquivalenceClass, the struct/type name, has been
> misspelled as 'EquivalenceClasses' a couple of times in the comment above
> its definition.
EquivalenceClasses stands for the plural of EquivalenceClass. So
think
On Tue, Nov 20, 2018 at 2:06 PM Amit Kapila wrote:
> On Mon, Nov 19, 2018 at 10:48 AM Haribabu Kommi
> wrote:
> > On Mon, Nov 19, 2018 at 1:37 PM Alvaro Herrera
> wrote:
> >>
> >> On 2018-Nov-19, Michael Paquier wrote:
> >>
> >> > On Mon, Nov 19, 2018 at 10:41:22AM +1100, Haribabu Kommi wrote:
On Tue, Nov 20, 2018 at 10:56 AM Haribabu Kommi
wrote:
>
> On Tue, Nov 20, 2018 at 2:06 PM Amit Kapila wrote:
>>
>> On Mon, Nov 19, 2018 at 10:48 AM Haribabu Kommi
>> wrote:
>> > On Mon, Nov 19, 2018 at 1:37 PM Alvaro Herrera
>> > wrote:
>> >>
>> >> On 2018-Nov-19, Michael Paquier wrote:
>> >>
Hi,
My customer uses PostgreSQL on Windows and hits the problem that following log
is written to the server logs too frequently (250 thousand times per day).
"LOG: could not reserve shared memory region (addr=%p) for child %p:"
This log is written when pgwin32_ReserveSharedMemoryRegion() in wi
Thank you for looking.
On 2018/11/20 14:13, Michael Paquier wrote:
> On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote:
>> It seems to me that EquivalenceClass, the struct/type name, has been
>> misspelled as 'EquivalenceClasses' a couple of times in the comment above
>> its definition.
Michael Paquier writes:
> On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote:
>> - * We also use EquivalenceClasses as the base structure for PathKeys,
>> letting
>> + * We also use EquivalenceClass as the base structure for PathKeys, letting
> ... But not that.
The reason that's not
On Tue, Nov 20, 2018 at 01:58:22AM -0500, Tom Lane wrote:
> The reason that's not good is that it creates a singular-plural mismatch.
> If you'd also changed "PathKeys" to "PathKey", it would still read OK,
> though I don't think it's an improvement particularly.
>
> (Hm ... though arguably, "stru
Hi all,
We prepared a patch that includes the hook points. And such hook points are
needed for disk quota extension.
There are two hooks.
One is SmgrStat_hook. It's used to perform ad-hoc logic in storage when
doing smgr create/extend/truncate in general. As for disk quota extension,
this hook is
>
> > In PostGIS workloads, UPDATE table SET geom = ST_CostyFunction(geom,
> magicnumber); is one of biggest time-eaters that happen upon initial load
> and clean up of your data. It is commonly followed by CLUSTER table using
> table_geom_idx; to make sure you're back at full speed and no VACUUM i
On 2018/11/20 15:58, Tom Lane wrote:
> Michael Paquier writes:
>> On Tue, Nov 20, 2018 at 02:00:39PM +0900, Amit Langote wrote:
>>> - * We also use EquivalenceClasses as the base structure for PathKeys,
>>> letting
>>> + * We also use EquivalenceClass as the base structure for PathKeys, letting
>
Hi,
On 2018/11/20 2:49, Jung, Jinho wrote:
> Execution time
> =
> 1.sql
> 10.6 : 469 ms
> 9.4.20: 10 ms
>
> 4.sql
> 10.6 : 34019 ms
> 9.4.20: 0.4 ms
I noticed that these two are fixed by running ANALYZE in the database in
which these queries are run.
> 20.sql
> 10.6 : 2791 ms
> 9
On Mon, Nov 05, 2018 at 11:43:16AM +0100, Pavel Stehule wrote:
> should be fixed now.
Here are some notes on the last version.
+ " FROM pg_inherits i\n"
Missing schema qualification.
+ case 'P':
+ if (cmd[2] == 'i')
+ success = listPartiti
72 matches
Mail list logo
